Age | Commit message (Collapse) | Author |
|
...so declare them as such. This avoids the recurring mistake of storing such
IDs as sal_uInt32, truncating in 64 bit environments, causing RemoveUserEvent to
potentially not remove the event, it thus firing "too late" and probably causing
a crash.
While at it, consolidate the trivially unnecessary overloads of both
Application::PostUserEvent and Window::PostUserEvent. And in each of them, it
looks like deleting the mpLink member was missing from the failure branch.
Change-Id: Iab13afbb06e12ac15dec6a6b5b85a7e402a3c654
|
|
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
|
|
Conflicts:
include/framework/preventduplicateinteraction.hxx
include/sfx2/sfxbasecontroller.hxx
include/sfx2/sfxbasemodel.hxx
include/toolkit/awt/vclxtabpagemodel.hxx
include/vcl/field.hxx
include/vcl/settings.hxx
Change-Id: Ibccf9f88c68267a3d7e656012b51eaf644c418c2
Reviewed-on: https://gerrit.libreoffice.org/8272
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Conflicts:
include/vcl/settings.hxx
svtools/source/table/tablecontrol_impl.cxx
sw/source/core/frmedt/fecopy.cxx
vcl/inc/canvasbitmap.hxx
vcl/inc/headless/svpframe.hxx
vcl/inc/unx/salframe.h
vcl/inc/win/salframe.h
vcl/inc/win/salprn.h
vcl/inc/win/salvd.h
vcl/osx/DragSource.cxx
vcl/osx/DragSource.hxx
vcl/osx/DropTarget.cxx
vcl/osx/DropTarget.hxx
vcl/osx/OSXTransferable.cxx
vcl/osx/OSXTransferable.hxx
vcl/osx/clipboard.cxx
vcl/osx/clipboard.hxx
vcl/osx/salprn.cxx
vcl/qa/cppunit/canvasbitmaptest.cxx
vcl/source/components/fontident.cxx
vcl/source/control/edit.cxx
vcl/source/control/spinfld.cxx
vcl/source/gdi/gdimtf.cxx
vcl/source/gdi/virdev.cxx
vcl/source/helper/canvasbitmap.cxx
vcl/source/window/dockwin.cxx
vcl/unx/generic/dtrans/X11_selection.hxx
vcl/unx/kde/UnxFilePicker.cxx
vcl/unx/kde/UnxFilePicker.hxx
vcl/unx/kde4/KDE4FilePicker.cxx
vcl/unx/kde4/KDE4FilePicker.hxx
vcl/unx/kde4/KDESalFrame.hxx
Change-Id: I9866d985da86dea2a56feff23f91c1467a1636b0
Reviewed-on: https://gerrit.libreoffice.org/8219
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I89a61aeffeebc69e06da6c1130436fb25528f1c7
|
|
Change-Id: I9b538bacbb98705b0345c3f6dc38fb554ce25bcf
|
|
Change-Id: Ia6967bd5ae412b473187d8bf5485e56fdc934efb
|
|
Change-Id: I90a9116aba75316992d2bddaf2f6466288b95bd0
|
|
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
|
|
Change-Id: I8c2fea0367ebfa53ce5e109ef48fd661cbfb78b3
|
|
If a menu won't fit in the desired location the default mode is to place it
somewhere it will fit. e.g. above, left, right. For some cases, e.g. menubars,
it's desirable to limit the options to above/below and force the menu to scroll
if it won't fit
Change-Id: I1998a842d25752389ec9032e54673408d1ed6cb5
|
|
Change-Id: Iaea4396f60aeade5303bf83a4504ad62f161b83c
|
|
Change-Id: Idd1e33b6da8be9575e74701735f0dbc742849c07
|
|
Change-Id: Ic3e96eebbb914c5b905a8c58532ead9cb01dd41d
Reviewed-on: https://gerrit.libreoffice.org/5721
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I579525326be702ffbb57d49970da5804fd2fe12d
|
|
Change-Id: I04c7da143425a9d8cc4fae155ad45a469df953c1
|
|
This reverts commit 43b1ac3651732a1ceb193268ab72b4aaa90dee65.
|
|
Change-Id: I9469363c09e4cc863ad4d8ddddf8d923fe444e25
|
|
Change-Id: Ie6b44d1f4abe1826254ab5bb178d73606bd1283c
|
|
- Add mouse rollover handling code to vcl::MenuBarWindow and vcl::Menu
- Add member variable of rollover color to StyleSettings and ImplStyleData
- Add rollover color definitions for each platforms
Change-Id: I9ececd8a7089918ac63c5f2027c0c2f361a9d227
Reviewed-on: https://gerrit.libreoffice.org/3856
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
|
|
for symmetry also the other constructors in the same class
and mark their destructors as virtual if they are anyway
(cherry picked from commit 870349eada8c0e56d58c8d2ee40ad561a9f982fe)
Conflicts:
vcl/inc/vcl/button.hxx
vcl/inc/vcl/combobox.hxx
vcl/inc/vcl/ctrl.hxx
vcl/inc/vcl/dialog.hxx
vcl/inc/vcl/dockingarea.hxx
vcl/inc/vcl/event.hxx
vcl/inc/vcl/field.hxx
vcl/inc/vcl/fixed.hxx
vcl/inc/vcl/floatwin.hxx
vcl/inc/vcl/fontmanager.hxx
vcl/inc/vcl/group.hxx
vcl/inc/vcl/lstbox.hxx
vcl/inc/vcl/menu.hxx
vcl/inc/vcl/menubtn.hxx
vcl/inc/vcl/metaact.hxx
vcl/inc/vcl/morebtn.hxx
vcl/inc/vcl/pngread.hxx
vcl/inc/vcl/scrbar.hxx
vcl/inc/vcl/spin.hxx
vcl/inc/vcl/spinfld.hxx
vcl/inc/vcl/split.hxx
vcl/inc/vcl/syschild.hxx
vcl/inc/vcl/tabpage.hxx
vcl/inc/vcl/virdev.hxx
vcl/inc/vcl/wrkwin.hxx
Change-Id: I8c29f74208cf382a9baa01c2e2d0757688cb4641
|
|
see https://gerrit.libreoffice.org/#/c/3367/
and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details
Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a
|