| Age | Commit message (Collapse) | Author |
|---|
|
The property "PreviewSizeHint" and the enum value ForPreview in
GraphicFilterImportFlags doesn't seem to be used from outside, so
let's remove it as it simplifies the PNG and JPEG import filters.
It is generally more recommended to load the bitmap file fully and
only then resize it to a smaller (preview) size.
Change-Id: I97f333686c25f7a7a4bdf6c6f0885154b515fd3d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89932
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
...as emitted by at least GCC 8.2 with --enable-optimized:
> In file included from vcl/source/gdi/pngread.cxx:27:
> include/vcl/pngread.hxx: In member function ‘bool vcl::PNGReaderImpl::ReadNextChunk()’:
> include/vcl/pngread.hxx:49:12: error: ‘aDummyChunk.vcl::PNGReader::ChunkData::nType’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> struct ChunkData
> ^~~~~~~~~
The immediately relevant part is initializing
sal_uInt32 nType = 0;
in the ChunkData ctor, but while at it, also make the Read*Int32 calls in
PNGReaderImpl::ReadNextChunk more robust.
Change-Id: Id6ad10a4382a8d063fd70c7bac595c3693475ca3
Reviewed-on: https://gerrit.libreoffice.org/66619
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca
Reviewed-on: https://gerrit.libreoffice.org/36896
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I36fb35338d8635e4bf1ac7c60e0f09da401406db
|
|
Conflicts:
include/framework/preventduplicateinteraction.hxx
include/sfx2/sfxbasecontroller.hxx
include/sfx2/sfxbasemodel.hxx
include/toolkit/awt/vclxtabpagemodel.hxx
include/vcl/field.hxx
include/vcl/settings.hxx
Change-Id: Ibccf9f88c68267a3d7e656012b51eaf644c418c2
Reviewed-on: https://gerrit.libreoffice.org/8272
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Iaea4396f60aeade5303bf83a4504ad62f161b83c
|
|
Change-Id: I85944f6912f01d883da976d5dd967f435104bad0
|
|
for symmetry also the other constructors in the same class
and mark their destructors as virtual if they are anyway
(cherry picked from commit 870349eada8c0e56d58c8d2ee40ad561a9f982fe)
Conflicts:
vcl/inc/vcl/button.hxx
vcl/inc/vcl/combobox.hxx
vcl/inc/vcl/ctrl.hxx
vcl/inc/vcl/dialog.hxx
vcl/inc/vcl/dockingarea.hxx
vcl/inc/vcl/event.hxx
vcl/inc/vcl/field.hxx
vcl/inc/vcl/fixed.hxx
vcl/inc/vcl/floatwin.hxx
vcl/inc/vcl/fontmanager.hxx
vcl/inc/vcl/group.hxx
vcl/inc/vcl/lstbox.hxx
vcl/inc/vcl/menu.hxx
vcl/inc/vcl/menubtn.hxx
vcl/inc/vcl/metaact.hxx
vcl/inc/vcl/morebtn.hxx
vcl/inc/vcl/pngread.hxx
vcl/inc/vcl/scrbar.hxx
vcl/inc/vcl/spin.hxx
vcl/inc/vcl/spinfld.hxx
vcl/inc/vcl/split.hxx
vcl/inc/vcl/syschild.hxx
vcl/inc/vcl/tabpage.hxx
vcl/inc/vcl/virdev.hxx
vcl/inc/vcl/wrkwin.hxx
Change-Id: I8c29f74208cf382a9baa01c2e2d0757688cb4641
|
|
see https://gerrit.libreoffice.org/#/c/3367/
and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details
Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a
|
