summaryrefslogtreecommitdiff
path: root/include/vcl/scrbar.hxx
AgeCommit message (Collapse)Author
2020-04-24loplugin:unusedenumconstants ScrollTypeNoel Grandin
Change-Id: I996bd987169caa60c63832e62e210a8c62e6a0e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92843 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-31loplugin:finalclasses in vclNoel Grandin
Change-Id: Id6dd59d0a335d84c513059ed7870135cf9959af8 Reviewed-on: https://gerrit.libreoffice.org/81827 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-23Fix moving / orientation-changing ScrollBarJan-Marek Glogowski
Just implements Move the same way then Resize. More importantly the patch correctly resets the Thumb and Page rectangles to position (0,0) instead of just Empty, which ImplCalc is based on. Otherwise this results in broken scroll bars, when the StarMath elements window is docked in in the bottom or top area and switches the scrolling orientation on undock. Change-Id: I32b0507cdd6551cc7f42655a730faf8ef25b747b Reviewed-on: https://gerrit.libreoffice.org/72794 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-09loplugin:unusedmethodsNoel Grandin
Change-Id: I7b4d2e5e611935284e2902b0089950768dfb7717 Reviewed-on: https://gerrit.libreoffice.org/72036 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-10tdf#42949 Fix IWYU warnings in include/vcl/s*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie87d27dd2c385a63349e0b322fd067ba03d2d152 Reviewed-on: https://gerrit.libreoffice.org/64479 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-05-21weld ScSortDlg, ScTabPageSortOptions and ScTabPageSortFieldsCaolán McNamara
Change-Id: I103e5e3670f8c95c1f480ce0c36e08c3de74e900 Reviewed-on: https://gerrit.libreoffice.org/54541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-25loplugin:useuniqueptr in ScrollBarNoel Grandin
Change-Id: I827e997391834d10a617b7c5be8ceafc19e97219 Reviewed-on: https://gerrit.libreoffice.org/53343 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-17loplugin:unusedfields in vcl part1Noel Grandin
Change-Id: I67d176003f39992cd0ff9271a7d6ce26d2cb6619 Reviewed-on: https://gerrit.libreoffice.org/38828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-23TODO: move to ScrollBar when binary incompatibility is no longer problematicCaolán McNamara
since... commit 72ebade6ba9e88a5a24db57266a53e8f52049214 Author: Ivo Hinkelmann <ihi@openoffice.org> Date: Thu Sep 13 15:33:31 2007 +0000 INTEGRATION: CWS aquavclcarbonfixes (1.20.70); FILE MERGED 2007/08/29 12:59:47 hdu 1.20.70.1: #i77549# extend native scrollbar NWF by adding PART_TRACK_*_AREA controls Change-Id: I124c4014556f3a10b986a2886202210ebfc9eb10 Reviewed-on: https://gerrit.libreoffice.org/35586 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-07loplugin:constantparam in vcl..xmlscriptNoel Grandin
Change-Id: Icf66c08071b154259c9e551342d30331caf2b15a Reviewed-on: https://gerrit.libreoffice.org/28685 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-05convert ScrollType to scoped enumNoel Grandin
Change-Id: I6dd02d4f7df028dada6cfd5d767a6ec1b1c1efe1
2016-06-24loplugin:singlevalfields in vcl(part1)Noel Grandin
Change-Id: I0031199937cc95793951a070c4b3d8910933e69f Reviewed-on: https://gerrit.libreoffice.org/26595 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-26loplugin:unuseddefaultparams in /include/vclNoel Grandin
Change-Id: I36daccd90bfa6ba0ee8b9e76bff2bd8494155a04 Reviewed-on: https://gerrit.libreoffice.org/22710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09Formatting changes across all modulesChris Sherlock
+ Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-09-04convert Link<> to typedNoel Grandin
Change-Id: I2136c3db2742afcb4722f69297276bea1e0119f4 Reviewed-on: https://gerrit.libreoffice.org/18306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-13loplugin:unusedmethods vclNoel Grandin
Change-Id: I53c66b7898f4e0a66e6172d22c6f782dadaf6589 Reviewed-on: https://gerrit.libreoffice.org/16975 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-10loplugin:unusedmethods vcl(part2)Noel Grandin
Change-Id: I12356b3fdce68282a30cae2b270b02e46558860a Reviewed-on: https://gerrit.libreoffice.org/16847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-27convert WINDOW_DRAW flags to scoped enumNoel Grandin
Change-Id: I9400a286fab18d683b4c109007961685f01b6da3
2015-05-20-Werror,-Winconsistent-missing-overrideStephan Bergmann
Change-Id: Ifc2e1159744dcaf5e7b0249ad00610e41cfe4fca
2015-05-20scrollbar - setup painting settings in ApplySettingsTomaž Vajngerl
Change-Id: I5eeaa1ee9c63f1a1d624022857a80cbebc079627
2015-05-07refactor ScrollBar to use RenderContextTomaž Vajngerl
Change-Id: I8707fa934d729d96e019ad5d0688299bf88954c4
2015-05-05Use typed Timer::SetTimeoutHdl LinkStephan Bergmann
Change-Id: Iaaf0c93e5b28c0f7dbe4f02eda8beeae30708100
2015-04-30Gradually typed LinkStephan Bergmann
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-29mass rewrite Paint(Rect&) to Paint(RenderContext&, Rect&)Tomaž Vajngerl
Change-Id: Ia1667246064d11827dbd149def15e5bf08b119b8
2015-04-09vcl: window destructors calling disposeNoel Grandin
Extend plugin to warn on any vcl::Window subclass that has a destructor and does not implement dispose. Apply this provision to the necessary classes in vcl/ Change-Id: I05189f8df02568131d59fc44fea904c87733c8c7
2015-04-09vcl: rename VclReference to VclPtrNoel Grandin
and remove the typedefs. The code is more obvious this way. Change-Id: I4c8f5b5ab050dd96216302a03e760ed0e3ab3464
2015-04-09manage VCL widgets using rtl::ReferenceNoel Grandin
Change-Id: Ie95790cbaa5d459c8e849d7333098d857d31ed0a
2015-01-26followup code removal after changing virtual methods to non-virtualNoel Grandin
This cleanups up indentation and removes dead classes. This is a followup patch to commit 272b1dd55797aacf511fb4342b0054e3697243f6 "new loplugin: change virtual methods to non-virtual" Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2014-10-29ref-counting vcl::Window subclassesNoel Grandin
Points of discussion -------------------- (*) where in the Window destructor should dispose() be called? It's a seriously large method. (*) we're going to need similar typedefs and declarations for every single sub-class of vcl::Window, I assume that I will need to create a macro to make it less verbose. TODO ---- Update clang plugin to verify that: (a) dispose() methods always call their superclass dispose() (b) dispose() methods don't forget to clear any references owned by that class. Change-Id: I873d5d5166f811e2f65e49327cc98862559fcf30
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-08-12callcatcher: another round of ResId removalsCaolán McNamara
Change-Id: Ia3acdb3501b7735820258cb090e731f5814bc07f
2014-08-11callcatcher: update unused codeCaolán McNamara
lots of ResID stuff going away now Change-Id: Iad8524e201cd3072db71da9e5ee1c244ed337967
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-01Remove visual noise from includeAlexander Wilms
Conflicts: include/framework/preventduplicateinteraction.hxx include/sfx2/sfxbasecontroller.hxx include/sfx2/sfxbasemodel.hxx include/toolkit/awt/vclxtabpagemodel.hxx include/vcl/field.hxx include/vcl/settings.hxx Change-Id: Ibccf9f88c68267a3d7e656012b51eaf644c418c2 Reviewed-on: https://gerrit.libreoffice.org/8272 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-21vcl: sal_Bool -> boolStephan Bergmann
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-01-18Window::PreNotify should return boolStephan Bergmann
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2013-10-23fixincludeguards.sh: include/vclThomas Arnhold
Change-Id: Iaea4396f60aeade5303bf83a4504ad62f161b83c
2013-05-10make some important single-parameter constructors explicitHerbert Dürr
for symmetry also the other constructors in the same class and mark their destructors as virtual if they are anyway (cherry picked from commit 870349eada8c0e56d58c8d2ee40ad561a9f982fe) Conflicts: vcl/inc/vcl/button.hxx vcl/inc/vcl/combobox.hxx vcl/inc/vcl/ctrl.hxx vcl/inc/vcl/dialog.hxx vcl/inc/vcl/dockingarea.hxx vcl/inc/vcl/event.hxx vcl/inc/vcl/field.hxx vcl/inc/vcl/fixed.hxx vcl/inc/vcl/floatwin.hxx vcl/inc/vcl/fontmanager.hxx vcl/inc/vcl/group.hxx vcl/inc/vcl/lstbox.hxx vcl/inc/vcl/menu.hxx vcl/inc/vcl/menubtn.hxx vcl/inc/vcl/metaact.hxx vcl/inc/vcl/morebtn.hxx vcl/inc/vcl/pngread.hxx vcl/inc/vcl/scrbar.hxx vcl/inc/vcl/spin.hxx vcl/inc/vcl/spinfld.hxx vcl/inc/vcl/split.hxx vcl/inc/vcl/syschild.hxx vcl/inc/vcl/tabpage.hxx vcl/inc/vcl/virdev.hxx vcl/inc/vcl/wrkwin.hxx Change-Id: I8c29f74208cf382a9baa01c2e2d0757688cb4641
2013-04-23execute move of global headersBjoern Michaelsen
see https://gerrit.libreoffice.org/#/c/3367/ and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a
generated by cgit (git 2.34.1) at 2025-02-03 00:55:53 +0000