summaryrefslogtreecommitdiff
path: root/include/vcl/splitwin.hxx
AgeCommit message (Collapse)Author
2020-02-11SplitWindow::ImplDrawBack is effectively unusedNoel Grandin
ever since commit facc94bb0aef58353d54e14f948790643ccbec32 Date: Thu Jan 30 14:36:57 2020 +0200 loplugin:unusedfields Change-Id: Idb09424a09074abe77d6d5b63ea4a526a3bb7ed2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88423 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-23loplugin:constparams in vclNoel Grandin
Change-Id: Icf1a952fbe190fd6c4efd89364136aa2b48050e3 Reviewed-on: https://gerrit.libreoffice.org/66767 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-10tdf#42949 Fix IWYU warnings in include/vcl/s*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie87d27dd2c385a63349e0b322fd067ba03d2d152 Reviewed-on: https://gerrit.libreoffice.org/64479 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-26remove unused enum value SplitWindowItemFlags::InvisibleNoel Grandin
Change-Id: I4d63601ca3658b4ffd9eaf1c13d4c17503640aa0 Reviewed-on: https://gerrit.libreoffice.org/64041 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-30ImplSplitSet::mpBitmap is unusedNoel Grandin
Change-Id: Iadbeb462a34b9bdabe5bf71249eeef798fe6372a Reviewed-on: https://gerrit.libreoffice.org/55044 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-23loplugin:useuniqueptr in SplitWindowNoel Grandin
Change-Id: I04b45f02ce0dc98d11fb78982b8364fdd8333f9c Reviewed-on: https://gerrit.libreoffice.org/53233 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-12More loplugin:cstylecast: vclStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I363c01a1ae9e863fca4fb4589829492d7280d711
2017-04-25loplugin:checkunusedparams in vclNoel Grandin
Change-Id: I26661684e634aa15a18f78442de15c9db832f319 Reviewed-on: https://gerrit.libreoffice.org/36886 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05loplugin:constantparamNoel Grandin
Change-Id: I1996319e5b664dff95f7a9b2346aea6092d333ec Reviewed-on: https://gerrit.libreoffice.org/36070 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-25Fix typosAndrea Gelmini
Change-Id: Ia8bd59be341b0731198d48df974b60ecb04e289c Reviewed-on: https://gerrit.libreoffice.org/35635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-21loplugin:unusedmethodsNoel Grandin
Change-Id: I52a9f16f3ed543a3c83ca111df70e3f7ae1ef33c Reviewed-on: https://gerrit.libreoffice.org/34508 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-04drop unused SplitWindow::ImplDrawButtonRectCaolán McNamara
Change-Id: I0ccb4adfec39f8717d5921e04809af65be066d0a
2017-01-04follow up remove unused autohide leftoversCaolán McNamara
Change-Id: Ic7281e915075519c300a330557399111838d7d34
2017-01-04drop AutoHide codeCaolán McNamara
only used from reportdesign and that appears to be overlooked from an earlier eradication program Change-Id: I196fd7ccbc909c935daf534d55e6b39de8510f23
2016-11-15loplugin:countusersofdefaultparams in include/vclNoel Grandin
Change-Id: I16979e6d49e7f1ff7ea53194cfc64fddf27d00cf Reviewed-on: https://gerrit.libreoffice.org/30841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-10loplugin:unnecessaryoverride in vclNoel Grandin
Change-Id: I8a49316dccdc142389d2f7121ff7c8cbbad55638 Reviewed-on: https://gerrit.libreoffice.org/29655 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-07loplugin:staticmethods: vclStephan Bergmann
Change-Id: I9a563100400375cd185729282b3e4f1ff3a44151
2016-09-15loplugin:countusersofdefaultparams in vclNoel Grandin
Change-Id: I046e6f16c5b171a06e2be2da2f72340634f3e979 Reviewed-on: https://gerrit.libreoffice.org/28891 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-08-31loplugin:countusersofdefaultparamsNoel Grandin
Change-Id: I697b9081424acdc61107709392baa8af8ce29028 Reviewed-on: https://gerrit.libreoffice.org/28497 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-24loplugin:singlevalfields in vcl(part1)Noel Grandin
Change-Id: I0031199937cc95793951a070c4b3d8910933e69f Reviewed-on: https://gerrit.libreoffice.org/26595 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16loplugin:constantparams in vcl/Noel Grandin
also some improvements to the plugin Change-Id: I0e3a519d70756e577fcb1bd47dd66864b5b4c871 Reviewed-on: https://gerrit.libreoffice.org/23289 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-26loplugin:unuseddefaultparams in /include/vclNoel Grandin
Change-Id: I36daccd90bfa6ba0ee8b9e76bff2bd8494155a04 Reviewed-on: https://gerrit.libreoffice.org/22710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-09-03convert Link<> to typedNoel Grandin
Change-Id: I8bea5ac685b0076649412bd95501461242797d77 Reviewed-on: https://gerrit.libreoffice.org/18266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-24convert WindowAlign to scoped enumNoel Grandin
Change-Id: I028d108b3a83bd5541d873c4d03b87339cd3be52
2015-07-13loplugin:unusedmethods vclNoel Grandin
Change-Id: I53c66b7898f4e0a66e6172d22c6f782dadaf6589 Reviewed-on: https://gerrit.libreoffice.org/16975 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-21convert SWIB constants to scoped enumNoel Grandin
Change-Id: If64368f22e748cc646a726cb962e60ad29a66df9 Reviewed-on: https://gerrit.libreoffice.org/15840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-19tdf#91259 Crash when closing HelpPhilippe Jung
Rewrite of splitwin. The previous implementation used struct and memset/memcpy/memmove. Struct have been replaced by classes with destructors. Array of pointers are handled in vectors. This enables clean call to clear of VclPtr. Change-Id: Iab77303fb1d802f208dfdf476140557e42af949a Reviewed-on: https://gerrit.libreoffice.org/15788 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-18Revert "tdf#91259 Crash when closing Help"Michael Meeks
This reverts commit 91b181467f8fe5f7bf325e3bb82aead7eadc6ad9.
2015-05-16Correct forward definition.Michael Meeks
Change-Id: I6cf65892c0b3dd929067f2bdc1176a1a870df042
2015-05-16tdf#91259 Crash when closing HelpPhilippe Jung
Rewrite of splitwin. The previous implementation used struct and memset/memcpy/memmove. Struct have been replaced by classes with destructors. Array of pointers are handled in vectors. This enables clean call to clear of VclPtr. Change-Id: Idfbe698348f7bfb46aae7f97f6edbe7127df58cf Reviewed-on: https://gerrit.libreoffice.org/15756 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-11refactor SplitWindow to use RenderContexTomaž Vajngerl
Change-Id: I4f36977e7b1c4c210b8c70ec7aa248d9e6912241
2015-04-30Gradually typed LinkStephan Bergmann
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-29mass rewrite Paint(Rect&) to Paint(RenderContext&, Rect&)Tomaž Vajngerl
Change-Id: Ia1667246064d11827dbd149def15e5bf08b119b8
2015-04-09vcl: window destructors calling disposeNoel Grandin
Extend plugin to warn on any vcl::Window subclass that has a destructor and does not implement dispose. Apply this provision to the necessary classes in vcl/ Change-Id: I05189f8df02568131d59fc44fea904c87733c8c7
2015-03-09V801: Decreased performanceCaolán McNamara
Change-Id: I9e9a00acf9503980f0c6c7cd0a20378e5ca7390d
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: I9ea64443350ed2e1341b99270fa8b29189f07eb2
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-02-21vcl: sal_Bool -> boolStephan Bergmann
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-01-30fdo#63154 Removed unused solar.h ref. in vclAlexandre Vicenzi
Change-Id: I038c941559a275c43c2be7d5453ca4c37390f343 Reviewed-on: https://gerrit.libreoffice.org/7733 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-18Window::PreNotify should return boolStephan Bergmann
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2013-10-23fixincludeguards.sh: include/vclThomas Arnhold
Change-Id: Iaea4396f60aeade5303bf83a4504ad62f161b83c
2013-04-23execute move of global headersBjoern Michaelsen
see https://gerrit.libreoffice.org/#/c/3367/ and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a
generated by cgit (git 2.34.1) at 2025-02-10 02:13:16 +0000