summaryrefslogtreecommitdiff
path: root/include/vcl/svapp.hxx
AgeCommit message (Collapse)Author
2014-02-21vcl: sal_Bool -> boolStephan Bergmann
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-20Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxxTobias Lippert
Added vcl/settings.hxx to all cxx files which require it. This helps to speed up compilation after changes to the settings. Conflicts: sc/source/ui/dbgui/pvlaydlg.cxx Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4 Reviewed-on: https://gerrit.libreoffice.org/7933 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-05Doxygen warnings correctedChris Sherlock
* Doxygen spits out a lot of warnings about not being able to find match function signatures, etc. This is because in some headers we have a using namespace statement, in others it gets confused between ::Window and Window (!). * Wrong use of tags: + Lots of @seealso - should be @see + Wrong usage of @overload - corrected with the right function signature + HTML tags that doxygen doesn't recognize removed Change-Id: I1c2eed941619b8764dbfcfc5ab38027518cdf261
2014-02-04Revert "Doxygen warnings corrected"Caolán McNamara
This reverts commit ff8036df5c5575503dc30d255dfbe99cc637c510. multiple build failures with namespace collisions etc Change-Id: Ie8ac08feff518af3584a26957f07a60d95932c76 Reviewed-on: https://gerrit.libreoffice.org/7855 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-04Doxygen warnings correctedChris Sherlock
* Doxygen spits out a lot of warnings about not being able to find match function signatures, etc. This is because in some headers we have a using namespace statement, in others it gets confused between ::Window and Window (!). * Wrong use of tags: + Lots of @seealso - should be @see + Wrong usage of @overload - corrected with the right function signature + HTML tags that doxygen doesn't recognize removed Conflicts: include/vcl/toolbox.hxx Change-Id: I687f45e426280d411ef3cb6d8d5993a829f2f324 Reviewed-on: https://gerrit.libreoffice.org/7725 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-04More Application class documentation updatesChris Sherlock
* Completed documentation of the Application class: + Documented and grouped functions relating to - dialogs - application help - mnemonics - accelerators - VCL toolkit and UNO wrapper functions - IME Status functions - platform functionality - graphic filter functions - headless mode functions. + Documented event hook function. * Documented the ApplicationEvent class Change-Id: I79a77212aa64ef1d4d40bfed2b73af5dce357731 Reviewed-on: https://gerrit.libreoffice.org/7713 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-04Change Application::SystemSettingsChanging to OverrideSystemSettingsChris Sherlock
The name Application::SystemSettingsChanging implies that the app is being notified that system settings are being changed. This is not what the function does - in fact, SystemSettingsChanging overrides a settings object with user defined settings Change-Id: Ibbf821ff3c7ec5b38e2e79751058494c749b6428 Reviewed-on: https://gerrit.libreoffice.org/7629 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2014-01-28Document Application classChris Sherlock
Documented more of the VCL Application class's public functions via Doxygen markup. Also, change from global groups to member groups. Change-Id: I5e80e707874db99c60e899d078f41c7817e2b6c3 Reviewed-on: https://gerrit.libreoffice.org/7664 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-23Remove unnecessary verbiage.Chris Sherlock
Change-Id: Icf0230577a5458425f22579e8d17f69c53310812 Reviewed-on: https://gerrit.libreoffice.org/7608 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-23Document more of VCL's Application classChris Sherlock
* Documented the Application class's settings functions. When reading through the code, I have noticed that GetSettings intializes the application settings (!) and that SetSettings relies on GetSettings to initialize the settings (!), so I have listed a todo entry. Furthermore, I've also noticed that SetSystemSettings and MergeSystemSettings may be confused with the purpose of SetSettings so I've added a todo entry that recommends that we return an AllSettings object and make the parameters const. * Minor whitespace changes * Update @see for a number of public functions * Group functions into Doxygen modules Change-Id: I48f8d21a5d6436a2ae545e5156b877d57a8bc585
2014-01-22Fix misaligned code commentChris Sherlock
I accidentally introduced this problem in commit 89a7b8a13285 Moved line of code to before the correct function. Change-Id: Ic044a5607dc385140ca51d1bf4aa734c0cf99904 Reviewed-on: https://gerrit.libreoffice.org/7595 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>
2014-01-22Improve settings code reabilityChris Sherlock
Application::SetSettings relies on Application::GetSettings to initialize the application's settings if this hasn't happened. This means that GetSettings is being used not to get the app's settings, but to initialize the settings! I have corrected this by introducing a private static function InitSettings(). Note that I assert if it attempts to initialize already initialized settings, because the (Get|Set)Settings does the check for you. Also changed a local variable from nGet to nDragMode in Desktop::SystemSettingsChanging to make it easier to read the code. Whilst this is minor, a variable name of "nGet" seems very sloppy. Change-Id: I04975217c2028b3489179997db4287957578cc93 Reviewed-on: https://gerrit.libreoffice.org/7586 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-01-21Change EnableNoYieldMode(bool) to better namesChris Sherlock
It makes no sense to disable something via an Enable function. I have split the function into Enable and Disable functions, and update the code accordingly. Conflicts: include/vcl/svapp.hxx Change-Id: Ic05d69796f43e802a4a2a16aaca44433b6eaa018 Reviewed-on: https://gerrit.libreoffice.org/7525 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-20Remove unused Window parameter from SystemSettingsChangingChris Sherlock
This took a bit of code archaelogy for me to track down. It turns out that as part of an effort to optimize startup, the line of code in this function was commented out, presumably to be rewritten later. This happened in commit ee3351d78c in July 2001 (!). About three years later, in February 2004, the function was rewritten in commit 189c2388d80. As it turns out, the only two functions that used the Window parameter were vcl/source/window/window.cxx (which passed itself in, but of course this did nothing) and vcl/source/window/winproc.cxx. Furthermore, winproc only ever passed in the first frame, so it didn't really do anything either. Consequently, the function as it stands *now* only notifies the application that system settings have been changed. It doesn't care which window it tells. Therefore, I have excised this parameter from the function. I don't think it made sense when it was implemented anyway, so there is no net loss. After removing the unneeded parameter, I was also able to remove the Window parameter from winproc.cxx's ImplHandleSalSettings function as it was only ever used to set the top level window, which is now irrelevant. Change-Id: I84f2c5c5ff8969387da3af81e4a9c7f9ac6237e1 Reviewed-on: https://gerrit.libreoffice.org/7541 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-20Document VCL Application classChris Sherlock
Documented the VCL Application class in Doxygen format. Also reindented some of the code, and moved ValidateSystemFont down the list of class functions (better code organization). Change-Id: Id421647a9a25e11be87b0f6c46d1ac0f4846f6a4 Reviewed-on: https://gerrit.libreoffice.org/7515 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-08Revert "make FilePicker::createWithMode not crash"Matúš Kukan
This reverts commit 58ea27124af27bfac21a796b0d13d72354bd0dd3. It's probably better to fix it another way.
2013-12-28make FilePicker::createWithMode not crashCaolán McNamara
i.e. calc->data->XML Source->"browse to set source" calls com_sun_star_comp_svt_FilePicker_get_implementation with its single argument in arguments as opposed to the empty argument expected there. So allow the single-argument case, and pass the argument through and apply it automatically via XInitialization::initialize in Application::createFilePicker. I'm far from sure that this is the right solution, but it has the advantage of working vs crashing. Change-Id: I07c1baae7f47781920eac56763e8fd003a7b99e1
2013-12-12chmod -xTor Lillqvist
Change-Id: I51d817cf01ba3cd87a2b78e00c96707dbdb78a3b
2013-12-05fdo#39956 Delete JABDavid Ostrovsky
JAB has been discontinued in favor of the native IA2 bridge. Change-Id: I88461f73c620507d3e97b077ea2abdd2229322e1 Reviewed-on: https://gerrit.libreoffice.org/6819 Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de> Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2013-11-19Gbuildify winaccessibility serviceDavid Ostrovsky
Conflicts: winaccessibility/source/UAccCOM/UAccCOM.def winaccessibility/source/service/AccObjectWinManager.cxx winaccessibility/source/service/checkmt.cxx winaccessibility/source/service/checkmt.hxx Change-Id: Ia66872bee7c70c840c1bd5caa626bf63eac9ef7c
2013-10-23fixincludeguards.sh: include/vclThomas Arnhold
Change-Id: Iaea4396f60aeade5303bf83a4504ad62f161b83c
2013-10-16cleanupThomas Arnhold
Change-Id: I7bfd221f89718ba8634417c93a26b3a199178694
2013-09-25Related: fdo#38838 remove UniString::EqualsIgnoreCaseAsciiCaolán McNamara
Change-Id: Ib5c3a2daa4a48bc286b14fa2cebb3306ea0012bc
2013-08-12convert vcl/svapp.hxx from String to OUStringNoel Grandin
Change-Id: I95c203d1096ebd2e58a11b52097e5080b891243b
2013-07-28Make AddToRecentDocumentList aware of the DocumentServiceFridrich Štrba
This information helps to map a document with an application ID needed for Windows 7 shell integration. Change-Id: I1224f566037ab7597a29b16f310f93d9f5441cce
2013-07-27fdo#54264: Fix multi-argument ApplicationEvent::TYPE_OPEN/PRINTStephan Bergmann
...that had been broken when 5c22a03320f20ae9ac2c3c16025e7c5e3a7915d5> "Cleaned up CommandLineArgs" changed the representation of those multi-arguments from a single string with \n delimiters to vector<string> in desktop/soruce/app/cmdlineargs.hxx, but missed updating other producers of such ApplicationEvents. Change-Id: I527d620c60a87f3a01d970927c521163fb6df192
2013-07-25convert some XubString to OUString in ApplicationNoel Grandin
Change-Id: Ieed48339e9fc01796674691d5b0580a36df6e63e
2013-07-19remove Application::GetWorkAreaPosSizePixelNoel Grandin
This internal API has always been problematic because we cannot support it under the Linux toolkits, where it has in fact always just returned the size of the screen. Change-Id: I406bcbca8a4161b4261ef46940823bb07c6ad18b Reviewed-on: https://gerrit.libreoffice.org/4976 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@suse.com> Tested-by: Michael Meeks <michael.meeks@suse.com>
2013-07-10Remove an un-used mode on Application::Yield.Michael Meeks
2013-06-30XubString->OUStringCaolán McNamara
Change-Id: I40ff06facc304630ccedd82d2f20b3573bdc5cb4
2013-06-04vcl: add a console-only mode to avoid problems on Mac for gengal.Michael Meeks
Change-Id: Ie5332330e6f398c3cd7e58df9b12fac121f5426f
2013-05-22replace DialogCancelledException with std::abortMarkus Mohrhard
Change-Id: Ib815c1a84efa4682ad644132ad3704f249b04a68
2013-05-14SolarMutex does not belong into the URE interfaceStephan Bergmann
...so move it from osl/mutex.hxx to its own comphelper/solarmutex.hxx. It looks like a newbie mistake that 59e7685d8d812ee8773f57475cbe3aa2a0bdfc81 "Create an abstract interface to be used to implement a SolarMutex" put it here in the first place. I do not consider this an incompatible change really, as no external URE client code should have used SolarMutex anyway. (Also included some clean up, like removing unused {Clearable,Resettable}SolarGuard, and spelling out SolarGuard in the few places it is used.) Change-Id: I121ffb5b7cefbc19e88b5405e5a85ffc895be852
2013-05-11sal_Bool to boolTakeshi Abe
Change-Id: I7e69466f189b845a807edbf3ca4422b0fb2aec94
2013-04-23execute move of global headersBjoern Michaelsen
see https://gerrit.libreoffice.org/#/c/3367/ and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a