summaryrefslogtreecommitdiff
path: root/include/vcl
AgeCommit message (Collapse)Author
2020-03-23make more classes private in mergedlibs modeNoel Grandin
Change-Id: I486922d0652f26fa7ee56f5fe308e19fe5ff137e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90856 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-21add get_modifier_state to toolbar for what modifiers are heldCaolán McNamara
Change-Id: I77e7f6238d82249ffede1edee2dc88f1a76b3717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90860 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-18pdfium: support for pages when using PDF import with pdfiumTomaž Vajngerl
Moving PDF to use VectorGraphicData in Graphic has temporary removed the support for showing different PDF pages when opening the PDF using pdfium (LO_IMPORT_USE_PDFIUM=1). This adds the support for back by specifying whcih PDF page to render when creating the VectorGraphicData (and can't be changd afterwards), which is used to create a Graphic and contains the PDF source data array. Change-Id: Ib915216b8d4c0c063d0fead44ff156b1915a35d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90562 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-17pdfium: Make Insert -> Image... use VectorGraphicData for PDF.Jan Holesovsky
In principle, the current Svg/Emf/Wmf and PDF handling is trying to achieve the same thing: Keep the original stream untouched, provide a replacement graphics, and a kind of rendering. To hold the data, the Svg/Emf/Wmf and PDF were using different structures though. This commit consolidatates that, and makes the Insert -> Image... (for PDF) actually using the VectorGraphicData to hold the original stream. This breaks loading the PDF as a document via PDFium - I'll fix it in the next commit(s). Change-Id: Iac102f32b757390a03438c165e430283851cc10b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90561 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-16Revert "loplugin:constfields in vcl"Noel Grandin
This reverts commit 59887868da3499c68d5f259cfa48178354397448. Change-Id: I0f3f6a7680c78103a559a0f881badc8211b97ace Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90544 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-13Revert "loplugin:constfields in svtools"Noel Grandin
This reverts commit 07c4aa4298f062cee1894b80ef82e76d5ffcf4c7. Change-Id: Ic3f639581b9aca373f82c011f15be60d117b1943 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90476 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-13vcl: warn about unused GraphicConversionParameters instancesMiklos Vajna
I just made the mistake of creating one but then forgetting to use it, warn about that. Change-Id: Ie7e6e34eb234468d4a255e438b9551c81a9d2fe2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90459 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-12comparison operators should be constNoel Grandin
Change-Id: Ifa76e004128223460945d58d1c59c4e23db0f108 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90370 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-11m_sHelpRoot in weld::Builder is unusedNoel Grandin
since commit 082e69fefb7439fd4f3d543f0c402039e94c1e9c convert various MessBox to weld::MessageDialog - Change-Id: I08370632803c26ac9c47267e57c51eb56ad713f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-11tdf#125440 Allow raising text import dialog for pasteSamuel Mehrbrodt
This adds an entry to the "Paste special" dialog to raise the Text Import Dialog. This way, users can correctly import CSV/TSV, even when pasting just one line of formatted input. Change-Id: Ic09d7d60a05b14906f166668b38ec0eb8ead2d19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89886 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-03-10writer navigator requires ability of per-row extra indentCaolán McNamara
Change-Id: Iaf34e245b2418c0dddb9a8a449da1a0abdd8def2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90257 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-09make SpinField DLLPUBLIC againNoel Grandin
to fix Window --enabled-mergedlibs Change-Id: I0459798449e63c5e77a7b2e961520317d2383527 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90218 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Jenkins
2020-03-09add capability to remove a menu itemCaolán McNamara
Change-Id: Ie87645ea6b477a0d14deb66690d95fd203315ca0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90194 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-08ofz#20622 oomCaolán McNamara
Change-Id: Id77d90197e98d29787a40966f248dd769c9dac28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90175 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-07Fix typed flags maskMatteo Casalin
after commit 2876a0f79f94cdd139cc8fa40669acde9674bf8c Change-Id: Ibf27d74d73b0e8624efaffdc252b27e366245e38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90165 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@libreoffice.org>
2020-03-06tdf#125532: White text on default/action buttons and selected tabs on macOSThorsten Wagner
Change-Id: I58ce75e711504553c8fc606382866754286f1aa7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89313 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-06add iter_previousCaolán McNamara
Change-Id: Id481e687c623db6ade6c17d039f347e66cb167aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90106 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-06document a bit about treeview selections and freeze/thawCaolán McNamara
Change-Id: I38bb84d26f99b845895ba397fa50e534111a114f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90104 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-06limit symbols exported when using --enable-mergelibsNoel Grandin
when doing LTO and --enable-mergelibs, we can improve the effectiveness of LTO by marking more code as internal to the merged library. So introduce a new macro UNLESS_MERGELIBS, which we can wrap around *_DLLPUBLIC annotations Also introduced here is a script that can be run on a completed build to determine which classes can be marked with this macro. Change-Id: I73fb87c897489da53791277d0b66b01f884ba061 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89991 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-05vcl: put Impl class for Gradient into the cxx fileTomaž Vajngerl
Change-Id: Ib39ba659a09b680b3d15a59c51944eb213e63110 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90008 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-05vcl: move read and write to/from GfxLink to TypeSerializerTomaž Vajngerl
Change-Id: Ie99d00ea54296f5f3a909ade7115d9a9251f688e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89983 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-05vcl: put first and last native type into GfxLinkType enumTomaž Vajngerl
Until now we had define GFX_LINK_FIRST_NATIVE_ID and define GFX_LINK_LAST_NATIVE_ID which pointed to the first and last type n the GfxLinkType which represented the native type. A more elegant way to solve this is to assign an alias to the first and last value. So now we have "NativeFirst" and "NativeLast" defined in the GfxLinkType enum instead. Change-Id: I5613a1b544fc7ae4f8b884df94c6fa4e2fb322d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89982 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-04add iter_previous_siblingCaolán McNamara
Change-Id: Ic9ff26361cc9fed32760260e085660f05e13f4d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89987 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-04We have had C++11 for some time nowTor Lillqvist
Change-Id: I3946aba66a49518fb6c3fe6e1767babecddc956b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89962 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-03-04graphic: remove preview when importing with GraphicFilterTomaž Vajngerl
The property "PreviewSizeHint" and the enum value ForPreview in GraphicFilterImportFlags doesn't seem to be used from outside, so let's remove it as it simplifies the PNG and JPEG import filters. It is generally more recommended to load the bitmap file fully and only then resize it to a smaller (preview) size. Change-Id: I97f333686c25f7a7a4bdf6c6f0885154b515fd3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89932 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-04vcl: rename GetContext to GetReaderContext in GraphicTomaž Vajngerl
GetContext is a very generic method name, so rename it to a more specific GetReaderContext name. It is easier to find references. Change-Id: Ieb05ac63080598357107dc3e485b481910cd79cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89929 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-04allow control over treeview scroll positionCaolán McNamara
Change-Id: Ifa29416c4a716b3759f279ae4f0ce9179325f7a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89927 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-03tdf#101181 Implement glow effect on shapesTamas Bunth
Glow effect is a color-blurred outline outside of the shape. In ooxml document it is specified with the <a:glow> element. The commit contains the following: - Add support for importing and exporting <a:glow> from ooxml documents. - Assign new properties to XShape which stores glow-related attributes. - A new 2D primitive is introduced in module 'drawinglayer' which is responsible for representing the glow primitive which is to be rendered. + A glow primitive is a clone of the original shape which has been scaled up slightly and a new color has been assigned to it. The radius of the glow effect and the color is defined in the <a:glow> element being imported. - A blur algorithm is introduced in module 'vcl', which is called during rendering the primitive. + The blur algorithm works on a bitmap. + Since the algorithm is CPU-intensive, the result is cached in the processor and it is recalculated only if needed. - Add support for importing and exporting glow effect to ODF format. For that, new attributes of element <style:graphic-properties> has been added: + loext:glow, which can have the values "visible" or "hidden" + loext:glow-radius: which holds the radius of the glow effect in cm. + loext:glow-color: holds the color of the glow effect - Tests have been added to assert properties after pptx import and export. Change-Id: I836aeb5e0f24e2c8d5725834c8c0f98083bc82e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89125 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2020-03-03add a collapsing row hookCaolán McNamara
Change-Id: I83d690715a9e427d23b3f2316fd114c037487d54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89841 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-02Fix typoAndrea Gelmini
Like in 7fe40724b7b07710a501710466b6f10b526c2c97 Change-Id: I52eeeb46d4a6de44af94bc6fb3fb19b1c2dab3b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89759 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-29tdf#130515 Time field in Base form will not display correct formatNoel Grandin
regression from commit 65b7b6322b662785bf032e66c76abc36c9a2bb0e Date: Wed Feb 8 10:40:28 2017 +0200 loplugin:unusedenumconstants read-only constants in vcl Change-Id: Icf2e385763c8ece34521895331d148a5baacf2d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89706 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-28weld calc navigatorCaolán McNamara
note: non-standard dnd via parent so the treeview triggers the dnd but doesn't itself strictly speaking drive the dnd, see copying a range from the navigator where the calc main edit window shows the outline where the copy of the range from the calc main window will go Change-Id: Ideecbe779e3d9bb5b392357a93ec25f625180ba8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89597 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-28use COL_AUTO to let set_font_color reset to automatic text colorCaolán McNamara
Change-Id: I5761081fde66da3dc8071709e53b2014f10b5916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89651 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-27inherit ScLinkTransferObj from TransferDataContainerCaolán McNamara
Change-Id: I04d8a673e92e847e1485f85d951172bf71a8877b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89647 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-27loplugin:unusedfieldsNoel Grandin
Change-Id: I0d3941ed2a6f0caadbe080ac8a6273c5ec21462c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89616 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-27loplugin:singlevalfieldsNoel Grandin
Change-Id: I3aa19805fab937cd9516ce8127753a0f599c73c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89611 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-22tdf#127205 split Desktop::terminate processJan-Marek Glogowski
Trying to somehow keep stuff correctly alive, truned out to be rather futile. Originally I tried the same way Caolan did in the attached patch to tdf#88985, when he finally settled on adding a special terminate listener. But this is not enough to handle in-process scripted extensions, like Java, Python or even Basic macros themself. So this separates the module shutdown and SfxApplication cleanup from the rest of the terminate call. Change-Id: Ice59816080c922a17511b68afe59348a662600c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88835 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-02-21Drop o3tl::optional wrapperStephan Bergmann
...now that macOS builds are guaranteed to have std::optional since 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". The change is done mostly mechanically with > for i in $(git grep -Fl optional); do > sed -i -e 's:<o3tl/optional\.hxx>\|\"o3tl/optional\.hxx\":<optional>:' \ > -e 's/\<o3tl::optional\>/std::optional/g' \ > -e 's/\<o3tl::make_optional\>/std::make_optional/g' "$i" > done > for i in $(git grep -Flw o3tl::nullopt); do > sed -i -e 's/\<o3tl::nullopt\>/std::nullopt/g' "$i" > done (though that causes some of the resulting #include <optional> to appear at different places relative to other includes than if they had been added manually), plus a few manual modifications: * adapt bin/find-unneeded-includes * adapt desktop/IwyuFilter_desktop.yaml * remove include/o3tl/optional.hxx * quote resulting "<"/">" as "&lt;"/"&gt;" in officecfg/registry/cppheader.xsl * and then solenv/clang-format/reformat-formatted-files Change-Id: I68833d9f7945e57aa2bc703349cbc5a56b342273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-21loplugin:unusedmethodsNoel Grandin
Change-Id: I2194158d555958f0192d8d6c18e4c093608b8fb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89119 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-20loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I47f0bfe8b1968ea33b0c20b06ef7d3eea3f29a61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89116 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-19Resolves: tdf#130762 honour "wrap" in FormattedFieldCaolán McNamara
Change-Id: Iefd9a537aa358eab179cf6f0eeb6f80a9a77284a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89011 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19drop newly unused methodsCaolán McNamara
Change-Id: I390134b3cd0187f0adcced3625ad0a3a26f8fe28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89008 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19move svtabbx.hxx to vcl/toolkitCaolán McNamara
Change-Id: Id4cf566f896b15b8d4e4cafbb92a990cedb447e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88931 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19weld WatchWindow panelCaolán McNamara
Change-Id: Idb43d7bd168ce37fce8694946be6c7de7ca5a2c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88930 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18move NumericBox to vcl/toolkitCaolán McNamara
Change-Id: I3f51e917eb1979bf93f2233ec54abc31af8ef51b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88872 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17remove some unnecessary button.hxx includesCaolán McNamara
and update pches Change-Id: I61ca0be7a838e4eec6c41e0ece58d8a6b0e64c37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88861 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-15allow workben tests to use theseCaolán McNamara
Change-Id: I01c69617c828dd50d00af35f38da465d9d4dd261 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88748 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14split StringToMetric and TextToValue into fieldvalue.hxxCaolán McNamara
Change-Id: I5d1102f7a50a7a246df9f6de8b7a6df6557eb54d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88682 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14split out MetricField value conversion functionsCaolán McNamara
Change-Id: I67a33bd2a5cb06dc66e471918b5c378044a2eff2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88679 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14don't need to include split.hxx or scrbar.hxxCaolán McNamara
Change-Id: I775e77a0f303d66ca571e1851205b8286c840bc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>