summaryrefslogtreecommitdiff
path: root/include/vcl
AgeCommit message (Collapse)Author
2014-02-18coverity#738938 nMouseSensitivity never usedCaolán McNamara
Change-Id: I59193af4c0b4945ef9612862e57a276cc1d89ea4
2014-02-13extend signatures to make some coverity rework easierCaolán McNamara
Change-Id: I670eaa51aa95bf29f51bc6542eae2f562987d5a4
2014-02-12callcatcher: update unused codeCaolán McNamara
Change-Id: Iaaad9302ef8edb47fa95ce8ca608b6f36449521b
2014-02-11more similar handling of InputSequenceChecker as in other placesMatúš Kukan
Change-Id: Ia6efc0eda03dac87c73e720d08f320ce3fc6ce4a
2014-02-10fdo#74424 HasMirroredGraphics changesChris Sherlock
HasMirroredGraphics should be called upon by the object using the OutputDevice. As I'm focussing on Window, which will be shortly decoupled from OutputDevice, I have changed HasMirroredGraphics into a virtual function, and introduced a wrapper function of the same name into Window that calls upon Window's OutputDevice object. Due to a bug that never appears to have been fully fixed, mirroring in printing was broken and a workaround ("hotfix" in the code!) was implemented but never fully fixed. Therefore, I have overridden HasMirroredGraphics in Printer and just return false. Change-Id: I9029e2c50cdb339c1e936bed6b92e8b2aac1dcf9 Reviewed-on: https://gerrit.libreoffice.org/7912 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-07sal_Bool -> boolStephan Bergmann
Change-Id: Ifc80202e0865b59931af6e50d3d60f5021f8b52e
2014-02-07Renamed VCL's OutputDevice mirroring functionsChris Sherlock
I have renamed the following functions: * ImplReMirror -> ReMirror * ImplHasMirroredGraphics -> HasMirroredGraphics This has been done because these functions are definitely public and there is no need to prefix them with "Impl" as they are exposed to other objects. Change-Id: Ib52493c9824e29a038de2fc35736a5ca863c091a Reviewed-on: https://gerrit.libreoffice.org/7911 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-07Document OutputDevice classChris Sherlock
As part of decoupling the OutputDevice class from the Window class, I am going through and documenting what each public function does first. This will give a clearer indication of what Window is responsible for, and what OutputDevice is responsible for. Also fixed ImplDevicePixelToLogic's parameter - should not be rLogicRect, it should be rPixelRect in the header definition. Change-Id: I0d0b977c3d432bd08cd6d7fddc7ed878b95506d1 Reviewed-on: https://gerrit.libreoffice.org/7892 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-07Group like Impl* functions in outdev.hxxChris Sherlock
Change-Id: Iede8395d9287a857601080e7a65dc3a3eea93c9e Reviewed-on: https://gerrit.libreoffice.org/7890 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-07Change from com::sun::star and ::com::sun::star to css alias.Chris Sherlock
Change-Id: I704f45c156e8e70476409a0369c6b481707152a3 Reviewed-on: https://gerrit.libreoffice.org/7889 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-07Reindent outdev.hxx - minor formatting changeChris Sherlock
Change-Id: I5095728ca486b6a609d26520ff45f8bc5bde1c21 Reviewed-on: https://gerrit.libreoffice.org/7888 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-07implement expandable toolbox itemsCaolán McNamara
Change-Id: I64ace48ed6a72cea670ac2cdd774764b7c586648
2014-02-07Convert template manager dialog to .ui + adapt code.Jan Holesovsky
Change-Id: I854abb47c2d22206ed5581373b3e841f221672e3
2014-02-06Resolves: rhbz#975421 wrong chart direction in FarsiCaolán McNamara
Where Farsi (and apparenly Moroccon) are RTL but have LTR math and charts should reportedly follow the math direction Change-Id: Ib60eaaaa90fe46ef240030a91169fdff3f736329
2014-02-06TabControl::DeactivatePage should return boolStephan Bergmann
Change-Id: I9fb774a235db2b9bc759976d2d3f84363ed944ec
2014-02-06IsUpdateDateEnabled was never calledStephan Bergmann
Change-Id: I056ed836f785191f0685dc6f1313436da33ca0ee
2014-02-05OutputDevice::ImplHasMirroredGraphics can be constCaolán McNamara
Change-Id: I639c4821d9ef4da04ccbed6b93f7e6e3b51ae74d
2014-02-05fdo#74424 Start to decouple Window class from OutputDeviceChris Sherlock
We want to start to decouple Window from OutputDevice. This is because a Window should *use* an OutputDevice, a Window is *not* an OutputDevice. In order to start to decouple the two classes, the strategy will be: 1. This patch adds in a new private member pOutputDevice as well as an accessor. When the Window is initialized, pOutputDevice is set to a downcasted instance of this (because we are still inheriting Window from OutputDevice). 2. We will start to go through all the functions in Window that rely on OutputDevice and use the getter function to use the OutputDevice private member. 3. Any subclasses of Window will then need to have the same procedure done on them. 4. Once this is done, we need to work out the best way of initializing mpOutputDevice, then we can remove OutputDevice as the parent class of Window (and all Window subclasses). Change-Id: I39886c77070befb1542c8f22346111cde1c360b1 Reviewed-on: https://gerrit.libreoffice.org/7786 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-05C2872: ´Window´ : ambiguous symbolCaolán McNamara
Change-Id: Id5a342b9fdc5240b70b0985f4c6de9493162f10c
2014-02-05rhbz#1057977 avoid use of invalidated pointersDavid Tardon
Change-Id: Ib81f79da696b5e8002f5a2ddcf160903231dc3f1
2014-02-05Doxygen warnings correctedChris Sherlock
* Doxygen spits out a lot of warnings about not being able to find match function signatures, etc. This is because in some headers we have a using namespace statement, in others it gets confused between ::Window and Window (!). * Wrong use of tags: + Lots of @seealso - should be @see + Wrong usage of @overload - corrected with the right function signature + HTML tags that doxygen doesn't recognize removed Change-Id: I1c2eed941619b8764dbfcfc5ab38027518cdf261
2014-02-04convert specialised SvStream::operator>> methods to ReadXXX methodsNoel Grandin
as preparation for converting the SvStream::operator>> methods on primitive types Change-Id: I62f134bced15c687d6e0d46924f56e8d1c3d95b9 Reviewed-on: https://gerrit.libreoffice.org/7798 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-04Revert "Doxygen warnings corrected"Caolán McNamara
This reverts commit ff8036df5c5575503dc30d255dfbe99cc637c510. multiple build failures with namespace collisions etc Change-Id: Ie8ac08feff518af3584a26957f07a60d95932c76 Reviewed-on: https://gerrit.libreoffice.org/7855 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-04Doxygen warnings correctedChris Sherlock
* Doxygen spits out a lot of warnings about not being able to find match function signatures, etc. This is because in some headers we have a using namespace statement, in others it gets confused between ::Window and Window (!). * Wrong use of tags: + Lots of @seealso - should be @see + Wrong usage of @overload - corrected with the right function signature + HTML tags that doxygen doesn't recognize removed Conflicts: include/vcl/toolbox.hxx Change-Id: I687f45e426280d411ef3cb6d8d5993a829f2f324 Reviewed-on: https://gerrit.libreoffice.org/7725 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-04More Application class documentation updatesChris Sherlock
* Completed documentation of the Application class: + Documented and grouped functions relating to - dialogs - application help - mnemonics - accelerators - VCL toolkit and UNO wrapper functions - IME Status functions - platform functionality - graphic filter functions - headless mode functions. + Documented event hook function. * Documented the ApplicationEvent class Change-Id: I79a77212aa64ef1d4d40bfed2b73af5dce357731 Reviewed-on: https://gerrit.libreoffice.org/7713 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-04Change Application::SystemSettingsChanging to OverrideSystemSettingsChris Sherlock
The name Application::SystemSettingsChanging implies that the app is being notified that system settings are being changed. This is not what the function does - in fact, SystemSettingsChanging overrides a settings object with user defined settings Change-Id: Ibbf821ff3c7ec5b38e2e79751058494c749b6428 Reviewed-on: https://gerrit.libreoffice.org/7629 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2014-02-03thumbnails: Nobody uses the overlay functionality now, kill it.Jan Holesovsky
Change-Id: I74c463b67dd950a3e4de838ed0dc55ec366ab8a7
2014-02-03thumbnails: Provide the size as a default parameter.Jan Holesovsky
And increase it consistently to 256 pixels. Change-Id: I123e11d597269d7e43298504f1dbd0098c9b0149
2014-02-03EXC_SYSOBJNOTCREATED was not really usedTor Lillqvist
Change-Id: Id5ece6db33aa92b619571252df91b965a8805c96
2014-02-03fdo#74424 OutputDevice no longer inherits ResourceChris Sherlock
OutputDevice does not need to inherit Resource. Window now inherits OutputDevice and Resource. This decouples OutputDevice from Resource, which was unnecessary. Change-Id: I9bc0d7ce65c026a8e38110e17fafdde9d8744392 Reviewed-on: https://gerrit.libreoffice.org/7785 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-02-03add std::ostream operators for Region and PolyPolygonMichael Stahl
Change-Id: I8f4129b840a27f3029643ad2a4852f9e10604905
2014-01-31fdo#71763: F6 key moves focus on this trip: Menu -> Sidebar -> Thumbnail viewZolnai Tamás
Sidebar and thumbnail View are actually not separate windows but F6 key traversal should simulate it as they would be. Define a new getfocus flag called GETFOCUS_F6 which means focus were grabed as a result of pressing F6 key. Use this and other two (GETFOCUS_FORWARD, GETFOCUS_BACKWARD) flags to indicate the focus were grabbed along subwindow relation (define a new ImplGrabFocusToDocument method with a flag parameter on the analogy of GrabFocus() <-> ImplGrabFocus()). Handle F6, Shift+F6 inside BackingWindow as it would have two subwindow (sidebar and thumbnail view). Plus Ctrl+F6 -> grab focus to the thumbnail view. Change-Id: Ie43d761e7cb0269afb79481a81947a4b96e1dde0 Reviewed-on: https://gerrit.libreoffice.org/7486 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2014-01-30fdo#63154 Removed unused solar.h ref. in vclAlexandre Vicenzi
Change-Id: I038c941559a275c43c2be7d5453ca4c37390f343 Reviewed-on: https://gerrit.libreoffice.org/7733 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-30Globally disable MSVC warning 4201 (nonstandard extension nameless struct)Stephan Bergmann
...it is caused by some external code (newly so by glm included in chart2) and does not really add value. (Incidentally, all relevent compilers, Clang, GCC, and MSVC uniformly support this language extension anyway.) Change-Id: I5b4c11b5cea0267bf39ac95e9021a5761a4d7b91
2014-01-28coverity#1019410 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: I121421f929caffa6e4ca5a657d190c1d544e5365
2014-01-28Resolves: #i124008# listbox entry's are selected automatically...Steve Yin
on mouse over instead of mouse click (cherry picked from commit ae97dcb5b8d2dead81b007c5c71daf608f0c7bc3) Change-Id: Ib1ce0db60785ddc96473ef4ce88b578287956164
2014-01-28Document Application classChris Sherlock
Documented more of the VCL Application class's public functions via Doxygen markup. Also, change from global groups to member groups. Change-Id: I5e80e707874db99c60e899d078f41c7817e2b6c3 Reviewed-on: https://gerrit.libreoffice.org/7664 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-27Spelling correctionsTor Lillqvist
Change-Id: Ifd27d37eceac4a0b9376b8df6b3e6503f4cedd71
2014-01-26Edit::IsModified should return boolStephan Bergmann
Change-Id: I0aafdd37c73cd47b9dc68b60a32db35c8c11f455
2014-01-24undef check to progress mac buildCaolán McNamara
Change-Id: Ia13df162916c115390b87b027e6f9a1dbb72b7d9
2014-01-23bool improvementsStephan Bergmann
Change-Id: I3a3a2122902e1731e95d8469dfe9efc5a6b567ee
2014-01-23Remove unnecessary verbiage.Chris Sherlock
Change-Id: Icf0230577a5458425f22579e8d17f69c53310812 Reviewed-on: https://gerrit.libreoffice.org/7608 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-23Move defines into settings.hxxChris Sherlock
For some unknown reason, there are a bunch of defines in the middle of Desktop::SystemSettingsChanging() that should really be in include/vcl/settings.hxx. I have now moved DRAG_OPTIONS_ALL into settings.hxx but entirely removed DRAG_OPTIONS_NONE because it is confusing. I also removed it in the one place this combination of options is used in the Desktop class. I have also removed the options DRAG_OPTIONS_OBJECT_* from settings.hxx because they are used nowhere in the code. I have carefully looked through the code and nothing flips bits 0x00000004 or 0x00000008 on the private member of ImplStyleData's mnDragFullOptions in any way. Basically, it is safe to remove. Change-Id: Icf6268f940cfaed271bd43c977473fecfc726949 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-01-23Document more of VCL's Application classChris Sherlock
* Documented the Application class's settings functions. When reading through the code, I have noticed that GetSettings intializes the application settings (!) and that SetSettings relies on GetSettings to initialize the settings (!), so I have listed a todo entry. Furthermore, I've also noticed that SetSystemSettings and MergeSystemSettings may be confused with the purpose of SetSettings so I've added a todo entry that recommends that we return an AllSettings object and make the parameters const. * Minor whitespace changes * Update @see for a number of public functions * Group functions into Doxygen modules Change-Id: I48f8d21a5d6436a2ae545e5156b877d57a8bc585
2014-01-22Fix misaligned code commentChris Sherlock
I accidentally introduced this problem in commit 89a7b8a13285 Moved line of code to before the correct function. Change-Id: Ic044a5607dc385140ca51d1bf4aa734c0cf99904 Reviewed-on: https://gerrit.libreoffice.org/7595 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>
2014-01-22Improve settings code reabilityChris Sherlock
Application::SetSettings relies on Application::GetSettings to initialize the application's settings if this hasn't happened. This means that GetSettings is being used not to get the app's settings, but to initialize the settings! I have corrected this by introducing a private static function InitSettings(). Note that I assert if it attempts to initialize already initialized settings, because the (Get|Set)Settings does the check for you. Also changed a local variable from nGet to nDragMode in Desktop::SystemSettingsChanging to make it easier to read the code. Whilst this is minor, a variable name of "nGet" seems very sloppy. Change-Id: I04975217c2028b3489179997db4287957578cc93 Reviewed-on: https://gerrit.libreoffice.org/7586 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-01-22bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)Stephan Bergmann
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2014-01-22bool improvementsStephan Bergmann
Change-Id: Ic5d82c2361a79a19f6675db30ea06dde91123ac1
2014-01-21bool improvementsStephan Bergmann
Change-Id: I714caa8dc3d34fd56e6a11f57db6723dcb7e6705
2014-01-21Change EnableNoYieldMode(bool) to better namesChris Sherlock
It makes no sense to disable something via an Enable function. I have split the function into Enable and Disable functions, and update the code accordingly. Conflicts: include/vcl/svapp.hxx Change-Id: Ic05d69796f43e802a4a2a16aaca44433b6eaa018 Reviewed-on: https://gerrit.libreoffice.org/7525 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-30 11:57:43 +0000