summaryrefslogtreecommitdiff
path: root/include/vcl
AgeCommit message (Collapse)Author
2019-03-15add drop target support to welded widgetCaolán McNamara
refactor the mega-widget dnd drop target to be reused at mini-widget level and weld SwInsertBookmarkDlg Change-Id: I3f36e1cd902ecf166e369d0a05902d3df2b4f791 Reviewed-on: https://gerrit.libreoffice.org/69274 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-14Fix scheduled Task priority change handlingJan-Marek Glogowski
If a task is still in the scheduler priority queue and its priority is changed, it won't be moved into the correct queue. We have to track the priority of the scheduled task, so we can warn the developer to fix the code and actually handle re-start correctly. Since we don't want to traverse the whole Scheduler queues on priority change (which sometimes get very long) to remove the wrong data item, we'll just invalidate it, if a priority change is detected. This also reverts commit d24b264c4a47 ("vcl opengl: avoid task priority warning on cursor blink"), which tried to avoid the warning, which was just half right and independent of the broken priority change handling. LO doesn't change priorities of scheduled tasks normally, so that bug didn't turn out to have much impact, I guess. Change-Id: I6e46b518a7c3532047c619c013bd8597f73ed7a6 Reviewed-on: https://gerrit.libreoffice.org/69249 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-03-14vcl: avoid OUString defaulted parameter in GDIMetaFile::dumpAsXml()Miklos Vajna
So that it's possible to do ad-hoc dumping from gdb with something like: print xMetaFile->dumpAsXml(0) Similar to how that already worked for SwDoc or SwFrame. Change-Id: I9cb884491f2a49afdb06179d8d54252101f37bb7 Reviewed-on: https://gerrit.libreoffice.org/69253 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-14LOK: re-factor async key & mouse event re-posting.Michael Meeks
A fairly pure re-factor, although adding disposed window checking to a number of sites with a warning. Moves the event emission helpers from VCL into SfxLokHelper: we're going to need more view / integration here next anyway. Removes lots of copy/paste horror. Change-Id: I279c11a1d8093b4feeeb6b7850f500806fff80dd Reviewed-on: https://gerrit.libreoffice.org/69218 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-03-14loplugin:unusedmethodsNoel Grandin
Change-Id: Ief7cdb14e2c0fe4b0332cd90e063d649065bf3b6 Reviewed-on: https://gerrit.libreoffice.org/69171 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-13Make the Help URL configurableAshod Nakashian
When the Help URL is blank, the Help buttons are hidden LOK (but not desktop). Change-Id: Ibd76452108d1e3a92fb43f2c0af0586b0cbed073 Reviewed-on: https://gerrit.libreoffice.org/69071 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/69142 Tested-by: Jenkins
2019-03-13make selected text/id usable in tree modeCaolán McNamara
Change-Id: I1b6ffdab5e1ba4a667957d321762bb9250068fe7 Reviewed-on: https://gerrit.libreoffice.org/69178 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-12prefer weld::Window variantsCaolán McNamara
Change-Id: I4938ea338a71e3c83d4d847317ba49b9c7088561 Reviewed-on: https://gerrit.libreoffice.org/69116 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-12Write HiDPI consistently without a hyphenTor Lillqvist
Hopefully makes it easier to find locations in the code related to HiDPI issues. Change-Id: I2b4e5ff6d66c0ca5792250c3fd0d42eeb59eb3ef
2019-03-12tdf#123304: Allow the full feature syntax as pre 6.2Khaled Hosny
Fix regression from: commit dc9ee533dc707cc10b99d537eaccc3ee5aa555fe Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> Date: Fri Jun 15 19:32:15 2018 +0200 vcl: parser of font features included in the font name Where hb_feature_from_string() was replaced by a simple parser that supports avery limited subset of the syntax it supports (as documented in https://harfbuzz.github.io/harfbuzz-hb-common.html#hb-feature-from-string) Change-Id: I613190a677d24183e8c718fcfcaf9cf9b37a1e8f Reviewed-on: https://gerrit.libreoffice.org/69062 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2019-03-11weld SvxConfigDialogCaolán McNamara
Change-Id: Ia6983fd658521cf8704ca1ed95ecff6590ddde09 Reviewed-on: https://gerrit.libreoffice.org/68906 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-11weld SvxMenuConfigPage/SvxToolbarConfigPageCaolán McNamara
Change-Id: I166ac6c0be8461ea38db711796d1e14fc5b78998 Reviewed-on: https://gerrit.libreoffice.org/68889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-11loplugin:constantparamNoel Grandin
Change-Id: Ibe167c208844b4cdd10df80ae804b1e5bfa6aa13 Reviewed-on: https://gerrit.libreoffice.org/68998 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-09MSForms: Add a drop-down button for drop-down form fieldTamás Zolnai
* Introduce a editing frame with a button for drop-down form field. ** The frame is mouse transparent. ** Pushing the button opens the popup window with the items of the field. * The button is visible when the cursor is inside the field. Change-Id: I5c7db138d14380899fee046c95a5afe14cfea213 Reviewed-on: https://gerrit.libreoffice.org/68961 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-09out of line some heavily repeated functionsNoel Grandin
Change-Id: Icd9f7ebab89d6c2b166b6f42fd7682e89127fd51 Reviewed-on: https://gerrit.libreoffice.org/68903 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-09loplugin:unusedmethodsNoel Grandin
Change-Id: I242f56f2bc5dc8fce6db1ba8f1f8269da4fec0fa Reviewed-on: https://gerrit.libreoffice.org/68938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-09loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I1fcde14b66ce80157cbebe7f3ec8c5ced1e13143 Reviewed-on: https://gerrit.libreoffice.org/68937 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-07can drop wallpaper if use alpha-enabled virdevCaolán McNamara
Change-Id: I655dca755ed8e1c1266c191f61998b3838fe9797 Reviewed-on: https://gerrit.libreoffice.org/68860 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-05weld SfxAcceleratorConfigPageCaolán McNamara
fixes a leak in the KeyList too Change-Id: I603218ff99481bc006df329c770ea6fe6f147483 Reviewed-on: https://gerrit.libreoffice.org/68694 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-05sync get_selected_id with get_active_idCaolán McNamara
Change-Id: I983cc45d13e02a020f608b8e9abfd2f12f7b10f5 Reviewed-on: https://gerrit.libreoffice.org/68741 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-05re-land "new loplugin typedefparam""Noel Grandin
This reverts commit c9bb48386bad7d2a40e6958883328145ae439cad, and adds a bunch more fixes. Change-Id: Ib584d302a73125528eba85fa1e722cb6fc41538a Reviewed-on: https://gerrit.libreoffice.org/68680 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-05Add support for <image> draw definition to draw a SVG imageTomaž Vajngerl
Attribute "source" is used to get the relative path to the image. Path is relative to the definition file. Change-Id: I6ca0c113385e26ad74b928e1f56635b4b0cef995 Reviewed-on: https://gerrit.libreoffice.org/68712 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-04Revert "new loplugin typedefparam"Noel Grandin
This reverts commit 9865440d217d975206a3f91612f0666312bc8fd8. This is not ready to land yet, seems like the latest update of the logic reveals a bunch more places I need to fix before it can land.
2019-03-04new loplugin typedefparamNoel Grandin
verify that parameters use the exact same typedef-names (if any) in definition and declaration Change-Id: I55d2817f599b0253904dce2d35a1a93967e15a77 Reviewed-on: https://gerrit.libreoffice.org/68439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-01weld SwChangeDBDlgCaolán McNamara
Change-Id: Ie0fc6a6346f9c777b7172a0b641a2783cf633c1d Reviewed-on: https://gerrit.libreoffice.org/68544 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27weld UpdateDialogCaolán McNamara
Change-Id: Ieca75774925a8766162481713f6e8a6ba0e9feb0 Reviewed-on: https://gerrit.libreoffice.org/68396 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27weld LicenseDialogImplCaolán McNamara
Change-Id: I4b2dbd2446779e7179d2b79bf81cc2ff879377bf Reviewed-on: https://gerrit.libreoffice.org/68389 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27Fix GenericSolarThreadExecutor<...,void> specializationStephan Bergmann
Change-Id: I4468a3a8d036ca4894ba7977f6654244552464aa Reviewed-on: https://gerrit.libreoffice.org/68423 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-27Fix commentStephan Bergmann
...after ce2792eda318b2760d24d2a744fc89e6a1d87138 "use C++11 exception rethrowing" Change-Id: I7a5cf53daa833cd398e520f67bf4bc5f36b21989 Reviewed-on: https://gerrit.libreoffice.org/68422 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-27loplugin:unusedfields look for classes where we can make all the..Noel Grandin
fields private Change-Id: Id3c6b123f06ab5dcf87628de4c347626110d2d27 Reviewed-on: https://gerrit.libreoffice.org/68302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-25loplugin:unusedmethodsNoel Grandin
Change-Id: I085394e0f4b780dc5b376d5ac0e9d761434e3ead Reviewed-on: https://gerrit.libreoffice.org/68301 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-22loplugin:unusedfields in vclNoel Grandin
maStatusText in HelpTextWindow is dead since commit bd3ea40ed49074c4fa4439de7b5dea4fc3161880 Date: Fri Jan 21 14:48:58 2011 +0200 Remove ShowHelpStatusText and HideHelpStatusText and associated cruft Change-Id: I7a74e2a1b909a479f9338bd4da5fad06ccc25283 Reviewed-on: https://gerrit.libreoffice.org/68153 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-21weld RecoveryDialogCaolán McNamara
Change-Id: Iaa755aca2468a23465a3ab8d8115ee19e3b05f6d Reviewed-on: https://gerrit.libreoffice.org/68155 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-21weld HangulHanjaConversionDialogCaolán McNamara
Change-Id: Ia41f1a03581a0a48d59706ac5b3c569fc39c7f4d Reviewed-on: https://gerrit.libreoffice.org/68099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-20weld SaveProgressDialogCaolán McNamara
Change-Id: Iad1786962dedb6cae0cf8720022498bfd793feb1 Reviewed-on: https://gerrit.libreoffice.org/68105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-20extract empty test as methodCaolán McNamara
Change-Id: If383e2f1542ffb57415f8138077013dbafa0fc69 Reviewed-on: https://gerrit.libreoffice.org/68095 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-19weld ChineseDictionaryDialogCaolán McNamara
and ChineseTranslationDialog Change-Id: I3b754c405c8379fc0c5fa94437cc0464a1dea999 Reviewed-on: https://gerrit.libreoffice.org/67991 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-19read/written as 32bit integersCaolán McNamara
so just use those 48->32 bytes ofz#13164 1.195G -> 1.190 Change-Id: I145049c9d5fba04c8d5b4271190d7e62755bf8bf Reviewed-on: https://gerrit.libreoffice.org/67964 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-19Fix typoAndrea Gelmini
Change-Id: I5c10b3f1dbcdce9064397a76eb583d477628c4b4 Reviewed-on: https://gerrit.libreoffice.org/68001 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-19use boost::optional in SvTreeListEntryNoel Grandin
it is inefficient to allocate a tiny object like Color separately on the heap Change-Id: Iac2cfc7c00c16240e7cf72e7d8814e97e9f65ac6 Reviewed-on: https://gerrit.libreoffice.org/67967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-18Resolves: tdf#122355 search help for active notebook pageCaolán McNamara
before checking for the dialog, to get more specific help results. Change-Id: I2d6128fa39d3f7ebf15e194354307dd924590009 Reviewed-on: https://gerrit.libreoffice.org/67973 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-18reorder to reduce size from 64 to 48 bytesCaolán McNamara
ofz#13164 1.200G -> 1.195G Change-Id: I3738b7635a7927f1f88021e5bf00dcc5509e6ea3 Reviewed-on: https://gerrit.libreoffice.org/67960 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-17weld HangulHanjaEditDictDialogCaolán McNamara
Change-Id: If0d49a65735b66eaa8db11686099ed29b01711c4 Reviewed-on: https://gerrit.libreoffice.org/67929 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-15BitmapColor string representation - fix proper paddingTomaž Vajngerl
Change-Id: I42727152e71b2dce4c2b5ce71f9a54464388a7fb
2019-02-15weld ScDPDateGroupDlgCaolán McNamara
adding a weld::Calendar and a pretty menubutton to access it, sidestepping the difficulty of abusing a spinbutton to select a date. The prettiness is wasted on this hard to find obscure dialog Change-Id: I51d461fe0220f947c106d96965e6422b4b26575b Reviewed-on: https://gerrit.libreoffice.org/67863 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-15move Calendar to vcl and map to GtkCalendarCaolán McNamara
Change-Id: I1784d4d69c6c069ef1b0ad6412e83e6a0b1db12a Reviewed-on: https://gerrit.libreoffice.org/67840 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-14Resolves: tdf#123426 don't reformat tabstop pos while editingCaolán McNamara
we want to know what it would format as, but we don't want to do the formatting during typing Change-Id: I817798adf5b3f9325682f43b92fe107659803b4f Reviewed-on: https://gerrit.libreoffice.org/67819 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-14cleanup of PngImageReaderTomaž Vajngerl
Change-Id: Ifa5efe5fab644f1c684ada3f6cd46e19c002d7ca Reviewed-on: https://gerrit.libreoffice.org/67842 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-13remove GetLuminance from BitmapReadAccessTomaž Vajngerl
It's not really that important shortcut function as the function is used only twice in the whole code base. Change-Id: Idf25ded6320f766bc66beec0ee272a62765303ba Reviewed-on: https://gerrit.libreoffice.org/67792 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-13weld CertificateViewer clusterCaolán McNamara
CertificateViewer, CertificateViewerGeneralTP, CertificateViewerDetailsTP, CertificateViewerCertPathTP Change-Id: I5792b673f17b3cd465ff17444776066139877ec1 Reviewed-on: https://gerrit.libreoffice.org/67756 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>