summaryrefslogtreecommitdiff
path: root/include/vcl
AgeCommit message (Collapse)Author
2014-03-12Spelling fix: suportedTor Lillqvist
Change-Id: I3b67edd5ba4541a65cb0916abea6db1362c32afd
2014-03-11fdo#74702 Moved ImplInitGraphics into correct classesChris Sherlock
Currently we check to see what type of class is being used. This really violates the Single Responsibility Principle, and tightly couples the code to OutputDevice. The responsibility for initializing graphics should be done by Printer, VirtualDevice and Window. Please note: to get this working, I've had to make Printer a friend class of VirtualDevice. I'm not entirely happy about this, I'll need to revisit this later when I look at Printer in more detail. For now, this is a hack to allow me to seperate out this function. Change-Id: I9d5946c22fa70670a4f85bf338b4209499d0aa54 Reviewed-on: https://gerrit.libreoffice.org/8528 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-10Update the documentation for ImplInitGraphics()Chris Sherlock
Better explain the whys and wherefores of the graphics LRU and how it is used. Change-Id: I345cd91044bc533c9650e2d17bf53d2879af3e39 Reviewed-on: https://gerrit.libreoffice.org/8030 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-10Seperate initialization of OutputDevice instanceChris Sherlock
I have split OutputDevice::ImplInitGraphics() from OutputDevice::ImplGetGraphics(). In future, we need to further seperate out this initialization function into it's own seperate classes. Note that ImplGetGraphics still initializes if mpGraphics is not set. Change-Id: I17d4778f735aa9d03bf9b37079a9d695bf95866b Reviewed-on: https://gerrit.libreoffice.org/7777 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-10Stick to function naming conventions in OutputDeviceChris Sherlock
Function name changes for consistency in OutputDevice: * impPaintLineGeometryWithEvtlExpand -> ImplPaintLineGeometryWithEvtlExpand * ImpDrawPolyPolygonWithB2DPolyPolygon -> ImplDrawPolyPolygonWithB2DPolyPolygon * ImpTryDrawPolyLineDirect -> ImplTryDrawPolyLineDirect * ImpDrawPolyLineWithLineInfo -> ImplDrawPolyLineWithLineInfo Change-Id: Iae1ce07036856902259cef0a05afb57fd657325e Reviewed-on: https://gerrit.libreoffice.org/8509 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-10callcatcher: update unused codeCaolán McNamara
Change-Id: I0d7f204473bd5fcddf2342850a16194fdb385c13
2014-03-09fdo#63154 Remove old solar.h referencesAlexandre Vicenzi
Remove some unused references in tools. Change sal_uLong to sal_uInt32 in filter and vcl. Change-Id: I92b928b980b2e7371edddfd74face10d5bec07df Reviewed-on: https://gerrit.libreoffice.org/8480 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-03-07x->getSomething(x->getImplementationId()) doesn't make any senseStephan Bergmann
...the point of the aIdentifier parameter to css.lang.XUnoTunnel.getSomething is so that caller and callee can verify they know each other and the value passed back (pointer in local address space, in this case) will actually make sense for the caller. Change-Id: Id79c419307992b30ea6ef7997b74a015631ad21c
2014-03-07callcatcher: update unused codeCaolán McNamara
Change-Id: I6487e6ede0a50d88a4f8c3d3b07bdad2603aa4b4
2014-03-06coverity#708643 nOffsetY missing from copy ctorCaolán McNamara
its normally always 0, so shrink the code based on that Change-Id: Ic9a4615f0ecb0713a00e4acd73485f99fd50a859
2014-03-05Simplify DrawWaveKeith Curtis
This patch simplifies the DrawWave logic. Callers of that code would try to figure out what size wave to draw and pass down a style integer to DrawWaveLine, but DrawWaveLine already has logic which trims the height of the wave so it doesn't need the hint. This doesn't change the UNO API (::com::sun::star::awt::FontUnderline::SMALLWAVE), but it does get rid of internal usages and maps those small waves to normal. Note that changing the zoom in Calc right now causes spelling underlines to disappear. That bug is not related to these changes. Conflicts: editeng/source/editeng/impedit3.cxx Change-Id: I3caa2a74a0f5228b924d4e1b0a77f96eaef5fa00 Reviewed-on: https://gerrit.libreoffice.org/8168 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-03-05made ListBox handle more than 64k elements, fdo#61520 relatedEike Rathke
ListBox and related now handle up to sal_Int32 elements correctly. sal_Int32 instead of sal_Size or size_t because of UNO and a11y API. Also disentangled some of the mess of SvTreeList and other containers regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures. Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a Reviewed-on: https://gerrit.libreoffice.org/8460 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05remove unused code TextEngine::GetLeftMargin()Noel Grandin
Change-Id: I1b702a4371154ebc10c0caa7697fdbe763337b6f
2014-03-05remove unused code ToolBox::GetItemExpand(unsigned short)Noel Grandin
Change-Id: If28d796a72ca7f375a82fbb0a42e9810db6f34c0
2014-03-05remove unused code vcl/VclMultiLineEditNoel Grandin
VclMultiLineEdit::IsRightToLeft() const VclMultiLineEdit::SetTextSelectable(bool) Change-Id: I430ffd0bac59baf49bac05123f22fa004a90ec40
2014-03-01Remove visual noise from includeAlexander Wilms
Conflicts: include/framework/preventduplicateinteraction.hxx include/sfx2/sfxbasecontroller.hxx include/sfx2/sfxbasemodel.hxx include/toolkit/awt/vclxtabpagemodel.hxx include/vcl/field.hxx include/vcl/settings.hxx Change-Id: Ibccf9f88c68267a3d7e656012b51eaf644c418c2 Reviewed-on: https://gerrit.libreoffice.org/8272 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28WaE: implicit conversion of literal of type 'sal_Bool' to 'bool'Tor Lillqvist
Change-Id: I0b325abc275b672a96c5513d285c0f5764dfb4fe
2014-02-28sal_Bool -> bool in mostly vcl moduleChris Sherlock
Conflicts: include/vcl/settings.hxx svtools/source/table/tablecontrol_impl.cxx sw/source/core/frmedt/fecopy.cxx vcl/inc/canvasbitmap.hxx vcl/inc/headless/svpframe.hxx vcl/inc/unx/salframe.h vcl/inc/win/salframe.h vcl/inc/win/salprn.h vcl/inc/win/salvd.h vcl/osx/DragSource.cxx vcl/osx/DragSource.hxx vcl/osx/DropTarget.cxx vcl/osx/DropTarget.hxx vcl/osx/OSXTransferable.cxx vcl/osx/OSXTransferable.hxx vcl/osx/clipboard.cxx vcl/osx/clipboard.hxx vcl/osx/salprn.cxx vcl/qa/cppunit/canvasbitmaptest.cxx vcl/source/components/fontident.cxx vcl/source/control/edit.cxx vcl/source/control/spinfld.cxx vcl/source/gdi/gdimtf.cxx vcl/source/gdi/virdev.cxx vcl/source/helper/canvasbitmap.cxx vcl/source/window/dockwin.cxx vcl/unx/generic/dtrans/X11_selection.hxx vcl/unx/kde/UnxFilePicker.cxx vcl/unx/kde/UnxFilePicker.hxx vcl/unx/kde4/KDE4FilePicker.cxx vcl/unx/kde4/KDE4FilePicker.hxx vcl/unx/kde4/KDESalFrame.hxx Change-Id: I9866d985da86dea2a56feff23f91c1467a1636b0 Reviewed-on: https://gerrit.libreoffice.org/8219 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28fix name of method in vcl/Menu, SetHightlightItem to SetHighlightItemNoel Grandin
Change-Id: I89a61aeffeebc69e06da6c1130436fb25528f1c7
2014-02-28remove unused code Menu::GetHighlightItem()Noel Grandin
Change-Id: I9b538bacbb98705b0345c3f6dc38fb554ce25bcf
2014-02-27Resolves: #i15508# Added support for BMP file typeArmin Le Grand
(cherry picked from commit 9956ed1303545cd61901e33b110698c4e5e224c4) Conflicts: filter/source/msfilter/escherex.cxx include/vcl/gfxlink.hxx svx/source/xml/xmlgrhlp.cxx sw/source/ui/docvw/romenu.cxx vcl/source/filter/graphicfilter.cxx Change-Id: Ibcbb69b9c57cd8a438788e9a9c95744e99b6fcdd
2014-02-27coverity#1187868 Uninitialized pointer fieldCaolán McNamara
Change-Id: I6fa813b983d217eb8ce028f9ae13a0cc764e29da
2014-02-27coverity#1187863 unused mnExtra2Caolán McNamara
Change-Id: Ic6a55a3640d782ba95a5ba4681f447ee28ae163e
2014-02-27GetContextMenuDown is always trueCaolán McNamara
Change-Id: Ib2ce1dd91cc7bfaf38feca7b056874a2508869e6
2014-02-27callcatcher: update unused codeCaolán McNamara
Change-Id: I560471a3c2ac9d8ccf759fca1d8c30ae00d73484
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26Remove implementation details from vcl/settings.hxxTobias Lippert
This reduces the number of files which need to be recompiled after a change to the internal details. Also: Remove explicit assignment operators since they are no longer needed. Change-Id: Ieb18a8437fbcd39c6003b50c656ce010f5002d9a Reviewed-on: https://gerrit.libreoffice.org/8161 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-02-25remove unused code Menu::GetItemAccKeyStrFromPos(unsigned short)Noel Grandin
Change-Id: Ia6967bd5ae412b473187d8bf5485e56fdc934efb
2014-02-25remove unused code Menu::IsTemporaryItemFromPos(unsigned short)Noel Grandin
Change-Id: I90a9116aba75316992d2bddaf2f6466288b95bd0
2014-02-25Add config_libraries.h definitions to get library names easily.Matúš Kukan
Works for libmerged too, so we can get rid of LIBO_MERGELIBS. And remove few more #defines in vcl. It's generated by gbuild, so probably abusing config_host directory. Open to improvements. Change-Id: I87ab109bf109e42751766011daf076e9cdf8f5ee
2014-02-24sal_Bool arg of SetUseImagesInMenus was abused to squeeze '2' through itCaolán McNamara
which means that icons suddenly reappeared in the menus when the gtk theme had disabled them ref e8f8f24c8415898c787bbfb629247ed62e73a2b9 Change-Id: Ia9aef5ca39bda2ddf6d7c4ebc2bddc01d470d09b
2014-02-24Replace exisiting TriState, AutoState with more generic TriStateStephan Bergmann
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-22SAL_DLLPUBLIC_EXPORT->VCL_DLLPUBLICCaolán McNamara
Change-Id: If8127ae939f6e38ab72919150ca6a6109355fb11
2014-02-21WaE: struct/class inconsistencyTor Lillqvist
Change-Id: Iedb9873bc36fa5854de56738351d3683e245024d
2014-02-21Bug #63962 Dynamically scan the config directory for icon themesTobias Lippert
The hard-coded icon themes have been replaced by a dynamic list which is filled by scanning the config directory Conflicts: include/vcl/settings.hxx vcl/source/app/settings.cxx vcl/source/window/window.cxx Change-Id: Ie3680ffe27d06e375acf22753e036cb6ddabc4ed Reviewed-on: https://gerrit.libreoffice.org/7935 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-21Replace handwritten reference counting with shared_ptrTobias Lippert
This will help to avoid race conditions because the shared pointers are thread safe and use atomic increments. Conflicts: include/vcl/settings.hxx vcl/source/app/settings.cxx Change-Id: Ie3d27d6412167855a0cea1442676b81b733c15e8
2014-02-21vcl: sal_Bool -> boolStephan Bergmann
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-20Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxxTobias Lippert
Added vcl/settings.hxx to all cxx files which require it. This helps to speed up compilation after changes to the settings. Conflicts: sc/source/ui/dbgui/pvlaydlg.cxx Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4 Reviewed-on: https://gerrit.libreoffice.org/7933 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-19Related: fdo#74242 hook up a selection and caret change for multiline editsCaolán McNamara
a) split the textengine selection changed broadcast into a text selection changed and text caret change event b) handle both in existing places that handled the text selection event c) listen for them in VclMultiLineEdit and translate to VCLEVENT_EDIT_SELECTIONCHANGED VCLEVENT_EDIT_CARETCHANGED events d) profit from the VCLEVENT_EDIT_SELECTIONCHANGED and VCLEVENT_EDIT_CARETCHANGED handling in accessibility/source/standard/vclxaccessibleedit.cxx for VCLXAccessibleEdits Change-Id: I09187e76ae4eb189ee9469e388374154087faf80
2014-02-19unotools: sal_Bool -> boolStephan Bergmann
Change-Id: I8051c0756e0474a5b4f748e0aa15a9922e82ea97
2014-02-18fdo#41524: CUPS printing: use "collate" option when PDF is availableMichael Stahl
Assume that the CUPS printer is able to handle collating by itself, don't send multiple print jobs (except if user clicks on "Create single print jobs for collated output" of course...). To enable collating with PDF based printers, add the "collate" option; legacy PS based printers still get the weird stuff read from the PPD (not sure what the risks of changing that are). Change-Id: Ia12dc69f9083bba94f2ed633ecbd153aac7e40ab
2014-02-18coverity#738938 nMouseSensitivity never usedCaolán McNamara
Change-Id: I59193af4c0b4945ef9612862e57a276cc1d89ea4
2014-02-13extend signatures to make some coverity rework easierCaolán McNamara
Change-Id: I670eaa51aa95bf29f51bc6542eae2f562987d5a4
2014-02-12callcatcher: update unused codeCaolán McNamara
Change-Id: Iaaad9302ef8edb47fa95ce8ca608b6f36449521b
2014-02-11more similar handling of InputSequenceChecker as in other placesMatúš Kukan
Change-Id: Ia6efc0eda03dac87c73e720d08f320ce3fc6ce4a
2014-02-10fdo#74424 HasMirroredGraphics changesChris Sherlock
HasMirroredGraphics should be called upon by the object using the OutputDevice. As I'm focussing on Window, which will be shortly decoupled from OutputDevice, I have changed HasMirroredGraphics into a virtual function, and introduced a wrapper function of the same name into Window that calls upon Window's OutputDevice object. Due to a bug that never appears to have been fully fixed, mirroring in printing was broken and a workaround ("hotfix" in the code!) was implemented but never fully fixed. Therefore, I have overridden HasMirroredGraphics in Printer and just return false. Change-Id: I9029e2c50cdb339c1e936bed6b92e8b2aac1dcf9 Reviewed-on: https://gerrit.libreoffice.org/7912 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-07sal_Bool -> boolStephan Bergmann
Change-Id: Ifc80202e0865b59931af6e50d3d60f5021f8b52e
2014-02-07Renamed VCL's OutputDevice mirroring functionsChris Sherlock
I have renamed the following functions: * ImplReMirror -> ReMirror * ImplHasMirroredGraphics -> HasMirroredGraphics This has been done because these functions are definitely public and there is no need to prefix them with "Impl" as they are exposed to other objects. Change-Id: Ib52493c9824e29a038de2fc35736a5ca863c091a Reviewed-on: https://gerrit.libreoffice.org/7911 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-07Document OutputDevice classChris Sherlock
As part of decoupling the OutputDevice class from the Window class, I am going through and documenting what each public function does first. This will give a clearer indication of what Window is responsible for, and what OutputDevice is responsible for. Also fixed ImplDevicePixelToLogic's parameter - should not be rLogicRect, it should be rPixelRect in the header definition. Change-Id: I0d0b977c3d432bd08cd6d7fddc7ed878b95506d1 Reviewed-on: https://gerrit.libreoffice.org/7892 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-07Group like Impl* functions in outdev.hxxChris Sherlock
Change-Id: Iede8395d9287a857601080e7a65dc3a3eea93c9e Reviewed-on: https://gerrit.libreoffice.org/7890 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-31 01:24:49 +0000