summaryrefslogtreecommitdiff
path: root/include/vcl
AgeCommit message (Collapse)Author
2014-02-03add std::ostream operators for Region and PolyPolygonMichael Stahl
Change-Id: I8f4129b840a27f3029643ad2a4852f9e10604905
2014-01-31fdo#71763: F6 key moves focus on this trip: Menu -> Sidebar -> Thumbnail viewZolnai Tamás
Sidebar and thumbnail View are actually not separate windows but F6 key traversal should simulate it as they would be. Define a new getfocus flag called GETFOCUS_F6 which means focus were grabed as a result of pressing F6 key. Use this and other two (GETFOCUS_FORWARD, GETFOCUS_BACKWARD) flags to indicate the focus were grabbed along subwindow relation (define a new ImplGrabFocusToDocument method with a flag parameter on the analogy of GrabFocus() <-> ImplGrabFocus()). Handle F6, Shift+F6 inside BackingWindow as it would have two subwindow (sidebar and thumbnail view). Plus Ctrl+F6 -> grab focus to the thumbnail view. Change-Id: Ie43d761e7cb0269afb79481a81947a4b96e1dde0 Reviewed-on: https://gerrit.libreoffice.org/7486 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2014-01-30fdo#63154 Removed unused solar.h ref. in vclAlexandre Vicenzi
Change-Id: I038c941559a275c43c2be7d5453ca4c37390f343 Reviewed-on: https://gerrit.libreoffice.org/7733 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-30Globally disable MSVC warning 4201 (nonstandard extension nameless struct)Stephan Bergmann
...it is caused by some external code (newly so by glm included in chart2) and does not really add value. (Incidentally, all relevent compilers, Clang, GCC, and MSVC uniformly support this language extension anyway.) Change-Id: I5b4c11b5cea0267bf39ac95e9021a5761a4d7b91
2014-01-28coverity#1019410 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: I121421f929caffa6e4ca5a657d190c1d544e5365
2014-01-28Resolves: #i124008# listbox entry's are selected automatically...Steve Yin
on mouse over instead of mouse click (cherry picked from commit ae97dcb5b8d2dead81b007c5c71daf608f0c7bc3) Change-Id: Ib1ce0db60785ddc96473ef4ce88b578287956164
2014-01-28Document Application classChris Sherlock
Documented more of the VCL Application class's public functions via Doxygen markup. Also, change from global groups to member groups. Change-Id: I5e80e707874db99c60e899d078f41c7817e2b6c3 Reviewed-on: https://gerrit.libreoffice.org/7664 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-27Spelling correctionsTor Lillqvist
Change-Id: Ifd27d37eceac4a0b9376b8df6b3e6503f4cedd71
2014-01-26Edit::IsModified should return boolStephan Bergmann
Change-Id: I0aafdd37c73cd47b9dc68b60a32db35c8c11f455
2014-01-24undef check to progress mac buildCaolán McNamara
Change-Id: Ia13df162916c115390b87b027e6f9a1dbb72b7d9
2014-01-23bool improvementsStephan Bergmann
Change-Id: I3a3a2122902e1731e95d8469dfe9efc5a6b567ee
2014-01-23Remove unnecessary verbiage.Chris Sherlock
Change-Id: Icf0230577a5458425f22579e8d17f69c53310812 Reviewed-on: https://gerrit.libreoffice.org/7608 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-23Move defines into settings.hxxChris Sherlock
For some unknown reason, there are a bunch of defines in the middle of Desktop::SystemSettingsChanging() that should really be in include/vcl/settings.hxx. I have now moved DRAG_OPTIONS_ALL into settings.hxx but entirely removed DRAG_OPTIONS_NONE because it is confusing. I also removed it in the one place this combination of options is used in the Desktop class. I have also removed the options DRAG_OPTIONS_OBJECT_* from settings.hxx because they are used nowhere in the code. I have carefully looked through the code and nothing flips bits 0x00000004 or 0x00000008 on the private member of ImplStyleData's mnDragFullOptions in any way. Basically, it is safe to remove. Change-Id: Icf6268f940cfaed271bd43c977473fecfc726949 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-01-23Document more of VCL's Application classChris Sherlock
* Documented the Application class's settings functions. When reading through the code, I have noticed that GetSettings intializes the application settings (!) and that SetSettings relies on GetSettings to initialize the settings (!), so I have listed a todo entry. Furthermore, I've also noticed that SetSystemSettings and MergeSystemSettings may be confused with the purpose of SetSettings so I've added a todo entry that recommends that we return an AllSettings object and make the parameters const. * Minor whitespace changes * Update @see for a number of public functions * Group functions into Doxygen modules Change-Id: I48f8d21a5d6436a2ae545e5156b877d57a8bc585
2014-01-22Fix misaligned code commentChris Sherlock
I accidentally introduced this problem in commit 89a7b8a13285 Moved line of code to before the correct function. Change-Id: Ic044a5607dc385140ca51d1bf4aa734c0cf99904 Reviewed-on: https://gerrit.libreoffice.org/7595 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>
2014-01-22Improve settings code reabilityChris Sherlock
Application::SetSettings relies on Application::GetSettings to initialize the application's settings if this hasn't happened. This means that GetSettings is being used not to get the app's settings, but to initialize the settings! I have corrected this by introducing a private static function InitSettings(). Note that I assert if it attempts to initialize already initialized settings, because the (Get|Set)Settings does the check for you. Also changed a local variable from nGet to nDragMode in Desktop::SystemSettingsChanging to make it easier to read the code. Whilst this is minor, a variable name of "nGet" seems very sloppy. Change-Id: I04975217c2028b3489179997db4287957578cc93 Reviewed-on: https://gerrit.libreoffice.org/7586 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-01-22bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)Stephan Bergmann
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2014-01-22bool improvementsStephan Bergmann
Change-Id: Ic5d82c2361a79a19f6675db30ea06dde91123ac1
2014-01-21bool improvementsStephan Bergmann
Change-Id: I714caa8dc3d34fd56e6a11f57db6723dcb7e6705
2014-01-21Change EnableNoYieldMode(bool) to better namesChris Sherlock
It makes no sense to disable something via an Enable function. I have split the function into Enable and Disable functions, and update the code accordingly. Conflicts: include/vcl/svapp.hxx Change-Id: Ic05d69796f43e802a4a2a16aaca44433b6eaa018 Reviewed-on: https://gerrit.libreoffice.org/7525 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-20Remove unused Window parameter from SystemSettingsChangingChris Sherlock
This took a bit of code archaelogy for me to track down. It turns out that as part of an effort to optimize startup, the line of code in this function was commented out, presumably to be rewritten later. This happened in commit ee3351d78c in July 2001 (!). About three years later, in February 2004, the function was rewritten in commit 189c2388d80. As it turns out, the only two functions that used the Window parameter were vcl/source/window/window.cxx (which passed itself in, but of course this did nothing) and vcl/source/window/winproc.cxx. Furthermore, winproc only ever passed in the first frame, so it didn't really do anything either. Consequently, the function as it stands *now* only notifies the application that system settings have been changed. It doesn't care which window it tells. Therefore, I have excised this parameter from the function. I don't think it made sense when it was implemented anyway, so there is no net loss. After removing the unneeded parameter, I was also able to remove the Window parameter from winproc.cxx's ImplHandleSalSettings function as it was only ever used to set the top level window, which is now irrelevant. Change-Id: I84f2c5c5ff8969387da3af81e4a9c7f9ac6237e1 Reviewed-on: https://gerrit.libreoffice.org/7541 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-20Document VCL Application classChris Sherlock
Documented the VCL Application class in Doxygen format. Also reindented some of the code, and moved ValidateSystemFont down the list of class functions (better code organization). Change-Id: Id421647a9a25e11be87b0f6c46d1ac0f4846f6a4 Reviewed-on: https://gerrit.libreoffice.org/7515 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-18Window::PreNotify should return boolStephan Bergmann
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-17Window::Notify should return boolStephan Bergmann
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-16make use that these VclBuilders have an XFrame to expose its dispatchCaolán McNamara
the sidebar widget-layout enabled panels could use frame::XDispatch::dispatch to send their commands directly rather than mapping back to SIDS and Executing those, which would allow removing piles of weird-ass stuff Change-Id: Ibbff56d4fb96820d3bdbf4b1cb582d25337fe48b
2014-01-16fdo#39468 translate more German comments, etc.Chris Sherlock
* Translated some more German comments * Some typos corrected * Removed useless comment decoration Change-Id: I40176e23983193e5087f48cf7d7b8e5eb339d6c6 Reviewed-on: https://gerrit.libreoffice.org/7463 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-16convert SvStream::operator<< overloads to more explicit methodsNoel Grandin
This is in preparation for more conversion of SvStream::operator<< calls to use more explicit method names. This converts the subclasses that have their own convenience overloads of operator<< to use normal methods. Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
2014-01-16Remove broken and unnecessary friend declaration.Matúš Kukan
Change-Id: I5ec11ce8a64bc50faf7305ae74f058a0114d095a
2014-01-14nFlags parameter to Window::Hide appears effectively unusedStephan Bergmann
...there was a handful of Hide(true) calls, which would happen to actually mean Show(false, SHOW_NOPARENTUPDATE) but I assume those were typos rather than genuine requests for SHOW_NOPARENTUPDATE. Change-Id: I20310d58437bb556f95965885f82784f855b517d
2014-01-14sal_uLong->size_tCaolán McNamara
Change-Id: Id10a0d7e0d635a6829966dc5ce0110dc715d7c6c
2014-01-14longparas: bump nLen to 32bitCaolán McNamara
Change-Id: I49621bc3887baf8fcee17559818193325b83f27d
2014-01-13longparas: convert ValidateKashidas to sal_Int32Caolán McNamara
we can use -1 as the failure return code as return value is always checked and isolated from the rest of the code. Change-Id: I87a743de82d681a7e4eabc61a576c4e50f1279a8
2014-01-13drop unnecessary tools/string.hxx includesCaolán McNamara
Change-Id: I2439ed19b554381f80e882aacbac05167622df92
2014-01-13longparas: weed out xub_StrLen in pdf writerCaolán McNamara
Change-Id: I3570f653ec44edcf0a215ffcac2017b9a5a3544a
2014-01-13longparas: drop 16bit string limits in meta text actionsCaolán McNamara
Change-Id: I35144034f002cdaaa759a84731aae5fa48c6aa5a
2014-01-13longparas: xub_StrLen to sal_Int32Caolán McNamara
Change-Id: Ib3eb5f9df112696b326bb30e4deed49d37f30c86
2014-01-13disentangle CalcSizeCaolán McNamara
Change-Id: I42248ff611dbe7c109076da5d548717898341be3
2014-01-12longparas: nStart and nEnd are always overwrittenCaolán McNamara
so simplify to the reality, which conveniently removes some hard-coded 0xFFFF and STRING_LEN uses Change-Id: I4fc014a972f6a157c18f8194c410b7cbff03de4a
2014-01-12longparas: raise 16bit cursor pos limit to 32bitCaolán McNamara
Change-Id: I08e4e954d4f07800d23b50d3fc933b1d2984eca0
2014-01-11longparas: OldTextLen and DeltaStart are unusedCaolán McNamara
Change-Id: Icfcbfece1954675cd4b8882f66726d80b7315e61
2014-01-11longparas: lift 16bit max edit lengthCaolán McNamara
Change-Id: Ide74f0a48f06cbe9539f16ef6c6d04bba043dcf9
2014-01-11longparas: convert GetMaxVisChars from xub_StrLen to sal_Int32Caolán McNamara
Change-Id: I25fcfc3ae5a599bbd7ebef3071895ec9dbf2949e
2014-01-11WaE: unsafe mix of type 'sal_Bool' and type 'bool'Tor Lillqvist
Change-Id: I6d9910d33b34672d412f3346ee9dd131610215d0
2014-01-10operator ==, != should return boolStephan Bergmann
Change-Id: I73cb672175f49535a3d0e248d9ed970bb5e3be4a
2014-01-10Use boolStephan Bergmann
Change-Id: I6a300087d28c8a8b7266657df4250864e689075b
2014-01-10endSpool return value is effectively success flag, not job IDStephan Bergmann
Change-Id: I5b96eeff80ca29f0f8f24ee6da7a2ca76cbb05ce
2014-01-08Revert "make FilePicker::createWithMode not crash"Matúš Kukan
This reverts commit 58ea27124af27bfac21a796b0d13d72354bd0dd3. It's probably better to fix it another way.
2014-01-02Resolves: #i123895# split impfont.cxx source from metric.cxxHerbert Dürr
and move the helper function UpdateAttributesFromPSName() there to make it available for all platforms, not only ATSUI-based ones. (cherry picked from commit a3895516f02a80151caaac8b92fb50aa5f7ee93b) Conflicts: include/vcl/metric.hxx vcl/aqua/source/gdi/salatsuifontutils.cxx vcl/inc/impfont.hxx vcl/source/gdi/metric.cxx Change-Id: I6d5702d429673c83740cb72775014f8942e5f44d
2014-01-02allow simple MessageDialogs to be created from just message stringsCaolán McNamara
Change-Id: I9f8324d1c61bd55ccc78e67699ebdfa946e48af6
2013-12-28make FilePicker::createWithMode not crashCaolán McNamara
i.e. calc->data->XML Source->"browse to set source" calls com_sun_star_comp_svt_FilePicker_get_implementation with its single argument in arguments as opposed to the empty argument expected there. So allow the single-argument case, and pass the argument through and apply it automatically via XInitialization::initialize in Application::createFilePicker. I'm far from sure that this is the right solution, but it has the advantage of working vs crashing. Change-Id: I07c1baae7f47781920eac56763e8fd003a7b99e1
generated by cgit (git 2.34.1) at 2025-01-01 19:06:17 +0000