summaryrefslogtreecommitdiff
path: root/include/xmloff
AgeCommit message (Collapse)Author
2016-04-14loplugin:passstuffbyref in xmloffNoel Grandin
Change-Id: I5995510c5c0686e5e69e8853d81dcba83ae96211
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: Id2c34c5515ca72bba98ff618171b94a6d2da3620
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-12clang-tidy performance-unnecessary-value-param in xmloffNoel Grandin
Change-Id: I8e6d8e66cdab2e50ee10882e139be29c14ce50f6
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-29Avoid reserved identifiersStephan Bergmann
Change-Id: I759939aa74570be63f5d41814c22aad1851d65c4 Reviewed-on: https://gerrit.libreoffice.org/23587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-16loplugin:constantparam in xmloff/Noel Grandin
Change-Id: I376f1d4ac65de584f9caa6ba8e25e43216374112 Reviewed-on: https://gerrit.libreoffice.org/23295 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-08loplugin:constantparam in xmloffNoel Grandin
Change-Id: I531dcf0861ab5a545eec16bf4aa92ac92eb9626e Reviewed-on: https://gerrit.libreoffice.org/23022 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-04loplugin:unuseddefaultparams in vcl and xmloffNoel Grandin
and teach the plugin about code that takes the address of a function Change-Id: Ia9d5afef44520aca236659e8176f1e27135ef4fc Reviewed-on: https://gerrit.libreoffice.org/22861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-25loplugin:unuseddefaultparams in xmloff/Noel Grandin
Change-Id: Ia504a4e96a4ebc8404fe6881e0f77fba29cd00ae
2016-02-22loplugin:write only fieldsNoel Grandin
Change-Id: I45895e9845a9037da207f001fece427452ed499f
2016-02-19add "use-wildcards" XML_USE_WILDCARDS, tdf#72196Eike Rathke
to support ODF table:use-wildcards Change-Id: I448bc53dd81d79a29efad9fbd240ae9c059dfd15
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09Formatting changes across all modulesChris Sherlock
+ Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-02xmloff: tdf#96147: ODF export: fix duplicate fo:background-colorMichael Stahl
... attributes that happen if both CharHighlight and CharBackColor properties are used, because the CharBackTransparent property wasn't taken into account, and combining the CharBackColor and CharBackTransparent properties happens *after* XMLTextExportPropertySetMapper::ContextFilter() runs. Also, it looks like a transparent highlight wouldn't export properly but apparently DomainMapper::getColorFromId() won't create such. (regression from f880962f5bf26bfaef06bd3f9e67e2d901a2e74c) Change-Id: Ib628ef8bb377482f74fadb97c81afb95fbbf7184
2016-01-15loplugin:unusedmethods unused return value in include/xmloffNoel Grandin
Change-Id: I6615a467152a50e9c65f04fd0d6c8cc128517bdb
2016-01-12xmloff: SvXMLExport::mbExtended is dead nowMichael Stahl
Change-Id: Ie679259deccce87949d7bf8767af707827b4134c
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-08tdf#96480: ODF import: eliminate duplicate cross reference heading bookmarksMichael Stahl
7c3c3006deaaaf1bb3f2f4eeeaf11da3bcebe53c is apparently worse than it appeared at first glance since there are numerous assumptions about bookmarks, such as that if they were inserted successfully they may be copied successfully, which isn't the case for duplicate cross reference bookmarks. So fix this differently, by eliminating the duplicates and mapping all reference fields to refer to the surviving bookmark. It was not possible to do this in SwXBookmark by checking the makeMark() return as that would raise interesting problems such as it's currently guaranteed to have 1:1 SwXBoomarks to core Marks so we can't just connect 2 SwXBookmarks to the same core Mark, and we also can't leave the SwXBookmark unconnected after attach. Another alternative would be to temporarily allow inserting the duplicate bookmarks and then eliminate them after the import, but what is implemented now is to check from xmloff for duplicates, which is reasonably simple. Change-Id: I7ee4854d1c9d8bf74201089cbb7287b1bd8ee3b9
2015-12-22tdf#96181 SVG: Add support for <use> elementXisco Fauli
Change-Id: Ia95c7e35158f8a4c6a597662524c74e1909983bb Reviewed-on: https://gerrit.libreoffice.org/20483 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2015-12-22loplugin:unusedfields in include/vclNoel Grandin
Change-Id: I61fc04e00970ea0d398ff80f6b1f81ec2f62dd5e Reviewed-on: https://gerrit.libreoffice.org/20868 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-19xmloff: missing includeMiklos Vajna
Change-Id: I425782f9e6b95264f08e91ddabbc377de2e3fffa
2015-12-19coverity#1343637 Double freeCaolán McNamara
and coverity#1343638 Double free coverity#1343639 Double free coverity#1343640 Double free coverity#1343641 Double free Change-Id: I8ce42f03d40fe514f73b3a7eabdb4f323b2239e6
2015-12-17Avoid memory leaksStephan Bergmann
...when exceptions get thrown while a context owns an rewind map Change-Id: I90d26caa57ef2ff508e6eae05ddbc62cdb3f01ea
2015-12-17tdf#32248 SVG: first attempt to support tspan elementsXisco Fauli
it's not perfect but at least we can already display the text, which is better than displaying nothing Change-Id: I89627010ac8071c106b41c1de6b183a619f8158b Reviewed-on: https://gerrit.libreoffice.org/20642 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2015-11-27typoMichael Stahl
Change-Id: Iebd5637328e905502d02a97b5294c67892688ecb
2015-11-26-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I3f328023d99d3505ab2ce2a80eef82d84d81446e
2015-11-25loplugin:unusedfields in include/xmloffNoel Grandin
Change-Id: I979743671e9a2e868d815f917427588b7b0320ba
2015-11-25store custom icon set info into ODFMarkus Mohrhard
Change-Id: I1581b28237d2b9f9c22d3f3b0436dc281508aafa Reviewed-on: https://gerrit.libreoffice.org/20118 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-11-18xmloff: add meta:generator constants LO_43x and LO_44xMichael Stahl
Change-Id: I1d962ad637f19b02855616edebcedbad719689c5
2015-11-18xmloff: document potential pitfall with SvI18NMap usageMichael Stahl
Change-Id: I37050203f9d7b4f04b6d0b0dc5c4e04855d017f7
2015-11-18remove unused typedefs and inline use-once typedefsNoel Grandin
and improve the script a little Change-Id: I2792ea4dd5df3a50736fbe209225c3f16fb86b84 Reviewed-on: https://gerrit.libreoffice.org/20033 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-17loplugin:unnecessaryvirtualNoel Grandin
update the plugin with lessons learned from the mergeclasses plugin and re-run it Change-Id: I9d622eb3d05fceaf8fa764c533c8fa5dfb4c7711 Reviewed-on: https://gerrit.libreoffice.org/20015 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-17use unique_ptr for pImpl's in xmloff/Noel Grandin
Change-Id: Ib95118941938af83fed566a085837e17f092017a
2015-11-115th step to remove tools/rtti.hxxOliver Specht
tools/rtti.hxx removed completed the interface of some Sdr.* Items and removed pseudo items Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a Reviewed-on: https://gerrit.libreoffice.org/19837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I8690de2cb68dcfedc9f2239ce66cea06fd94bc16
2015-11-05tdf#95510: SVG: Import stop-color and stop-opacityXisco Fauli
Change-Id: Ie073ff3e92c9344a78badfeefa0afed2c2b76fb8 Reviewed-on: https://gerrit.libreoffice.org/19731 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-10-27don't allocate rtl::Reference or SvRef on the heapNoel Grandin
There is no point, since it's the size of a pointer anyway Found by temporarily making their 'operator new' methods deleted. Change-Id: I265e40ce93ad4bad08b4f0bd49db08929e44b7d6 Reviewed-on: https://gerrit.libreoffice.org/19628 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-10-27Missing includeStephan Bergmann
Change-Id: Id57c9dded321b870002792056e9734ac3074a606
2015-10-26fix includes that are not stand-aloneNorbert Thiebaud
includes should be able to be included on their own fix some of the ones that do not respect that rule. Change-Id: Id161224a1978461d3cea43252f232f18888a4f61 Reviewed-on: https://gerrit.libreoffice.org/19612 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-10-23com::sun::star->css in include/ucbhelper to include/xmlscriptNoel Grandin
Change-Id: Iaa7f0b8455a601d3992c08cde0943c709c417256
2015-10-12Replace "SAL_FINAL" with "final" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: Ifa5ba21308e32df44571fa2941370f2f11179580
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-07tdf#88154 workaround and unit testMarco Cecchetti
Fixed 45-degree layout for axis labels, too. Change-Id: I9764e281aeee0a439fa9eec1e3b0df840221b72f Reviewed-on: https://gerrit.libreoffice.org/18889 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2015-10-07tdf#90839: follow-up workMarco Cecchetti
- Removed the data-label-wrap token and related code in xmloff module. - Using the already present `fo:wrap-option` seems to be the preferred solution: investigated to see how the token is imported exported: the class `XMLWordWrapPropertyHdl` takes care of that, luckily it converts the token to a boolean property. - Fixed a minor issue in the code for the data label dialog. Change-Id: Id050fdfeedd3af7fb79be96bfe157c61c4b44191 Reviewed-on: https://gerrit.libreoffice.org/19197 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-10-01remove old standalone Sun bug numbersNoel Grandin
Sun bug numbers without any accompanying text are completely useless. Fixed with git grep -lP '//\s*#\d+#\s*$' | xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print' And then hand-checking the result to restore places where it deleted code. And then some more grepping and hand-editing to kill the others. Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29 Reviewed-on: https://gerrit.libreoffice.org/19023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-29loplugin:removeunusedmethods, remove unused stuffNoel Grandin
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-09-14tdf#92586 xmloff: fix import of stretched background imageMiklos Vajna
The bug document has: <style:page-layout-properties ... style:repeat="no-repeat"> <style:background-image ... style:repeat="stretch"/> </style:page-layout-properties> When a stretched background image is set on a page style using the Writer UI, then these two style:repeat attributes always match, but not in the bugdoc. The later used to have priority, till commit 7d9bb549d498d6beed2c4050c402d09643febdfa (Related: #i124638# Second step of DrawingLayer FillAttributes..., 2014-06-02). Fix the problem by extending XMLBackgroundImageContext::EndElement(): if we know that the <style:page-layout-properties> sets the FillBitmapMode property, then don't blindly set BackGraphicLocation, but try to overwrite the exiting FillBitmapMode one. Change-Id: I64ab4363b20cc95003d35acd63ea421472b1c071
2015-09-09tdf#90839: support for wrapped text in data labels and for centered data valueMarco Cecchetti
Now in a pie chart the text of a label can be wrapped, the wrapping is automatic and the maximum text width is fixed to almost half the pie radius. This feature is used to import correctly the relative text wrapping property provided by MSO. Moreover the data value and percent value of a label are now centered horizontally, respect with the label text. Conflicts: chart2/qa/extras/xshape/chart2xshape.cxx Change-Id: Ie10d6184365436f763cd9693a5bbefcfa9b3862b Reviewed-on: https://gerrit.libreoffice.org/17193 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>