Age | Commit message (Collapse) | Author |
|
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
|
|
Change-Id: I824e8436945e056840386960308b8e63627a603f
|
|
The saveAsWithOptions/saveAs split existed for reasons of historical
API compatibility. Since we're breaking the API currently we can
now get a clean start, and get rid of the redundant saveAs, and
make saveAsWithOptions the standard saveAs function.
Change-Id: Ia3e2294a8604cab08e95b07544c9d10d42dd1152
|
|
Change-Id: Icebdf0cad5306ae42a30de0b4f997e3b611675eb
|
|
Change-Id: I9de33fdcd8b1ef73d57884033f502ac4a03f63d3
|
|
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
|
|
Change-Id: Ia25c686dac799707cae3f6112c731f8cd3f686c2
|
|
Change-Id: Ia391ccc9889a135730f0fead11eb0b6c2f748ec4
|
|
Change-Id: I4d558e9a6e2c4e4d9feb45eb5a3fd01ee322bef8
|
|
Change-Id: I4d3dd913faea8b9f4a0bd3c13af37d097ced9888
|
|
Change-Id: I7dd08c182657084ffa635e1960f4d0def6d7a6bb
|
|
Change-Id: If272d5025e08fcf5e67de30ffdf177383ef59370
|
|
Change-Id: Ib48999c7fe532b2a8bf5222ef27d8d4929937e3b
|
|
Change-Id: I259bf6012684e393765cfd73e813bcf2875abd5f
|
|
Change-Id: I6967a3c871338d1801d913d9bb54eba50a7660ca
|
|
Change-Id: I098c9ee9d22ac0401faf7fc6d65e91bf5b4b2bf8
Reviewed-on: https://gerrit.libreoffice.org/9797
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I2b6f33eaf12343c7da1328a932eb703bb4e4ef6f
|
|
Change-Id: Ic63372285fecb6f1be22e92c36cdb6f94733f5c1
|
|
...no reason to not have it enabled for URE C include files and what
little real C code is still left. (But note that Clang ignores that
warning.)
Change-Id: Ia6940f9f940a0c226e9b724331d65c9862ce32e6
|
|
toolbar combination
(cherry picked from commit 0ce4a90e14ddc9067d014405235a36aa959c6ea2)
Conflicts:
include/svx/fillctrl.hxx
svx/source/tbxctrls/fillctrl.cxx
Change-Id: I9a1b2490a7e9285559dddd4df7fb20c2216fd450
|
|
Change-Id: Ice7a4802605fbe59dfb24a27408106756a3494ba
|
|
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
|
|
Previously, we always exported the text of the shape itself. Bring the
VML export in sync with the drawingML export, where we only do that if
the shape doesn't have an associated textbox -- if that's the case, then
export the textbox's text instead.
CppunitTest_sw_ooxmlsdrexport's testFdo69636 is a reproducer for this
problem, the VML assert failed because of the lack of this.
Change-Id: Icb236579da4e3b74e983a95aa5675fed7862d1e1
|
|
especially because most of them don't handle intercepting text getting *pasted*
into them right, so start with the one which does that right.
Change-Id: If6770798872ed3c72c469656ebf0d4fd76d2171d
|
|
Change-Id: I833e6e9c78620443325b5ef9efa403a5eef497cc
|
|
* No need to support null pNewModel argument (the one call site that did pass in
null explicitly in sd/source/ui/func/fupate.cxx can just as well pass in
mpDoc, and all existing call sites are guaranteed to pass in a non-null
value).
* With that changed, SdrModel::MigrateItemSet can be static. (At least in
JunitTest_forms_unoapi it could happen that the call from
svx/source/sdr/properties/attributeproperites.cxx called MigrateItemSet on a
null GetSdrObject.GetModel(), which was undefined behavior even though it was
harmless.)
Change-Id: Idface48da7e889c6e5768d0e49bc67c88b4c3ec4
|
|
...which the recent loplugin:staticcall changes showed was occasionally used
apparently under the assumption that it was non-static and changed the object
it was called on.
Change-Id: I989a2a4ed3886d7f370855c9e8c1867e646c059b
|
|
and strip away some stuff in rsc that should now be dead
Change-Id: I6411e706c50dff299099680f1f942bf61c4e79f2
|
|
Change-Id: I07ba855e473fb137551e70de9cfa858c5e079324
|
|
Change-Id: Ib3b25a0aab2389be68fc8339f9b08a87de419b33
|
|
Regression introduced with 83f77ab0661df992f241e5f9ecb1aa8f8eaeafec.
Interpreter errors are transported using NaN coded doubles, using simple
setNan()/isNan() to flag and ignore non-numeric values skips all error
values.
Change-Id: I0d3cb30262bc5ba7ee77e53a2bc45e56569fbc4b
|
|
ForceArray parameters weren't propagated and enforced to array arguments
on svJump tokens (FormulaJumpToken), namely IF, CHOOSE, IFERROR and
IFNA.
Change-Id: Icf9074f11b826655a52858d778d9a0122d207aa4
|
|
Plus fix some problems related to temp files.
e.g. kmz converter was creating temp files next
to the input file.
Change-Id: Ib3f367fe1c4ef3cb25f5ca1c3d06b2dde78c5e45
|
|
Change-Id: Icd7d78a332fbb67e32ab929f0afc5881ab7448eb
|
|
Change-Id: Ic688f08cada4ae70ea1dfb1e29e249a166456452
|
|
We can't check for NULL from beyond the end of a smaller structure.
Change-Id: Id3754bf747c402cf0d767eda5fd4b5ad6b5789e9
|
|
Change-Id: Ice611cf5913051346a3a0c0b00ed35a35a0dfe3c
|
|
Change-Id: Icff9a0f112c80569a4533d5c0c6e789eec3925ee
|
|
Change-Id: I596ec18deca1a7bd85bc49f637fc1765e43d1278
|
|
Change-Id: Ib751fe39cca72fe1cfc9789e63f28a00abb9113a
|
|
Change-Id: Ibd4ded85d5d3e1de8bf12934cbe55210d1983b18
|
|
Change-Id: I9143e7fffef6e99d25a0fd87712ed26d2d42116e
|
|
Change-Id: If263b8fc748f67a1ed423c0f3f7cd465cf533993
|
|
However for the sake of ABI compatibility we can't change
liblibreoffice_hook.
Change-Id: I0e921efeeab40ef1b53a67c0e7a89d4c75ced831
|
|
Change-Id: Ib2754a77be470faaa6f9b27644a1d8dd082ed2b8
|
|
...and also corresponding param of CreateTabPage function type and corresponding
Craete functions. There were some call sites that passed undefined "null
pointer references" and SfxTabPage internally uses a pointer member pSet that is
checked for null anyway.
Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
|
|
Change-Id: I54880de44ee10d4f71c8a514f905e8e00774fde7
|
|
Change-Id: Iee19af81c648cb82074d8cabc13716b0d38c7ff6
|
|
...there was a call site that passed undefined "null pointer reference"
(apparently in a case where the passed argument was actually unused)
Change-Id: I663d4264b7a84f44ca69c732f3bc502f614b2b2a
|
|
Change-Id: Ia08f67e359bbd26cefdba8661f0b0c4ae2147382
|