Age | Commit message (Collapse) | Author |
|
Change-Id: Ica0ff6a36e64c732000ef900fa7aeafaf6da3e04
|
|
Change-Id: Id00e2579edcc9856c0fa3985e34c4a2f3e7ae5ec
|
|
... to avoid bugs like commit f0d6e0e1e21afd0adf5bd01d771b2d83d8f13a48.
Change-Id: I1e41d421609e09bf62a7a04ba34f3a8e8d118fd3
|
|
The primary benefit of this is that it's no longer necessary to manually
downcast to each and every subclass in sw.
Change-Id: I5742d5744836eef192eef2d4f7ad180da67eb914
|
|
regression from
commit 10e77ab3ff6f4314137acd6e2702a6e5c1ce1fae
Author: Thorsten Behrens <thb@documentfoundation.org>
Date: Sun Nov 2 22:37:32 2014 +0100
coverity#1242508: swapped arguments
rename the variables to indicate which are source and
which are dest indexes and that the aNewBitmap
argument is always, and assert that it must be, of
equivalent rotated source to the Bitmap which has
ImplConvolutionPass called on it.
Change-Id: If9715b9f29655da66c6981c0f7cab3d89c528ed7
|
|
after paint"
(and its later fixup)
This reverts commits
e8a68c1f50f32a0f9d8bcdf16c1270c319910baa
e60b589952985edff12b1a28392ce6fa0ca8d9be
It was a work-around for the real underlying issue, which was that the
result of dbaccess::ResultSet::isFirst() et al were clobbered by moves
made by its clones.
The BrowseBox has two different cursors:
1) One for data to edit (which is kept on the current/active row)
2) One for data to *paint*
The second is a clone of the first.
The real underlying issue is fixed by:
commit d7c9a1d9d65fe8b1a56c5c280d2ca6640a549d2f
Author: Lionel Elie Mamane <lionel@mamane.lu>
Date: Thu Jan 22 10:49:42 2015 +0100
fdo#88475 RowSetBase: reposition cache before interrogating it
Change-Id: I28d62673fdf10ee6507d38bb7c79c08e4b40902f
|
|
The Itanium C++ ABI mandates that for a unique (complete) C++ type a single
unique symbol for the type's RTTI name is used across a process's dynamic
objects (so type equivalence can be determined via pointer comparison on the
RTTI names).
GCC nowadays deviates from that, using strcmp to determine equivalence, so it is
resilient to RTTI names being bound locally within dynamic objects (which has
performance benefits, but also makes it impossible to have unrelated types that
happen to have the same name "encapsulated" in individual dynamic objects---
whether or not that would violate the ODR would be open to interpretation of how
dynamic objects fit into the C++ Standard).
LLVM sticks to the Itanium ABI, which becomes notable in at least two places:
For one, libc++abi's __dynamic_cast uses strict checking. It still has a
_LIBCXX_DYNAMIC_FALLBACK for now that additionally uses strcmp checking and
syslogs visibility violations. Mac OS X uses libc++abi with
_LIBCXX_DYNAMIC_FALLBACK enabled, and running LO routinely logs dynamic_cast
errors to the Console there.
For another, RTTI-based UBSan checks unconditionally only use strict checking
(cf. isDerivedFromAtOffset in lib/ubsan/ubsan_type_hash.cc). This causes false
positives from Clang -fsanitize=function and -fsanitize=vptr even on Linux not
using libc++abi.
Therefore, introduce SAL_DLLPUBLIC_RTTI to mark types for which RTTI needs to
have default visibility under the Itanium/LLVM semantics. There is
unfortunately no way to mark only the (implicitly generated) RTTI symbols for
default visibility, but at least with the cases where SAL_DLLPUBLIC_RTTI is used
for now that is no real problem---any class type marked SAL_DLLPUBLIC_RTTI only
has inline (covered by -fvisibility-inlines-hidden) or undefined pure virtual
functions. It appears that even the vtables of those classes remain hidden, at
least with Mach-O on Mac OS X. (That also means there is no need for a
SAL_DLLPRIVATE_RTTI marker analoguous to the---also superfluous in retrospect---
CPPU_GCC_DLLPRIVATE one.)
Nevertheless, the number of exported symbols of course increases when
SAL_DLLPUBLIC_RTTI is "active." For a full-blown --enable-dbgutil build on Mac
OS X,
find instdir/LibreOffice.app/Contents -name \*.dylib\* -exec nm -gU {} \; \
wc -l
increased from 125541 to 139239. For Linux, an option might be to "activate"
SAL_DLLPUBLIC_RTTI only for __clang__ plus !ENABLE_RUNTIME_OPTIMIZATIONS.
The set of types marked SAL_DLLPUBLIC_RTTI with this patch (wholesale cppumaker-
generated UNO enum, struct, and interface types; plus some IEmbeddedHelper and
IUndoManager) is chosen so that a full "make check" on Mac OS X no longer
syslogs any dynamic_cast errors to the Console.
Change-Id: I42fa6ec01c2503ec24bcd9c0518abb112afa3235
|
|
Change-Id: If218d83297bfdd39471d5502c0639248c96af9c6
|
|
It is already loaded correctly, and reloading leads to bogus TextChanged event.
Change-Id: I9ad384ce60bbfd477199a1c9fb81e8e201a5162b
Reviewed-on: https://gerrit.libreoffice.org/14096
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
|
|
Change-Id: I56205bf5c28b6196aae10ecfa658111768f0e433
|
|
so docs cannot be toggled r/o r/w from properties page or the file name
changed. Unkink the logic a bit based on that and move now static widget
settings to .ui and remove unused checkbox
Change-Id: Ic55e41be8ffd02e214a233a2eb90736c070b5418
|
|
Change-Id: I225cbb3a4a66a8f20bec91c4770ad78e72b663b1
|
|
We don't want such a mode to affect other uses of randomness, though. Thus use
a separate random number generator object for these two functions, and use a
fixed seed for it if the SC_RAND_REPEATABLE environment variable is set.
As RAND() is implemented in sc, and RANDBETWEEN() is implemented in scaddins,
it was a bit hard to figure out where to add the new functions needed, without
having to over-engineer things with UNO. (This functionality is totally
Calc-specific, but neither sc nor scaddins has any public (non-UNO) API.)
Caolan suggested the formula module, which seems like a good enough place to
me.
Change-Id: I4b0cb327392e51a18bce28478af91b0174d6b726
|
|
Change-Id: I665cde5d4c89443238efb283c86277dedf621197
|
|
Change-Id: I10e8c344ae6aa2e0a4ef562154f57e2070c70e2f
|
|
Looking into the code we handle more cases correctly so remove this
misleading comment.
Change-Id: Id738bb8af312dfce97560a43122a81a6708f64d3
|
|
Change-Id: Ia47c0bc3539ddf8f925cd053a2431c742c46d337
|
|
Change-Id: Id25a050a9840d83cff4b390faec7478f17336524
|
|
Change-Id: I74d35630b9fcdaa97af0b1f1e6d1e5c72488964d
|
|
Change-Id: I2b540c4c0c34823143e13d16559dac7458a38933
|
|
Change-Id: I5eb4e1cae38decb293ea11f7cd4bfda0bad3afcb
|
|
Change-Id: Ie54d340478412e62b87d66e287fd8a3963e97898
|
|
Change-Id: Iec1251648031afa9eddd7445135fb08dc74821bd
|
|
Change-Id: I6d3ffb195a7c9a3c44744d296fb9d9eca00115cd
|
|
Take care not reproducing fdo#86552 again.
Change-Id: I4a5967e76afcb5467addc81bc9eca61bb65865e7
Reviewed-on: https://gerrit.libreoffice.org/13992
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
OSL_ENSURE does not execute in non-debug builds (and is deprecated).
Do not try to seek back if paint did not seek.
This happens in particular when there is no data source attached (and thus trying to seek fails).
Change-Id: I3f4908c4dcae2bb120bf58c1218e3386c40d5721
|
|
So far it's been always disabled, with the exception of the slide preview
extension.
Change-Id: Iaee6fe2d5267c9dfdc31cbf4fb90a9ac0e08e781
|
|
Additioanlly cleanup and use ScopedReadAccess
Change-Id: Ia3365f4dc968368bdd90d4398188bffe2d56e89b
|
|
Change-Id: Ia6c178dd9390bf75a08c0d53e6505582a7f5ab4f
|
|
Change-Id: I52d7a7aaf304b7d698705cda7d3e70e723811fb2
|
|
from 234e45bf1d27484b72e73fe327b1e92fda1933f1
Change-Id: Ic1bcab8a9662e2f302a24a6eaad2f813c12b28a8
|
|
This fixes a crash as we would need to make each context current before
calling ReleaseFramebuffers.
However this is totally unnecessary as only the current context can have
bound framebuffers.
Change-Id: I8b1496bb890982742b3d2ebf60fdce47db642d70
|
|
This thing was starting a timer that re-starts itself forever, and when
the file it was watching changed, it would just assume the drawing
objects were still there (and the document, for that matter...)
Change-Id: I35f187f0828097a05618dc1733dce819fc6bffc6
|
|
Change-Id: I79371b4ad9d29a5ab8fd01244c3f80db92b07f97
|
|
The primary purpose of gtktiledviewer is to see the same features / bugs
than on mobile devices. On Android we already render 256x256px tiles, do
the same in gtktiledviewer instead of a single huge tile.
Change-Id: I377dcab59e7019dcf1d15a27ccba117eb53d0d5b
|
|
Change-Id: I0863ec8fb159a2e367951ba9e7d7310d250d8a1e
|
|
Change-Id: I3d422670323cd982251569c4226dc46803d4f6a1
|
|
Change-Id: Ifdc8df1852e29173ee571102aed1c21d5611171b
|
|
Change-Id: Ic206ebff28683da2b1daf23039820c2184788595
|
|
This reverts commit 06a5b619a76c96783ee67bdcfd21f203d3ddb53c, which broke
Solaris/Illumos builds for no good reason, cf. mail thread starting at
<http://lists.freedesktop.org/archives/libreoffice/2015-January/065844.html>
"4.4.0.1 build error on sal/types.h on solaris/illumos."
Conflicts:
include/sal/config.h
Change-Id: I063453ee1115ae3f97e2835828800c74e3cb5e48
|
|
...broken with 60d60caf99a40ca0c3891bf230c5a1fdbae5f49c "Renamed XPropertySet2
to XPropertySetOption" et al
Change-Id: I684736ffafc4642548b7c24171cc52c1acb32252
|
|
sorted_vector no longer inherits from std::vector
and simplified some of the code.
Change-Id: Ie9ab93dae6865f21f62abc384ed8c166b74d15ec
Reviewed-on: https://gerrit.libreoffice.org/13881
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id28c3e1617f2e73c36f13b506488d401a22b00a8
|
|
Change-Id: Ie116cee9282b3cc73e3bbb9b3fbaa50b1e8e974a
|
|
if we didn't make use of them.
Change-Id: Iee1c2fef5966a614b068c832bf8c6b51973b4c8a
|
|
Change-Id: I662f51d8d7c88a6c6f7306c344d99841a3102bb4
|
|
Change-Id: If47baad0ec31f18fcb55c7db86fb2a316dd0807f
|
|
Change-Id: I1f7b51094acf0baf79160f65fdec67c9934930aa
Reviewed-on: https://gerrit.libreoffice.org/13897
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: I8148081e2f2d89bdd319b5dc7346af672a8cf310
Reviewed-on: https://gerrit.libreoffice.org/13896
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: I65a79d4e88f82cb76d9b6ab39f06a11acd4f3e41
Reviewed-on: https://gerrit.libreoffice.org/13895
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|