summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): testStephan Bergmann
Change-Id: I9cef15ecfcf15d6b5db5ccf6eed8d1a4ca962e67 Reviewed-on: https://gerrit.libreoffice.org/76638 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): toolkitStephan Bergmann
Change-Id: I598d89be70d476663ffef95029015cba17bf09b9 Reviewed-on: https://gerrit.libreoffice.org/76636 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): unotoolsStephan Bergmann
Change-Id: Idc40b72de04ee17dcc60913cc5f81f5f69dd57e9 Reviewed-on: https://gerrit.libreoffice.org/76631 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): vbahelperStephan Bergmann
Change-Id: I10c543744f22a9f4db4e99c97629bb0e0b7f37db Reviewed-on: https://gerrit.libreoffice.org/76628 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-30remove newly unused SvxCheckListBoxCaolán McNamara
Change-Id: I6a5f4dfea9fbb34f02c1752140e04d1d0a8a67a7 Reviewed-on: https://gerrit.libreoffice.org/76617 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld OfaLanguagesTabPageCaolán McNamara
Change-Id: Ib0938f0c9d810c0f851dd0180093aabb4babdc19 Reviewed-on: https://gerrit.libreoffice.org/76594 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld SwRedlineOptionsTabPageCaolán McNamara
Change-Id: Ic901356d399e8d758747f0fea07d3656fbf89aab Reviewed-on: https://gerrit.libreoffice.org/76559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30tdf#62699 Drop (now) pass-through header include/vcl/salbtype.hxxGabor Kelemen
Change-Id: I2e2093ac3c8c6833b70d4932bc12a82a4483bde5 Reviewed-on: https://gerrit.libreoffice.org/76499 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-30Fix typosAndrea Gelmini
It passed "make check" Change-Id: I50c3639ec258c7fb6d73104f8e777f96995aa8e3 Reviewed-on: https://gerrit.libreoffice.org/76543 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-30tdf#125609 c14: vcl button: don't modify style directlyJustin Luth
LO 6.4/6.3 commit d35171456bc230efdaa9426da1398b2db7fa0df8 could cause a recursive loop. ImplInitStyle RETURNS the suggested style, while ImplUncheckAll MODIFYS the actual style. Since the call to set WB_TABSTOP was already redundant in this case (and many others), I provided an option to avoid that direct modification. An example crashing document is attached to the bug report, which will eventually find its way into automatic crash testing. For this particular example document, it also requires LO 6.4 commit 5cf057c3365a0feafc8f2e4f4a9e24d69a581999 in order to trigger a crash. Change-Id: I26dddca27471dec10650f848f787363505b16c0f Reviewed-on: https://gerrit.libreoffice.org/76186 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2019-07-29weld ScTpContentOptionsCaolán McNamara
Change-Id: Ia0ad05337ae3195e565e4b913cdf34e9a32e9cea Reviewed-on: https://gerrit.libreoffice.org/76552 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29revert bits of "loplugin:sequentialassign"Noel Grandin
from commit 0d36b32755ac662299e6a8165e9fa57311b74a2f Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Sun Jul 28 12:03:35 2019 +0200 loplugin:sequentialassign which were false positives and not meant to be committed Change-Id: I6f2f185bd3564c9329f5a0c78c9020f3ddb52d34 Reviewed-on: https://gerrit.libreoffice.org/76518 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-29Fix typoAndrea Gelmini
"an API", to complete: https://gerrit.libreoffice.org/#/c/75984/ Change-Id: I441f89b44a96957ea254823b9f28086fa289cc54 Reviewed-on: https://gerrit.libreoffice.org/76036 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-29Fix typosAndrea Gelmini
Change-Id: Ic2fb0772648b3f93c2fdfa4d2f663b6ede2ead51 Reviewed-on: https://gerrit.libreoffice.org/76507 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-29loplugin:sequentialassignNoel Grandin
Change-Id: I56a9bf698b60bd278c71cc632aacef2bd2f4c13f Reviewed-on: https://gerrit.libreoffice.org/76501 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-28lok: send cell selection rectangle and cell area fill rectangleTomaž Vajngerl
Instead of text selection start/end for cell selection we send a cell selection rectangle event. This is needed so we're able to differentiate when to draw cell selection and text selection markers. In addition send cell fill area rectangle, which is the area where we need to hit to trigger area fill functionality in Calc. Change-Id: I54af958932815818a1a4d48364192ba43f1df7de Reviewed-on: https://gerrit.libreoffice.org/76491 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-07-27weld SwStdFontTabPageCaolán McNamara
Change-Id: I9bf2177b9d95949815431789093b1fa6c30e2dee Reviewed-on: https://gerrit.libreoffice.org/76482 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-27weld OfaHtmlTabPageCaolán McNamara
Change-Id: I10ee46d19047da9a3e3d8b0f99866568a12aa0f1 Reviewed-on: https://gerrit.libreoffice.org/76471 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-27tdf#74702: vcl add OutputDevice::Flush() to remove GetOutDevType()Chris Sherlock
Change-Id: I3e8775845e471517945876a48696747a46e5270a Reviewed-on: https://gerrit.libreoffice.org/75616 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-07-27enable setting a highlight bgCaolán McNamara
(cherry picked from commit 9b618c846835abb1fe664b5951dffb3c133380fe) Change-Id: I44649a9e2b1b267b56c2a5691d23665e7df94a58 Reviewed-on: https://gerrit.libreoffice.org/76449 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-27drop empty GetParentLabeledBy and GetParentLabelFor membersCaolán McNamara
Change-Id: I92b36874879f89ef4dc862d61da58edd64867e92 Reviewed-on: https://gerrit.libreoffice.org/76450 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-27devirtualize these now nothing overrides themCaolán McNamara
Change-Id: Iae9a832b1a198a02c916c1e5eab893c166cdf615 Reviewed-on: https://gerrit.libreoffice.org/76387 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-27Fix typosAndrea Gelmini
Change-Id: I380856ca45c835e732fdf080a522caab4534db5b Reviewed-on: https://gerrit.libreoffice.org/76346 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-27tdf#94395 Show paragraph style line spacing in organizer containsJim Raykowski
This patch provides functionality to SvxLineSpacingItem::GetPresentation and also fixes tdf#126466 Change-Id: I9e0cb042c83c568051061de3467d402ef88cfdf4 Reviewed-on: https://gerrit.libreoffice.org/76069 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-07-27tdf#74702: remove GetOutDevType() from ImplAnimViewChris Sherlock
I have done a spot of refactoring - it turns out that the bits where we save and reset the map mode during background saves should probably be done in Window::SaveBackground(). As Window::SaveBackground() doesn't need the animation size (maSzPix) I have rarrange the parameter order so the Window function can ignore the parameter. OutputDevice::SaveBackground() has been introduced as a virtual function and now is overridden by Window for its own purposes - OutputDevice just does a DrawOutDev(...) operation on the background. Change-Id: Ifeffe9536c01d8e4737f6e39a4f3dd14ba418f4d Reviewed-on: https://gerrit.libreoffice.org/76399 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-07-26weld SfxCommonPrintOptionsTabPageCaolán McNamara
Change-Id: I11fa5e3b39b7ab0142192c293205dc8e23caaa0c Reviewed-on: https://gerrit.libreoffice.org/76386 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-26sfx2: LOK: resize the sidebar after layouting to avoid scrollbarsAshod Nakashian
By resizing the deck we ensure that if the contents do not fit in the existing height, they will after we expand to the minimum height. Also, the minimum height is now the correct one. This prevents seeing vertical scrollbar in LOK, which is very slow and unfriendly, instead renders the full sidebar and lets the client scroll, if necessary. Change-Id: Idc2a622a65074b7afb26263624f2df0b5968f40d Reviewed-on: https://gerrit.libreoffice.org/73523 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26sfx: LOK: notify clients of the sidebar stateAshod Nakashian
Change-Id: I35b174c3a5e302ce52ee4063fa71d47feffab624 Reviewed-on: https://gerrit.libreoffice.org/73520 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26sfx: LOK: don't shrink sidebar height below minimumAshod Nakashian
This avoids scrolling within the sidebar and makes it possible to scroll the rendred sidebar image in the client, which is more responsive and lighter. Change-Id: I0713c699ba82bfc5fe503c9351402c67aef4494e Reviewed-on: https://gerrit.libreoffice.org/73519 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26sfx: LOK: toggle sidebar decksAshod Nakashian
Change-Id: I0559a2a4ae041bc61cf3a2d5979656a7941f4b02 Reviewed-on: https://gerrit.libreoffice.org/73518 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26Extension support for gtkmenuItem and notebookbar.ui file added for writerSumit Chauhan
Change-Id: I65a07fbef7726cdaa9061ebf2227fbedd725d4db Reviewed-on: https://gerrit.libreoffice.org/76278 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-07-26Fix typoAndrea Gelmini
Change-Id: Id01f3ef311e2fccc5fafa51d4fe19c0012f91345 Reviewed-on: https://gerrit.libreoffice.org/75560 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-26sfx: LOK: no sidebar tabbarAshod Nakashian
Change-Id: I210df42fec4404ed9629c9b1c24c78b680212214 Reviewed-on: https://gerrit.libreoffice.org/73517 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26LOK: sidebar: publish notifications to the correct viewAshod Nakashian
The ViewShell, which represents the view in question and therefore which view gets the window notifications, is incorrect when the sidebar is first created upon creating/attaching a new view. This leads us to a workaround to make sure that we publish notifications to the correct view. We also have to hide the sidebar instead of closing because the workaround wouldn't work when re-creating the sidebar on an existing view. See comments in code. Change-Id: I9d3be901688291b04d634b68e1e20c7add77381f Reviewed-on: https://gerrit.libreoffice.org/73516 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26cid#1401328 Uncaught exceptionCaolán McNamara
Change-Id: I3585fc84437d084670727b048d3b26231c76e659 Reviewed-on: https://gerrit.libreoffice.org/76352 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-26LOK: sidebar: enable only for Impress in LOKAshod Nakashian
Change-Id: Idb361164db9ea8681b45fe99608d2cb5690db161 Reviewed-on: https://gerrit.libreoffice.org/73511 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26sfx2: LOK: route the parent sidebar window instead of the deckAshod Nakashian
Change-Id: I0269a67c637afbc63a81405918f620009e681ff6 Reviewed-on: https://gerrit.libreoffice.org/73508 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26LOK: sfx2: disble sidebar menu-button when deck is hiddenAshod Nakashian
There is no render area on the sidebar virtual-device to render the popup menu when the sidebar is collapsed into the TabBar, so we disable it altogether as we can't properly display it in LoKit. Change-Id: I2edee9e734485bb685f0ddc0c30bfe584e42a550 Reviewed-on: https://gerrit.libreoffice.org/73507 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25LOK: support resizing windowsAshod Nakashian
And delegate resizing of floating windows. Currently used for resizing sidebars in LOK. Change-Id: Iadc1b71c15a7d16a8c9dd7246490ae6bd645644c Reviewed-on: https://gerrit.libreoffice.org/73509 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25tdf#47807 Invalidate bindings to Undo RedoJim Raykowski
This patch reverts the previous commit made for this and provides a new fix. Change-Id: I487ecf0a7564f1130ef9a42e893e73185701d8c9 Reviewed-on: https://gerrit.libreoffice.org/76287 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-07-25tdf#119228 Add storage and serialisation for the Resolved flagScott Clarke
Change-Id: I0278588dc533378104e544d05b60583c85271f6a Co-authored-by: Jim MacArthur <jim.macarthur@codethink.co.uk> Reviewed-on: https://gerrit.libreoffice.org/75858 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-25sd: sidebars are now visible in LOOLAshod Nakashian
Change-Id: I7ceae056e3d6ce1c991fe1194faa8bebfd6aae1e Reviewed-on: https://gerrit.libreoffice.org/73500 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25QRCode Dialog Box featureShubham Goyal
The patch handles the created QR code as a Customized Shape (Graphic Object) Change-Id: I1cee6f0e7fac585de880a9ac34e3bc441a4b7390 Reviewed-on: https://gerrit.libreoffice.org/74167 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-25Fix typosAndrea Gelmini
Change-Id: I59a0fd175fa5185c15d093d2d9bed9f95bb4cfd5 Reviewed-on: https://gerrit.libreoffice.org/76280 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-25tdf#47807 Invalidate bindings to Undo RedoJim Raykowski
Change-Id: I71a16e60395003402372202a755b976d37690a27 Reviewed-on: https://gerrit.libreoffice.org/76146 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-07-24Fix typoAndrea Gelmini
"an URI", to complete: https://gerrit.libreoffice.org/#/c/75985/ Change-Id: I57489b05117fd12ae6aa22544437ab5bc6b5154f Reviewed-on: https://gerrit.libreoffice.org/76037 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-24remove unused SvLBoxButtonKind::StaticImageNoel Grandin
and consequently unused SvBmp::STATICIMAGE Change-Id: Ie48deb0c757e6eb9e22e7b29cde72b0145c16943 Reviewed-on: https://gerrit.libreoffice.org/76235 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-24remove unused accessibility::DescriptionGenerator::PropertyType::FillStyleNoel Grandin
Change-Id: I20005ad23088d41262ff988eac2132918db56ab8 Reviewed-on: https://gerrit.libreoffice.org/76236 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-24move aboutdialog header inside vclCaolán McNamara
Change-Id: I1906992759afec0176b723917662fa0644a03c1c Reviewed-on: https://gerrit.libreoffice.org/76221 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-24tdf#114166 DOCX chart import: fix missing complex categoriesBalazs Varga
Now complex category labels are visible, and the inner data table contains the correct texts of the category columns. Note: repeating call of createDataSequenceByValueArray() API function can create all columns of the complex categories. See also commit 6c4e21a234f12e1310ba06f9859e08b424acf8bf "bnc#812796: Correctly handle static value array for OOXML charts." Change-Id: I333b79be35a24a912bb9e662116d0c85809a8fb2 Reviewed-on: https://gerrit.libreoffice.org/75776 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>