summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2014-10-21fdo#84938: replace WINDOW_BORDER constants with enumNoel Grandin
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-21nShearWink -> nShearAngleMiklos Vajna
Change-Id: I122f16783db4025b9335ed82a12f051516d98d4c
2014-10-20loplugin: cstylecastNoel Grandin
Change-Id: If50022b55a558c4124d71acbbe0ef5eb48801d0b
2014-10-20loplugin: cstylecastNoel Grandin
Change-Id: Ia3055b00c20a885dfa0584f864f0e91ccad1e9c9
2014-10-20Resolves: fdo#85006 limit script stripping to known suffixesCaolán McNamara
Change-Id: I276535b007bbb55555148d5937076b86da5de825
2014-10-20fix problem with gcc compiler complaining on variable typeAdam Co
Change-Id: I9a16e24e79d22b0af1710d6ac25eaa5fb19c71ff Reviewed-on: https://gerrit.libreoffice.org/12047 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-20coverity#1242606 Untrusted loop boundCaolán McNamara
Change-Id: Iafa03d4dd65eb343a80996880bc1ed846d1b7491
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-20Increase assert coverage of OStringBuffer argumentsMatthew J. Francis
Change-Id: Ifd3c9919ef104909efa8964e7a0cb5e723e3331d Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-10-19-Werror=shadowMiklos Vajna
Change-Id: I940661c947307dc5dea371e5e6f9a9aedbfc904d
2014-10-18convert SV_BMP_ constants to enumNoel Grandin
Change-Id: I46cb7f649fa44d8967e0e7da03583157d2706f05 Reviewed-on: https://gerrit.libreoffice.org/12018 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-17SID_TOGGLE_MENUBAR (aka slot:6661, .uno:MenuBarVisible) is deadStephan Bergmann
...since introduction of XLayoutManager's private:resource/menubar/menubar in 3fb2acf5b77bff59909f616c44c7de17048b64d7 "INTEGRATION: CWS layoutmanager (1.52.10); FILE MERGED" etc. and final removal of SID_TOGGLE_MENUBAR bits in f605b16e395e8ccc3d1aba7907b0792039016f69 "INTEGRATION: CWS sfxcleanup (1.119.8); FILE MERGED" etc. What still needs fixing are extensions/source/activex/SOActiveX.cxx odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/CustomizeView.java odk/examples/OLE/activex/SOActiveX.cpp in a similar way as e.g. 0273d3d81d29d5c1f6c387cca633cd99722c100e "INTEGRATION: CWS jl18 (1.6.8); FILE MERGED." Change-Id: I52a43fc7186a4f60929ab6246a2da2e715be7510
2014-10-17Resolves: fdo#62682 crash on second export of svgCaolán McNamara
because the first export has left "dangling" CalcFieldValueHdl Links in Outliners that got created based on the Drawing Outliner while it had a temporary CalcFieldValueHdl installed, and didn't get the old CalcFieldValueHdl installed when the old Drawing Outliner one was re-installed. Change-Id: I064a154ece488c9a4c3467b753451df7e73ae883
2014-10-17coverity#1247646 Uncaught exceptionCaolán McNamara
Change-Id: I332fb602466613e9e79ba4510879411e0bee9da6
2014-10-17coverity#1247643 Uncaught exceptionCaolán McNamara
Change-Id: I0da9140bf1f76a92c95c042c5039f7cfdbde6c34
2014-10-17coverity#1247638 Uncaught exceptionCaolán McNamara
Change-Id: Ibdda31c2a8d8c3314173f381b60800ccfbcc25f7
2014-10-17coverity#1247635 Uncaught exceptionCaolán McNamara
Change-Id: Ic346a5820102a922f54c971e01587601991bd484
2014-10-17coverity#1247632 Uncaught exceptionCaolán McNamara
Change-Id: I8d6df8c6853f0bd2f0b099d14bf0ac246170e7f1
2014-10-17coverity#1247629 Uncaught exceptionCaolán McNamara
Change-Id: Ib0f0555ba5630b225a4a5fbc64394becdeb9f7dd
2014-10-17Consistency around SdrAngleItem in svx/sxciaitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I8e76e4751e50f5952c6dfff9ee10362166bf0523
2014-10-17allow construction of BigInt from sal_Int64 on 32 bitDavid Tardon
Change-Id: Ib68920fc9bd693d2f2679b4fc27d9956dc42fc86
2014-10-17Remove some completely unused SID_sStephan Bergmann
Change-Id: I1a259f9af77bbbffc4f0bc85beb7945e3d74ff77
2014-10-17-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I8f312a511b383e1f0f7943a210935386869035b1
2014-10-17Increase assert coverage of OUStringBuffer argumentsMatthew J. Francis
Only covers arguments that can be validated with a simple comparison, and does not attempt validation of arguments which would require calculation of the length of a string inline Change-Id: I8a29c8743b47efe3dd45897a1f1371191a5ddb62 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16Strip svidl down to what is still usedStephan Bergmann
...the generated .ilb, .lst, and .sid outputs requested by SdiTarget were apparently unused. Change-Id: I1abb2abc7945070451fce4a98a11d955515e3f63
2014-10-15coverity#735333 flush out pointless calls to IsRemote and IsOpenCaolán McNamara
etc. Change-Id: I588d4486071b1e31897d4e6468a2c634d6856832
2014-10-15SfxMedium::IsRemote can be made constCaolán McNamara
Change-Id: Id6b14366d11c15ec1440482cfb725e497807fa2e
2014-10-15Blind Win fix attemptStephan Bergmann
Change-Id: I39df464321685ebef29f44221bab9005295d0c3f
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15loplugin: cstylecastNoel Grandin
Change-Id: I0ccdd2ce18336afea67a3f296b26b2de50f14808
2014-10-15fdo#84938: replace SYMBOL_TYPE constants with enumNoel Grandin
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51 Reviewed-on: https://gerrit.libreoffice.org/11983 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-15avoid double-deleteDavid Tardon
This is a regression from commit b1d48f0d9a3442c11adae6e36325a463d89ce44e. Change-Id: Iffd39782c1d1fd7be14f4d657919f704807a40f5
2014-10-15remove unused DECL_OBJHINT and IMPL_OBJHINT macrosNoel Grandin
these have been unused since we switch to using normal C++ RTTI with the SfxHint subclasses Change-Id: Ia271cfa01d2f49ed335e90f78309cd26d6ec9d8f
2014-10-15nDrehWink -> nRotationAngleMiklos Vajna
Change-Id: I33ca88f38210140931b12a05e426d1373243156e
2014-10-14Missing ModelessDialog -> ModalDialogStephan Bergmann
Change-Id: I83a3eb34138c75dbc5a0239a9d761d22c6cd98a0
2014-10-14fdo#75757: remove inheritance to std::mapTakeshi Abe
from UniqueIndexImpl. Change-Id: Iaa9040dff117ed5b05955c9f6eef31878dccf3b0 Reviewed-on: https://gerrit.libreoffice.org/11951 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-14Resolves: fdo#72587 make template dialog ModalCaolán McNamara
Change-Id: Iefb63bc7cdbff2217f16c1a72fc271361227588b
2014-10-14do not forward-declare templatesDavid Tardon
Change-Id: I3b0a145f70406f0c8a12b6c4b7876c4148f76e93
2014-10-14basebmp: accelerated method to create a clipping device.Michael Meeks
This was some staggering proportion of tiled rendering documents with complex clipping; it seems 'clear' is not what memset is for 1bit clip masks. Change-Id: I9142ffb7d7016603feb7782d6f03b9992b9494e3
2014-10-14Make -1 a valid value of enum MSO_SPTStephan Bergmann
...as e.g. CppunitTest_sw_filters_test under -fsanitize=undefined complains > svx/source/customshapes/EnhancedCustomShapeTypeNames.cxx:304:13: runtime error: load of value 4294967295, which is not a valid value for type 'const MSO_SPT' > EnhancedCustomShapeTypeNames::Get(MSO_SPT) svx/source/customshapes/EnhancedCustomShapeTypeNames.cxx:304:5 > SdrObjCustomShape::MergeDefaultAttributes(rtl::OUString const*) svx/source/svdraw/svdoashp.cxx:873:26 > SvxCustomShape::createCustomShapeDefaults(rtl::OUString const&) svx/source/unodraw/unoshap2.cxx:1933:26 > non-virtual thunk to SvxCustomShape::createCustomShapeDefaults(rtl::OUString const&) svx/source/unodraw/unoshap2.cxx:1934:1 > oox::vml::CustomShape::implConvertAndInsert(com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, com::sun::star::awt::Rectangle const&) const oox/source/vml/vmlshape.cxx:976:9 > oox::vml::ComplexShape::implConvertAndInsert(com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, com::sun::star::awt::Rectangle const&) const oox/source/vml/vmlshape.cxx:1073:12 > oox::vml::ShapeBase::convertAndInsert(com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, oox::vml::ShapeParentAnchor const*) const oox/source/vml/vmlshape.cxx:307:22 > oox::shape::ShapeContextHandler::getShape() oox/source/shape/ShapeContextHandler.cxx:432:27 > non-virtual thunk to oox::shape::ShapeContextHandler::getShape() oox/source/shape/ShapeContextHandler.cxx:545:1 > writerfilter::ooxml::OOXMLFastContextHandlerShape::sendShape(int) writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:1742:48 > writerfilter::ooxml::OOXMLFastContextHandlerShape::lcl_endFastElement(int) writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:1769:9 > writerfilter::ooxml::OOXMLFastContextHandler::endFastElement(int) writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:249:9 > non-virtual thunk to writerfilter::ooxml::OOXMLFastContextHandler::endFastElement(int) writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:250:1 > (anonymous namespace)::Entity::endElement() sax/source/fastparser/fastparser.cxx:484:13 > sax_fastparser::FastSaxParserImpl::callbackEndElement(char const*) sax/source/fastparser/fastparser.cxx:1216:9 > (anonymous namespace)::call_callbackEndElement(void*, char const*) sax/source/fastparser/fastparser.cxx:295:5 > doContent (instdir/program/libexpwraplo.so+0x369381) > contentProcessor (instdir/program/libexpwraplo.so+0x34d9ee) > doProlog (instdir/program/libexpwraplo.so+0x330991) > prologProcessor (instdir/program/libexpwraplo.so+0x32a1f6) > prologInitProcessor (instdir/program/libexpwraplo.so+0x38d185) > XML_ParseBuffer (instdir/program/libexpwraplo.so+0x31359b) > XML_Parse (instdir/program/libexpwraplo.so+0x30f34e) > sax_fastparser::FastSaxParserImpl::parse() sax/source/fastparser/fastparser.cxx:1058:52 > sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) sax/source/fastparser/fastparser.cxx:852:13 > sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource const&) sax/source/fastparser/fastparser.cxx:1339:5 > non-virtual thunk to sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource const&) sax/source/fastparser/fastparser.cxx:1340:1 > writerfilter::ooxml::OOXMLDocumentImpl::resolve(writerfilter::Stream&) writerfilter/source/ooxml/OOXMLDocumentImpl.cxx:500:13 > WriterFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) writerfilter/source/filter/ImportFilter.cxx:107:9 > non-virtual thunk to WriterFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) writerfilter/source/filter/ImportFilter.cxx:173:1 > SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) sfx2/source/doc/objstor.cxx:2271:21 > SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:767:23 > SwFiltersTest::filter(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, unsigned int, unsigned int, unsigned int, bool) sw/qa/core/filters-test.cxx:112:20 > SwFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, unsigned int, unsigned int, unsigned int) sw/qa/core/filters-test.cxx:71:12 > test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, unsigned int, unsigned int, unsigned int, bool) unotest/source/cpp/filters-test.cxx:111:24 > test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, unsigned int, unsigned int, unsigned int, bool) unotest/source/cpp/filters-test.cxx:137:5 > SwFiltersTest::testCVEs() sw/qa/core/filters-test.cxx:162:5 Change-Id: I8249f962585def8c98327cce9939e2b96b648612
2014-10-14Resolve some unnecessary typedefsStephan Bergmann
Change-Id: If57e32d41fe03db402aad74d2bd3e4d03c5e0643
2014-10-14Reintroduce SFINAE-based selective enablement of &=, |=Stephan Bergmann
...they had erroneously become unconditionally enabled. Also, rename Self to Wrap. Change-Id: I574662012bf74114b18f3bab0c1c5825a2bd61bb
2014-10-14fixes and tests for o3tl::typed_flagsNoel Grandin
create test suite for typed_flags template. fix the operator&= and operator|= definitions Signed-off-by: Stephan Bergmann <sbergman@redhat.com> Conflicts: include/o3tl/typed_flags_set.hxx Change-Id: I1df9ae197889af98a2fd76ff2bc07756c7b14ced
2014-10-14Remove commented out codeStephan Bergmann
Change-Id: I1ebcffc9f1b77b9491335c13ca99090385882ec3
2014-10-14No apparent reason to fix underlying type of PushFlagsStephan Bergmann
Change-Id: I7d578b135c7a1e681a70484bba30ff1e8b33e04d
2014-10-14Work around missing std::underlying_type in GCC 4.6Stephan Bergmann
Change-Id: Ic641fe2f1771fe979423c58d285a96399ea16fe2
2014-10-14fdo#84938 - replace LIST_ACTION constants with enumNoel Grandin
Change-Id: I21c05ada0a793b1e3ddf87481e66b60b83529767
2014-10-13fdo#84213 Add show/hide ruler to sd context menuSamuel Mehrbrodt
Change-Id: Iee42ab31a82ed4459f956706cef513afcf70ef94
2014-10-13oox: refactor embedded media importMichael Stahl
Currently the oox import creates a temp file and leaks it, and there is no way to clean it up afterwards. Unfortunately it turns out that SdrModel has no way to access the imported OOXML storage, so add a really ugly hack to get the embedded media into the SdrMediaObj by setting both MediaURL and PrivateStream properties (currently oox really wants to set the properties in alphabetical order too...) Change-Id: I5a235fbeb08e7bc17faf066de52b94867e9a79a2