Age | Commit message (Collapse) | Author |
|
Change-Id: Id08a999764bfeeff3bb3409b46f48b278009ccbe
Reviewed-on: https://gerrit.libreoffice.org/26238
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
from a range address
trying to make all SbxVariables reference count their parents
is ludiciously hard, so just reference count this one known
crashing case
Change-Id: Ie1fa6624e8184146dd00d766cdbacef674153ef6
Reviewed-on: https://gerrit.libreoffice.org/26272
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Callgrind tinderbox complains that "string" shadows some global, so
let's try "rString" instead.
Change-Id: I3973f23ef6e8ebf861d66012fede84cb8a685be8
|
|
... to prevent accidental surprises. Not interned shared strings
constructed from OUString have mpDataIgnoreCase=nullptr so can't be used
for case insensitive comparison.
Change-Id: I03323354298a73e93b18d2796ec447c072fdefa5
|
|
Change-Id: I90d3d008f68991613775234b29379c31b8f4ad39
Reviewed-on: https://gerrit.libreoffice.org/26237
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
... and remove some, at least from my point of view,
useless comments
Change-Id: Id97c90dd7764ae4569468abc73c79ae9b2a56e75
Reviewed-on: https://gerrit.libreoffice.org/26235
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
instead of unique_ptr as in commit
7bc1c79c26e52d5196fb36eee5c2f12f12d49ba6
Change-Id: I4e57378a333455b818162c6cc8484be9dcaddb03
Reviewed-on: https://gerrit.libreoffice.org/26236
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I8562a69bf624902a54da004b0786cae2a98102e5
Reviewed-on: https://gerrit.libreoffice.org/26168
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I646495e3538cb438a06765fe8cde252bad667bea
Reviewed-on: https://gerrit.libreoffice.org/25969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: If52f2bba475e7a8a5b7c63d5114f2725c9ce8617
|
|
Change-Id: Iaf93ff58229e9362b03b3e810611e969ef8baf38
Reviewed-on: https://gerrit.libreoffice.org/26206
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
We have two major groups of text fitting options in draw/impress
ones that apply only to custom shapes
* Word wrap text in shape
* Resize shape to fit text
those that apply to other elements, e.g. text boxes, legacy rectangles and lines
* Fit width to text
* Fit height to text
* Fit to frame
* Adjust to contour
Of the second group, only "fit to frame" is always available. Text boxes
have "Fit width to text" and "Fit height to text", while stuff like legacy
rectangles and lines etc have "Adjust to contour" instead.
A fun issue is that (currently anyway) the bit for "resize shape to
fit text" in custom shapes and the bit for "fit height to text" in text boxes
is the same bit, SDRATTR_TEXT_AUTOGROWHEIGHT.
So before this change in all circumstances the same collection of checkboxes
for all settings was visible. With context used to enable or disable which
ones could be set according to the type of shape it was. Simultaneously there
is logic to enable/disable checkboxes depending on if other checkboxes that
control contradictionary options were checked/unchecked. e.g. "Fit to frame"
disabled if "fit height to text" is enabled. So its not apparently why some
can be enabled and some disabled by clicking about the place in the shared
collection.
In this commit we split the sizing options into their two families, one frame and
column for each of "custom shapes" and "everything else". When adjusting
a single selected object we use context to determine which column to show
or hide. When editing multiple objects or the underlying graphic styles we show
both columns. When editing a presentation style we show just the text box
column. (The use of HasText in the original code is a concern, cause it doesn't
make sense to me, using it like that means that in the original dialog
format->text on an empty text box from F2 shows the contour option, but after
entering text and then format->text it shows a set of different text box sizing
options, so that's dropped here)
Because (currently) the same SDRATTR_TEXT_AUTOGROWHEIGHT bit it used for two
apparently different things then we visually toggle on all things that use that
bit in multi-column mode when its togged on, i.e. on editing a style visually
both "fit height to text" and "resize shape to fix text" are kept in sync when
you toggle one or the other. We don't disable the "resize shape to fit text"
checkbox (unlike the fit height to text checkbox which controls the same bit)
if "fit to frame" and "adjust to contour" are set, and give it additional
powers to unset those if clicked.
This hopefully makes the ui describe the way things actually are.
Because this SDRATTR_TEXT_AUTOGROWHEIGHT is currently sort of doing two purposes
selecting a freshly drawn custom rectangle and using format->default formatting
will cause it to change properties because the underlying
SDRATTR_TEXT_AUTOGROWHEIGHT bit is cleared.
The way things should probably be I guess is that there should be a
SDRATTR_TEXT_AUTOGROWSIZE property (which used to exist but wasn't hooked up to
anything) just for custom shapes which overrides the old family of options if
set.
Change-Id: I49241c90d919eeb5caa8775beab57746d5c6df04
|
|
Change-Id: I6ce045db236b81aa8bc7bce2a0e20c4132c5931f
|
|
Change-Id: I95e42012d8503493a89aee94fd05b2a878535f06
Reviewed-on: https://gerrit.libreoffice.org/26198
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Converted libmar into static library and removed duplicate code.
Change-Id: I51c58ae9a6a1f1128422b4a79491d0cd62e6ced6
Reviewed-on: https://gerrit.libreoffice.org/23312
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
|
|
Change-Id: I3567c3f9c5fe8374abd81d3f6e9a4a41e6a4c23d
|
|
Change-Id: Ib28e76ed6947431c6466d11aaadca8d95abfc275
|
|
Change-Id: I61f811ddfff624f76eb75695cb12576b8aeca47a
|
|
Change-Id: Ic3efae53430fbb2c1eb7962c3cf69bf99315e55b
Reviewed-on: https://gerrit.libreoffice.org/26202
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
|
|
Change-Id: Icf24af615e6020b40f92f565194b2328e99f47ad
Reviewed-on: https://gerrit.libreoffice.org/26199
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
since
commit 51fe4d63dfdf0ea24d2fecf75d25cbe607ed1c09
Author: melikeyurtoglu <aysemelikeyurtoglu@gmail.com>
Date: Tue May 3 00:34:05 2016 +0300
tdf#97527 vcl: reference-count Menu
Change-Id: Ia12434fede69ad247ed67691517437a9ada31acd
Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/24596
which created a base-class VclReferenceBase for OutputDevice and
Menu and so moved isDisposed from OutputDevice to VclReferenceBase,
but *duplicated* the mbDisposed in VclReferenceBase so the
bit set by disposeOnce in OutputDevice was a different bit to the
bit returned by isDisposed from VclReferenceBase.
Which meant that the fix of...
commit 26c32cfee9fc9a769adba19f455e4d6c13b6d89d
Author: Caolán McNamara <caolanm@redhat.com>
Date: Fri Nov 27 16:10:10 2015 +0000
Resolves: rhbz#1283426 using vdevs based on now dead physical devs is unsafe
no longer worked.
Finish moving the mbDisposed to VclReferenceBase to fix this
Change-Id: I9bc1ba3d03f3aae7c3f58eb277176d9521bdb05d
|
|
Change-Id: I3418c4a3d24b3b6630d6c80a6c8aa9d4ffb7e73a
Reviewed-on: https://gerrit.libreoffice.org/24346
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I196f2bbff0e7796804c2d74eb68ebf914796993d
Reviewed-on: https://gerrit.libreoffice.org/26138
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Given that the per-view callback is in SfxViewShell, and editeng doesn't
depend on sfx2, add an interface class in editeng to invert the
dependency.
With this, gtktiledviewer no longer crashes when starting editeng text
edit with per-view callbacks.
Change-Id: I783cdc646b890a6b597000f1d88428c8042417cf
Reviewed-on: https://gerrit.libreoffice.org/26169
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: Ief76037f087a2225442294b972d331fc4476bbec
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/25486
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
|
|
By removing unnecessary variables/strings/function calls,
and making proper changes in the related .ui files.
Change-Id: I04244b360b4bb32ccbbe5bde4756a9166ae1fcaf
Reviewed-on: https://gerrit.libreoffice.org/26018
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
...so rename to o3tl::tryAccess to make it more obvious that the returned
proxy points into the internals of the given Any, and forbid calling
o3tl::tryAccess on a temporary
Change-Id: Ia412c6b2b06693811b9b7f0076a08bbf97142df9
|
|
Isolated to a single Primitive2D class based on the AnimatedSwitch-
Primitive2D which does the specializing in one place. Buffers small
GIFs completely, handles 1st frame always buffered, huge GIFs get
animated by just playing he next frame.
To reach more with the current approach we would have to re-implement
AnimatedGIF import, replay it internally on a sys-specific Surface
and blit the current content (with alpha) to our display
Change-Id: I46c3325fa7936df73bea9a9284a0421f1475a34b
Reviewed-on: https://gerrit.libreoffice.org/26103
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ife6ce05430c99cd5452166c942320a3a301578ff
|
|
Change-Id: I2f73a200b04322dd65e0758f4238347bfea832fb
|
|
Change-Id: I753880ce146fef6523561290b8e13310d9f7219c
Reviewed-on: https://gerrit.libreoffice.org/26142
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
...although the includes were mostly correct.
Change-Id: I82d62f9e239d9e2523c8561e54bf7af1183b8828
Reviewed-on: https://gerrit.libreoffice.org/26141
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
With this, bindings updates ("cursor moved into a bold area", etc) are
correctly sent to (and only to) the matching view.
Change-Id: If10ff46dd0243cfc2f1c5566c53a7e81efa635b4
Reviewed-on: https://gerrit.libreoffice.org/26145
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
and do one trivial merge
Change-Id: Iff30553f73de946c74fa6b082928e7d47adadd04
|
|
Change-Id: I0ad43869d24e210b3591af25f108c68ed8f6160b
Reviewed-on: https://gerrit.libreoffice.org/25634
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
delete key: delete operation
shift-f10 and contextmenu: create context-menu
ctrl + A: select all
Conflicts:
sfx2/source/control/templateabstractview.cxx
Change-Id: I97486c050c5dbb88b8551aa8a9bb9ba4285ad003
Reviewed-on: https://gerrit.libreoffice.org/26044
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Tooltip text:
1. Template Manager:
All Categories: Title + Category
Category: Title
2. Start center: Title
Conflicts:
sfx2/source/doc/doc.hrc
Conflicts:
sfx2/source/doc/templatedlg.cxx
Change-Id: I0bfd5e78120f13338f88c1b0617df3a057cce02f
Reviewed-on: https://gerrit.libreoffice.org/26040
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
|
|
Change-Id: I8e199535803faf364469f9b9df46f339febe25c6
|
|
Change-Id: I746e47b118a8b8c687c435371e2bdf2dc22cbf88
|
|
Change-Id: Ied6ec5f7830c53a339de985d173c1dec711ac8f7
Reviewed-on: https://gerrit.libreoffice.org/26092
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I7b43e417607b20c300e3c18e7da76a6173a18b7d
Reviewed-on: https://gerrit.libreoffice.org/26098
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: I900cc79e2834c1942840ee9fb1a8ab680b646c92
Reviewed-on: https://gerrit.libreoffice.org/26082
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
put SIP_SA_CHAINNEXTNAME into that position to keep this
list in the same order as the SDRATTR_TEXT_ list
Change-Id: I6be4b373d188a2a6e4cd52cc1c8a18f3f9514503
|
|
as far as I can see there is no use of SDRATTR_TEXT_AUTOGROWSIZE anywhere,
just a reuse of SDRATTR_TEXT_AUTOGROWHEIGHT for a different mechanism to resize
the surrounding shape to fit text in custom shapes.
Note there is another different feature to resize text to fit into its frame
of SDRATTR_TEXT_FITTOSIZE.
Change-Id: Icf08966c70ef79271f462da7d4b2c6e8e855d5df
|
|
Change-Id: I0d04c23b8760ce2e7df9523d99a1fd862e501038
Reviewed-on: https://gerrit.libreoffice.org/25938
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
removed <cppuhelper/implbase1.hxx>
Change-Id: If54eb2fb64be1884ba058858da0d220bbce673f1
Reviewed-on: https://gerrit.libreoffice.org/26074
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I68c67e77a2759c8542dd4a44a78a9fcf8aa7dcc0
Reviewed-on: https://gerrit.libreoffice.org/26056
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ic40d0852c8e0a8f0957fc782c85c1084c7fe265f
|
|
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
|
|
Added possibility to select single item in ThumbnailView.
Then, used it in Template Selection dialog.
Change-Id: I39b2ea83479ae1536285d4037fb1d24455a52ddc
Reviewed-on: https://gerrit.libreoffice.org/25998
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|