summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2014-01-21bool improvementsStephan Bergmann
Change-Id: I85faf4e3fcab6763af11eb6a4082820e88bea1ca
2014-01-21bool improvementsStephan Bergmann
Change-Id: I714caa8dc3d34fd56e6a11f57db6723dcb7e6705
2014-01-21EDITENG : Remove usage of DBG_CTOR and DBG_DTOR.Arnaud Versini
Valgrind is capable of detecting such bugs. No need for extra macros. Change-Id: Ifc04e2ec9d27c706868569a3bcb8fbfae0e84c69 Reviewed-on: https://gerrit.libreoffice.org/7524 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-21Change EnableNoYieldMode(bool) to better namesChris Sherlock
It makes no sense to disable something via an Enable function. I have split the function into Enable and Disable functions, and update the code accordingly. Conflicts: include/vcl/svapp.hxx Change-Id: Ic05d69796f43e802a4a2a16aaca44433b6eaa018 Reviewed-on: https://gerrit.libreoffice.org/7525 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-21drop unused STRING_LENCaolán McNamara
Change-Id: I95446e7bcdfb19cea9eb8055ac880f7c8a04eb37
2014-01-21warning C4805: '!=' : unsafe mix of type 'sal_Bool' and type 'bool'Stephan Bergmann
Change-Id: I3d4f1ac0debf506e3c4f1ce9143cb8c1cf66925d
2014-01-21Consistently let SetDesingMode functions take bool argumentStephan Bergmann
...to avoid "warning C4805: '!=' : unsafe mix of type 'bool' and type 'sal_Bool' in opertaion" style errors. Additionally, mark those functions that are virtual overrides as such. Change-Id: I64f919f7e2d8f6224303f9bac67f6270d58de014
2014-01-21warning C4805: != unsafe mix of type 'bool' and type 'sal_Bool' in operationStephan Bergmann
Change-Id: I212ea47cabb5c556b7d822e4f45aacb6c96cb6e8
2014-01-20Removed unused solar.h reference in filterAlexandre Vicenzi
Change-Id: Ieffee3f06a12836b8a01dcebe2a6dc097b35dde9 Reviewed-on: https://gerrit.libreoffice.org/7520 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-20Removed unused solar.h reference in sotAlexandre Vicenzi
Change-Id: If49a8b583c8805e31abe158c31b3d2c9c79e6e27 Reviewed-on: https://gerrit.libreoffice.org/7518 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-20Removed unused solar.h reference in svtoolsAlexandre Vicenzi
Change-Id: Ic1dc7c32bb749888bc8751d4d488ba76e46b155f Reviewed-on: https://gerrit.libreoffice.org/7517 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-20Removed unused solar.h reference in linguisticAlexandre Vicenzi
Change-Id: I43a78b0a24d92362100cf9fab956120f01843222 Reviewed-on: https://gerrit.libreoffice.org/7516 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-20Removed unused solar.h referenceAlexandre Vicenzi
Change-Id: I1ff7d4bad068a8bc8cdc7f27dbfaee199d0f2e5f Reviewed-on: https://gerrit.libreoffice.org/7513 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-20Better pixelization of dashed lines for screen rendering.Kohei Yoshida
Now the dashed lines are evenly placed on screen. For now, horizontal lines only. I'll work on vertical lines later. Change-Id: I474e9c8214e5f079ea2cfca12b35381d8fcf2ae1
2014-01-20component-defines.h should be generated.Jan Holesovsky
Change-Id: I759d119e0ad6c5ae2881284c82292d4d9cb7ae87
2014-01-20Minimize the constructor functions to a bare minimum.Jan Holesovsky
Most of the constructors are supposed to be only a call of new TheInstance(arguments) or an equivalent; so let's just change the constructor caller accordingly, to accept unacquired new instance. If there are exceptions that need to do more heavy lifting, they do not have to use the constructor feature, or there can be a wrapper for the real implementation, doing the additional work in their (C++) constructor. Change-Id: I035c378778aeda60d15af4e56ca3761c586d5ded
2014-01-20Remove unused Window parameter from SystemSettingsChangingChris Sherlock
This took a bit of code archaelogy for me to track down. It turns out that as part of an effort to optimize startup, the line of code in this function was commented out, presumably to be rewritten later. This happened in commit ee3351d78c in July 2001 (!). About three years later, in February 2004, the function was rewritten in commit 189c2388d80. As it turns out, the only two functions that used the Window parameter were vcl/source/window/window.cxx (which passed itself in, but of course this did nothing) and vcl/source/window/winproc.cxx. Furthermore, winproc only ever passed in the first frame, so it didn't really do anything either. Consequently, the function as it stands *now* only notifies the application that system settings have been changed. It doesn't care which window it tells. Therefore, I have excised this parameter from the function. I don't think it made sense when it was implemented anyway, so there is no net loss. After removing the unneeded parameter, I was also able to remove the Window parameter from winproc.cxx's ImplHandleSalSettings function as it was only ever used to set the top level window, which is now irrelevant. Change-Id: I84f2c5c5ff8969387da3af81e4a9c7f9ac6237e1 Reviewed-on: https://gerrit.libreoffice.org/7541 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-20Document VCL Application classChris Sherlock
Documented the VCL Application class in Doxygen format. Also reindented some of the code, and moved ValidateSystemFont down the list of class functions (better code organization). Change-Id: Id421647a9a25e11be87b0f6c46d1ac0f4846f6a4 Reviewed-on: https://gerrit.libreoffice.org/7515 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-20misuse of OUString::boolean on sal_uInt8 valuesCaolán McNamara
regression since 64b993e046f23baaacaff1572b7d2a816588b5ef Change-Id: Ifc907a34430c36a64318fc42342e630e2b84ad13
2014-01-20Related: #i56998# provide a way to format % per-locale rulesCaolán McNamara
Change-Id: Ic27b230cc9dce366f281ff720ded5873e94f6191
2014-01-18ooxml: Preserve shape theme attribute for solid fillJacobo Aragunde Pérez
Users can select the fill color for a shape among the theme-defined colors. This results in the following XML: <wps:spPr> ... <a:solidFill> <a:schemeClr val="accent2"/> </a:solidFill> ... </wps:spPr> Now we store both the original fill color and the name of the theme-defined color, if it exists, on the import phase. They are put into the InteropGrabBag of the shape with the names OriginalSolidFillClr and SpPrSolidFillSchemeClr. Additionally, we needed to to store the decoded theme color inside StyleFillRef. On the export phase we have to take into account several combinations of factors: * If the final color for the shape fill is different from the original color, we must ignore any theme attributes and write the new color. * If the fill color is unchanged and some theme color exists, we must write the theme color. * If the fill color is unchanged and no theme color exists, we must check if the original color matches the style-defined color. If it does, we must not write any <a:solidFill> tag. * Otherwise we must write the <a:solidFill> tag with the RGB color. The method putPropertiesToGrabBag was added to the Shape object for convenience. The data files for some /sd/qa/ unit tests were updated to reflect the new properties inside the Shape InteropGrabBag. Change-Id: If0915c5442872a8acab0a8a081f60c89c97277bd
2014-01-18ooxml: Preserve shape style attribute fillRefJacobo Aragunde Pérez
Shape style attributes contain the default format for the shape in case that no direct format is specified for it. This is an example of the attribute we want to preserve with this patch: <wps:style> ... <a:fillRef idx="1"> <a:schemeClr val="accent1"/> </a:fillRef> ... </wps:style> The relevant values in these tags are stored at the maShapeStyleRefs member in the Shape object. The storage happens at ShapeStyleContext::onCreateContext which is run when the <a:fillRef> tag is opened. The ShapeStyleRef object contains the idx value and a Color object which will contain the inner tag <a:schemeClr>. The Color object has been modified to store the string value of schemeClr. The storage happens at ColorValueContext::onStartElement which is run when the tag <a:schemeClr> is opened. Later, Shape::createAndInsert is called by the ShapeContextHandler to create the actual XShape, this happens when the tag <wps:wsp> is closed. createAndInsert puts idx and schemeClr values into the InteropGrabBag property of the XShape with the name StyleFillRef. On export time, when the shape data is written at ShapeExport::WriteCustomShape, we added a call to DrawingML::WriteShapeStyle. This method will check the existence of the InteropGrabBag property in the shape, read the StyleFillRef prop inside it and output the proper XML to the style definition. DrawingML::WriteShapeStyle also writes some mock tags into the <wps:style> because we found that they are compulsory. We will replace them with the proper data in further patches. The method putPropertyToGrabBag was added to the Shape object for convenience. The data files for some /sd/qa/ unit tests were updated to reflect the new property StyleFillRef inside the InteropGrabBag. Change-Id: I5ffa5242852461a1a709a8f169d40f0d7a2c9aa3
2014-01-18Window::PreNotify should return boolStephan Bergmann
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-17bool improvementsStephan Bergmann
Change-Id: Ic46fa46c200b94e2e6c5a073ba89b9aae5c14542
2014-01-17bool improvementsStephan Bergmann
Change-Id: I9f5564100aa64ff4940dd93a81ff5a8d8edc7a07
2014-01-17Remove warning and build error with MSVC.Kohei Yoshida
Change-Id: I8eac2f5ff08968a885a8e413bf4db38092036957
2014-01-17This is a struct.Kohei Yoshida
Change-Id: Ieee10f9acb67453ac6c3d893d29330e19d96bdef
2014-01-17Apply dashing without consulting current map unit.Kohei Yoshida
Using scaling is sufficient. Change-Id: If976bec3940772432d814a77681170d7c99306d2
2014-01-17Pass scaling to borderline primitive objects.Kohei Yoshida
This will be used when generating line patterns. Change-Id: I2fa0298bd3e34df1cb304d9be41e471835484d83
2014-01-17Make thse constructors non-inline.Kohei Yoshida
Change-Id: Iaf23a9962c9dd748247cb986ffabb1a5ba173c09
2014-01-17Remove STYLE_* and use css::table::BorderLineStyle instead.Kohei Yoshida
Change-Id: I187511dbf85ecdfe0c5d05c6f77cf4ac93363051
2014-01-17Typos etc.Kohei Yoshida
Change-Id: I4838514bc85636df1b3f0558ce1796431bfe19f3
2014-01-17Hide the implementation of svx::frame::Array.Kohei Yoshida
Change-Id: Iad2d494bf7dd9f1f69e4e863aeaa514bf76c7c76
2014-01-17Window::Notify should return boolStephan Bergmann
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-17test::BootstrapFixtureBase::getPathFromWorkdir not unusedMichael Stahl
Change-Id: I4ddad27d1e5a4de9885956b80db37f1e2f80a96e
2014-01-17removed some unused code (svx, svtools, unotest)Petr Vorel
Change-Id: I1250581d69423030bd0a93a1529458b8d424ce3e Reviewed-on: https://gerrit.libreoffice.org/7329 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-16fdo#71511: reload ColorConfig after tweaking relevant a11y settingsBjoern Michaelsen
note that the autodetect HC option is somewhat broken anyway: it resets the icon theme hard, so there are not simple roundtrips enableing/disabling it for that, but those havent been there before either. Change-Id: Ia35a41717224dfb7437054bb885c61d7e0b189d7
2014-01-16make use that these VclBuilders have an XFrame to expose its dispatchCaolán McNamara
the sidebar widget-layout enabled panels could use frame::XDispatch::dispatch to send their commands directly rather than mapping back to SIDS and Executing those, which would allow removing piles of weird-ass stuff Change-Id: Ibbff56d4fb96820d3bdbf4b1cb582d25337fe48b
2014-01-16fdo#39468 translate more German comments, etc.Chris Sherlock
* Translated some more German comments * Some typos corrected * Removed useless comment decoration Change-Id: I40176e23983193e5087f48cf7d7b8e5eb339d6c6 Reviewed-on: https://gerrit.libreoffice.org/7463 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-16convert SvStream::operator<< overloads to more explicit methodsNoel Grandin
This is in preparation for more conversion of SvStream::operator<< calls to use more explicit method names. This converts the subclasses that have their own convenience overloads of operator<< to use normal methods. Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
2014-01-16fdo#72520 : Exporting sheet external data for chart for docx files.sushil_shinde
- Adding external data path relationship for chart[n].xml for docx files. - Added Unit Test. Change-Id: If48ed21237433ddf6659454dda95d720aabdb300
2014-01-16Resolves: #i123457# suppress import and export of hyperlinks without an URLOliver-Rainer Wittmann
(cherry picked from commit 71d322a8ce0f5f5cbfd66fd689ff10b3490c1ee4) Conflicts: include/xmloff/xmlexp.hxx xmloff/source/core/xmlexp.cxx xmloff/source/text/txtparae.cxx xmloff/source/text/txtparai.cxx Change-Id: Ie8291c93c86815cab68482b35a5e88a3bd9b731e
2014-01-16Remove broken and unnecessary friend declaration.Matúš Kukan
Change-Id: I5ec11ce8a64bc50faf7305ae74f058a0114d095a
2014-01-16fdo#72520 : Added property to store external data path in chart.sushil_shinde
- added new property entry to store xlsx external data for chart. Change-Id: I3695865ad7e888359d1048e9bc380cba26108636 Reviewed-on: https://gerrit.libreoffice.org/7212 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-01-15Fix fallout after a700ce8e2b2f2dad50bf36dfd69de577211f1dc3Tor Lillqvist
Change-Id: I489126d291f9420aa1692d4b1f187f72dfd92a62
2014-01-15DdeSetData should apparently return boolStephan Bergmann
Change-Id: Ie0e66ac6c76eabb80340d4c11b60dd7890c6a378
2014-01-15Reduce the number of experimental direct constructor calls.Matúš Kukan
It puts the function into binary in cases we don't want it for mobile platforms. We want to generate this list later anyway. Change-Id: I59be18b7b394254d845f5b2de02684c774510174
2014-01-15remove sfx2/appuno.hxxMatúš Kukan
Change-Id: Ibfcd2954b20def05d2a7db36f5ccc0b570305441
2014-01-15Related: #i17171# big xub_Strlen -> sal_Int32 changesCaolán McNamara
Change-Id: I31bce794c95062abfa1171c13cf565498688b5f3
2014-01-15DdeGetData should apparently return boolStephan Bergmann
Change-Id: I603198b9fd2c6fea1c9ec7de09b23c61fe9d603c
generated by cgit (git 2.34.1) at 2024-07-23 07:36:46 +0000