summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2019-10-04loplugin:unusedmethodsNoel Grandin
Change-Id: Idd98dc9e1090a6b09124c80eed5a878e5e966cfc Reviewed-on: https://gerrit.libreoffice.org/80182 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-04Deduplicate some serializer writing code, and simplify writing OStringMike Kaganski
Change-Id: I391f8cb499a83f1f774fdcaa794169a218bdc7e5 Reviewed-on: https://gerrit.libreoffice.org/80189 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-04use SfxUInt16Item for SID_METRIC_ITEMNoel Grandin
because we aren't using the array of values in SfxAllEnumItem Change-Id: I67ccb7737c52f9949495c53881e052d5005882aa Reviewed-on: https://gerrit.libreoffice.org/80165 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-04Resolves: tdf#127953 destroy shape before modelCaolán McNamara
Change-Id: I27bf76d8f7e196db57fa56181e06e578915b980d Reviewed-on: https://gerrit.libreoffice.org/80148 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04Convert FSNS macro to constexpr functionMike Kaganski
Change-Id: I823305cdf746098762b77a53c5b93035cda7ec6f Reviewed-on: https://gerrit.libreoffice.org/80176 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-04loplugin:methodcyclesNoel Grandin
Change-Id: Ie2eeba83bf176d5c2beadc4dc5286e827ddbadfc Reviewed-on: https://gerrit.libreoffice.org/80155 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-04loplugin:singlevalfieldsNoel Grandin
Change-Id: Ic74b400f0b929b4c57ad70d0b0936983a3d46360 Reviewed-on: https://gerrit.libreoffice.org/80154 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-03Make sure TerminateListener doesn't outlive TransferableHelperStephan Bergmann
With <https://gerrit.libreoffice.org/#/c/80147/> "Propagate soffice process failure from OfficeConnection's tearDown" included, UITest_calc_tests2 would start to fail with > ==1492559==ERROR: AddressSanitizer: heap-use-after-free on address 0x6110009d26a8 at pc 0x7f38d09d1eda bp 0x7f3814e617f0 sp 0x7f3814e617e8 > READ of size 8 at 0x6110009d26a8 thread T44 (cppu_threadpool) > #0 in com::sun::star::uno::BaseReference::is() const at include/com/sun/star/uno/Reference.h:94:27 > #1 in TransferableHelper::ImplFlush() at vcl/source/treelist/transfer.cxx:518:22 > #2 in TransferableHelper::TerminateListener::notifyTermination(com::sun::star::lang::EventObject const&) at vcl/source/treelist/transfer.cxx:254:14 > #3 in framework::Desktop::impl_sendTerminateToClipboard() at framework/source/services/desktop.cxx:1655:24 > #4 in framework::Desktop::terminate() at framework/source/services/desktop.cxx:332:13 > #5 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) at bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77:5 > #6 in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233:13 > #7 in unoInterfaceProxyDispatch at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:413:13 > #8 in binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const at binaryurp/source/incomingrequest.cxx:236:13 > #9 in binaryurp::IncomingRequest::execute() const at binaryurp/source/incomingrequest.cxx:79:26 > #10 in request at binaryurp/source/reader.cxx:85:9 > #11 in cppu_threadpool::JobQueue::enter(long, bool) at cppu/source/threadpool/jobqueue.cxx:107:17 > #12 in cppu_threadpool::ORequestThread::run() at cppu/source/threadpool/thread.cxx:165:31 > 0x6110009d26a8 is located 104 bytes inside of 216-byte region [0x6110009d2640,0x6110009d2718) > freed by thread T0 here: > #0 in free at /home/sbergman/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:123:3 > #1 in rtl_freeMemory at sal/rtl/alloc_global.cxx:51:5 > #2 in cppu::OWeakObject::operator delete(void*) at include/cppuhelper/weak.hxx:87:11 > #3 in ScSelectionTransferObj::~ScSelectionTransferObj() at sc/source/ui/app/seltrans.cxx:149:1 > #4 in cppu::OWeakObject::release() at cppuhelper/source/weak.cxx:233:9 > #5 in cppu::WeakImplHelper<com::sun::star::datatransfer::XTransferable2, com::sun::star::datatransfer::clipboard::XClipboardOwner, com::sun::star::datatransfer::dnd::XDragSourceListener, com::sun::star::lang::XUnoTunnel>::release() at include/cppuhelper/implbase.hxx:115:62 > #6 in com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable>::~Reference() at include/com/sun/star/uno/Reference.hxx:110:22 > #7 in vcl::GenericClipboard::~GenericClipboard() at vcl/source/components/dtranscomp.cxx:49:7 > #8 in cppu::OWeakObject::release() at cppuhelper/source/weak.cxx:233:9 > #9 in cppu::WeakComponentImplHelperBase::release() at cppuhelper/source/implbase.cxx:84:22 > #10 in cppu::PartialWeakComponentImplHelper<com::sun::star::datatransfer::clipboard::XSystemClipboard, com::sun::star::lang::XServiceInfo>::release() at include/cppuhelper/compbase.hxx:86:36 > #11 in com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboard>::~Reference() at include/com/sun/star/uno/Reference.hxx:110:22 > #12 in ImplFrameData::~ImplFrameData() at vcl/inc/window.h:126:8 > #13 in vcl::Window::dispose() at vcl/source/window/window.cxx:550:9 > #14 in ImplBorderWindow::dispose() at vcl/source/window/brdwin.cxx:1664:18 > #15 in VclReferenceBase::disposeOnce() at vcl/source/outdev/vclreferencebase.cxx:38:5 > #16 in VclPtr<vcl::Window>::disposeAndClear() at include/vcl/vclptr.hxx:206:19 > #17 in vcl::Window::dispose() at vcl/source/window/window.cxx:517:34 > #18 in SystemWindow::dispose() at vcl/source/window/syswin.cxx:108:13 > #19 in WorkWindow::dispose() at vcl/source/window/wrkwin.cxx:128:19 > #20 in VclReferenceBase::disposeOnce() at vcl/source/outdev/vclreferencebase.cxx:38:5 > #21 in VclPtr<OutputDevice>::disposeAndClear() at include/vcl/vclptr.hxx:206:19 > #22 in VCLXWindow::dispose() at toolkit/source/awt/vclxwindow.cxx:939:21 > #23 in (anonymous namespace)::XFrameImpl::disposing() at framework/source/services/frame.cxx:2183:18 > #24 in cppu::WeakComponentImplHelperBase::dispose() at cppuhelper/source/implbase.cxx:102:17 > #25 in cppu::PartialWeakComponentImplHelper<com::sun::star::lang::XServiceInfo, com::sun::star::frame::XFrame2, com::sun::star::awt::XWindowListener, com::sun::star::awt::XTopWindowListener, com::sun::star::awt::XFocusListener, com::sun::star::document::XActionLockable, com::sun::star::util::XCloseable, com::sun::star::frame::XComponentLoader, com::sun::star::frame::XTitle, com::sun::star::frame::XTitleChangeBroadcaster, com::sun::star::beans::XPropertySet, com::sun::star::beans::XPropertySetInfo>::dispose() at include/cppuhelper/compbase.hxx:90:36 > #26 in (anonymous namespace)::XFrameImpl::close(unsigned char) at framework/source/services/frame.cxx:1728:5 > #27 in framework::pattern::frame::closeIt(com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&) at framework/source/inc/pattern/frame.hxx:62:21 > #28 in framework::CloseDispatcher::implts_closeFrame() at framework/source/dispatch/closedispatcher.cxx:492:10 > #29 in framework::CloseDispatcher::impl_asyncCallback(LinkParamNone*) at framework/source/dispatch/closedispatcher.cxx:371:20 > #30 in framework::CloseDispatcher::LinkStubimpl_asyncCallback(void*, LinkParamNone*) at framework/source/dispatch/closedispatcher.cxx:246:1 > #31 in Link<LinkParamNone*, void>::Call(LinkParamNone*) const at include/tools/link.hxx:112:45 > #32 in vcl::EventPoster::DoEvent_Impl(void*) at vcl/source/helper/evntpost.cxx:52:13 > #33 in vcl::EventPoster::LinkStubDoEvent_Impl(void*, void*) at vcl/source/helper/evntpost.cxx:48:1 > #34 in Link<void*, void>::Call(void*) const at include/tools/link.hxx:112:45 > #35 in ImplHandleUserEvent(ImplSVEvent*) at vcl/source/window/winproc.cxx:1960:30 > #36 in ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) at vcl/source/window/winproc.cxx:2513:13 > #37 in SalFrame::CallCallback(SalEvent, void const*) const at vcl/inc/salframe.hxx:299:29 > #38 in SvpSalInstance::ProcessEvent(SalUserEventList::SalUserEvent) at vcl/headless/svpinst.cxx:283:22 > #39 in non-virtual thunk to SvpSalInstance::ProcessEvent(SalUserEventList::SalUserEvent) at vcl/headless/svpinst.cxx > #40 in SalUserEventList::DispatchUserEvents(bool) at vcl/source/app/salusereventlist.cxx:108:17 > #41 in SvpSalInstance::DoYield(bool, bool) at vcl/headless/svpinst.cxx:428:19 > #42 in ImplYield(bool, bool) at vcl/source/app/svapp.cxx:446:48 > #43 in Application::Yield() at vcl/source/app/svapp.cxx:510:5 > #44 in Application::Execute() at vcl/source/app/svapp.cxx:427:9 > #45 in desktop::Desktop::Main() at desktop/source/app/app.cxx:1620:17 > #46 in ImplSVMain() at vcl/source/app/svmain.cxx:190:35 Not sure if there is a better fix that would guarantee that mxTerminateListener can never be non-null in ~TransferableHelper. (It is cleared in TransferableHelper::lostOwnership, so maybe a call to that is missing somewhere, or there is a race here?) Change-Id: I6d190b9565a352c1d454fd66ba598bf1b9e8d875 Reviewed-on: https://gerrit.libreoffice.org/80149 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-03loplugin:unnecessaryvirtualNoel Grandin
Change-Id: Ib329e251ee405f60568a2fea6cb93f54a84063cd Reviewed-on: https://gerrit.libreoffice.org/80144 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-03loplugin:virtualdeadNoel Grandin
Change-Id: I86bae18ed2682871032aeb2a178f49f3e4601129 Reviewed-on: https://gerrit.libreoffice.org/80129 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-03loplugin:unusedmethodsNoel Grandin
Change-Id: I9790d053248ae6bd58ecc026c774014c4e5e04aa Reviewed-on: https://gerrit.libreoffice.org/80115 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-03Resolves: tdf#127882 gtk 3.18 crash in property dialog teardownCaolán McNamara
due to the menubutton popovers in the custom property page workaround by reordering so scrolling window is torn down after the menubutton is destroyed and clear the popover in the menubutton dtor Change-Id: Icf06d912524af13a5590f160150f1a4e15f3e9f7 Reviewed-on: https://gerrit.libreoffice.org/80117 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-03loplugin:unusedfieldsNoel Grandin
and filter out the weld fields, since we're not touching them yet Change-Id: I3cc23c46d2650f13cb29c7d381687939d23e2882 Reviewed-on: https://gerrit.libreoffice.org/80104 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-03merge msgbox and stdtextCaolán McNamara
Change-Id: If95d78746eff3ae5343e7d4c6bb2433537ccb84d Reviewed-on: https://gerrit.libreoffice.org/80099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-03Simplify a bit SfxAllEnumItem (svl)Julien Nabet
Make private GetValueByPos which is only used in svl/source/items/aeitem.cxx Remove "RemoveValue" method which is only used in InsertValue( sal_uInt16 nValue, const OUString &rValue ) It allows to call once "GetPosByValue" and the assert is useless since we're in the case: "else if ( nPos != USHRT_MAX )" I think we can more optimize by replacing vector by another container for pValues (type "SfxAllEnumValueArr"). Indeed, we insert and remove a lot in pValues in a specific position. Vector is not the best container for this There's also still the part "//FIXME: Optimisation: use binary search or SortArray" in GetPosByValue_ method Change-Id: I0cafea70e9d0361ef9a7b345ff770a9b888ef85b Reviewed-on: https://gerrit.libreoffice.org/80089 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-02drop some unnecessary includesCaolán McNamara
Change-Id: Ibbf459284a1555ad8ff836a610901844c82a6871 Reviewed-on: https://gerrit.libreoffice.org/80062 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-02move Breadcrumb to sole user in fpickerCaolán McNamara
Change-Id: I2028f921e78611698e82e50a652b67dba1ece909 Reviewed-on: https://gerrit.libreoffice.org/80054 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-02weld PrintDialogCaolán McNamara
Change-Id: Id4adbe484f88be74f45dab8e7ef426c66e5cbc8b Reviewed-on: https://gerrit.libreoffice.org/80002 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-02Ensure that 'input' events are processed asynchronously too.Michael Meeks
Change-Id: I715eadd444e428148cfff8a61436987517004fae Reviewed-on: https://gerrit.libreoffice.org/79882 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-02extend popup handler to cover all CommandEventsCaolán McNamara
Change-Id: I26360ce5c696d0e571385d83a15876eb2286e12f Reviewed-on: https://gerrit.libreoffice.org/80021 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-02Avoid std::vector inheritance for SfxAllEnumValueArrJulien Nabet
No need to inherit, just create a typedef Change-Id: Ifeabb90e640e10e590f793716c022f91850ae8b9 Reviewed-on: https://gerrit.libreoffice.org/79991 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-02tdf#42949 Fix IWYU warnings in xmloff/source/[s-x]*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I986ba9f661854d1b5fafc337ec109b0ee558a86a Reviewed-on: https://gerrit.libreoffice.org/79904 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-02tdf#127711 - A runtime-switch for the MiniCrashDumpJuergen Funk
- in soffice.ini (sofficerc) the entry "CrashDumpEnable" default is "true" - when false then the Dump.ini and the dump-file are not written - when the switch --disable-crashdump is set, then the switch "CrashDumpEnable" set to "false" - when the entry "CrashDumpEnable" is missing, in this case is the default true, too - the checkbox under Options-General "Send crash reports to ..." is deactive and shows off (only view, not change the config) - when set the environment variable "CRASH_DUMP_ENABLE" to any char then the switch "CrashDumpEnable=false" are overrules with true and the Dump.ini and dump-file are write Change-Id: I34e7795640eb95d111e18b0ad46ec67b2c126b19 Reviewed-on: https://gerrit.libreoffice.org/79273 Tested-by: Jenkins Reviewed-by: Juergen Funk (CIB) <juergen.funk_ml@cib.de>
2019-10-02Refactoring of the class CrashReporterJuergen Funk
- remove double code - using of all the methode of the CrashReporter-Class - all methode only active when crash-dump enable except the addKeyValue With this change the handling for the patch tdf#127711 A runtime-switch for the MiniCrashDump would be simpler Change-Id: I339b3b8e06f7fc2cd3c0d34ece112a6fd352913a Reviewed-on: https://gerrit.libreoffice.org/79272 Tested-by: Jenkins Reviewed-by: Juergen Funk (CIB) <juergen.funk_ml@cib.de>
2019-10-01loplugin:returnconstval (clang-cl)Stephan Bergmann
Change-Id: Ib3c3e32bd998ac7e29f45cc4ce511a863096c3b5 Reviewed-on: https://gerrit.libreoffice.org/79958 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01Implement parallel version of super-scalar-sample-sort...Dennis Francis
and use it for the pivot table construction routine processBuckets(). The implementation uses ideas from the non-parallel sample sort discussed in the below paper, but parallelizes the "binning"/"classification" operations and the sorting of the bins themselves. Sanders, Peter, and Sebastian Winkel. "Super scalar sample sort." European Symposium on Algorithms. Springer, Berlin, Heidelberg, 2004. which can be accessed at : http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.72.366&rep=rep1&type=pdf Change-Id: I3723b87e2feb8d7d9ee03f71f6025e26add914ce Reviewed-on: https://gerrit.libreoffice.org/79486 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-01lok jsdialogs: Add handling of checked state for checkbox and radiobutton.Jan Holesovsky
Change-Id: Id64833a08c62388220921208cba33a60c178e9ac Reviewed-on: https://gerrit.libreoffice.org/79797 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01jsdialogs: set frame as a separate typeSzymon Kłos
Change-Id: I7f56d49dbe3b403c3716798bb52691748974aaae Reviewed-on: https://gerrit.libreoffice.org/79801 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01jsdialogs: export vertical property for BoxesSzymon Kłos
Change-Id: I377638b0e9c5575e41ea3f3714541cc94f61a92b Reviewed-on: https://gerrit.libreoffice.org/79798 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01jsdialogs: set panel as a separate typeSzymon Kłos
Change-Id: I715915ddcaff807ae6a6593dd776dbdb86f2bf4a Reviewed-on: https://gerrit.libreoffice.org/79802 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01jsdialogs: send toolitemsSzymon Kłos
Change-Id: I113cd99dbcd8b7a2551271041ae749eaa68af8fc Reviewed-on: https://gerrit.libreoffice.org/79806 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01tdf#127777 OOXML chart export: fix X axis position setting "CrossBetween"Balazs Varga
Export ShiftedCategoryPosition value into the CrossBetween OOXML tag. Change-Id: I3d8b298ed47c5326ee4faf0e8663c8c79d5a1d86 Reviewed-on: https://gerrit.libreoffice.org/79502 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-10-01crashreport: change addKeyValue to lower-case camelJuergen Funk
Change-Id: Ife5775d3a570da1fc2e4dd627456523705b64e1d Reviewed-on: https://gerrit.libreoffice.org/79601 Reviewed-by: Juergen Funk (CIB) <juergen.funk_ml@cib.de> Tested-by: Juergen Funk (CIB) <juergen.funk_ml@cib.de>
2019-10-01jsdialogs: export more propertiesSzymon Kłos
Change-Id: Iaabe560867025c30c1478d4b33357231e67b0b57 Reviewed-on: https://gerrit.libreoffice.org/79799 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01jsdialogs: send listbox entriesSzymon Kłos
Change-Id: I00b2260e2ceaffbfbe415633ef5a35c7d147b44a Reviewed-on: https://gerrit.libreoffice.org/79804 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01lok jsdialogs: Introduce dumping of widgets hierarchy to vcl::Window.Jan Holesovsky
Change-Id: Ie3267e1f888df371d281e81ead437a150aa8dc1c Reviewed-on: https://gerrit.libreoffice.org/79796 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01lok: handling a single msg for deleting multiple charactersMarco Cecchetti
also includes: lok: fixing testABI failure Change-Id: I4df662a0df49a864c4b307efdd963b857bb77792 lok: missing removeTextContext implementation for Document class Change-Id: I884ad07f330afc19dfe759c08c8a17bdb4f9dcf3 Change-Id: I045d89f9fa478f37fc2917e159e044eee7e1ab31 Reviewed-on: https://gerrit.libreoffice.org/79879 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-01tdf#127306 Fix crash when closing LO after deleting a chartSamuel Mehrbrodt
This crash was introduced with b58aa94f1f365c746135470bceb97cc182c289bc This patch basically reverts that patch and implements a different fix. Change-Id: I394a2f6490d3ee0769c0f78bb8a3980167719893 Reviewed-on: https://gerrit.libreoffice.org/79865 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-01Drop SfxItemIter::FirstItemMike Kaganski
It is always used right after the iterator is created, where simple GetCurItem gives the same value without reseting the position. Change-Id: I871dc7989b79e13f06436ef7928692645b5209f6 Reviewed-on: https://gerrit.libreoffice.org/79903 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-01Avoid redundant IsAtEnd: NextItem returns nullptr iif iterator is at endMike Kaganski
To keep the check efficient, split NextItem to inline and Impl parts Change-Id: Id5877a3c5bed73aac9c39c655b106a715cf888ea Reviewed-on: https://gerrit.libreoffice.org/79894 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-30jsdialogs: add callback LOK_CALLBACK_JSDIALOGSzymon Kłos
Change-Id: Ie79e24ae3a376e0de3d82daff4a1263c7ce3b33a Reviewed-on: https://gerrit.libreoffice.org/79825 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-09-30Slightly DRY the O(U)StringNumber codeMike Kaganski
At least don't repeat the "O(U)StringNumber" in template argument of base class, and the number type in ctor argument Change-Id: I65cbe49a8fbbf5d9839cae9efc218130756a6710 Reviewed-on: https://gerrit.libreoffice.org/79822 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-29Move Rectangle,Point,Size serialization to GenericTypeSerializerTomaž Vajngerl
Change-Id: Iae489fc31b13b836e1df5327ba2fa07e0325907a Reviewed-on: https://gerrit.libreoffice.org/79793 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-09-29weld DbaIndexDialogCaolán McNamara
Change-Id: I5fe97c0bea6d386c4b39d8bf9341c844ccb792ae Reviewed-on: https://gerrit.libreoffice.org/79745 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-29constmethod for accessor-type methodsNoel Grandin
Apply the constmethod plugin, but only to accessor-type methods, e.g. IsFoo(), GetBar(), etc, where we can be sure of that constifying is a reasonable thing to do. Change-Id: Ibc97f5f359a0992dd1ce2d66f0189f8a0a43d98a Reviewed-on: https://gerrit.libreoffice.org/74269 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-28loplugin:virtualdead in basegfxNoel Grandin
Change-Id: I8b3f7810eb08b5217df30b7be27aafadeeed247a Reviewed-on: https://gerrit.libreoffice.org/79647 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-28loplugin:constmethod in vclNoel Grandin
Change-Id: I6a456979a6cfcd7920dc468baf9b23013cb701a4 Reviewed-on: https://gerrit.libreoffice.org/79783 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-28loplugin:virtualdead in editengNoel Grandin
Change-Id: I72f9cf62f9daeaed5108ede41dd41544204a9745 Reviewed-on: https://gerrit.libreoffice.org/79643 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-27Add conversion from rtl::OStringNumber to std::string_viewStephan Bergmann
...and revert the relevant part of 2f5f45921b05904a4be1ff633be09c62cb44ff08 "support O(U)String::number() for fast string concatenation", as discussed in the comments of that Gerrit change, now that 89bb0b0dcd8dc4656d0047cd10702d1c471c0fa1 "Deduplicate O(U)StringNumber definitions; add toAsciiUpperCase" paved the way. For consistency, also add conversion from rtl::OUStringNumber to std::u16string_view, even if that remains unused as of now. Change-Id: Ieb64bff0b59c22f3dec05c99fca5676b27a46e9a Reviewed-on: https://gerrit.libreoffice.org/79750 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-27Missing include (for std::move)Stephan Bergmann
Change-Id: I38a59d2955a8081bf3ae701a102b0b5c68bd16f3 Reviewed-on: https://gerrit.libreoffice.org/79749 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-08-09 05:57:29 +0000