summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2019-08-15embeddedobj: allow controlling if Visio documents are converted to Draw or notMiklos Vajna
At the moment this affects only Insert -> Object -> OLE Object -> from file. Change-Id: I8d1c6456481610491916e3be3766b0bb04dfa296 Reviewed-on: https://gerrit.libreoffice.org/77489 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-15tdf#122529 lok - table border position manipulationTomaž Vajngerl
This adds a new LOK callback (LOK_CALLBACK_TABLE_SELECTED) that sends the border positions to the client when the user has the cursor or slelection in a table. In addition this adds a .uno:TableChangeCurrentBorderPosition uno command, which implements changing a specific border in the current table. Border can be either a column or a row border, which is either at the first, middle or last position. Change-Id: Ife7cff14d91ffc84c95c040f0b42319e3d6194b4 Reviewed-on: https://gerrit.libreoffice.org/77365 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-08-14svl: update grabbbagitem docMiklos Vajna
Commit 5261417cbb3051b812164838d19c0f748573df45 (weld SpellDialog, 2019-06-14) started to use this for purposes outside OOXML interop, so the doc was misleading. Change-Id: Iece7b5b084585e486854d10e98bccbbf0451a6dd Reviewed-on: https://gerrit.libreoffice.org/77431 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-13Fix typosAndrea Gelmini
Change-Id: I5c3d7a041f0d654d04d8cbe71393921ed46c1220 Reviewed-on: https://gerrit.libreoffice.org/77426 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-08-13Add a TaskStopwatch to interrupt idle loopsJan-Marek Glogowski
If we have multiple pending Idles, they will interrupt / starve each other, because there will be an instant pending timeout for the next Idle. This patch introduces a time slice to tasks, so long running events can use a TaskStopwatch to do the real interrupt after running out of their time slice. Apart from the time, this breaks when AnyInput is available, except for the timer event. This class just helps to track the time, as the scheduler is coop, not preemptive. Change-Id: I9d0b4a5aa388ebdf496b355d100152d890224524 Reviewed-on: https://gerrit.libreoffice.org/75568 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-08-13warn on load when a document binds an event to a macroCaolán McNamara
a) treat shared/Scripts equivalently to document scripts This doesn't automatically warn/block running those scripts when used in a freshly loaded document on its own however because DocumentMacroMode::checkMacrosOnLoading will see at... if ( m_xData->m_rDocumentAccess.documentStorageHasMacros() || hasMacroLibrary() ) that the document contains no macros and flip the allow macros flag to true so that potentially new uses of macros added by the user during the edit are allowed to run b) so, add an additional flag to indicate existence of use of macros in a document c) for odf import, set it when a script:event-listener tag is encountered d) for html import when registerScriptEvents or SwFormatINetFormat::SetMacroTable is called e) for doc import when Read_F_Macro or StoreMacroCmds is called as well for good measure f) for xls import when registerScriptEvent or ScMacroInfo::SetMacro is called g) for oox import when VbaProject::attachMacros is called Change-Id: Ic1203d8ec7dfc217aa217135033ae9db2888e19b Reviewed-on: https://gerrit.libreoffice.org/77131 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-13Fix Clang 10 -Werror,-Wimplicit-int-float-conversionStephan Bergmann
> idlc/source/astexpression.cxx:330:68: error: implicit conversion from 'sal_Int32' (aka 'int') to 'float' changes value from 2147483647 to 2147483648 [-Werror,-Wimplicit-int-float-conversion] > if (ev->u.fval < SAL_MIN_INT32 || ev->u.fval > SAL_MAX_INT32) > ~ ^~~~~~~~~~~~~ > include/sal/types.h:209:32: note: expanded from macro 'SAL_MAX_INT32' > #define SAL_MAX_INT32 ((sal_Int32) 0x7FFFFFFF) > ^~~~~~~~~~~~~~~~~~~~~~~ > idlc/source/astexpression.cxx:414:58: error: implicit conversion from 'sal_uInt32' (aka 'unsigned int') to 'float' changes value from 4294967295 to 4294967296 [-Werror,-Wimplicit-int-float-conversion] > if (ev->u.fval < 0.0 || ev->u.fval > SAL_MAX_UINT32) > ~ ^~~~~~~~~~~~~~ > include/sal/types.h:210:32: note: expanded from macro 'SAL_MAX_UINT32' > #define SAL_MAX_UINT32 ((sal_uInt32) 0xFFFFFFFF) > ^~~~~~~~~~~~~~~~~~~~~~~ > idlc/source/astexpression.cxx:492:68: error: implicit conversion from 'sal_Int64' (aka 'long') to 'float' changes value from 9223372036854775807 to 9223372036854775808 [-Werror,-Wimplicit-int-float-conversion] > if (ev->u.fval < SAL_MIN_INT64 || ev->u.fval > SAL_MAX_INT64) > ~ ^~~~~~~~~~~~~ > include/sal/types.h:212:32: note: expanded from macro 'SAL_MAX_INT64' > #define SAL_MAX_INT64 ((sal_Int64) SAL_CONST_INT64(0x7FFFFFFFFFFFFFFF)) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > idlc/source/astexpression.cxx:501:68: error: implicit conversion from 'sal_Int64' (aka 'long') to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Werror,-Wimplicit-int-float-conversion] > if (ev->u.dval < SAL_MIN_INT64 || ev->u.dval > SAL_MAX_INT64) > ~ ^~~~~~~~~~~~~ > include/sal/types.h:212:32: note: expanded from macro 'SAL_MAX_INT64' > #define SAL_MAX_INT64 ((sal_Int64) SAL_CONST_INT64(0x7FFFFFFFFFFFFFFF)) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > idlc/source/astexpression.cxx:574:58: error: implicit conversion from 'sal_uInt64' (aka 'unsigned long') to 'float' changes value from 18446744073709551615 to 18446744073709551616 [-Werror,-Wimplicit-int-float-conversion] > if (ev->u.fval < 0.0 || ev->u.fval > SAL_MAX_UINT64) > ~ ^~~~~~~~~~~~~~ > include/sal/types.h:213:32: note: expanded from macro 'SAL_MAX_UINT64' > #define SAL_MAX_UINT64 ((sal_uInt64) SAL_CONST_UINT64(0xFFFFFFFFFFFFFFFF)) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > idlc/source/astexpression.cxx:583:58: error: implicit conversion from 'sal_uInt64' (aka 'unsigned long') to 'double' changes value from 18446744073709551615 to 18446744073709551616 [-Werror,-Wimplicit-int-float-conversion] > if (ev->u.dval < 0.0 || ev->u.dval > SAL_MAX_UINT64) > ~ ^~~~~~~~~~~~~~ > include/sal/types.h:213:32: note: expanded from macro 'SAL_MAX_UINT64' > #define SAL_MAX_UINT64 ((sal_uInt64) SAL_CONST_UINT64(0xFFFFFFFFFFFFFFFF)) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Consitently use the new o3tl::convertsToAtLeast/Most(o3tl::roundAway(...), ...) for all cases in coerce_value that check that a floating-point value falls into an integer range, even those that don't cause a warning. The new idlc/test/parser/conversion.tests is deliberately left out of unoidl/CustomTarget_unoidl-write_test.mk. as unoidl-write doesn't support such conversions from floating-point to integer types. Change-Id: Ie00923e665f2bcb306e1e328614c75b9247512ee Reviewed-on: https://gerrit.libreoffice.org/77353 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-12Fix typosAndrea Gelmini
Change-Id: Ia51fa09db3db0c00432fc02ef9fe445444aa463b Reviewed-on: https://gerrit.libreoffice.org/77321 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: Id20e239b8a5a2dababe9284dc30d4d155ffecfc5 Reviewed-on: https://gerrit.libreoffice.org/77322 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-08-12Don't select hyperlink fields arbitrarilySamuel Mehrbrodt
For some functions, like remove or edit hyperlink, it's required that the hyperlink field is selected. However, we should do that only when executing the function, not when queriying its status. This led to selection changes on mouse over/right click. Change-Id: I22035698032d1e651aae6a74d6e445dfe044bf74 Reviewed-on: https://gerrit.libreoffice.org/77336 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-12Fix typosAndrea Gelmini
Change-Id: Ibd802e81649373fd9ad6d0309276b8e6ae43dd24 Reviewed-on: https://gerrit.libreoffice.org/77261 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: Id465a50e53b35d259a3fde91bfad35cebf1ce064 Reviewed-on: https://gerrit.libreoffice.org/77263 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: Iff95876fc0dcb10af9b06f4091f1d9934d416c5f Reviewed-on: https://gerrit.libreoffice.org/77262 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
"its" Change-Id: I02c660e46964270376a66210fdb5f1b1985ce5b6 Reviewed-on: https://gerrit.libreoffice.org/77255 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-11Use standard algorithms instead of custom copy functionMike Kaganski
Change-Id: If0e3233590b31558dd0f28ff361461f2c5de5697 Reviewed-on: https://gerrit.libreoffice.org/77270 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-10Fix typosAndrea Gelmini
Information is always singular Change-Id: I55275d7c2fd76c3ec0ae4a98aa952777feb90460 Reviewed-on: https://gerrit.libreoffice.org/75645 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-08-09tdf#126746 Fix exporting closed Polylines to PPTXBartosz Kosiorek
In previous implementation the closed shapes was imported as a polylines without closing joint. As a result the joint style was not applied. This patch fixes that, and allow proper PPTX export. TODO The same issue needs to be fixed for PPT export Change-Id: I557daac1ba02330d8923f7eda3476e67d8711384 Reviewed-on: https://gerrit.libreoffice.org/77179 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-08-09tdf#126722 Deleted svxcommands.hSzabolcs Toth
Change-Id: Ife8296ba74ad0f3016f65e69a488b9166d86e07b Reviewed-on: https://gerrit.libreoffice.org/77150 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-08-09Resolves: tdf#126790 use TopLevelWindowLocker in welded help pathCaolán McNamara
Change-Id: I4340d021b63609189d3179a7bcff7fac4fcef69d Reviewed-on: https://gerrit.libreoffice.org/77195 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-09Fix typosAndrea Gelmini
Change-Id: I994f656b0828c9c7ea1463b86cd692f847d01e7e Reviewed-on: https://gerrit.libreoffice.org/77126 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-09Fix typosAndrea Gelmini
Change-Id: I545154bddfd29194630d744b4aa4f5c385321531 Reviewed-on: https://gerrit.libreoffice.org/77138 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-09Fix typoAndrea Gelmini
"Inherting" Change-Id: Ib9b1fcfd9ef585149de5018ce650707c71d412c8 Reviewed-on: https://gerrit.libreoffice.org/77127 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-08tdf#74702: use OutputDevice::GetBackgroundColor()Chris Sherlock
Apply the Liskov substitution principle to OutputDevice::GetBackgroundColor(). This helps in SmTmpDevice::Impl_GetColor() because it no longer needs to know about what type of OutputDevice it is calling to get the background color. This forced a rename of basctl::ModulWindowLayout::GetBackgroundColor() to be GetSyntaxBackgroundColor(), but this is a happy coincidence as it makes the function intent clearer anyway. Change-Id: I11298a63cb01c187f3a8a4a2c9e90eacda6c3e6b Reviewed-on: https://gerrit.libreoffice.org/75521 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-08-08tdf#74702: removes GetOutDevType() from OutputDevice::ImplRefreshFontDataAdrien Ollier
Change-Id: I8a51afe0979d83862bbe384e6d67702f4687072d Signed-off-by: Adrien Ollier <adr.ollier@hotmail.fr> Reviewed-on: https://gerrit.libreoffice.org/75068 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-08-07tdf#126722 All unnecessary defines are removed.Szabolcs Toth
Change-Id: I00f4f8c5b767a34563a0274ebcd37870ea9b346c Reviewed-on: https://gerrit.libreoffice.org/77094 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-07move WizardDialog to vclCaolán McNamara
Change-Id: I93d03601cb429687a9a73b7d28c595e69977bf87 Reviewed-on: https://gerrit.libreoffice.org/76901 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-07move Roadmap to vclCaolán McNamara
Change-Id: I3ddb2a4906351d4134c14a1e9af710c9e7aeb5c6 Reviewed-on: https://gerrit.libreoffice.org/76900 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-07move HyperLabel into vclCaolán McNamara
could this be merged with FixedHyperlink? Change-Id: I00abe4bfa62a55c7b62ccd40e6c0294699317f26 Reviewed-on: https://gerrit.libreoffice.org/76897 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-06Move CopyHyperlinkLocation to svxSamuel Mehrbrodt
so that it can be used by other modules too Change-Id: I43d197320f85a3ec06b6b0b832f7bb5647800076 Reviewed-on: https://gerrit.libreoffice.org/77012 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-05tdf#126684: store "DialogUseCharAttr" in RES_PARATR_GRABBAGMike Kaganski
... because RES_CHRATR_GRABBAG value may be later reset by initial value read from char format, when it's present there. OTOH, RES_PARATR_GRABBAG shouldn't be present in character format, so it should be safe to pass the grabbag item there. Regression after commit 074fc4a1499aac6eb67cd0b2dca00a51071cff0e. Change-Id: Iebbee04929714d6a3fb72274a211699b2a80b3d2 Reviewed-on: https://gerrit.libreoffice.org/76981 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-05SmartArt: store diagram data model in SdrObjectGrzegorz Araminowicz
It will allow modifying loaded diagram and exporting it. This data is used for regenerating diagram instead of parsing xml fragment every time. Also provided an interface for UI that can be extended to show, add and remove nodes from data model. It is stored as SdrObject field because diagram top-level shape is group shape. Item set doesn't exist for them and storing data in child shapes is not possible here because children are removed and recreated on every diagram reload. Change-Id: I84e5ec955f638b254fef9ef9d1731ca7938982b7 Reviewed-on: https://gerrit.libreoffice.org/76121 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-05tdf#39593 Drop connectivity::sdbcx::ODescriptor::getImplementationArkadiy Illarionov
Replace with comphelper::getUnoTunnelImplementation. Change-Id: Ia08561c11872a4ede9077863f81040633c30aebc Reviewed-on: https://gerrit.libreoffice.org/76914 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-03Fix typosAndrea Gelmini
Change-Id: I5c95e180681220fc592400435d90e4d46603d41c Reviewed-on: https://gerrit.libreoffice.org/76883 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-02LOK: Improved selection complexity detectionAshod Nakashian
Only Graphics and OLE now unconditionally trigger 'complex' case, and for all others, we actually tally the number of text characters. Currently anything above 512KB is flagged as 'complex'. Change-Id: I19fbef72f2eb725648b2a18c1ee41b1612d2bac0
2019-08-02lok: clipboard: per view clipboard creation.Michael Meeks
A bit brutal, but the mess around clipboard instantiation is awful. Change-Id: I62d6af8bf6813e6bab81123417ea8bfb28394e29
2019-08-02Fix build: unused argumentSzymon Kłos
Change-Id: Id79d9c093da21b9f68bb38a51ac5f142a69364ed
2019-08-02LOK: Support detecting complex selectionsAshod Nakashian
Includes unit-test, but is otherwise not complete implementation. Change-Id: I5fdcd543358caab1858f6351238c21312665839c
2019-08-02Add more powerful selection fetch & clipboard set methods.Michael Meeks
Change-Id: I6633356d13480377a83a006588ec69ebcb56a93f
2019-08-02Fix typoAndrea Gelmini
Change-Id: Idaaec17114aa2b03c00da075f5accc4c0c0e69b4 Reviewed-on: https://gerrit.libreoffice.org/75768 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-08-02DrawButtonFlags::NoText never setCaolán McNamara
Change-Id: I23531adc0798ec4a97538a8002ba0866535677a3 Reviewed-on: https://gerrit.libreoffice.org/76829 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02DrawButtonFlags::NoImage never setCaolán McNamara
Change-Id: I7ad7dbadad3bff1fe60b4aa9950bf1ec6a902835 Reviewed-on: https://gerrit.libreoffice.org/76828 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: Icdb749d46249ea29badbe523320b17312e077684 Reviewed-on: https://gerrit.libreoffice.org/76811 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-02Fix typosAndrea Gelmini
Change-Id: Ic7b6014e09e3ee1a1b4917008a267b8fa2dbc1f5 Reviewed-on: https://gerrit.libreoffice.org/76814 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-08-01Make QR Code callable in calc and writerShubham Goyal
Change-Id: I73793100478c34a7721821cec1f8ccec0174d20c Reviewed-on: https://gerrit.libreoffice.org/74598 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-01drop newly unused EnableImageDisplay + EnableTextDisplayCaolán McNamara
Change-Id: I534c5fcfe2e8b55d0f01075b62e7168a10e805a9 Reviewed-on: https://gerrit.libreoffice.org/76819 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01tdf#126282 add English (Sri Lanka) [en-LK] 0xA409 to language listEike Rathke
Change-Id: I2b02498684c952f9a6bf8f6bc17a3355c3607aac Reviewed-on: https://gerrit.libreoffice.org/76807 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-08-01weld SvxPathTabPageCaolán McNamara
Change-Id: If9b982d9e73adbb55e940ae12e5d894dd803f7f3 Reviewed-on: https://gerrit.libreoffice.org/76788 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01new loplugin:mapindexNoel Grandin
Change-Id: I6b5f73b2187009e95d4d666e03e5803f522cee06 Reviewed-on: https://gerrit.libreoffice.org/76584 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-31weld SvxFontSubstTabPageCaolán McNamara
Change-Id: If24e80da4042ea37ea2613a6c62e015d0d925dc8 Reviewed-on: https://gerrit.libreoffice.org/76753 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): comphelperStephan Bergmann
Change-Id: Ie0d3604b8742aed139131d523f6c7371bc02b7c3 Reviewed-on: https://gerrit.libreoffice.org/76691 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>