summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2019-04-04Get rid of b2u/u2b helpers; use OUString's toUtf8/fromUtf8 insteadMike Kaganski
These helpers are used in code generator code; so any invalid UTF-8 or UTF-16 in the conversion is programmer's error which needs fixing. Thus, the behavior of toUtf8/fromUtf8 which asserts the validity is fine here. Change-Id: I3004e233c9de59f8e348455f1f04d23e8c51ed3d Reviewed-on: https://gerrit.libreoffice.org/70249 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-04Get rid of USS macroMike Kaganski
The helper marco is used in export code to convert UTF-16 internal string representation to UTF-8 used in XML encoding. I suppose that all strings here should be already valid UTF-16 (an invalid input should have been validated at import/input stage). An invalid string at this stage means a programming error in another part of code that breaks this precondition, and should not be handled at export stage. (See also commit 0267a2326b5282023e8b08a147eca178c5db1980.) This effectively changes flags used in conversion from UTF-16 to UTF-8, so that now RTL_UNICODETOTEXT_FLAGS_INVALID_ERROR is used instead of RTL_UNICODETOTEXT_FLAGS_INVALID_DEFAULT, so that the result would be truncated on invalid bytes instead of inserting U+FFFD, and would fail assertion in debug builds. Other changed flags don't affect UTF-16-to-UTF-8 conversion. Change-Id: I12b2cc5378208904c3266924187d6402700ed6f3 Reviewed-on: https://gerrit.libreoffice.org/69801 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-04CreateUndoRemoveObject default arg is always usedCaolán McNamara
Change-Id: I5676281be56ff454962900fe7500d078b1f9e7e9 Reviewed-on: https://gerrit.libreoffice.org/70252 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04change GetColorCount to use sal_Int64Tomaž Vajngerl
Hopefully fixes problems on 32-bit linux. Change-Id: I1fc22f1bb37c8297bd3bd6828206d1ffa9ae722d Reviewed-on: https://gerrit.libreoffice.org/70241 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-04tdf#124323: show restart dialog when toggling multi-threaded...Xisco Fauli
calculation Change-Id: I853ae21d4c085488232a375ef42480453c01880b Reviewed-on: https://gerrit.libreoffice.org/70210 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-04-04expand async to allow it to resize to optimal sizeCaolán McNamara
Change-Id: I87c413108a41f994c0e8d86f469fc361d4cd42e5 Reviewed-on: https://gerrit.libreoffice.org/70220 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04weld ClassificationDialogCaolán McNamara
with the extra problem of hosting an EditView/EditEngine within a weld::DrawingArea Change-Id: Id48a57ed0dfd2d92217209c43f752edd9cf8e1bd Reviewed-on: https://gerrit.libreoffice.org/70219 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04add nullchecking SelectionEngine::CaptureMouseCaolán McNamara
Change-Id: Ie8594c8fe2a9e2d84121f3a6a1ee8afab265b14f Reviewed-on: https://gerrit.libreoffice.org/70216 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04tdf#124155 fix slider to not go beyond rect boundsTomaž Vajngerl
We need to ask the NWF for the size of the thumb and not just use the hard-coded value. Change-Id: I98c6b5782c6a043fc358198ddf844d36d7aa90d6 Reviewed-on: https://gerrit.libreoffice.org/70201 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-03Revert "add more append methods to *StringBuffer"Noel Grandin
This reverts commit 8cfa7f4dc00f3dd37e57917ef25c806b0e9e6e73. comment from sberg: we already have 70519a43e0d89a6b5d89859a6851f8c757c6b0c7 "Replace OUStringBuffer::appendCopy with append(std::u16string_view)" (which can be extended to OStringBuffer if needed) Change-Id: Ifcc550a8cf26ef38ad49fde8b067f53c999c9276 Reviewed-on: https://gerrit.libreoffice.org/70178 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-03Support for native 32bit Bitmap in VCL and SVP (cairo) backendTomaž Vajngerl
This adds basic support for 32bit bitmaps for the SVP backend. For other backends the support is disabled for now as we need to add it for each backend separately and enable support. When this patch is applied it is possible to a Bitmap with bit count 32, but currently no input filter uses this with the exception of the new PngImageReader(libpng based), which is used only for the icons. For a general support more things need to be implemented and tested: - conversion back and fourth between 32-bit and 24-bit + 8bit alpha (or other supported pairs) - 'raw' export of the bitmap needs to be handeled properly (like in SVM import/export) so it creates the correct image. - input filters need to be checked and converted if this is necessary - look for possible bugs when drawing transparent bitmaps - check of UNO API Change-Id: I7a7be0e6134dfdd9a7aeaef897131bb6e710ae7e Reviewed-on: https://gerrit.libreoffice.org/69289 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-03tdf#124155 change "gradient tab page" - increment & angle sliderTomaž Vajngerl
Remove slider for increments as the increments should better be left to "auto" and rarely modified (setting a value means it will use a limitied amount of increments, but auto effectively means as much as it is needed and can use the native backend for drawing). OTOH use a slider for setting the "angle" as it is already present in hatch tab page. Angle needs a slider as it is usually one of the main properties of a gradient (especially linear). Increase the tab pages a bit (10px on every side) to have a bit of breating space for all the widgets. Change-Id: I66167fe2c97b53bc3627237279332bdd59fb03d7 Reviewed-on: https://gerrit.libreoffice.org/70175 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-03add more append methods to *StringBufferNoel Grandin
which performs the append without needing the creation of a temporary *String Change-Id: If9ad3222275f26659db2e7df8d34f068977c4d17 Reviewed-on: https://gerrit.libreoffice.org/69826 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-03Fix typosJens Carl
Change indefinite article "an" to "a" before the word unique and some variants. Change-Id: Ia14a6f3b9ec6b257ad8bed3b089faa9b6f07d44f Reviewed-on: https://gerrit.libreoffice.org/70174 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-03tdf#45904 Move XCellRange Java tests to C++Jens Carl
Move XCellRange Java tests to C++ for ScTableRowObj. Change-Id: I2735779cae777c5af4e622bc1b538df2d8bf70df Reviewed-on: https://gerrit.libreoffice.org/70163 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-03tdf#45904 Move TableRow Java tests to C++Jens Carl
Move TableRow Java tests to C++ for ScTableRowObj. Change-Id: I72cd8006b8ad932bab56681de9aac66fb40542fe Reviewed-on: https://gerrit.libreoffice.org/70159 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-02weld XMLFilterSettingsDialogCaolán McNamara
Change-Id: Ia027fa0b5e99651988f2447bf29f6f5653dd0c48 Reviewed-on: https://gerrit.libreoffice.org/70139 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-02Split large test method in twoSamuel Mehrbrodt
Change-Id: If1b915f721a5768b682c63dc9c08b708ba37a705 Reviewed-on: https://gerrit.libreoffice.org/70116 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-04-02tdf#108423 autocorrect English word i' -> I’László Németh
Now correction of the ASCII quotation mark to the typographical one (’) capitalizes the preceding single lowercase i, too, as in MSO, if the language of the text is English. Change-Id: Ic7586f07aa13f441e25494ff4cc11c672ac4a67a Reviewed-on: https://gerrit.libreoffice.org/70088 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-04-01drop unnecessary includesCaolán McNamara
Change-Id: I12c02a03202d778d9c2d7bf41022db64af492e04 Reviewed-on: https://gerrit.libreoffice.org/70075 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-01tdf#42949 Fix IWYU warnings in include/sfx2/[sS]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I4a3baffa8944b522b16b50975185759081662020 Reviewed-on: https://gerrit.libreoffice.org/69945 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-01tdf#124150 increase size of color valueset widgetTomaž Vajngerl
Size of the color value set can be set through settings, but there was no setter. Added a setter and set it to a bigger value so it is better suited for touch. Change-Id: I8c9b17f7379c4702b0faf7847f1e6292cd89b0d0 Reviewed-on: https://gerrit.libreoffice.org/70031 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-30tdf#45904 Move XFormLayerAccess Java tests to C++Jens Carl
Move XFormLayerAccess Java tests to C++ for ScViewPaneObj. Change-Id: I7ed6ff51d435b6f3de85daec99a13583e50a450a Reviewed-on: https://gerrit.libreoffice.org/69942 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-30Some refactor of lockfile classes to minimize interfaceMike Kaganski
Change-Id: Icc67c31d6a2351b6504429e25067c25353233f5f Reviewed-on: https://gerrit.libreoffice.org/69947 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-29Move UNO Api helper form to include/Jens Carl
Move UNO Api helper form to include/, so it can be used outside of directory test/. Change-Id: I9392f44df8a93d2b5ee092b0458aeef12f99fc7a Reviewed-on: https://gerrit.libreoffice.org/69936 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-29tdf#42949 Fix IWYU warnings in include/sfx2/[n-r]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia2bea9bd4775f4ed5ef0133971106a6c0bfdd1c0 Reviewed-on: https://gerrit.libreoffice.org/69896 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-29tdf#45904 Move XNamed Java tests to C++Jens Carl
Move XNamed Java tests to C++ for ScSheetLinkObj. Change-Id: I64904ed6bae1b96767f8b0a65b0850a8694b10c2 Reviewed-on: https://gerrit.libreoffice.org/69907 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-29tdf#45904 Move XShapes Java tests to C++Jens Carl
Move XShapes Java tests to C++ for ScDrawPageObj. Change-Id: I1b65e8ad685c3d387a5023e8e8e9b9e06627af11 Reviewed-on: https://gerrit.libreoffice.org/69904 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-28Fix header guard and improve commentsJens Carl
Change-Id: I7ddef04a88381e3e58a6604de35694dea658c81d Reviewed-on: https://gerrit.libreoffice.org/69900 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-28weld SfxTemplateManagerDlgCaolán McNamara
like expert configuration change the gear menu not to display a down indicator and use CommandEvent to distinguish mouse/non-mouse context menus Change-Id: I64bb660a9c7dacb5b90b240d9d76d29324c5fd9f Reviewed-on: https://gerrit.libreoffice.org/69893 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-28tdf#42949 Fix IWYU warnings in include/sfx2/[e-M]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6e97c7ed6c0211dfafee83b9bdbea672e415fc49 Reviewed-on: https://gerrit.libreoffice.org/69715 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-28return unique_ptr from SdrPage::CreateObjectSpecificViewContactNoel Grandin
Change-Id: I3297128efd44f4df86886d6f0349420d6ce18571 Reviewed-on: https://gerrit.libreoffice.org/69855 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-28tdf#45904 Move XShapeGrouper Java tests to C++Jens Carl
Move XShapeGrouper Java tests to C++ for ScDrawPageObj. Change-Id: I4a1ed4f14f759fa4214141f0d552e35ccae28035 Reviewed-on: https://gerrit.libreoffice.org/69873 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-27move LineListBox beside last consumerCaolán McNamara
Change-Id: Ie683784a9f4ecfb0015bf7ae79769238719a6376 Reviewed-on: https://gerrit.libreoffice.org/69841 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-27Helper to create various drawing::XShapeJens Carl
This ports SOfficeFactory::createShape() from file qadevOOo/runner/util/SOfficeFactory. Change-Id: I2c7eb0304ac1d439211d3851b2debdb4843130e3 Reviewed-on: https://gerrit.libreoffice.org/69772 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-27tdf#60242 remember horizontal/vertical choice in split cells dialogMartin van Zijl
Change-Id: I25f6b7c8ff6aa678b597bbede0dd1492468f2f62 Reviewed-on: https://gerrit.libreoffice.org/65606 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-27loplugin:typedefparam (clang-cl)Stephan Bergmann
Change-Id: I07604028845c49cc084927e21db7f21c5d053bab Reviewed-on: https://gerrit.libreoffice.org/69796 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-27return by unique_ptr from weld_parentNoel Grandin
Change-Id: I3582b3000330fab96f6abef0f412b648b0573af4 Reviewed-on: https://gerrit.libreoffice.org/69793 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-27MSO lockfiles: Deduplicate MSO lock file reading codeTamás Zolnai
The removed code was extracted to MSODocumentLockFile class so use that class here too. Use openStreamNoLock() for reading MSO lockfiles, because otherwise we can not read lock files written by MSO. Change-Id: Ib31cb9f3783d0b0ce784f900821047b9d32156f2 Reviewed-on: https://gerrit.libreoffice.org/69759 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-27Resolves: tdf#123291 set hex input to overwrite by defaultCaolán McNamara
and ensure the modify arrives after the input text has been filtered Change-Id: I16c0bd095700e7d9858e3e74884b5a1ad3eb7e4c Reviewed-on: https://gerrit.libreoffice.org/69764 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-27condition always true in XSpreadsheets2::importSheetToCopyNoel Grandin
leftover from commit ed45c87896de74048708d51c050ecd42c9f4a0a0 Date: Mon Oct 20 21:08:54 2014 +0200 sc: fix temp file leak in ScTableSheetsObj Change-Id: Ic108fb36cc0caccbe57f2b47f7fcbe80156842dc Reviewed-on: https://gerrit.libreoffice.org/69749 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-26Generate MSO lock files when the related MSO compat. option is setTamás Zolnai
Added a new compatibility option to the Tools -> Load / Save -> Microsoft. When this option is set on the UI or or set in the configuration files LO generates lock files for MSO supported file formats, similar to the lock files MSO generates itself. Change-Id: I2f882723841162add01be9d3f7285a5162a60331 Reviewed-on: https://gerrit.libreoffice.org/69678 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-26weld URLDlgCaolán McNamara
Change-Id: I3dd002a97d7c90e62c09f65bfc0333892bbd817c Reviewed-on: https://gerrit.libreoffice.org/69718 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-26weld SvxRubyDialogCaolán McNamara
Change-Id: I32f26b9d3e495e64a38cd8a56e532374dd4891f1 Reviewed-on: https://gerrit.libreoffice.org/69651 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-26loplugin:unnnecessaryvirtualNoel Grandin
Change-Id: I2aa9a8f14b6db2098931a14c6eed522a9d2653ed Reviewed-on: https://gerrit.libreoffice.org/69682 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-26Consolidate declarations of {fire,reap}_glxtest_process in single include fileStephan Bergmann
Change-Id: I7f25cba311d42a7e8751cf3651f684b88d1fb8ac Reviewed-on: https://gerrit.libreoffice.org/69711 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-26loplugin:unusedmethodsNoel Grandin
Change-Id: I8bbf439d69a330a9ad28ff52cc49a9fec2c12500 Reviewed-on: https://gerrit.libreoffice.org/69684 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-26loplugin:unusedfieldsNoel Grandin
Change-Id: I31c953c8e4c1d4ec235ea318d0aa3b7cedaed1a3 Reviewed-on: https://gerrit.libreoffice.org/69683 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-26loplugin:singlevalfieldsNoel Grandin
Change-Id: I4a56a27ebce927b8e21cf37bb2c527caf1317bcc Reviewed-on: https://gerrit.libreoffice.org/69681 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-26Allow irregular feature value structures in feature dialogMartin Hosken
Change-Id: I92df2d47bebb0b0af38f3527881ac65a11d1bb98 Reviewed-on: https://gerrit.libreoffice.org/69643 Tested-by: Jenkins Reviewed-by: Martin Hosken <martin_hosken@sil.org>
generated by cgit (git 2.34.1) at 2024-08-04 17:27:42 +0000