summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2017-03-03Typo: requirments -> requirementsSamuel Mehrbrodt
Change-Id: I02c5846eb51071e1a958c3d65e150fb7cbc7d58a Reviewed-on: https://gerrit.libreoffice.org/34873 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-03[API CHANGE] Remove SAL_CONSTEXPR againStephan Bergmann
...now that LIBO_INTERNAL_ONLY always has constexpr support. It had been added for LO 5.0 (effectively always expanding to nothing for !LIBO_INTERNAL_ONLY), not wrapped in '#if LIBO_INTERNAL_ONLY' presumably because it was assumed to be used freely in URE include files, but turned out to be only used in LIBO_INTERNAL_ONLY code. It is unlikely that any 3rd party code made use of it. Change-Id: I68970c5a2e2d7ef68ac5b79efc8dc1de54c43198
2017-03-03drop SvxNumType and rename SvxExtNumType->SvxNumTypeNoel Grandin
Both of them are abstractions over the css::style::NumberingType constants. SvxNumType serves no useful purpose, since it's just a typedef to sal_Int16. At least SvxExtNumType wraps up the css::style::NumberingType constants in a nice enum. Change-Id: I7b3f97cd42b0aa23aff7a4db4930da86149d4f4e Reviewed-on: https://gerrit.libreoffice.org/34816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03remove unused CreateDefault methodsNoel Grandin
Change-Id: Ifbdd7d41f0938e9a03693f88416792ff8087f8c2 Reviewed-on: https://gerrit.libreoffice.org/34850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03Fix typosAndrea Gelmini
Change-Id: I95fc63af11c336cde9f5bef908e1389c2fb56f02 Reviewed-on: https://gerrit.libreoffice.org/34823 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03Fix typosAndrea Gelmini
Change-Id: I5e3c9683741ddc66283008c20794be5c2b2bc53f Reviewed-on: https://gerrit.libreoffice.org/34804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03Remove uses of SAL_CONSTEXPR in LIBO_INTERNAL_ONLYStephan Bergmann
Change-Id: I9a7dc7c83302b3361f056fcf6636bbba7672f15f Reviewed-on: https://gerrit.libreoffice.org/34840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03use SvxExtNumType in SvxNumberTypeNoel Grandin
and follow the rabbit trail, fixing various other types in the process Change-Id: I8fc7df3b585df21578ffb28fdd7e5e427b3bfd9d Reviewed-on: https://gerrit.libreoffice.org/34814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03convert SfxEnumItem to type-safe template classNoel Grandin
and drop the SvxChartTextOrientItem class, unused. Change-Id: I99100837d1beb953450f57b2cda47d165df1620c Reviewed-on: https://gerrit.libreoffice.org/34747 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-02Remove HAVE_CXX11_CONSTEXPR, always true nowStephan Bergmann
...after 84b36c704d73362d4d86dc9e9c0efa0625958347 "Drop support for MSVC 2013". Make this a fatal configuration error for now. The check should be removed completely after LO 5.4 branch-off. Change-Id: I990fd8fcb4ec1327282df4efe21640c938d3cf06 Reviewed-on: https://gerrit.libreoffice.org/34821 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-02tdf#60874 Set custom HID for Protect Document windowGabor Kelemen
The window has its own help page but the SfxPasswordDialog has a default help page as well. We need to use custom help IDs here. The Password entry already has a custom HID however it is used on the default help page of SfxPasswordDialog. We need to set a custom help ID for the Confirm entry and use it in the scalc/01/06060200.xhp file like the one belonging to the Password entry. Change-Id: I9344c85cf362a1829202664315f8c8be0a265b59 Reviewed-on: https://gerrit.libreoffice.org/34501 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-03-02COMPRESS_OWN define is not used standalone anywhereCaolán McNamara
Change-Id: Iaca54d62a48711a7763cac98c6f303b952b2da29
2017-03-02don't need this STL hack anymoreNoel Grandin
Change-Id: Id0883060acf2ca73af5cce56e1cf9021c2fb121a
2017-03-02no need to use smart pointers for DataFlavorExVectorJochen Nitschke
DataFlavorExVector is a std::vector<..> typedef. remove odd void pointer in BrowseBox. return const references to keep getter const qualified. Change-Id: Iafd529a46b7511941c1dffc86d2066fdc4f07e28 Reviewed-on: https://gerrit.libreoffice.org/34767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-01ofz: timeout loading emf with move clip recordCaolán McNamara
Change-Id: Id5d60f0037873598e1447b063e66e9c29840587c Reviewed-on: https://gerrit.libreoffice.org/34740 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-01Blind fix for 64-bit Windows buildsNoel Grandin
Change-Id: Ica9e99fc363d8c7bfbc40dceb66ad350e5a02ce5
2017-03-01typesafe wrappers for css::i18nutil::TransliterationModulesNoel Grandin
and related css::util::SearchOptions2 The TransliterationModules enum has it's constants spread over multiple UNO enum/constant-collections - TransliterationModules and TransliterationModulesExtra, which means that most code simply uses sal_Int32. Wrap them up into a better bundle so that only the lowest layer needs to deal directly with the UNO constants. Change-Id: I1edeab79fcc7817a4a97c933ef84ab7015bb849b Reviewed-on: https://gerrit.libreoffice.org/34582 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-28loplugin:sallogareasStephan Bergmann
Change-Id: I9af09bc52775501c8dbf0e883f4ec3b53c397de4
2017-02-28Run macro:// via LOKitKatarina Behrens
Change-Id: I54d3c734d86d4b44e1dfe1ad7728e2f51cd26d53 Reviewed-on: https://gerrit.libreoffice.org/34538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-27uitest: add scheduler method that runs until a signal is receivedMarkus Mohrhard
The other method only runs 1000 events. Change-Id: I43076988e9e25b35e3fdfd8dff19270d9e066d9a Reviewed-on: https://gerrit.libreoffice.org/34690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-27tdf#105829 Infobar design, tdf#102785 Font issueheiko tietze
Only one constructor to append an infobar Colors defined at one place in infobar.cxx based on InfoBarType Icons as an additional attribute of the notification Change-Id: I4dc85c2b4ef0b7eafc139290b3b4ee21636da6ec Reviewed-on: https://gerrit.libreoffice.org/34426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-02-27tdf#105093 vcl PDF export: add embedded video testcaseMiklos Vajna
Fails with commit 4ad249af88d15f2c8a09f0721a59d82718fcc201 (tdf#105093 sd PDF export: handle embedded videos, 2017-01-04) reverted. Change-Id: I413ec9a5da3c0783541dcd28fb9a62dd896f955b Reviewed-on: https://gerrit.libreoffice.org/34681 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-27Clean up use of integer typesStephan Bergmann
Change-Id: Idf47d1511aff3cdb7c139671173a97e405b6078e
2017-02-27uitest: add a specific method for executing dialogsMarkus Mohrhard
This allows us to split the parts that need to run async and the ones that can run synchronous. This will reduce the number of signals that we need. Change-Id: I9c9f3df3422cc66d28d66e0638e212b39c743e33 Reviewed-on: https://gerrit.libreoffice.org/34669 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-27tdf#105461 vcl: add text highlight textcaseMiklos Vajna
Fails with commit ee32c7d8083ae1449d6b379034be92995c142da9 (tdf#105461 PDF export: handle text fill color, 2017-02-01) reverted. Change-Id: I3628a16d0810e3be3fb352340d06cdba472dcd3f Reviewed-on: https://gerrit.libreoffice.org/34621 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-26Restore the GetPreferredContextMenuShortcuts methodMaxim Monastirsky
Because of a typo in GetContextMenuShortcuts it was actually unused and removed later in 7419057e3ec4365748fa6456e207f40fd9e09c62 ("loplugin:unusedmethods in chart2..svx"). Change-Id: Iab3d8e39ef19e7c6dd7df63db5d2dcfc57007a5f
2017-02-26Unwind trivial DbGridControl_Base typedefStephan Bergmann
Change-Id: Ie58d1e119af6d98b44f67d65ec2586928c1d3360
2017-02-26Clean up use of integer typesStephan Bergmann
Change-Id: Ief9b377b4352796e19797c397e677e9f8397cc53
2017-02-24Added Test for EditEngine - Copy/Paste using Legacy FormatVarun Dhall
Change-Id: I3153010f4e327abd2ef48bdefa50ade1c0ba2f81 Reviewed-on: https://gerrit.libreoffice.org/34552 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-02-24vcl: add initial CppunitTest_vcl_pdfexportMiklos Vajna
Invoke the PDF export filter and then use the PDF tokenizer from xmlsecurity to assert the contents of created PDF file. The testcase fails with commit 6db0f1feb1d9931d2726dd11a889c58815710ce0 (tdf#106059 PDF export: create a reference XObject for PDF images, 2017-02-22) reverted. Change-Id: I90526fef41d9560ae447f586df766bc50a491c43 Reviewed-on: https://gerrit.libreoffice.org/34609 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-24vector::data seems more natural than &vector::frontCaolán McNamara
Change-Id: I0ce48075ad186cf1f9bd3e13fa76269fa9819af1
2017-02-24Notebookbar: Better resize supportSzymon Kłos
Change-Id: I0bb5a5600be60a68e53132f2c3c42f79c958b2b3 Reviewed-on: https://gerrit.libreoffice.org/34491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-23tdf#106059 PDF export: create a reference XObject for JPG images with PDF dataMiklos Vajna
In case the bitmap is large enough, the bitmap for the PDF image is a JPG one, not a PNG one. Handle this case as well. Also stop compressing the PDF data: Adobe Acrobat gets confused when the second bugdoc is compressed and it doesn't provide much as most of a PDF is already compressed anyway. The rest is just refactoring to decouple the reference XObject code from PNG, to be able to use it for JPG as well. Change-Id: I5314a39b0f6d8c6493ecb36a0c588c895f5a70ee
2017-02-23loplugin:unusedmethodsNoel Grandin
Change-Id: I5a72ee666e71b4c5c8f43d327aa7e8eb62d1e51b Reviewed-on: https://gerrit.libreoffice.org/34537 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-22Revert "Fix typos"jan iversen
This reverts commit ffd7f8fcfc2b551509e9cb31c0920e0f64292ea7. Caused some problems, need to be broken down. Change-Id: Iee816a266c32e7cebe623d36300c13d079e77c52 Reviewed-on: https://gerrit.libreoffice.org/34534 Reviewed-by: jan iversen <jani@libreoffice.org> Tested-by: jan iversen <jani@libreoffice.org>
2017-02-22Fix typosAndrea Gelmini
Change-Id: I61764094dd6f8e13f29ca554373d30d1d5def447 Reviewed-on: https://gerrit.libreoffice.org/34476 Reviewed-by: jan iversen <jani@libreoffice.org> Tested-by: jan iversen <jani@libreoffice.org>
2017-02-22loplugin:unusedfieldsNoel Grandin
Change-Id: I8a114bcda99f123d230d61b0d0595bfe657cc3c0 Reviewed-on: https://gerrit.libreoffice.org/34513 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21Remove unused function. Following tdf#105657Laurent Balland-Poirier
Change-Id: I7890d76b35bcf5eb9a965fb90ae1a106913548e8 Reviewed-on: https://gerrit.libreoffice.org/34506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-02-21make every menu id uniqueCaolán McNamara
instead of every id within each menu so submenu ids are not shared by an id in the parent Change-Id: Ic94794b5c461307b79969472e9fb24d11c96ca53
2017-02-21improve loading submenus from .uiCaolán McNamara
Change-Id: Ida5382bffa3cee55ffa64fd50d3733a178afa639
2017-02-21Move INetMIME::getHexDigit(int to its only place of useStephan Bergmann
Change-Id: I8d02a51a0da5aad4cd95e15fe6bb329b43e32067
2017-02-21tdf#106052 Treat SubFormat for "Precision as shown"Laurent Balland-Poirier
Get precision from the correct subformat Change-Id: I458e5b3d1fb515864f19499ac9ac529e1d68a267 Reviewed-on: https://gerrit.libreoffice.org/34505 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-02-21fix KDE buildNoel Grandin
after commit 0649622956431e0a1955cb80d1175025401ab5e5 "loplugin:unusedmethods" Change-Id: Ia9ef3f8c1e64397a350656a3addc1b2a67f0b118
2017-02-21Translate German variable namesJohnny_M
This is to follow up on the commit 9bbc168c29d3f48839d40173f5467228ce9a7268 by: - Changing "Comma" to "DecimalMark" - Changing "VorComma" (literally "before comma") to "BeforeDecimalMark" Change-Id: I3eff7024df56c701ac721a1e74645c8be764bff4 Reviewed-on: https://gerrit.libreoffice.org/34429 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-21loplugin:unusedmethodsNoel Grandin
Change-Id: I52a9f16f3ed543a3c83ca111df70e3f7ae1ef33c Reviewed-on: https://gerrit.libreoffice.org/34508 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21Kill bitrot Emscripten experimentKhaled Hosny
Change-Id: I1cd5331157e684afb01e6555168ce646194c6ff2 Reviewed-on: https://gerrit.libreoffice.org/34493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-02-21Remove wrong and broken encoding from INetMIMEMessage::SetHeaderField_ImplStephan Bergmann
INetMIMEEncodedWordOutputSink had been intended to encode (non-ASCII) content of a "free-form text" header field as per RFC 2047. It used a heuristic trying to detect already encoded words (=?...?...?...?=) in the input, to pass them through unmodified. (Arguably, it could just as well have encoded them, assuming they were meant to be genuine input.) However, that heuristic had a bug ever since 8ab086b6cc054501bfbf7ef6fa509c393691e860 "initial import", going from STATE_FIRST_EQUALS to STATE_FIRST_EQUALS instead of STATE_FIRST_QUESTION, rendering the heuristical detection logic effectively unused. Instead of fixing the bug, 6e12729f715f142140d220dc7d3b28a4a0657016 "remove unused enumerator from EncodedWordState" and b8d8fb3f0cf4a961bbff54523eaca1a4f8179c7a "convert EncodedWordState to scoped enum" crippled the code further by removing any reputedly unused cases. But the only remaining use of INetMIMEEncodedWordOutputSink is in INetMIMEMessage::SetHeaderField_Impl, encoding MIME-Version, Content-Transfer- Encoding, Content-Type, and Content-Disposition header fields. And none of those headers have any "free-form text" content that should be encoded as per RFC 2047. The first two have fixed ASCII-only content ("1.0" and "7bit", "8bit", etc., respectively), while the latter two have structured content that may contain parameters of arbitrary content, which must be encoded according to RFC 2231 (but currently isn't). And the only place where such arbitrary-content parameters are generated is in the two calls to SetContentTransferEncoding in forms/source/component/DatabaseForm.cxx. (The calls to SetContentType there and in tools/source/inet/ itself are all known to have unproblematic ASCII-only content.) So mark those two places with TODOs about the missing encoding (which had been missing since forever) and, in INetMIMEMessage::SetHeaderField_Impl, liberally convert the content to 8-bit via OUString::toUtf8 for now. Change-Id: I4b2a219b396953b219ca66441a5227157a35951f
2017-02-21loplugin:subtlezeroinit: comphelperStephan Bergmann
Change-Id: I6b97583d9bdc0d0f8c059d0fbc9e3f41f822bf3b
2017-02-21remove unused enumerators from WindowTypeNoel Grandin
Change-Id: I1e100302dd60ebbcdf187cf30befe0c767c6d6b8 Reviewed-on: https://gerrit.libreoffice.org/34474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21remove unused OBJ_DUMMY from SdrObjKind enumNoel Grandin
Change-Id: I953c81cf477fddf0f136b3b03a6682c962850deb Reviewed-on: https://gerrit.libreoffice.org/34471 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>