summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2017-07-03C++11 remove std::unary_function bases from functorsJochen Nitschke
std::unary_function is deprecated since C++11 and removed in C++17 90% done with regexp magic. removed obsolete <functional> includes. The std::unary_function base class was used in 3 places: * chart2/source/tools/DataSeriesHelper.cxx: lcl_MatchesRole is used in a std::not1 function helper who uses the members return_type and argument_type. - replace deprecated std::not1 with a lambda * chart2/source/tools/ModifyListenerHelper.cxx: lcl_weakReferenceToSame used the argument_type member in the operator() parameter. - inline the parameter type. * xmloff/source/chart/SchXMLExport.cxx: lcl_SequenceToMapElement used result_type and argument_type in operator(). - inline the types Also fix compile error with gcc about finding std::for_each. Change-Id: I073673beb01410c3108e7d0346d9e7d6b9ad2e2f Reviewed-on: https://gerrit.libreoffice.org/39358 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-07-03loplugin:unusedfields in svxNoel Grandin
Change-Id: I027b70ee92ab07eb68452457c3ee45de3ad22c8b Reviewed-on: https://gerrit.libreoffice.org/39412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-03use sal_Int64 in tools::DateTimeNoel Grandin
instead of long which has platform-dependent bitlength Change-Id: I888458d7807027e237772940d4b2cc15c2971243 Reviewed-on: https://gerrit.libreoffice.org/39434 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-03use sal_Int32 in tools::DateNoel Grandin
instead of long, which has platform-dependant length (32bits on windows, 64bit on everything else) Change-Id: I9b5a950f56dad99a016b481c221bfd103ffa3911 Reviewed-on: https://gerrit.libreoffice.org/39433 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-02loplugin:casttovoid: canvasStephan Bergmann
Change-Id: I2b719ff5fc03a74ba0f657351343462aaa9c7296
2017-07-02loplugin:casttovoid: comphelperStephan Bergmann
Change-Id: I28752323d31320141a537c0e108c911cef09c10a
2017-07-02loplugin:casttovoid: cppuhelperStephan Bergmann
Change-Id: I70a8f00b5ec9d100185d2865bcf54ce96c93adc3
2017-07-02loplugin:casttovoid: vclStephan Bergmann
Change-Id: Icdc9d009849f2a93f6e1dbba07b1042dbb1ff561
2017-07-02loplugin:casttovoid: xmloffStephan Bergmann
Change-Id: I4f9ffd686e8e5a10bdd3f5ad4282dc4776923b62
2017-07-02looks like namespace syntax does not work like I think it doesLionel Elie Mamane
Change-Id: I891bcc49a03ccb6c248065819f0cbbb5cd44d191
2017-07-02tdf#108789 and others: overhaul DBase files encoding handlingLionel Elie Mamane
- Calc: make the complete "what encoding to use" decision before calling the connectivity driver, so that the driver has no ambiguity about whether it should override our setting or not. To this end, factorise the part of the driver that reads the encoding from the file header into dbtools. - Calc: don't ask for encoding when the file's header give the encoding. - don't confuse CP850 (the default) and "don't know", including: * don't ignore CP850 user setting * don't overwrite user setting with CP850 Thanks to Julien Nabet for the extensive collaboration on this. Change-Id: Id80b7c505858b88f717b0ce6bd890527909e5fd1
2017-07-02tdf#45904 Move Java XCellAddressable test to C++Jens Carl
Change-Id: Ib68c7dd8087f19bd969cf5273c3a6e8664c6bb62 Reviewed-on: https://gerrit.libreoffice.org/39348 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-07-02notify the clipboard terminate listener before any other terminate listenerMarkus Mohrhard
Otherwise we may have destroyed a service that is needed to generate one of the clipboard formats requested by the system clipboard. Change-Id: Id05de3ac569e3ed38cd97efc4c48326bc6a8db0b Reviewed-on: https://gerrit.libreoffice.org/39429 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-07-01tdf#108622: use correct type for last check timestamp during autocorrectAron Budea
It's only supposed to check the files once every 2-mins, with mismatching type that happens each time. Change-Id: Ie9243cf928d952e28989dd981508de86cb7dbddb Reviewed-on: https://gerrit.libreoffice.org/39428 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-30loplugin:unusedfields in toolkit..xmloffNoel Grandin
Change-Id: I4964ff97e0a1735dc08c6ad204cae0b08e9ffc2c Reviewed-on: https://gerrit.libreoffice.org/39406 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-30EditEngine: Changing export selection for copy/pasteVarun Dhall
Change-Id: I6f52f30eff76de5f0d641271ce3ea36ced572cc4 Reviewed-on: https://gerrit.libreoffice.org/39083 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-30tdf#108863 svx: fix use-after-free in SdrEditView::DeleteMarkedObj()Michael Stahl
The sdr::ViewSelection has multiple vectors with pointers to the same SdrObjects, and those are only cleared in sdr::ViewSelection::SetEdgesOfMarkedNodesDirty(), so deleting SdrObjects that are marked must be delayed until after that is called. Change-Id: I7ab18cb2116164a71dce29bf10eca974061ab424
2017-06-29Added find function to FastAttributeList:Mohammed Abdul Azeem
It returns a FastAttributeIter, which can be used to obtain value in different formats directly. Also, avoids one unnecessary iteration. Change-Id: Ic28e0177100738bbd71a3a89634cae9f1f7ee996 Reviewed-on: https://gerrit.libreoffice.org/39380 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-06-29improve refcounting lopluginNoel Grandin
to find ref-counted classes being managed via other smart pointer classes. Hopefully prevent needing fixes like 642ae256ea5b8083ba0b3c097ca8ea52304b9cdb "ChangedUIEventListener is refcounted, mustn't be helt by unique_ptr" Change-Id: I6b0c5f8f87ce3546a8a1104ce1000470c09459bd Reviewed-on: https://gerrit.libreoffice.org/39378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-29Using range-for instead of iterator loop:Mohammed Abdul Azeem
It's much easier to write and looks cleaner. And this doesn't affect performance, I think. Change-Id: Ia946b068979b9cef04ac2479c9179a70b6775dea Reviewed-on: https://gerrit.libreoffice.org/39370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mohammed Abdul Azeem <azeemmysore@gmail.com>
2017-06-28Watermark: tdf#91687 correct size in the .docSzymon Kłos
Export: * Watermarks saved using Writer were very small in the MSO. Export fUsegtextFStretch property in the Geometry Text Boolean Properties. * tdf#91687: SnapRect contains size of Watermark after rotation. We have to export size without rotation. Import: * When import set height depending on used font and width. Text will keep the ratio. Remember the padding for export. * added unit test * introduced enum to avoid magic numbers for stretch and best fit properties. Change-Id: I3427afe78488d499f13c543ca401c096161aaf34 Reviewed-on: https://gerrit.libreoffice.org/38979 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-06-28SvXMLEmbeddedObjectHelper::Create bDirect parameter is unusedStephan Bergmann
...ever since 63d13cb2ee2c4725599714f6184bcd6e77a1eab7 "#87246#: OLE object support through SAX interface" Change-Id: Ib1d63a3a6adf64e2b5d3a16df5a7c6473d46abfb Reviewed-on: https://gerrit.libreoffice.org/39364 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-06-28Fix typosAndrea Gelmini
Change-Id: I59777c29fe20f112327ce28a1c0b9cdd2f60857c Reviewed-on: https://gerrit.libreoffice.org/39354 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-27-Werror=shadow (GCC 8)Stephan Bergmann
> include/o3tl/lru_map.hxx:70:24: error: declaration of ‘iterator’ shadows a previous local [-Werror=shadow] > map_iterator_t iterator = mLruMap.find(rPair.first); > ^~~~~~~~ > include/o3tl/lru_map.hxx:61:29: note: shadowed declaration is here > typedef list_iterator_t iterator; > ^~~~~~~~ Change-Id: Ic0f8ab4609a06b713ffa6e8e9fdd04f0c42869d7
2017-06-27Using fast tokens directly:Mohammed Abdul Azeem
Replacing integer-to-integer mapped tokens with fast Tokens direcly for branching. Adding a macro XML_ELEMENT that combines namespace and element tokens. Change-Id: I8701c8af9607392843460fe726bffb6556cf9b33 Reviewed-on: https://gerrit.libreoffice.org/39275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-06-27xmloff: remove obnoxious ## usage from XML_NAMESPACE macrosMichael Stahl
So we can finally grep these things. Change-Id: I7ab4d0c82d8abf3fad4063321fc73772a7a6cb8d
2017-06-27xmloff: remove duplicate XML_NAMESPACE_##prefix##_IDX macrosMichael Stahl
Why do we need 2 identical constants? Change-Id: Ib969f9b9583261f26fe65e04f183bdfabcb9eefe
2017-06-27Fix typosAndrea Gelmini
Change-Id: If4373f47fdf0ccfcbd490299f8b8d09e17bf92cd Reviewed-on: https://gerrit.libreoffice.org/39272 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-27tdf#108809 Message boxes: Add more descriptive window titleSamuel Mehrbrodt
E.g. 'Error' for error boxes instead of just 'LibreOffice 6.0' Change-Id: I7142d15e9219a2aa6733523887cdf43b50200b7b Reviewed-on: https://gerrit.libreoffice.org/39284 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-27gpg4libre: Show error message when signing failsSamuel Mehrbrodt
Change-Id: I58f3febaaaaa225952e87ad3f092950ace37d15d Reviewed-on: https://gerrit.libreoffice.org/39283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-27loplugin:useuniqueptr in variousNoel Grandin
extending it to find places we can use std::unique_ptr on arrays Change-Id: I9feb1d12d738d6931e752ecb6dd51cbc1540c81b Reviewed-on: https://gerrit.libreoffice.org/39255 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-26tdf#39674 Translate some German variable namesJohnny_M
This translates "Neu..." to "New..." in names of some variables. No functional change is intended. Change-Id: I29859ecdd44e15820414746cd2b39f62cdfc0ae3 Reviewed-on: https://gerrit.libreoffice.org/39213 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-26ChangedUIEventListener is refcounted, mustn't be helt by unique_ptrStephan Bergmann
Fixes c0ce1ec3736be861a2ed58827fadb25269ab0117 "loplugin:unusedfields in sfx2 part1" part on "fix a memory leak in NotebookbarTabControl where it was not freeing it's m_pListener field", which now caused ASan to report heap-use-after- free during CppunitTest_sw_dialogs_test. Change-Id: Ic0209650692a34abd1ee451713615a03ed9c746f
2017-06-26Fix typosAndrea Gelmini
Change-Id: I2ce725f87ee6f8ebcffbac268cc7e7f8850023e5 Reviewed-on: https://gerrit.libreoffice.org/39232 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-26s/catched/caughtNoel Grandin
Change-Id: I7ea6977a9749e86f8058b78cdb91cd2c62da8264 Reviewed-on: https://gerrit.libreoffice.org/39164 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25make some tools macros into functionsNoel Grandin
in the process, eliminate the need to explicitly specify the source/destination type at the callsites. Change-Id: Ie556645791a479989fb737933f1dd58e8533cb1c Reviewed-on: https://gerrit.libreoffice.org/39171 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25fix constants used before definitionNoel Grandin
ERRCODE_AREA_SO and ERRCODE_AREA_SBX were being referenced before their definition., by ERRCODE_AREA_SVX_END and ERRCODE_AREA_SO_END Change-Id: I51af1752290479adf0985746253134a0924b1e17 Reviewed-on: https://gerrit.libreoffice.org/39150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25vcl: delete fake copy ctor and assignment operator of TextEngineJochen Nitschke
Change-Id: I9db651d2d9763aca8c70c1a313bab8d7d4d73e10 Reviewed-on: https://gerrit.libreoffice.org/39228 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25svx: pass struct by const reference ...Jochen Nitschke
and use references instead of pointers for output parameters. Change-Id: Ib91a821ff84e464639aa6f09a44ba00301f1d783 Reviewed-on: https://gerrit.libreoffice.org/39220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25osl: document pipe functionalityChris Sherlock
Change-Id: I1b2fa0db88bf9b25283ff532f9634eb4605775c3 Reviewed-on: https://gerrit.libreoffice.org/39221 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-06-25osl: variety of doxygen fixesChris Sherlock
Change-Id: I48e4bcce447a1efdb37d6dca9e5808ec8d73492b
2017-06-25osl: document and group code via doxygenChris Sherlock
Change-Id: I9945df95e14fbca47f7cea80b1d4097d00a3eb54
2017-06-25osl: doxygen parblockChris Sherlock
Change-Id: Ica1b604484c855a94c9a21fab04d62c2f5952fe7
2017-06-25osl: remove @relates Condition, not relevantChris Sherlock
Change-Id: Ifabb961817b8c3cc326264bb9d9bb1c3a4e7e461
2017-06-25osl: the addr parameter of osl_mapFile is [in,out]Chris Sherlock
Change-Id: I29992bfecf50b5e6a185257b3df404bb474dd225
2017-06-23simplify some string handling in tracing callsNoel Grandin
Change-Id: I0fb76562429e691400a02216019c7f96791cf9b3 Reviewed-on: https://gerrit.libreoffice.org/39159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23Fix typosAndrea Gelmini
Change-Id: I1348be80d3150966124a7f62134ecf3df01c659e Reviewed-on: https://gerrit.libreoffice.org/39158 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-23loplugin:unusedfields in accessibility..comphelperNoel Grandin
Change-Id: Ifb68d65fc3e48dd80e3ff2b7a4124468fdda1695 Reviewed-on: https://gerrit.libreoffice.org/39137 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23loplugin:unusedfields in desktop..editengNoel Grandin
Change-Id: Ieea12d0790a1034eba8975fe74fa205f02003b7d Reviewed-on: https://gerrit.libreoffice.org/39134 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23inline some ERRCODE_AREA aliasesNoel Grandin
and drop unused ERRCODE_AREA_OFA_END constant Change-Id: Ic34ecda7f842c5db93807b3f21aa1062966ca523 Reviewed-on: https://gerrit.libreoffice.org/39089 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>