summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2023-02-22osl::Mutex->std::mutex in OSQLParseNodesContainerNoel Grandin
Change-Id: Ie47589a454799494bc150eec1e135c8948eb7fbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147420 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-22MCGR: Adapted GradientLinear to make use of MCGRArmin Le Grand (allotropia)
Added to make GradientLinear work using the MCGR as 1st of six types. Had to do quite some tickeling to get it all work, but looks good. Five more to go, already started to put some things to tooling to make re-usable for the other types. Besides adapting this the main change is that the adaption of defined step-count (versus automatic) has to be done in modifyBColor now instead of the back-mapping methods (e.g. getLinearGradientAlpha). It is still 100% backward-compatible, so as long as there is no source using this it will stay invisible - by purpose. I started to do quite some tests (and fixes/ adaptions in consequence), see the static variable nUseGradientSteps. If you want to play with this, you might set it to '1' instead of '0' and use a linear gradient on an object. Change-Id: I9d61934defb0674456247f2879f0a89b6a5e50f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147413 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-02-22Extend LOKit API with functionality to extract a request and paint thumbnailsTor Lillqvist
Original author was Mert Tümer. Change-Id: I181a9955bcce1d5ee4c81e2a52445ef318dc4823 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147396 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-02-22BaseMutex->std::mutex in CommandDispatchNoel Grandin
Change-Id: Ic73a84eb793d45e1041698e45e2c844a1e2f2f66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147415 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-21tdf#152921 add uitestJim Raykowski
Change-Id: I6d3e6d8503c23549b04f5aaace6a90de9f3ced5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145522 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-21Resolves: tdf#148047 don't move focus if dropdown is activeCaolán McNamara
a bit of a corner case, for the popover gtk sets the focus in two steps, one to null, then to the final widget, not in just one step. On seeing the interim null case we assume that focus was lost and set it to the parent, which causes the popover to be dismissed while it's still appearing. Workaround this by ignoring the grab to parent while the popover is active. Change-Id: I1bdef51731bf714de2df93fbe6694e9ed3e366d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147411 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-21tdf#142783 consider the Calendar Edit and DropDown as one compound controlCaolán McNamara
for the purpose of notification of loss of focus from the control Change-Id: I9191b413978549c6f8e1775dc96a696059150e4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147398 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-21replace RES_TITLE_CHANGED and RES_DESCRIPTION_CHANGED with SfxHintsBjoern Michaelsen
Change-Id: I8342722dc4235508c86683fd292bd525247a9910 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147134 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-02-21osl::Mutex->std::mutex in FmSearchConfigItemNoel Grandin
Change-Id: Ic7d805f05f906a1f61ad958d33de0102d6835a36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147380 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-21osl::Mutex->std::mutex in FmXGridPeerNoel Grandin
Change-Id: Ib0796a86f864ab0a1a1b99183668f486a8a8f198 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147381 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-21Related: tdf#153752 Use virtual method to avoid dynamic castsMike Kaganski
Change-Id: I97c09d82699621d5a43a525b5f2cf75ff5d131c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147353 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-02-21tdf#153752: SbxObject::Execute: extra characters in Option Compatible modeMike Kaganski
Change-Id: Ib3e4bd9eb9a249123a686f2434ded7b529fb050f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147345 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-02-20tdf#132110 page ids might not be state idsCaolán McNamara
Change-Id: I9f8946acbcf593e9adf6d31631b82cdafcd3f472 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147327 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-20BaseMutex in oox::core::FilterBase is unusedNoel Grandin
Change-Id: Ie101a45c435ce10136761dd210d927a4b271507c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147339 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-20osl::Mutex->std::mutex in ucbhelper::FdInputStreamNoel Grandin
Change-Id: I10482c3a5f9848f45463837d5d8982476b3910a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147340 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-20VBA: Remove conversions in writer from OORGBTOXLRGB (XLRGB is actually BGR!)Hannah Meeks
Enum to store if document is Writer or Calc because font colors are treated differently depending on this: In writer the colors come in as RGB but in calc they are in BGR and both palettes are in RBG so we only need this conversion for calc. Includes testdoc for calc - to show this still works Change-Id: I79d9d585dbfc527c0781543ce1f1095c4db190b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144788 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-02-19osl::Mutex->std::mutex in BasePrimitive3DNoel Grandin
Change-Id: I49e196885845f352c6c4cda6e3890b749d4eb0fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147263 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-19fix locking in OMultiTypeInterfaceContainerHelperVar4::diposeAndCloearNoel Grandin
where I forgot to relock at the end of the method And sprinkle some asserts around to catch mistakes like this in future Change-Id: I4908ac0ffdfe33b1b5cf1b02e6765f20973af841 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147296 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-19Fix error compiler error with VS2019 C2487Andras Timar
e.g. 'GetLibCount': member of dll interface class may not be declared with dll interface Change-Id: I4856d0848447ca04747015015af4147b28c2f188 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147278 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-02-19osl::Mutex->std::mutex in OWeakEventListenerAdapterNoel Grandin
Change-Id: I3ebd6cfdb8ff76b2d1988c3c481ef4effa5c2964 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147262 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-18osl::Mutex->std::mutex in DefaultGridColumnModelNoel Grandin
Change-Id: Ie3df092b013f10b36c85028fe3b9966d58b22005 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147264 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-18osl::Mutex->std::mutex in OGenericUnoControllerNoel Grandin
Change-Id: If49864f3127b185bb0212be02abd0f92e14c3908 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147261 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-18osl::Mutex->std::mutex in dbaui::OAsynchronousLinkNoel Grandin
Change-Id: Ida29c113db891b260ebc2b6d0d4638cb5224eac6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147231 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-17Add Saraiki {skr-PK} [0x06B0] to language list, CTL, RTLEike Rathke
Change-Id: I2bc1462acbcc69023586333a4c6b10ba415e5ca2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147233 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-02-17tdf#147739: Medium is not a synonym of normalKhaled Hosny
For some reason, medium was thought to be a synonym of normal, but that is not the case. Seems to be from: commit b05701988492b051b3bb07bb46ae0397e23f032f Author: th <th@openoffice.org> Date: Fri Mar 9 14:44:26 2001 +0000 #83090# - Extensions for localized sytle names #77189# - FontAlias should now also work Extensions for Chinese fontsize numbers Change-Id: Ic5e463b6e77c0fa88701108597c99c9fa0c6bf4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147258 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2023-02-17tdf#149756 tdf#152545 PPTX import: position of standard connector - part2Tibor Nagy
and add new compatibility option "ConnectorUseSnapRect". Standard connectors (bentConnector3, bentConnector4, bentConnector5) are improved. MSO calculates the edge track differently, so have to add "ConnectorUseSnapRect" compatibility option: - For PPTX file format, it is set to true and use the snap rectangle - For ODP format, it is set to false by default and use the bounding rectangle. Follow-up to commit eec48130271188cab63665acedbabf1ff5e850a2 "tdf#148926 tdf#151678 PPTX import: position of standard connector - part1" (bentConnector2) Change-Id: Icca84708d6e10d44ebf7262415d055ce9cfc157d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146162 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-02-17SfxViewFrame* arg of SfxRequest ctor always dereferencedCaolán McNamara
change it to take a reference Change-Id: Ib9349f4c2660d297d93ee81256e7fa9873728ba3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147163 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-16Only specialize CppUnit::assetion_traits<T>::toString member functionsStephan Bergmann
...not the whole CppUnit::assetion_traits<T> classes (where applicable). That avoids spelling out the (identical) equals member functions, and also leaves around the less and lessEqual member functions, in case they want to be used after all. Change-Id: I18f8d6cff0353921ced4952b33a0c85ff8292923 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-16SfxRequest::GetMacroRecorder arg is always derefed before passedCaolán McNamara
so null can never be seen in the function Change-Id: Iebe25ca26aa3f2105e4e20a0742c6cccbbf8b182 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147150 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-16HasMacroRecorder can take a reference, never passed nullCaolán McNamara
Change-Id: I213f2d93e49f03e88a5357af8fead32b97b2c37b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147149 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-16SfxViewShell::GetViewFrame never returns null, change to a referenceCaolán McNamara
various null checks can be seen to be redundant and removed Change-Id: Icf49c1de4b0302795d2769a370af3abceaad0221 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147147 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-16set visibility of classes in mergelib+asan caseAndras Timar
Change-Id: I2eb80d0b3002f174deea0d8657cb0cdbdec5be8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147144 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-02-16SfxViewShell never takes a null SfxViewFrame*Caolán McNamara
Change-Id: I36f3a5c77a7fb2d3cf267184e403e6cd24dbd70b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147112 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-16no need to lock when accessing m_pInstance hereNoel Grandin
as noted by mkaganski, this field is valid until the object destructs, so no need to take a lock Change-Id: Id0b9a1a26391d4e971bd0b37b9d6e1b1a20e163a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147136 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-15MCGR: Add GradientSteps to GeoTexSvxGradientArmin Le Grand (allotropia)
Move GradientSteps data to GeoTexSvxGradient and adapt interfaces. Also move tooling to more isolated place in gradienttools in basegfx. Keep everything still compatible, the work will be now to adapt all six different derivations of GeoTexSvxGradient to make use of the evtl. given GradientSteps. Change-Id: Iaa212763c603d46de0a94b1b203b979bb7ce359d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147050 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-02-15new comphelper::SingletonRefNoel Grandin
to replace salhelper::SingletonRef, but using a std::mutex instead of an osl::Mutex Change-Id: Ibf88a3778f47300c08b8ec9ee58ed24eb83aed7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147046 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-15replace RES_GRAPHIC_PIECE_ARRIVED and RES_LINKED_GRAPHIC_STREAM_ARRIVEDBjoern Michaelsen
- also use SfxHintIds and get rid of some dynamic_casts Change-Id: Id12d72fb726c1d747008f72defd6ba9eba3ba253 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146820 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-02-15tdf#153559: Untranslatable string in safemodedialog.cxxJulien Nabet
Change-Id: I35bccb70bef74b6438c2744f693aff6d1842e894 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146830 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-02-15osl::Mutex->std::mutex in LockFileCommonNoel Grandin
Change-Id: I729b7ecf8280c67e4698b174a6151d1eda41be60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147040 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-15osl::Mutex->std::mutex in SvxShapeNoel Grandin
Change-Id: I4b2d13dcd87f49cb73e7239102498629239005d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147036 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-14no need to use unique_ptr for OInterfaceContainerHelper4Noel Grandin
it has an empty size of one pointer, so it saves no memory to use unique_ptr. Need to fix the const-ness of some methods in OInterfaceContainerHelper4 Change-Id: I0c0c28a228ccfe0e97174fbc83555059fc351b3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147007 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-13enforce proper locking when calling OInterfaceContainerHelper4Noel Grandin
Change-Id: Ic86305f3d16148925c7753200a687f36f08a6516 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146936 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-13tdf#143148 Use pragma once instead of include guardbuldi
Change-Id: I6fa77335ced02442eec69b0dbb088505eb4b1aa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146818 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-02-13These const_casts are unneededMike Kaganski
Change-Id: I4b1d81665f9bfeb040530bac6bafa3ee2c85782f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146849 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-02-12Fix typoAndrea Gelmini
Change-Id: Ia21de983bd4295f399e9753c29bc2a3cace2f250 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146835 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-02-12Fix typoAndrea Gelmini
Change-Id: I51b5c88e1d82c596b926e7074ee3a7e1395a21a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146834 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-02-12MCGR: Add/Provide GradientSteps to FillGradientAttributeArmin Le Grand (allotropia)
MCGR stands for MultiColorGRadient. This change allows/ prepares adding multiple color steps to gradient rendering. This is preparation work to allow rendering MCGRs in the future. All places are adapted in a way that currently no change of behaviour will happen. It will be the base to get MCGR rendering/decompose for Primitives and our internal/existing gradients working. Change-Id: I28bbd7d10b8670042343ada2a66b5909d3d31bbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146748 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-02-09ofz#55798 TimeoutCaolán McNamara
Change-Id: Ifbff597d02da9b870ef936bdcca31e31d49cbf58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146684 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-09re-apply "optimize ConfigurationProperty::get()"Noel Grandin
This reverts commit 05b2bfc289df8712097cc1e640bf7d3bc6b86a84, but adds clearing of some more members, which were holding onto references to bits of config data after the config service was disposed. Change-Id: I9969ee2472445e4e1dbe8ea15e081401845ad29c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146605 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-08tdf#153229 add a switch to override honoring system dark modeCaolán McNamara
Change-Id: Iafb6182e05dc65d20d0809476ee58908f7426d39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146597 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>