summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2014-10-16Strip svidl down to what is still usedStephan Bergmann
...the generated .ilb, .lst, and .sid outputs requested by SdiTarget were apparently unused. Change-Id: I1abb2abc7945070451fce4a98a11d955515e3f63
2014-10-15coverity#735333 flush out pointless calls to IsRemote and IsOpenCaolán McNamara
etc. Change-Id: I588d4486071b1e31897d4e6468a2c634d6856832
2014-10-15SfxMedium::IsRemote can be made constCaolán McNamara
Change-Id: Id6b14366d11c15ec1440482cfb725e497807fa2e
2014-10-15Blind Win fix attemptStephan Bergmann
Change-Id: I39df464321685ebef29f44221bab9005295d0c3f
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15loplugin: cstylecastNoel Grandin
Change-Id: I0ccdd2ce18336afea67a3f296b26b2de50f14808
2014-10-15fdo#84938: replace SYMBOL_TYPE constants with enumNoel Grandin
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51 Reviewed-on: https://gerrit.libreoffice.org/11983 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-15avoid double-deleteDavid Tardon
This is a regression from commit b1d48f0d9a3442c11adae6e36325a463d89ce44e. Change-Id: Iffd39782c1d1fd7be14f4d657919f704807a40f5
2014-10-15remove unused DECL_OBJHINT and IMPL_OBJHINT macrosNoel Grandin
these have been unused since we switch to using normal C++ RTTI with the SfxHint subclasses Change-Id: Ia271cfa01d2f49ed335e90f78309cd26d6ec9d8f
2014-10-15nDrehWink -> nRotationAngleMiklos Vajna
Change-Id: I33ca88f38210140931b12a05e426d1373243156e
2014-10-14Missing ModelessDialog -> ModalDialogStephan Bergmann
Change-Id: I83a3eb34138c75dbc5a0239a9d761d22c6cd98a0
2014-10-14fdo#75757: remove inheritance to std::mapTakeshi Abe
from UniqueIndexImpl. Change-Id: Iaa9040dff117ed5b05955c9f6eef31878dccf3b0 Reviewed-on: https://gerrit.libreoffice.org/11951 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-14Resolves: fdo#72587 make template dialog ModalCaolán McNamara
Change-Id: Iefb63bc7cdbff2217f16c1a72fc271361227588b
2014-10-14do not forward-declare templatesDavid Tardon
Change-Id: I3b0a145f70406f0c8a12b6c4b7876c4148f76e93
2014-10-14basebmp: accelerated method to create a clipping device.Michael Meeks
This was some staggering proportion of tiled rendering documents with complex clipping; it seems 'clear' is not what memset is for 1bit clip masks. Change-Id: I9142ffb7d7016603feb7782d6f03b9992b9494e3
2014-10-14Make -1 a valid value of enum MSO_SPTStephan Bergmann
...as e.g. CppunitTest_sw_filters_test under -fsanitize=undefined complains > svx/source/customshapes/EnhancedCustomShapeTypeNames.cxx:304:13: runtime error: load of value 4294967295, which is not a valid value for type 'const MSO_SPT' > EnhancedCustomShapeTypeNames::Get(MSO_SPT) svx/source/customshapes/EnhancedCustomShapeTypeNames.cxx:304:5 > SdrObjCustomShape::MergeDefaultAttributes(rtl::OUString const*) svx/source/svdraw/svdoashp.cxx:873:26 > SvxCustomShape::createCustomShapeDefaults(rtl::OUString const&) svx/source/unodraw/unoshap2.cxx:1933:26 > non-virtual thunk to SvxCustomShape::createCustomShapeDefaults(rtl::OUString const&) svx/source/unodraw/unoshap2.cxx:1934:1 > oox::vml::CustomShape::implConvertAndInsert(com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, com::sun::star::awt::Rectangle const&) const oox/source/vml/vmlshape.cxx:976:9 > oox::vml::ComplexShape::implConvertAndInsert(com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, com::sun::star::awt::Rectangle const&) const oox/source/vml/vmlshape.cxx:1073:12 > oox::vml::ShapeBase::convertAndInsert(com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, oox::vml::ShapeParentAnchor const*) const oox/source/vml/vmlshape.cxx:307:22 > oox::shape::ShapeContextHandler::getShape() oox/source/shape/ShapeContextHandler.cxx:432:27 > non-virtual thunk to oox::shape::ShapeContextHandler::getShape() oox/source/shape/ShapeContextHandler.cxx:545:1 > writerfilter::ooxml::OOXMLFastContextHandlerShape::sendShape(int) writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:1742:48 > writerfilter::ooxml::OOXMLFastContextHandlerShape::lcl_endFastElement(int) writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:1769:9 > writerfilter::ooxml::OOXMLFastContextHandler::endFastElement(int) writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:249:9 > non-virtual thunk to writerfilter::ooxml::OOXMLFastContextHandler::endFastElement(int) writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:250:1 > (anonymous namespace)::Entity::endElement() sax/source/fastparser/fastparser.cxx:484:13 > sax_fastparser::FastSaxParserImpl::callbackEndElement(char const*) sax/source/fastparser/fastparser.cxx:1216:9 > (anonymous namespace)::call_callbackEndElement(void*, char const*) sax/source/fastparser/fastparser.cxx:295:5 > doContent (instdir/program/libexpwraplo.so+0x369381) > contentProcessor (instdir/program/libexpwraplo.so+0x34d9ee) > doProlog (instdir/program/libexpwraplo.so+0x330991) > prologProcessor (instdir/program/libexpwraplo.so+0x32a1f6) > prologInitProcessor (instdir/program/libexpwraplo.so+0x38d185) > XML_ParseBuffer (instdir/program/libexpwraplo.so+0x31359b) > XML_Parse (instdir/program/libexpwraplo.so+0x30f34e) > sax_fastparser::FastSaxParserImpl::parse() sax/source/fastparser/fastparser.cxx:1058:52 > sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) sax/source/fastparser/fastparser.cxx:852:13 > sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource const&) sax/source/fastparser/fastparser.cxx:1339:5 > non-virtual thunk to sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource const&) sax/source/fastparser/fastparser.cxx:1340:1 > writerfilter::ooxml::OOXMLDocumentImpl::resolve(writerfilter::Stream&) writerfilter/source/ooxml/OOXMLDocumentImpl.cxx:500:13 > WriterFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) writerfilter/source/filter/ImportFilter.cxx:107:9 > non-virtual thunk to WriterFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) writerfilter/source/filter/ImportFilter.cxx:173:1 > SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) sfx2/source/doc/objstor.cxx:2271:21 > SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:767:23 > SwFiltersTest::filter(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, unsigned int, unsigned int, unsigned int, bool) sw/qa/core/filters-test.cxx:112:20 > SwFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, unsigned int, unsigned int, unsigned int) sw/qa/core/filters-test.cxx:71:12 > test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, unsigned int, unsigned int, unsigned int, bool) unotest/source/cpp/filters-test.cxx:111:24 > test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, unsigned int, unsigned int, unsigned int, bool) unotest/source/cpp/filters-test.cxx:137:5 > SwFiltersTest::testCVEs() sw/qa/core/filters-test.cxx:162:5 Change-Id: I8249f962585def8c98327cce9939e2b96b648612
2014-10-14Resolve some unnecessary typedefsStephan Bergmann
Change-Id: If57e32d41fe03db402aad74d2bd3e4d03c5e0643
2014-10-14Reintroduce SFINAE-based selective enablement of &=, |=Stephan Bergmann
...they had erroneously become unconditionally enabled. Also, rename Self to Wrap. Change-Id: I574662012bf74114b18f3bab0c1c5825a2bd61bb
2014-10-14fixes and tests for o3tl::typed_flagsNoel Grandin
create test suite for typed_flags template. fix the operator&= and operator|= definitions Signed-off-by: Stephan Bergmann <sbergman@redhat.com> Conflicts: include/o3tl/typed_flags_set.hxx Change-Id: I1df9ae197889af98a2fd76ff2bc07756c7b14ced
2014-10-14Remove commented out codeStephan Bergmann
Change-Id: I1ebcffc9f1b77b9491335c13ca99090385882ec3
2014-10-14No apparent reason to fix underlying type of PushFlagsStephan Bergmann
Change-Id: I7d578b135c7a1e681a70484bba30ff1e8b33e04d
2014-10-14Work around missing std::underlying_type in GCC 4.6Stephan Bergmann
Change-Id: Ic641fe2f1771fe979423c58d285a96399ea16fe2
2014-10-14fdo#84938 - replace LIST_ACTION constants with enumNoel Grandin
Change-Id: I21c05ada0a793b1e3ddf87481e66b60b83529767
2014-10-13fdo#84213 Add show/hide ruler to sd context menuSamuel Mehrbrodt
Change-Id: Iee42ab31a82ed4459f956706cef513afcf70ef94
2014-10-13oox: refactor embedded media importMichael Stahl
Currently the oox import creates a temp file and leaks it, and there is no way to clean it up afterwards. Unfortunately it turns out that SdrModel has no way to access the imported OOXML storage, so add a really ugly hack to get the embedded media into the SdrMediaObj by setting both MediaURL and PrivateStream properties (currently oox really wants to set the properties in alphabetical order too...) Change-Id: I5a235fbeb08e7bc17faf066de52b94867e9a79a2
2014-10-13build error: specialization in different namespaceCaolán McNamara
Change-Id: Ic1730a49576a663a2e04a2386bd3962a21b6fc48
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-13vcl: Make ImplFontCharMap a pImpl and move functions to FontCharMapChris Sherlock
To do this, I've made FontCharMap a friend class for ImplFontCharMap, and have moved the functions directly into FontCharMap. In this patch, I am attempting to stop the direct use of ImplFontCharMap by anything other than FontCharMap. However, FontCharMap itself requires a refcounter, so we will use FontCharMapPtr to access the font character map. Change-Id: I509b990a8cbd911c5cc1572c7d24fc5348ca06d9 Reviewed-on: https://gerrit.libreoffice.org/11823 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-10-12RTF filter: fix \acc* handlingMiklos Vajna
The exporter didn't write circle and underdot at all. Change-Id: Ia8f45f2b03fb14e9a0027ec24ee7f36adc8c018d
2014-10-12Typo: compatability->compatibilityJulien Nabet
Change-Id: If0b98a30452a9d1fcc340173deb6856755926471
2014-10-11convert SFX_CALLMODE constants to SfxCallMode enum classNoel Grandin
and fix a couple of bugs in SC and SW where the call mode was being passed to the hints parameter by accident Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58 Reviewed-on: https://gerrit.libreoffice.org/11916 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11convert vcl StateChangedType to enum classNoel Grandin
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11fdo#75757: remove inheritance to std::mapTakeshi Abe
from oox::core::Relations. Change-Id: If2e0109a2ad6598436177b7638cb6d568fb2d3d6 Reviewed-on: https://gerrit.libreoffice.org/11899 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-11move the removeTree function from desktop to unotoolsMichael Stahl
Change-Id: I98d3f4a68abfee42dac987633878b850134671d3
2014-10-10Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happyStephan Bergmann
Change-Id: I4add22edf2bcfe9c1d5ef1641eabee08d402191d
2014-10-10Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happyStephan Bergmann
Change-Id: Id535824a9429576a469cf88d9bdbb6b53c5e314b
2014-10-10Use better castsStephan Bergmann
Change-Id: Ibcf2d715ac306bd4bedae716ad82c614f136d1bc
2014-10-10coverity#1244953 Uncaught exceptionCaolán McNamara
Change-Id: I3c4aeb3318af7cdb964128dd78f7d2cfba48000e
2014-10-10cid#1244949 Uncaught exceptionNoel Grandin
Change-Id: Ic33d60a435ee875e8e342420046aae436739c123
2014-10-10move TRANSPARENT #define from windows.h out of global namespaceNoel Grandin
so it doesn't conflict with enums Change-Id: Ic4143130762d6e878d7c23276393ba09d9f86d45 Reviewed-on: https://gerrit.libreoffice.org/11880 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-09vendorplugin.h is jvmfwk-internal (and no need for extern "C")Stephan Bergmann
Change-Id: I954f789d5850e8016f5900812f9aa99be2416ce4
2014-10-09Remove unused JVMFWK_DLLPRIVATEStephan Bergmann
Change-Id: I9b562e085e0b2a446a16ff5189c1d6b03c0d924b
2014-10-09Remove jvmfwk plugin featureStephan Bergmann
...which was effectively unused; there only ever was a single sunjavaplugin that is now folded directly into jvmfwk. Leaves room for further clean up. Change-Id: I14dd2a3a09bd1ce9a8c3f5c156628ec11d954a0b
2014-10-09UNO_JAVA_JFW_PLUGIN is long goneStephan Bergmann
...since e7f7d511a3ad39faef431bdfc2a79fa090d0b5f7 etc. "INTEGRATION: CWS jl15: #i37828# removed support of bootstrap parameters UNO_JAVA_JFW_DISABLE and UNO_JAVA_JFW_PLUGIN" Change-Id: Ia70fa9919b4b55e8b13473602cfca723f554ec30
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-09typo: Lable -> LabelAndras Timar
Change-Id: I8b9e9f75dd22ee5bff678c5bc0e1fa9381a103de
2014-10-09remove SvRefBase::QueryDeleteNoel Grandin
Move it's functionality into the only place that needs it, in the dbase driver. Removes an extra virtual call from a widely used class. The dbase driver seems to be using to perform some kind of whacky object recycling, so it's not like we want this functionality to be used somewhere else. Change-Id: I41018f71e0b0a79fdd3d527536f0ac95c788e614 Reviewed-on: https://gerrit.libreoffice.org/11786 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-09Improve wording on several actionsSamuel Mehrbrodt
* "More Styles" (Styles dropdown) * "More Fields" (Insert field dropdown and menu) * "More Options" (Table dropdown) Change-Id: I593a1d1dd68e666d05a4ac20ae97308ad45ff18e
2014-10-08coverity#706283 Uncaught exceptionCaolán McNamara
Change-Id: I2c3f10894ffe514dbc71cd1dd672685aa8f09a0d
2014-10-08fdo#75757: remove inheritance to std::vectorTakeshi Abe
from SvxMSDffShapeOrders. Change-Id: Idf551f1fbde907759d6a296141e2837264dbbb10 Reviewed-on: https://gerrit.libreoffice.org/11840 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-08-11 09:48:46 +0000