summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2015-07-07fix deselect of textbox on slides with images in underlying masterCaolán McNamara
The original work of tdf#55430 tries to select an object under another one on the second click, but these images are unselectable so this fails. Red Hat has a whole new shiny bunch of templates which have such images in their masters. Check if the object is selectable before continuing (cherry picked from commit abbe4f9d64073d77c4be93b7c89c03d0651bacef) (cherry picked from commit 4189530530320a82adc785a4426735423a1188c1) Change-Id: I182abaf50e8bb1084c5819dc9e1ffd8b386a9e93 Reviewed-on: https://gerrit.libreoffice.org/16742 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-07-07tdf#92431 Keep thumbnail for modified but unsaved docMaxim Monastirsky
A regression of 1166966eb4112fdf332c656eae5082d82a3ec2f2. We need to consider 2 use-cases: 1. Protecting an existing document with a password (by overwriting the original file). In this case we don't want to generate a thumbnail from the now encrypted file, but we do want to erase the stored thumbnail and show a generic icon instead. 2. Closing a modified document without saving the changes. Here we don't want to generate a thumbnail either, because it may contain the unsaved changes, but either we don't want to replace the stored thumbnail, because most likely it correctly represents the last saved state of the document. Conflicts: sfx2/source/appl/newhelp.cxx sfx2/source/appl/sfxpicklist.cxx Reviewed-on: https://gerrit.libreoffice.org/16659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit d9c476bfbb4a8f1858c072d2fba33aa9e8e0ae92) Change-Id: Ia7b1f3dbc9fbbc2ef1d87442c1dee25306f65826 Reviewed-on: https://gerrit.libreoffice.org/16765 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-07-07tdf#87348 implement nonsequential and mso-next-textbox textbox chainingJustin Luth
Change-Id: I017049a8f3578ad4c2a1f549be1c683f98c20318 Reviewed-on: https://gerrit.libreoffice.org/16691 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-06-23LinkUpdateMode is a global settingStephan Bergmann
(cherry picked from commit 77cc71476bae2b3655102e2c29d36af40a393201) Conflicts: sw/source/core/doc/DocumentLinksAdministrationManager.cxx sw/source/filter/xml/xmlimp.cxx Change-Id: Ida1257337c6e0916f2228fe053d9c9f085183af6 Reviewed-on: https://gerrit.libreoffice.org/16422 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-06-20tdf#88290 Adapt the numbering popup to more than 8 itemsMaxim Monastirsky
The items count of NumberingTypeMgr is limited by 8, but some languages have more items, so remove that limitation. Also fix the behavior of the 10th item. The old sidebar popup had a "None" item, whose id was 10 (defined by DEFAULT_NONE from include/svx/nbdtmg.hxx), and that causes now the 10th item to behave as on/off toggle. Since we don't have a "None" item anymore, get rid of that behavior completely. Conflicts: include/svx/nbdtmg.hxx (cherry picked from commit 71b35212265bb93b10ca35ab964a36e6b6cc552b) Change-Id: I5546ca637f9951cc093a7bbf8fda11dc35341d4e Reviewed-on: https://gerrit.libreoffice.org/16337 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-06-18tdf#88295: Don't export transparent background colour as whiteKatarina Behrens
The fix is twofold: 1. retrieve transparency from colour in SvxBackgroundColorItem (add QueryValue, PutValue methods, use additional memberID to retrieve alpha channel as a bool property) 2. add CharBackTransparent bool property to Draw [text] shapes, xmloff needs it to be able to output 'transparent' string instead of '#XXYYZZ' colour code in ODF format Conflicts: include/editeng/colritem.hxx Change-Id: I6e14b81cc82f6b4d7fdd4756ff2e4f75e9270361 Reviewed-on: https://gerrit.libreoffice.org/16243 Reviewed-by: Muthu Subramanian K <muthusuba@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15Resolves: tdf#89643 report builder function wizard segfaultsCaolán McNamara
regression from commit 3d6521280929ecacc53b7c358d29d0b5d31b3462 CommitDate: Thu Jul 31 22:14:25 2014 +0200 fix memory leak around function descriptions Found by Lsan. There are two implementations of getCategory, one (sc) returns a new one each time (hence the leak fix) and the other (reportdesign) returns a pointer to one that belongs to the manger (hence the crash). The code in formula really looks to me to expect that the getCategory return a pointer that "someone else" needs to look after, i.e. the reportdesign variant is the more correct so revert 3d6521280929ecacc53b7c358d29d0b5d31b3462 and to fix the leak make the sc own the ScFunctionCategories and just cache them like the reportdesign one does Change-Id: Ifd986301a54b4d20449e864697655cd973e0c4df (cherry picked from commit 7c3abee29c742593206b755b20a718c46f0780fa) (cherry picked from commit 73107eb3375f1671f549f0467be2812df9223848) Reviewed-on: https://gerrit.libreoffice.org/16232 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-06-09tdf#78854 do not crash when undoing layout changeDavid Tardon
It turns out that the ordinal number adjustment that was added for fdo#34548 is no longer necessary. Change-Id: I2c491a008500b6a269b6f05a2a72f5aa70edecb2 (cherry picked from commit c0117fcb3dbd6c2a8d5e7679ee8d6fb29264ff6b) Reviewed-on: https://gerrit.libreoffice.org/16152 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-08tdf#90804 Revert "remove unused values from SfxFieldUnit enum"Andras Timar
This reverts commit b78d881520f2eb658180e2c90ffee3d30a80f0ae. Change-Id: I68340831d2397b1d3e2fc44c07ba01bacdd93162 Reviewed-on: https://gerrit.libreoffice.org/16162 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-05-27tdf#88056: Implement ODF import/export of page title fieldKatarina Behrens
to/from loext namespace, since new tag's needed for the new field and it isn't approved by ODF-TC yet Change-Id: I70ceb4e16e1199663520dbdf3beae31423bc81d0 Reviewed-on: https://gerrit.libreoffice.org/15485 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-05-05Avoid redefine of TRANSPARENT on solaris after including stream.hRichard PALO
Change-Id: I90611a4855320148f1d4b6e61a420ada47308c28 Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit e4f10cb0e12e7965df5e469cc22e6893044cabc3) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-04-30rhbz#1213173: connectivity: Calc driver: prevent document being disposedMichael Stahl
... by adding a XCloseListener that vetoes any attempt to close it. The Calc document can be opened by the user in the UI and closed again. (cherry picked from commit 7368b6ca3f61e750765f42e97d0a00e10fcac516) Conflicts: unotools/source/misc/closeveto.cxx Change-Id: Ied427b67274d925c911e516c0a50a4c0b2b18db9 Reviewed-on: https://gerrit.libreoffice.org/15567 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-04-13Resolves: tdf#90384 queue_resize needs to Invalidate the optimal cache sizeCaolán McNamara
but the PanelLayout didn't (cherry picked from commit b39a6449d5debc7cdf55c3f967b441f3de4d50f3) Conflicts: svx/source/sidebar/PanelLayout.cxx vcl/source/window/dockwin.cxx vcl/source/window/syswin.cxx Change-Id: I38a8975f1488fa2a2ffe91b66745e1a1c6c48a28 Reviewed-on: https://gerrit.libreoffice.org/15215 Tested-by: David Tardon <dtardon@redhat.com> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-04-08Resolves: fdo#84795 Menus don't disappear with right mouse clickCaolán McNamara
re-do this so right-clicking when a menu is open closes that menu but doesn't cause another popup menu or otherwise pass that click through to the app Revert "fdo#84795 Menu, DropDown-List don't disappear with right mouse click" This reverts commit fa022a9c4fe74f3f67fb3c35ef49022842d7499b. because if a right-click context menu is active and we click outside it in order to remove it then that click goes to whatever is underneath the mouse which is undesirable the list dropdown part of this looks good, its the general menus that are the problem Conflicts: vcl/source/window/winproc.cxx (cherry picked from commit 473eae3a7d43ca13ef14eca844b991ffd143e3a0) Conflicts: vcl/source/window/winproc.cxx Change-Id: Ib96e52f22cdeefd59dbf4333f555d9f52b3385e2 Resolves: fdo#84795 Menus don't disappear with right mouse click Change-Id: I95ae2e2d564ec1c45de6df5158e4dec1d93053cb (cherry picked from commit 4f9e20c46b616c7c51bae74bfefd5247f922b2a6) why would we ever want FLOATWIN_POPUPMODE_PATHMOUSECANCELCLICK if we're from the menubar we never set it, but if we are a submenu from a menu in the menubar we set it. with it set, and on right click, the right click is passed through to what ever is underneath the pointer I don't see why we want to do that, especially the inconsistency from e.g. the File menu, vs the "File->New" menu Change-Id: I548f5c95e2511b5e921e8b74600f65eecdd8f498 (cherry picked from commit a8f9dd59de4e655bc77fa0546b81440aee46b837) remove the gap now to pretend it was never there Change-Id: I234defd865e6bf5d9d9eccc85cde7e69c0549c3f (cherry picked from commit a62d7f3b08b413d17e650279110ab8a48c419b18) Reviewed-on: https://gerrit.libreoffice.org/15092 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-04-08Resolves: tdf#89885 use a readonly GtkEntry for locationCaolán McNamara
Change-Id: I324d5e0776da942eae62984b96951d9947702b49 Reviewed-on: https://gerrit.libreoffice.org/15137 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-03-17detect MSO 2007 OOXML documentsMarkus Mohrhard
Change-Id: I4052c6f1e5dde71ce4cede1ec9a313f461861d71 Reviewed-on: https://gerrit.libreoffice.org/14877 Tested-by: David Tardon <dtardon@redhat.com> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-03-02More improvements of graphic cache size handlingZolnai Tamás
* ImplFillSwappedGraphicObject method is part of the old caching mechanism which interferes with the newer one, so remove this method. * Use Graphic size directly becuase in some case it does not match with the GraphicObject's size. * Assertions to avoid underflow of mnUsedSize Change-Id: I3381f49ca05e3e5d565848c8af24c78e7b9ac3af (cherry picked from commit ab00ac3e88e0a28d0e38c5968c23014a6a8fb194) Reviewed-on: https://gerrit.libreoffice.org/14699 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-02-26SkipImages option for PDF importMihai Varga
This option allows images and drawings to be skipped while importing a PDF, the main reason was performance improvement where images were not needed. And I've also added unit tests for it. Change-Id: I6595d3ff22d5389eab4fe8450460d083f626d216 Reviewed-on: https://gerrit.libreoffice.org/14628 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-25-Werror,-Winconsistent-missing-overrideStephan Bergmann
(cherry picked from commit d7e92309239e6da60bd13b984ffaace8b4ef638e) Conflicts: include/vcl/floatwin.hxx Change-Id: Ib1445e9c66c08044434c7e8c828d2fc7b6a0a04c
2015-02-23file UCP: Ensure myLocalTime is initializedStephan Bergmann
When a file's time is epoch (1970-01-01 00:00:00, i.e., TimeValue temp is all zero) and the TZ is UTC or westward, osl_getLocalTimeFromSystemTime returns false and leaves myLocalTime uninitialized. That e.g. confuses getModuleByUrl (scripting/source/pyprov/pythonscript.py), potentially re-loading a Python script with epoch time (as happens e.g. for the share/Scripts/python/ files in an xdg-app installation of LO) every time it is accessed, falsely assuming it has changed on disk since last load. Change-Id: I8d4228feb28e2697a7021e3488ae2c09e8439ed8 (cherry picked from commit 94c9206399954d018aae8a1bd4e4b33354b9cdaf) Reviewed-on: https://gerrit.libreoffice.org/14587 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-19implement fill based on style also for chart area, tdf#89451Markus Mohrhard
Change-Id: I7b488e222cd44e75d1e0ff7f8e545e9399f418b5 better way to set default for chart area fill style, related tdf#89451 Change-Id: Iee7fea0f55cf54d43a349b6cc0ffa25995069e40 no need for that anymore Change-Id: I53002c0b97da66c44429b5ace0fc709b5e8a325f Reviewed-on: https://gerrit.libreoffice.org/14547 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-17Resolves: tdf#88792 do not hold a ScFormulaCell** in group area listenerEike Rathke
... as the mdds storage segment may change when a formula cell is inserted at a position such that two segments are merged into a new one. (cherry picked from commit 47230a036fe35b9a7a7c0609232849fcbb51efcc) add some SAL_INFO to group area listener and formula cell ctor/dtor guess we'll need them more often.. (cherry picked from commit f8d6640afa3c8528d2a66741edc49a48c67902d3) let have FormulaGroupAreaListener a virtual dtor (cherry picked from commit 0fafb53d1c860388461f30e613a37c128c90ad79) 0ef149fc5edceee765419764bf0efa571ba9d977 1f5e246d68971124ef21e9c2d0db80499928998b Change-Id: I449a89005418aff7ea12099ea931b786959dbc3b Reviewed-on: https://gerrit.libreoffice.org/14332 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-17fdo#81596 export to OOXML that need argument changesWinfried Donkers
Reviewed-on: https://gerrit.libreoffice.org/10831 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 4feaf96f50fa89eccb4e7a638220099e9a8482f1) sensible indenting, fdo#81596 related (cherry picked from commit 3dd241c52d6db424bd4696ff8f223976542e411b) simplify RewriteMissing() and switch in Add...(), fdo#81596 related (cherry picked from commit 14aabee5a73e57e26b2062b1ebf00c3f1dff1250) write TRUE() for 2nd IF() parameter, fdo#81596 related (cherry picked from commit 8f031861f590ba914321816657a003375d93ef5d) f7eb11a950b45793d04837d02f9546a93673fa2f f2ca37e1fda87ce56282fc2d2fc57a0784851139 52d0b43b19e10bee82109b635b3b7ce4f43650a3 Change-Id: I3a99e416be9f3f04175939e4560f8f7c55497185 Reviewed-on: https://gerrit.libreoffice.org/14388 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-17Resolves: tdf#86159 floating windows have complicated bordersCaolán McNamara
take the border window dimensions into account on the layout size, but not the layout position (cherry picked from commit d1f38b47c29ef5e2db2cabeb657668637d97e13d) Conflicts: include/vcl/syswin.hxx Change-Id: I9deb722933e325c92e93ae917fa8e34eaccfca2d Reviewed-on: https://gerrit.libreoffice.org/14480 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-02-17tdf#78174: toolkit: work around GCC 4.9 -Os link failureMichael Stahl
A build with gcc (GCC) 4.9.2 20141101 (Red Hat 4.9.2-1) for 32-bit x86 fails because of these undefined symbols: > nm --demangle workdir/CxxObject/svx/source/fmcomp/fmgridif.o | grep \\bWindowListenerMultiplexer::acquire U non-virtual thunk to WindowListenerMultiplexer::acquire() They should probably be generated inline. Work around by out-lining the definition of the methods. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64812 Change-Id: I318f7c39bdf1243be385bc6dc0a47862b22e92c5 (cherry picked from commit 6b3aa0fe4094e87290bd33a30bd6cd99ee78ce38) Reviewed-on: https://gerrit.libreoffice.org/14509 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-02-12fix linker errorDavid Tardon
/builddir/build/BUILD/libreoffice-4.4.1.1/workdir/CxxObject/svtools/source/misc/imageresourceaccess.o: In function `com::sun::star::uno::Reference<com::sun::star::io::XOutputStream>::Reference(com::sun::star::io::XOutputStream*)': /builddir/build/BUILD/libreoffice-4.4.1.1/include/com/sun/star/uno/Reference.hxx:137: undefined reference to `non-virtual thunk to utl::OSeekableOutputStreamWrapper::acquire()' Change-Id: Ic644a8299cf2f79f02c1e3ca0de9687520f402a9 (cherry picked from commit 8bb0446974282b32d06cdbd35af83f91e033b4af) Reviewed-on: https://gerrit.libreoffice.org/14437 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-09tdf#47577 Zoom slider should only react to full clickRodolfo Ribeiro Gomes
Change-Id: If859754c956a634a96066ac407b70d6dd2759d53 Signed-off-by: Rodolfo Ribeiro Gomes <libo@rodolfo.eng.br> Reviewed-on: https://gerrit.libreoffice.org/14265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 53740bd71a0ae569da36b9293ef22842a0b53f1e) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-02-03Query Design: use correct name for columns that come from another query.Lionel Elie Mamane
Change-Id: I25b4ccdc2f50ba89687e1f4c871f286251a28e21 Reviewed-on: https://gerrit.libreoffice.org/14232 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-03Resolves: fdo#87639 Image-filter Smooth crashesCaolán McNamara
regression from commit 10e77ab3ff6f4314137acd6e2702a6e5c1ce1fae Author: Thorsten Behrens <thb@documentfoundation.org> Date: Sun Nov 2 22:37:32 2014 +0100 coverity#1242508: swapped arguments rename the variables to indicate which are source and which are dest indexes and that the aNewBitmap argument is always, and assert that it must be, of equivalent rotated source to the Bitmap which has ImplConvolutionPass called on it. Change-Id: If9715b9f29655da66c6981c0f7cab3d89c528ed7 (cherry picked from commit 4b9ecfd4f45501e4696f966c714fc2bcc43ce38b) Reviewed-on: https://gerrit.libreoffice.org/14115 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-28make it possible to easily have variants of glsl programsLuboš Luňák
Now it's possible to add a preamble to the compiled program, so there can be just one program with #ifdef's inside and the small variants can be selected using #define in the preamble instead of having several almost identical programs. Change-Id: I6c5112313b91b6269ebdecdfc896e0f96209ea2b Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-28prefer ptr_container to manual memory managementMarkus Mohrhard
Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Conflicts: vcl/source/opengl/OpenGLContext.cxx Change-Id: I11326c2873aad5116fd70bfa31eb94e93fef3f40
2015-01-28use constructor initializer listMarkus Mohrhard
Change-Id: Ieede6dec05f63ed0fa1dde376b2e89c381601cd6 Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-28some debug code for finding leaked OpenGLContextsMarkus Mohrhard
Change-Id: I10e8c344ae6aa2e0a4ef562154f57e2070c70e2f Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-27font cache gets broken on adding an embedded fontCaolán McNamara
Change-Id: I665cde5d4c89443238efb283c86277dedf621197 (cherry picked from commit 20142afafc809890d5e8dcfd4103c46319a488df) Reviewed-on: https://gerrit.libreoffice.org/14045 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-21fdo88632: Make the Calc random functions non-random when requestedTor Lillqvist
We don't want such a mode to affect other uses of randomness, though. Thus use a separate random number generator object for these two functions, and use a fixed seed for it if the SC_RAND_REPEATABLE environment variable is set. As RAND() is implemented in sc, and RANDBETWEEN() is implemented in scaddins, it was a bit hard to figure out where to add the new functions needed, without having to over-engineer things with UNO. (This functionality is totally Calc-specific, but neither sc nor scaddins has any public (non-UNO) API.) Caolan suggested the formula module, which seems like a good enough place to me. Change-Id: Ic1c9ca165278d53036598b03b13b4ffbdc98a75e Reviewed-on: https://gerrit.libreoffice.org/14053 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-19Resolves: fdo#32664 pass keyboard media keys through to the OSCaolán McNamara
if we didn't make use of them. (cherry picked from commit 508c020cf5f7999f0c23d972133f9b6bf85de245) Conflicts: sw/source/uibase/docvw/edtwin.cxx vcl/osx/salinst.cxx vcl/win/source/window/salframe.cxx Change-Id: Iee1c2fef5966a614b068c832bf8c6b51973b4c8a Reviewed-on: https://gerrit.libreoffice.org/13993 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-19fdo#88475 BrowseBox/grid: reposition data cursor to current row after paintLionel Elie Mamane
Squash with (from master): fixup previous commit: OSL_ENSURE does not execute in non-debug builds (and is deprecated). Do not try to seek back if paint did not seek. This happens in particular when there is no data source attached (and thus trying to seek fails). Change-Id: I3f4908c4dcae2bb120bf58c1218e3386c40d5721 Change-Id: I0deee2c3cfdb111b178c4254d7b0544c4ce5c966 Reviewed-on: https://gerrit.libreoffice.org/13953 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-19use supersampling in Impress if fast opengl scaling is availableLuboš Luňák
So far it's been always disabled, with the exception of the slide preview extension. Change-Id: Iaee6fe2d5267c9dfdc31cbf4fb90a9ac0e08e781 Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-19rhbz#1136013: svx: try to make the ExternalToolEdit not crash all the timeMichael Stahl
This thing was starting a timer that re-starts itself forever, and when the file it was watching changed, it would just assume the drawing objects were still there (and the document, for that matter...) (cherry picked from commit 5f6bdce0c0ac687f418821ce328f2987bf340cda) Conflicts: sc/source/ui/drawfunc/graphsh.cxx Change-Id: I35f187f0828097a05618dc1733dce819fc6bffc6 Reviewed-on: https://gerrit.libreoffice.org/13995 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-19-Werror,-WuninitializedStephan Bergmann
(in CachedPrimitiveBase ctor: base class 'comphelper::OBaseMutex' is uninitialized when used here to access 'comphelper::OBaseMutex::m_aMutex') Change-Id: I30855a80ad9dbc3fa90e45d51d2a02794033f2f1 (cherry picked from commit 1f94761288ad5bb1319bb32f845586bbc8c6d1b9)
2015-01-17no need to do that for all contextsMarkus Mohrhard
This fixes a crash as we would need to make each context current before calling ReleaseFramebuffers. However this is totally unnecessary as only the current context can have bound framebuffers. Change-Id: I8b1496bb890982742b3d2ebf60fdce47db642d70 Reviewed-on: https://gerrit.libreoffice.org/13973 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-16Revert "never wonder if sun is not sun"Stephan Bergmann
This reverts commit 06a5b619a76c96783ee67bdcfd21f203d3ddb53c, which broke Solaris/Illumos builds for no good reason, cf. mail thread starting at <http://lists.freedesktop.org/archives/libreoffice/2015-January/065844.html> "4.4.0.1 build error on sal/types.h on solaris/illumos." Signed-off-by: Michael Stahl <mstahl@redhat.com> Conflicts: include/sal/config.h Change-Id: I063453ee1115ae3f97e2835828800c74e3cb5e48 (cherry picked from commit 234e45bf1d27484b72e73fe327b1e92fda1933f1) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-01-16Silence unhelpful -Wpotentially-evaluated-expressionStephan Bergmann
...on Clang trunk towards 3.6, firing for typeid(*e) where e is a side-effecting expression (of polymorphic pointer type). Simpler to disable it via #if in sal/config.h than to disable it in solenv/gbuild/platform/com_GCC_defs.mk with an additional feature test in configure.ac. Change-Id: If94692a9e06ff2659bf168b4968200aeee9ebb0a (cherry picked from commit d1a74c273d10e6ab228acac2b8ebc151362a41b3) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-01-12Resolves: fdo#87015 image missing from docCaolán McNamara
regression from commit e0cce521f1ad0cc384d30ce2f1077ea229fffe62 Author: Armin Le Grand <alg@apache.org> AuthorDate: Thu Jan 10 16:28:40 2013 +0000 Commit: Caolán McNamara <caolanm@redhat.com> CommitDate: Thu Jun 13 14:50:46 2013 +0100 Resolves: #i121504# Support for alpha channel in clipboard for all systems (cherry picked from commit ef3931ff410117e1237b3bef7bc090e8b83b9519) which blindly just bulldozed out the bMSOFormat branch Change-Id: Iec354f1fb585f0803b9df472bc9ec9e103aa5847 (cherry picked from commit 470fcca594ba4f6bf473d4d44b415c2ba151b0d9) Reviewed-on: https://gerrit.libreoffice.org/13874 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2015-01-07Resolves: fdo#82219 color graphics as black and whiteCaolán McNamara
i.e. revert commit bb5c7d6a79309236d4f19bb2498f2e850f735a2f Date: Sun Apr 13 01:42:27 2014 +1000 fdo#38844 Reduce XOR clipping for gradients Removed XOR clipping version of ClipAndDrawGradientMetafile. Because it has been removed, the other version isn't really needed in it's own function so I've moved it back into DrawGradient. Change-Id: Ib1519a019061c8c71183db63e5c11681bcad4cc4 Change-Id: Iff1cb48cb8fa6d29937cf228a57aea9e8072110c (cherry picked from commit e2883ca86f747eb62d1fe9e9b8d115c689e3abd7) Reviewed-on: https://gerrit.libreoffice.org/13773 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-01-07vcl: reset OpenGLContext(s) when yielding the last SolarMutex.Michael Meeks
This should make OpenGL thread-safe to allow multiple threads to render using VCL's OpenGL backend, and fix misc. associated driver horrors, will give some performance cost for tight Yield loops. Change-Id: Ib23702262fd9f0925a5ed8c642d0a26e92136b37
2015-01-05I assume this class is not public due to an oversightDavid Tardon
Change-Id: If43e49dc05ad213cbbf6363dfa68a7a93959582f (cherry picked from commit 02266c33f23cd9fa59b73db3ef88e32c24106587) Reviewed-on: https://gerrit.libreoffice.org/13750 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-05bnc#822341: PPTX export of embedded text documentsZolnai Tamás
-Make embedded text documents exported by analogy with spreadsheet embedded documents. -Convert MS ole objects to LO sepcific objecst to allow exporting those ole objects too. Plus use gb_CppunitTest_use_rdb instead of wasting time on finding out which missing components cause test failing. Especcially when we have platform dependent components (e.g. related to embedded object) (cherry picked from commit 0c3d5fb0ad35ff7fc18917fc86fa58d9312fe3ae) Conflicts: sd/qa/unit/export-tests.cxx ERROR: Attribute 'spid' must appear on element 'p:oleObj'. As pointed out by CppunitTest_sd_export_tests. (cherry picked from commit 124c33dd1d6bf2040f0153de8c9ecaebe759c3bd) ERROR: Invalid content was found starting with element 'p:pic'. Again, as pointed out by CppunitTest_sd_export_tests. Sadly it seems that the spec and PowerPoint is not in sync here, so just do what makes both happy. This fixes the --with-export-validation build. (cherry picked from commit cf15306ccf49da290b391517e2c5dd22a4f1be45) Change-Id: Ic76d659b51274777a1669c215344a1169ebcba81 8ecbc3ef4ea9dc84ebf88506967d02de04ded852 c76d659b51274777a1669c215344a1169ebcba81 Reviewed-on: https://gerrit.libreoffice.org/13600 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-12-19Resolves: fdo#86552 undo want to take ownership of nodes, but can'tCaolán McNamara
Revert "fdo#75757 remove inheritance from std::vector" This reverts commit 63d8977f9fb0618d36dc8e0ee2f8068b1af92fe6. Change-Id: Idc9902a77ee2c1cb21b9e3b477b2d960772a022e (cherry picked from commit 68d87e98951ae3ed5f7b863954667bfdd9805985)
2014-12-16ucbhelper::InteractionAuthFallback::getCode() can be an implementation detailMiklos Vajna
Change-Id: I4967e5e12aa348692b3b954398faede843db381b (cherry picked from commit 26e564db14fcb3c229d30a0d5fe232b3d768343f)