summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2020-04-03tdf#80194 autoEsc: use fontmetrics in calculationJustin Luth
This replaces the previous 7.0 patch in commit 2940d1905b921d9909b08b1e32014d3c44474ef0 where the following is still true: THIS WILL CHANGE THE POSITION OF EDITENG SUBSCRIPTS AND SUPERSCRIPTS IN EXISTING DOCUMENTS! That is because they were very poorly placed before - using a formula that is very different from how Writer does it. Everyone in the bug reports indicates that Writer does it good, but Impress does it really bad. (tdf#89849, tdf#63083). Instead of using the previous patch's 80%/20% generalization, copy Writer's use of the actual ascent and descent of the font to determine the best position for the subscript or superscript. Change-Id: I0f10f6174b0709f3bc3b9acdc54b7b1fd59c5ee2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90489 Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Justin Luth <justin_luth@sil.org>
2020-04-03loplugin:singlevalfieldsNoel Grandin
Change-Id: I69c5b28636806e45d7ba5d8c4678caeda09caa50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91607 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-03loplugin:unnecessaryvirtualNoel Grandin
Change-Id: If50fcacc6710f582281d8030c97c39a5d2201390 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91572 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-02loplugin:virtualdeadNoel Grandin
Change-Id: I5698862e5890d3208bc7012b0ce5b60520797c2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91571 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-02make SvListView::IsSelected take const argCaolán McNamara
Change-Id: I1e6d2ed5b092741499505bdfd65c6a583495204c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91594 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-02loplugin:unusedmethodsNoel Grandin
Change-Id: I906234a38b96c6ba6eaadf7693abd33e98debf50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91567 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-02tdf#79426, tdf#125180 - Don't convert missing parameters to requested typeAndreas Heinisch
If a particular parameter type is requested during the construction of a parameter list, don't convert missing parameters to avoid implicit casting to the specified data type and value of the method. Missing parameters are handled in StepEMPTY, where additional information about missing parameters is added. Change-Id: Ia413b2996d7d1feecedc1dfefaf6baf0fd9d917e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90215 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-01fix ubsan after 7d6c67d323a87f1006d84c2a95b45dfbfb03c0c8Noel Grandin
ubsan exposed some bugs in commit 7d6c67d323a87f1006d84c2a95b45dfbfb03c0c8 Date: Mon Mar 30 15:11:55 2020 +0200 convert enum to scoped in SvBaseLink where I had converted the bit operations incorrectly Change-Id: I85bc0f0d69c34d9d714f983f82d4d26dd967f892 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91484 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-01add SAL_LOG area vcl.skia.traceLuboš Luňák
So that Skia tracing debug output can be disabled selectively (e.g. SAL_LOG=+INFO.vcl.skia-INFO.vcl.skia.trace). Change-Id: Id90c77d90ce871b958429d0fe3e59c9da97b0307 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91469 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-03-31add iter_next_visible to skip unexpanded entriesCaolán McNamara
Change-Id: I64acfc28579135f52ad0021418e863988c05ca94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91431 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-31Introduce comphelper::ValueRestorationGuard extending FlagRestorationGuardMike Kaganski
... to any value type. Change-Id: I808f4729478cb3f90a86ef30be8158ebc40a6b96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91428 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-31Translate German variable namesJohnny_M
Ende -> End Change-Id: Ia3df5ee48e0d61051d99ac93e62c8a6dceafb41d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91218 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-03-31vcl: add doxygen comment for VclBuilderMiklos Vajna
Change-Id: I3faa2752a4d5bfbf75f38c1a4c62eb689158c90a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91409 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-31convert enum to scoped in SvBaseLinkNoel Grandin
Change-Id: Ief399381ac27764fce95ee053c322571a07b671c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91366 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-31Resolves: tdf#131372 Write "error cell" formula to OOXMLEike Rathke
Change-Id: Iedbe0912ff28e6203bec0104c59b1102cf97daf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91382 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-03-30remove Matrix class from basegfx, convert B2DHomMatrix testsTomaž Vajngerl
The common test cases of MAtrix and B2DHomMatrix are just converted into additional test cases for B2DHomMatrix. Change-Id: I8ed2f6d25263797b21a844e209e910a8a3f2a347 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91342 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-29pdfium: fix setting the size of the document when opening PDFTomaž Vajngerl
When loading the pages of PDF, the size of the document was set to the wrong value. Size returned by ImportPDFUnloaded was in pixels, which is not really useful considering the svx and sd core uses 100th mm as the unit and converting it to a device dependent pixel will just bring grief. Also we don't need to know the size in pixels until we actually render. This change removes DPI as the parameter to the ImportPDFUnloaded and changes the code to get the size of the page from the PDF as points and converts that to 100th mm. Change-Id: I0c0db23d2775e2897ba7621ef6320a974c0b9275 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91330 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-29tdf#131632 animation effects are missing featuresNoel Grandin
regression from commit 5352d45dd4a04f8f02cf7f6ad4169126d3b3586a Date: Tue Feb 18 15:45:08 2020 +0200 convert AnimationImport to fast-parser APIs Change-Id: I7227b122213c877b8ea5db25239eae8151597a8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91320 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-29Fix is_typed_flags for SfxStyleSearchBits (svl/style)Julien Nabet
+ fix All and AllVisible enum values and comment Change-Id: I69b8a3d789d7221c9809ea774d09a7350316c262 Change-Id: I169d6c97454bb72552f263af3df6d3dd1e867ec2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91314 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-29OutlinerMode is not a typed_flags, it's not a bitmask (editeng)Julien Nabet
Thank you Noel for having spotted this! Change-Id: I37162504f19b163da570aac3ac27b24e94b9ce47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91306 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-29Fix is_typed_flags for SelectionEngineFlags (vcl/seleng)Julien Nabet
Change-Id: I6f317fc8f986abdd7fb1bb8f3d21983d4bb72349 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91317 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2020-03-29basegfx: Fix the problem with Matrix Concatinate and TransformTomaž Vajngerl
In Concatinate and Transform methods we change the instance variables during calculation (matrix multiplication), which leads to the wrong result. This change fixes both calculations. Change-Id: I9f7ef7323707df1ab4a764f97f9bae8593c42940 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91311 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-29basegfx: add convenience access. and creator to B2DHomMatrixTomaž Vajngerl
In SVG, CSS, HTML Canvas it is usual to define a matrix with a,b,c,d,e,f attributes, where the values correcpond to the following: [a,c,e] [b,d,f] [0,0,1] This change adds accessors and creator to B2DHomMatrix, so it is easier to deal with other matrices that are defined like that. Change-Id: I6927513b1a70ad5eb70d7fe14a00de4a767f176a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91310 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-29add convenience accessors to Matrix.hxxTomaž Vajngerl
Change-Id: Ifaaff3b1526aed111725a46c6cc64c189909a904 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91309 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-29basegfx: export B2DRange operator*=Tomaž Vajngerl
Change-Id: Ia2e72e6650b14d5d024b65b1261876885cf1b05a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91308 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-29Fix is_typed_flags for SvxNumRuleFlags (editeng)Julien Nabet
Since https://cgit.freedesktop.org/libreoffice/core/commit/?id=2b1f0d31c34464bdece4eea158097b3e4923cf5f author Tamás Zolnai <tamas.zolnai@collabora.com> 2017-11-11 18:17:52 +0100 committer Tamás Zolnai <tamas.zolnai@collabora.com> 2017-11-11 20:44:48 +0100 commit 2b1f0d31c34464bdece4eea158097b3e4923cf5f (patch) tree 66fff19490e124a00321590eb5a5ba00ab149714 parent 019e6ae7be38176978943d95fa3b586830e1b3b1 (diff) tdf#111738: Duplicated numbering alignment option on numbering dialog Change-Id: I65defa76c3b325f1cf4d33482216f2663bbb82b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91284 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-29Fix is_typed_flags for EEControlBits (editeng)Julien Nabet
Change-Id: I40b719f58e7c41e33ce68cde217161924de6e3cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91285 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-29Fix is_typed_flags for RegAccessMode (registry)Julien Nabet
Change-Id: I5b58d10eea35652bb201d6153e413ca1aee3c4ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91307 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-29Fix is_typed_flags for SvxMSDffHandleFlags (svx/EnhancedCustomShapeGeom)Julien Nabet
Change-Id: I8947a7b11a67397fdca36fb5087c2c1306b76b1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91315 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-29Fix is_typed_flags for ConfigItemMode (unotools/configitem)Julien Nabet
Since DelayedUpdate removed with: https://cgit.freedesktop.org/libreoffice/core/commit/?id=67ff7348756ec88d09fc00e6d284ba5b579e9b33 author Noel Grandin <noel.grandin@collabora.co.uk> 2018-12-06 10:05:06 +0200 committer Noel Grandin <noel.grandin@collabora.co.uk> 2018-12-07 10:35:44 +0100 commit 67ff7348756ec88d09fc00e6d284ba5b579e9b33 (patch) tree d9bc9015abadce440e6637e280286e04e9ba062a parent 1e6cc2c8564e86465594f6651490f529dafb3aaf (diff) remove unused ConfigItemMode::DelayedUpdate unused ever since commit c1758889cbd5e8e4afb1044425c908715eb3e1cd Date: Fri Nov 11 22:48:37 2011 +0100 Heavily simplified utl::ConfigManager. and rename ConfigItemMode::ImmediateUpdate to NONE, since it doesn't mean that anymore Change-Id: I3f5e5a63cbbc12f15a4af104fc6e007cdf10cab3 Change-Id: Idc4c4f0a90bfce26483f2f4d66b47c263bcb5954 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91316 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-29Fix is_typed_flags for SfxShellFeature (sfx2/shell)Julien Nabet
Since remove of FormTBMoreControls (0x800) https://cgit.freedesktop.org/libreoffice/core/commit/?id=00f96e88a7c6feea98d446e82a2718c5aae6256c author Roman Kuznetsov <antilibreoffice@gmail.com> 2019-03-13 19:18:49 +0100 committer Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> 2019-03-14 08:52:29 +0100 commit 00f96e88a7c6feea98d446e82a2718c5aae6256c (patch) tree 9bff711b6e7b70ede72cd6a9f913a72ac237981e parent c196d70337f6b755cfc4c34beda05554c6fab114 (diff) tdf#112411 Remove all that remains of the More controls toolbars Change-Id: I90bb25b2033374498d4e3306651c4b4024154739 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91313 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-28svdpdf: move Matrix to basegfx just to get it separatedTomaž Vajngerl
Change-Id: I9d887dc7a2836b90151ef352b47a9b9ad3b6f12b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91280 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-28Fix is_typed_flags for EConfigurationModesJulien Nabet
LazyWrite = 4 dropped with cb2550750386f51ef7a46a8a664a4ab9de614f8d Change-Id: Ie14e7c34c681288dec8ff53c77485ab642c1c29b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91278 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-27add text alignment support to treeview entriesCaolán McNamara
Change-Id: I3ebbaf7b722ad9b6f2b8fadb443053ea816d1643 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91147 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-27these methods can take a const argumentCaolán McNamara
Change-Id: I0ec68d40dcc34075c72c0d60d3a4b6e8262a8e0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91152 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-26tdf#130074: add missing translations (line styles part)Julien Nabet
+resorting to follow extras/source/palettes/standard.sod order Change-Id: I3246490578fb4b1af46bfe99b59bbb1e8a36ea8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87792 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-26sd: extend test to check the PDF pages aren't rendered when loadedTomaž Vajngerl
Change-Id: I9e407bb20a00ec620fe3f772f50708f997027942 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91093 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-26extract GetAbsPos for reuseCaolán McNamara
Change-Id: Ida6b70f4166f8b1e19990300a5856ee54556a9f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-25tdf#101181: add sidebar panel for Glow effectMike Kaganski
... in Writer, Calc, Draw and Impress for CustomShapes. The artifacts that become apparent using the controls, e.g. remnants of the effect when decreasing radius (in Impress), or glow not drawn until reload after enabled or radius set to 0, should be fixed in a separate commit. Change-Id: I6107597161bc67ae8c3e62c260ef6ad241c7dedf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91056 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-25ValueSet is still needed from the CppunitTest_svtools_dialogs_tests libraryStephan Bergmann
...at least in a Windows --enable-mergelibs `make screenshot` build Change-Id: Id1168d5c0a4c417144a2d10a9ddc8ff1b33525f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91043 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-25no reason for the FontAntiAliasing setting being UNX-only (tdf#107744)Luboš Luňák
This dates back to the ancient times where no revision control history dares, so no idea why this was so, but it doesn't make sense, as at least Windows can disable AA for fonts too. And if some platform really wants to hide the setting, it should be enough just to hide the UI element, no reason for '#if defined( UNX )' all over the place. Change-Id: I76fc9ad157358321904573079ace5a3fe556f86a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91041 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-03-25Fix typoAndrea Gelmini
Change-Id: I22dad8c614e04da2234746834fffa8365c71d713 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90226 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-24weld writer navigatorCaolán McNamara
GtkToggleToolButton are much wider than vcl equivalents. Split the bottom toolbar into two toolbars. Rearrange their contents so the layout of each level visually match. Notes: Master documents have two modes, master content tree and the normal content tree. You can drag entries from the content tree into the document, drag mode drop down controls whether its a link or a copy etc that's dropped in. Documents can be dropped into the content and global trees. If outline tracking isn't active, then when content changes the tree is cleared and refilled, typically an effort is made to reselect the same entry that was previously selected. Additionally, if the amount of content didn't change an effort is made to scroll back to the location the scrollbar was at before the clear. Change-Id: I00c015145eac5b1acc3398d3c40861d830e4264a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89725 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-24Removed duplicated includesAndrea Gelmini
Change-Id: If00e89686210be5f76208a5e3ff366096f4ac9fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90927 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-03-24Simplify the LibreOfficeKit mobile phone and tablet APITor Lillqvist
There is not need to ever change the kind of device a view is for, so why bother with the bool parameter to setMobilePhone() and setTablet(). Also, make sure just either of them is called, at most once, for a view. Change-Id: I9ac872f0ab4772e4a7c40c49f62b32fa7b1e47f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90968 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-03-24Fix typoAndrea Gelmini
Change-Id: I5a430d2e681b0c95476b4b59ca5281da6a05ee8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90924 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-23Fix typosAndrea Gelmini
Change-Id: Iba46fbe8559211403118a23cd198a2217b333a81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90900 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-23Related tdf#97694 Check Base macro signatures on loadSamuel Mehrbrodt
Change-Id: I45c6eae633c41585c6c7e4c5fff0b187a6dc1f60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90908 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-03-23sw: add pad-to-5 numberingMiklos Vajna
This is the last padded numbering type that is supported by Word but was not supported by Writer. Change-Id: Ica1a0843897c61a4b569105fd21e5bfe7b5012cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90912 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-03-23make more classes private in mergedlibs modeNoel Grandin
Change-Id: I486922d0652f26fa7ee56f5fe308e19fe5ff137e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90856 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>