summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2019-03-28tdf#42949 Fix IWYU warnings in include/sfx2/[e-M]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6e97c7ed6c0211dfafee83b9bdbea672e415fc49 Reviewed-on: https://gerrit.libreoffice.org/69715 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-28return unique_ptr from SdrPage::CreateObjectSpecificViewContactNoel Grandin
Change-Id: I3297128efd44f4df86886d6f0349420d6ce18571 Reviewed-on: https://gerrit.libreoffice.org/69855 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-28tdf#45904 Move XShapeGrouper Java tests to C++Jens Carl
Move XShapeGrouper Java tests to C++ for ScDrawPageObj. Change-Id: I4a1ed4f14f759fa4214141f0d552e35ccae28035 Reviewed-on: https://gerrit.libreoffice.org/69873 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-27move LineListBox beside last consumerCaolán McNamara
Change-Id: Ie683784a9f4ecfb0015bf7ae79769238719a6376 Reviewed-on: https://gerrit.libreoffice.org/69841 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-27Helper to create various drawing::XShapeJens Carl
This ports SOfficeFactory::createShape() from file qadevOOo/runner/util/SOfficeFactory. Change-Id: I2c7eb0304ac1d439211d3851b2debdb4843130e3 Reviewed-on: https://gerrit.libreoffice.org/69772 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-27tdf#60242 remember horizontal/vertical choice in split cells dialogMartin van Zijl
Change-Id: I25f6b7c8ff6aa678b597bbede0dd1492468f2f62 Reviewed-on: https://gerrit.libreoffice.org/65606 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-27loplugin:typedefparam (clang-cl)Stephan Bergmann
Change-Id: I07604028845c49cc084927e21db7f21c5d053bab Reviewed-on: https://gerrit.libreoffice.org/69796 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-27return by unique_ptr from weld_parentNoel Grandin
Change-Id: I3582b3000330fab96f6abef0f412b648b0573af4 Reviewed-on: https://gerrit.libreoffice.org/69793 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-27MSO lockfiles: Deduplicate MSO lock file reading codeTamás Zolnai
The removed code was extracted to MSODocumentLockFile class so use that class here too. Use openStreamNoLock() for reading MSO lockfiles, because otherwise we can not read lock files written by MSO. Change-Id: Ib31cb9f3783d0b0ce784f900821047b9d32156f2 Reviewed-on: https://gerrit.libreoffice.org/69759 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-27Resolves: tdf#123291 set hex input to overwrite by defaultCaolán McNamara
and ensure the modify arrives after the input text has been filtered Change-Id: I16c0bd095700e7d9858e3e74884b5a1ad3eb7e4c Reviewed-on: https://gerrit.libreoffice.org/69764 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-27condition always true in XSpreadsheets2::importSheetToCopyNoel Grandin
leftover from commit ed45c87896de74048708d51c050ecd42c9f4a0a0 Date: Mon Oct 20 21:08:54 2014 +0200 sc: fix temp file leak in ScTableSheetsObj Change-Id: Ic108fb36cc0caccbe57f2b47f7fcbe80156842dc Reviewed-on: https://gerrit.libreoffice.org/69749 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-26Generate MSO lock files when the related MSO compat. option is setTamás Zolnai
Added a new compatibility option to the Tools -> Load / Save -> Microsoft. When this option is set on the UI or or set in the configuration files LO generates lock files for MSO supported file formats, similar to the lock files MSO generates itself. Change-Id: I2f882723841162add01be9d3f7285a5162a60331 Reviewed-on: https://gerrit.libreoffice.org/69678 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-26weld URLDlgCaolán McNamara
Change-Id: I3dd002a97d7c90e62c09f65bfc0333892bbd817c Reviewed-on: https://gerrit.libreoffice.org/69718 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-26weld SvxRubyDialogCaolán McNamara
Change-Id: I32f26b9d3e495e64a38cd8a56e532374dd4891f1 Reviewed-on: https://gerrit.libreoffice.org/69651 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-26loplugin:unnnecessaryvirtualNoel Grandin
Change-Id: I2aa9a8f14b6db2098931a14c6eed522a9d2653ed Reviewed-on: https://gerrit.libreoffice.org/69682 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-26Consolidate declarations of {fire,reap}_glxtest_process in single include fileStephan Bergmann
Change-Id: I7f25cba311d42a7e8751cf3651f684b88d1fb8ac Reviewed-on: https://gerrit.libreoffice.org/69711 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-26loplugin:unusedmethodsNoel Grandin
Change-Id: I8bbf439d69a330a9ad28ff52cc49a9fec2c12500 Reviewed-on: https://gerrit.libreoffice.org/69684 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-26loplugin:unusedfieldsNoel Grandin
Change-Id: I31c953c8e4c1d4ec235ea318d0aa3b7cedaed1a3 Reviewed-on: https://gerrit.libreoffice.org/69683 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-26loplugin:singlevalfieldsNoel Grandin
Change-Id: I4a56a27ebce927b8e21cf37bb2c527caf1317bcc Reviewed-on: https://gerrit.libreoffice.org/69681 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-26Allow irregular feature value structures in feature dialogMartin Hosken
Change-Id: I92df2d47bebb0b0af38f3527881ac65a11d1bb98 Reviewed-on: https://gerrit.libreoffice.org/69643 Tested-by: Jenkins Reviewed-by: Martin Hosken <martin_hosken@sil.org>
2019-03-26tdf#124146 support posting of gesture event for LOKitTomaž Vajngerl
Change-Id: I51845f2e41dbcbe1ae6cb0a18cf9f42d5549968b Reviewed-on: https://gerrit.libreoffice.org/69657 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-26tdf#124146 add (general) gesture event support to VCLTomaž Vajngerl
Change-Id: I766930bb35071442e132b91477cd3d55e8f00f48 Reviewed-on: https://gerrit.libreoffice.org/69655 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-25ubsan detect null derefCaolán McNamara
Change-Id: I78a8c91f2c7493a12f5acb325c3f79efbbfbffcc Reviewed-on: https://gerrit.libreoffice.org/69650 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-25sfx2: missing includeMiklos Vajna
Change-Id: I3778f8e6870c31c15a6c04e720414def47f7fc6c
2019-03-25tdf#42949 Fix IWYU warnings in include/sfx2/[a-D]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I444cb71bc3d045072a4b1f9eed279ed7e425a0d4 Reviewed-on: https://gerrit.libreoffice.org/69481 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-24weld SvxSearchDialogCaolán McNamara
I have to use the other way to specify an a11y role, both are implemented in the vcl parser, but in my gtk3-3.24.7 the role tag crashes the gtk parser, while the other route works fine. The CONTENT_FLOWS_TO accessibility relation is another additional complexity over the norm Change-Id: Ia096bcbe9f00f9944e4e4d5ad9bb1a52d19c7b3f Reviewed-on: https://gerrit.libreoffice.org/69569 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-23Introduce new lockfile handler for MSO like lockfilesTamás Zolnai
* Implement writing of MSO lockfiles * Grab the already implemented parsing code (tryMSOwnerFile method) and put it together into one class * Add tests about the generated URL for lockfiles and the lockfile content * MSO lockfiles are not written yet by LO, next step is to integrate this code into the locking mechanism. Change-Id: I3b0ed1975cd57dfd006d4e1890b23c307890de5c Reviewed-on: https://gerrit.libreoffice.org/69582 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-22tdf#124263 Respect XSidebarPanel::getMinimalWidthSamuel Mehrbrodt
even if it's larger than max sidebar width (increase max sidebar width in that case). Change-Id: I2efbd546596f756df205196fae3e545beddd2f7c Reviewed-on: https://gerrit.libreoffice.org/69551 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-22weld SwFieldDlgCaolán McNamara
Change-Id: I324a581721e01c907113bb3ab1cc91a290bd71a7 Reviewed-on: https://gerrit.libreoffice.org/69475 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-22refactor into a shareable base classCaolán McNamara
Change-Id: I5eb1f2b6b7b2dbc3bc675845730cb3aef1cab5f0 Reviewed-on: https://gerrit.libreoffice.org/69528 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-22tdf#124255 Make maximum sidebar width configurableSamuel Mehrbrodt
Also change the default max width to 500px (instead of 400px). Change-Id: Idece5aadaf4c4165cc873b4605d2c0f026c89c6e Reviewed-on: https://gerrit.libreoffice.org/69545 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-22Fix some doxygen-generated documentation.Christophe JAILLET
Doxygen is misled by the "127." at the beginning of a sentence and converts it to "<ol><li>..." So it is erroneously rendered as: all ASCII characters are in the allowed range between 0 and 1. The ASCII string must be NULL-terminated. Change-Id: If36de7d4df668b5f9e9f6c7ea139552798e349d2 Reviewed-on: https://gerrit.libreoffice.org/69360 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-03-21tdf#121671 Floating toolbars remain their position after reopenIlhan Yesil
Calculate the relative position of the floating toolbars by calling the ImplCallMove function, where the current position is read from the real window. Change-Id: I6a142055c3340dda2339980fbc5a7ebb431e228b Reviewed-on: https://gerrit.libreoffice.org/64093 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-03-21Limit tagging of background objects to imagesKatarina Behrens
i.e. don't tag custom shapes and other than bitmap background fills Change-Id: I1d42012420f59e1e7b62affb8aca5a8c85688423 Reviewed-on: https://gerrit.libreoffice.org/69258 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-03-21Increase the life-cycle of threads in thread-pool...Dennis Francis
to ScDocument lifetime if possible. This helps to avoid lots of thread setup-cost while doing recalcs especially if there are many formula-groups in the document and most of them are fairly light-weight. Change-Id: Idd57e1ebd0d4e492f99e31237d4a55ec9c95a121 Reviewed-on: https://gerrit.libreoffice.org/69473 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-03-20sw: make ODT export of paragraph auto-styles deterministicMiklos Vajna
If a complex enough document is loaded into Writer and saved as ODT, then the content.xml's automatic paragraph styles (P<num>) are re-ordered on each save, which leads to unnecessary noise. The actual random order is created during import by the time we convert direct formatting (e.g. from HTML import) to autostyles, as StylePoolImpl::maRoot stores autostyles in a map that orders autostyle parents based on their pointer address. This has benefits like automatic ordering of item sets and fast comparison, so don't change that, but extend the svl API to also track the name of those parents. This way by the time StylePool::createIterator() would iterate over those autostyles, it can order the parents by their name, so two import->export runs will result in the same autostyle ordering. (This appears to be the only indeterminism in content.xml for a test HTML input, while meta.xml and settings.xml still changes all the time.) Change-Id: I1cfcae2c664a5c5c3dee48be733046979c1593ed Reviewed-on: https://gerrit.libreoffice.org/69469 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-20weld SwFieldEditDlgCaolán McNamara
Change-Id: I786944a4bf8979526f0ccae5b00fb42ad5016a66 Reviewed-on: https://gerrit.libreoffice.org/69463 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-20tdf#123909 fix event source that refers to a timenode.Mark Hung
p:tn (see below) were treated as delay value instead of timenode id. <p:stCondLst> <p:cond evt="begin" delay="0"> <p:tn val="5"/> </p:cond> </p:stCondLst> Just convert the timenode id to XAnimationNode and set the event source properly. Change-Id: Ib408be6714c6ac70dad7018e544e560cf59a40c0 Reviewed-on: https://gerrit.libreoffice.org/69340 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-03-20tdf#42949 Fix IWYU warnings in include/drawinglayer/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I8daf57df5b8f9c609d4f3ca44bae7366addceb6c Reviewed-on: https://gerrit.libreoffice.org/69151 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-19weld SwFieldVarPageCaolán McNamara
Change-Id: Ifd71cbb4c3ed3baa33136c5b86c042144faa5002 Reviewed-on: https://gerrit.libreoffice.org/69435 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-19Resolves: tdf#124024 scaling factor isn't displayed correctlyCaolán McNamara
Change-Id: If08731217c0839ebd8d51399bb0dd1a3b598dceb Reviewed-on: https://gerrit.libreoffice.org/69420 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-19weld SwFieldDBPageCaolán McNamara
Change-Id: Ic4919fa3caa2106598ed8da3cec5deffa506eee1 Reviewed-on: https://gerrit.libreoffice.org/69401 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-19name apitest suites consistently while we still canBjoern Michaelsen
- writer test apitest suites are now called like the UNO implementation they are testing - also mark them final for good measure - move tests to module test and try to match its conventions * BaseIndex * TextDocumentIndex * TextDocumentSettings * TextPrinterSettings * TextSettings * XDocumentIndex - also remove anonymous namespace in header, as that is a bad idea - also remove now obsolete ApiBaseTest - also remove dead code in TextPrinterSettings - remove writer xtextcontent test as it duplicates the impl in module test Change-Id: I71aa5f3755d5c90726f4ff4394117fa2391495d7 Reviewed-on: https://gerrit.libreoffice.org/69374 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-03-18weld SwFieldRefPageCaolán McNamara
Change-Id: I5ae3965aa681ea1f5a005fbc8dad4d0ce36af1b3 Reviewed-on: https://gerrit.libreoffice.org/69373 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-18Adapt o3tl::span to updated C++2a std::spanStephan Bergmann
...where index_type has changed from ptrdiff_t to size_t, see <https:// github.com/cplusplus/draft/commit/7f2493e2e2d34b42a6c12c8806e536d4feb3aee3> "P1227R2 Signed ssize() functions, unsigned size() functions". Ideally, ece27693ba52417bc4b68045f5544a5cc43299dc "Adapt to C++2a std::span<>::index_type being unsigned size_t" could be simplified now to use std::size_t, but there may be build environments that include a C++2a <span> that hasn't been adapted to P1227R2 yet. Change-Id: I7bfc0da65d415ef06e94d95b5f62030aeb8b35f6 Reviewed-on: https://gerrit.libreoffice.org/69391 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-18tdf#81437 XLSX import: fix missing chart borderBalazs Varga
of MSO 2007/2010 documents with "automatic" chart area formatting, setting also the default 0.75 pt border width and light gray border color. Note: MSO 2007/2010 and MSO 2013/2016 have different "automatic" border colors. This fix uses the last, light gray version instead of the dark one. Change-Id: I579f3745d5fcb2a36e1b4d519320631d20e60fd4 Reviewed-on: https://gerrit.libreoffice.org/69341 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-03-18PPTX import: save also OOXDrawing in InteropGrabBagGrzegorz Araminowicz
Change-Id: Ieaf341dd13e06046044f3523c3aad74476160402 Reviewed-on: https://gerrit.libreoffice.org/69328 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-16tdf#62728 add PDF/A-2 support, change UI default to use thatThorsten Behrens
There was not much missing to make LibreOffice export valid PDF/A-2, so let's add that, and switch the UI to use that instead of A-1. The old PDF/A-1 feature is still accessible via UNO / filter parameter 'SelectPdfVersion': - 1 gives you PDF/A-1a - 2 gives you PDF/A-2b - 16 gives you PDF 1.6 Change-Id: Iea4262b119bcf33b75f3d1406cc793bdcaec65d1 Reviewed-on: https://gerrit.libreoffice.org/69294 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-03-16Component testBjoern Michaelsen
Change-Id: I03785b3126671629011d5e62925a5658ab5ec2f7 Reviewed-on: https://gerrit.libreoffice.org/69067 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-03-16Fix typoJens Carl
Change-Id: I5e75f430090e6812d82146c88e7b687d6c6fcffa Reviewed-on: https://gerrit.libreoffice.org/69344 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>