summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2017-03-14change SvxFrameDirectionItem base to SfxEnumItemJochen Nitschke
Change-Id: I82f01d0e3e4bf15ed6ba435406ae63b7c9110091 Reviewed-on: https://gerrit.libreoffice.org/35160 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14make o3tl::strong_int constructor explicitNoel Grandin
Could have sworn I did this originally, somehow it got lost. Also fix a thinko in tools::ResId I introduced in commit 2b70fb58be039fbd05ea833a40b1b3e9f922e45c "Use o3tl::strong_int on RESOURCE_TYPE" Change-Id: Id3b39962255297010cd1feaaca6d822168311081 Reviewed-on: https://gerrit.libreoffice.org/35108 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-13More ToolBox sal_uInt16 -> ImplToolItems::size_type clean-upStephan Bergmann
Change-Id: I6ec50033a452493852729dc8efe78da2708cbd96
2017-03-13fix remainingSize for writable modified MemoryStreamCaolán McNamara
Change-Id: If8abbca4701002b7c171c19fc6ec56d3211b0cb4 Reviewed-on: https://gerrit.libreoffice.org/35145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-13merge these similar buffer flushes togetherCaolán McNamara
adds an extra SVSTREAM_WRITE_ERROR check to some of them, otherwise they're all the same Change-Id: I2a4c766ff267a246a9f126fa9b7d557cfa2d66b0 Reviewed-on: https://gerrit.libreoffice.org/35144 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-13Clean up odd non-static member functions with pThis paramterStephan Bergmann
...and get member function const'ness right overall Change-Id: Idb422039108d1dde9f6a8b881f6dff742030f6f0
2017-03-13force SvNumberformat::FormatterPrivateAccess for Get/SetLastInsertKeyEike Rathke
... so only SvNumberFormatter can use it, as intended. Change-Id: I91875dfd00d1f83b3ae988bda922782336489f73
2017-03-13Clean up integer types representing positions in ToolBox's item vectorStephan Bergmann
(vs. uses of sal_uInt16 representing such items' IDs). APPEND and ITEM_NOTFOUND are members of ToolBox now (and have been bumped to the corresponding type's max). The payload of VclEventIds ToolboxButtonStateChanged ToolboxClick ToolboxHighlightOff ToolboxItemAdded ToolboxItemDisabled ToolboxItemEnabled ToolboxItemRemoved ToolboxItemTextChanged ToolboxItemUpdated ToolboxItemWindowChanged ToolboxSelect has been changed too (note that reading/writing of those payloads isn't very consistent, though: for some of these, values are written that are never read, while for some others no values are ever written but the reading code would like to receive some value if the payload wasn't a nullptr). Change-Id: I4856ffb3637404b8d866621a3503d7922b1b8141
2017-03-13templatize SvXMLEnumMapEntryNoel Grandin
in preparation for "scoped UNO enums". This is a little hacky: In order to limit the scope of this change, the templated SvXMLEnumMapEntry struct actually has a fixed size field, and we cast it to SvXMLEnumMapEntry<sal_uInt16>* in various places, to avoid carrying the type param around. Change-Id: Idfbc5561303c557598dd5564b7a7259ae5261d83 Reviewed-on: https://gerrit.libreoffice.org/34987 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-13convert GraphicDrawMode to scoped enumNoel Grandin
Change-Id: I18eec89c4e1ebb86d64297e7cef4b36bf12df59f Reviewed-on: https://gerrit.libreoffice.org/35004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-12Fix typosAndrea Gelmini
Change-Id: I63da858b3f264cd099e60192633b44d362b6fad7 Reviewed-on: https://gerrit.libreoffice.org/35055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-12make this a member of SvxBrushItemCaolán McNamara
Change-Id: If1216b03a313885bb284ca5ddcd8a91167a3638b
2017-03-12fix typo: ambigous --> ambiguousdennisroczek
Change-Id: I4940fe7e51df19275ba42a572c7a7a35ac2079f4 Reviewed-on: https://gerrit.libreoffice.org/35090 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-12ToolBox::mnFocusPos is unusedStephan Bergmann
...ever since b8f7708176f56d6093405faf6f112004db359be9 "#96972# improved key and focus handling" Change-Id: I236143997f6e90eaa8cc28e10c17ff5a647da48c
2017-03-11Passing shaperect to addShape function is uselessTamás Zolnai
Shaperect is ignored by createAndInsert() so it has no effect at all. Also when this parameter is set the size and position is set using the same shaperect, so don't need to pass it also as a parameter. Change-Id: I35a7953f3eda1bdd19af6f3e77c55b5c7e1f7161 Reviewed-on: https://gerrit.libreoffice.org/35073 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-03-10Propagate integer type mismatch out of ToolBox::ImplFindItemPosStephan Bergmann
Change-Id: I6f0c06491cf3c09d97b637d7456debd1e3decbcd
2017-03-10tdf#99352: create editeng::SharedVclRessourcesBjoern Michaelsen
- instead of keeping vcl resources in a rtl::Static - these are shared owned by all EditEngines - they let go of them when disposed - thus, this should prevent VclPtrs to leak beyond dispose() Change-Id: Ic6198c19d0ff9c09ecdea377d07807f08711d6a0 Reviewed-on: https://gerrit.libreoffice.org/34986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-10coverity#1402152 Uninitialized pointer fieldCaolán McNamara
forgot to remove this unused member Change-Id: I596d9f95284d1e27c2ca86e4c1ee75fc38cb7fce
2017-03-09No need for extra heap allocationStephan Bergmann
Change-Id: I0844a0a8a3476cdb007ab1d587b15ce26c68783e
2017-03-09just calculate the scanline positionsCaolán McNamara
rather than generating a big offset table to dramatically reduce the amount of memory loading graphics takes Change-Id: I8a4b1dc5cbcb686d6b8570f2eeef61ee0fe25515 Reviewed-on: https://gerrit.libreoffice.org/35005 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-09Clean up uses of integer typesStephan Bergmann
Change-Id: I1155dfe3e2bcfe2c15c101c7373fcc9e161aa366
2017-03-09Fix "specialization in different namespace" error with old GCCsStephan Bergmann
Change-Id: I8b2c678ec70de3432bb335d7e76487ef44cd72a6
2017-03-09Clean up uses of integer typesStephan Bergmann
Change-Id: If022ca9de8db49b885065c32b4f6f89debae1392
2017-03-09mpScanBuf can be privateCaolán McNamara
Change-Id: I78d6f94f65c9f6e667840c26c1359aa1ab9ad794
2017-03-09Use o3tl::typed_flagsStephan Bergmann
Change-Id: I02b88e60a03441c3c4df6ed32616bb618089539c
2017-03-09convert SvxCellHorJustify to scoped enumNoel Grandin
Change-Id: I0dd88b5bf9e1aededfa2d94b6b2d3d26694fff33 Reviewed-on: https://gerrit.libreoffice.org/34968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-09Don't use SetDisplayable when enabling Unity modeMaxim Monastirsky
because now it tracks the global menu too, but all we need here is to hide the in-window menubar widget. Change-Id: Ic3c8c20b88d37430e80b682333ca384bccc3f697
2017-03-08Clean up uses of integer typesStephan Bergmann
Change-Id: Ia89668f12f93c9fada3ecf31851f8df2a2567979
2017-03-08make SfxGetpApp just get and move GetOrCreate to the peripheryCaolán McNamara
Change-Id: If3b22635e46dbccf0fad101f51bb653cbbcd3a32 Reviewed-on: https://gerrit.libreoffice.org/34957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-08convert SvxShadowLocation to scoped enumNoel Grandin
Change-Id: Ie51995579312328538263172cd3173641df89bca Reviewed-on: https://gerrit.libreoffice.org/34965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-08convert SvxCaseMap to scoped enumNoel Grandin
Change-Id: Iea77ddc21e9b2d5a021c08e323da9ccabf9d46bd Reviewed-on: https://gerrit.libreoffice.org/34963 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-08convert VclReferenceBase::mnRefCnt to oslInterlockedCountNoel Grandin
Which means that ref-counting VCL widgets is now thread-safe. Destroying them, however, is not safe without holding the SolarMutex, which will the subject of a future patch. According to my tests running 'perf stat make check', this costs us approx 2% runtime on a non-debug Linux build using gcc. Costs are quite a bit higher when building with clang, which might need further investigation. Change-Id: I737170b74ec79e6b7c7d586ed5be89a73ee83597 Reviewed-on: https://gerrit.libreoffice.org/34948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-08convert SvxAdjust to scoped enumNoel Grandin
Change-Id: I0df7a5313d6d62d0c657e62ef6014a3ddbab4639 Reviewed-on: https://gerrit.libreoffice.org/34941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-07loplugin:loopvartoosmallStephan Bergmann
Change-Id: Ia8c57fb69873d57c3271a8f6d497fecec3db1899
2017-03-07ofz: fix ppt import leakCaolán McNamara
Change-Id: I48b855f96464c74b76b473d5674fcdcc8388bf1b
2017-03-07only one use of GetLastSaveDirectoryCaolán McNamara
which is to get its value and do a const_cast dance to save and restore its value which is a strange thing to do just for one obscure dialog when no other use of the save/load dialogs does this Change-Id: I7700d7ed738d578869284d415197de06167001b5
2017-03-07make SfxApplication ctor privateCaolán McNamara
Change-Id: I85d2a112b1f7e6215480d89e038d6515d641d147
2017-03-07Remove unused include/systools/win32/comptr.hxxStephan Bergmann
(there's a close cousin in fpicker/source/win32/filepicker/ that's actually in use there) Change-Id: I3250112703f09871e7451257b0417d1d3c332f73 Reviewed-on: https://gerrit.libreoffice.org/34932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-07Remove redundant 'inline' keyword, Linux reduxStephan Bergmann
Change-Id: I10c7dbd6a7acce309b056a1ae57c39f00f22c46d
2017-03-07Add Tooltips for emoji toolbar controlAkshay Deep
Change-Id: I93d9fb1af42d83c7f7f518a1441f4666fd7ee30a Reviewed-on: https://gerrit.libreoffice.org/32231 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-06convert SdrTextAniKind to scoped enumNoel Grandin
Change-Id: Ie79aaf96a0d89c96c4ecd4ee8ccb0eabd3456bd0 Reviewed-on: https://gerrit.libreoffice.org/34916 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06convert HTMLTableRules to scoped enumNoel Grandin
Change-Id: Id8758955565579abd1f4687907d7fe06aaefa749
2017-03-06convert HTMLTableFrame to scoped enumNoel Grandin
Change-Id: I1353619ca11f867ca37dec3105e50ba9f3d70d54
2017-03-06convert HTMLInputType to scoped enumNoel Grandin
Change-Id: I3f6f6aadd813898ccff93154138a2fbf911b9c8f
2017-03-06convert HTMLScriptLanguage to scoped enumNoel Grandin
Change-Id: If87863b520da704410a6ad261330bbde7ef8008c
2017-03-06convert ScrollingMode to scoped enumNoel Grandin
Change-Id: Ice1628ba09998be455fd6a77a044cb403235d462 Reviewed-on: https://gerrit.libreoffice.org/34914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06templatize HTMLEnumOption::GetEnum methodsNoel Grandin
And consequently fix bug in htmlfld.cxx in the RES_DOCSTATFLD/SwDocStatSubType handling, where it was updating the m_bUpdateDocStat fields by comparing the wrong enum variable. Change-Id: If9a68699a9d375ace120a3bf4f4bf4d4ae20a8e0 Reviewed-on: https://gerrit.libreoffice.org/34857 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-05ubsan: add in all the valid value for NumberingType to the SvxNumType enumCaolán McNamara
/include/editeng/numitem.hxx:69:67: runtime error: load of value 52, which is not a valid value for type ´SvxNumType´ #0 0x2b29cf86dc41 in SvxNumberType::SetNumberingType(SvxNumType) /include/editeng/numitem.hxx:69:67 #1 0x2b29d5448771 in SwXNumberingRules::SetPropertiesToNumFormat(SwNumFormat&, rtl::OUString&, rtl::OUString*, rtl::OUString*, rtl::OUString*, SwDoc*, SwDocShell*, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sw/source/core/unocore/unosett.cxx:1851:25 #2 0x2b29d542f727 in SwXNumberingRules::SetNumberingRuleByIndex(SwNumRule&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, int) /sw/source/core/unocore/unosett.cxx:1517:5 #3 0x2b29d542b0e8 in SwXNumberingRules::replaceByIndex(int, com::sun::star::uno::Any const&) /sw/source/core/unocore/unosett.cxx:1180:9 make CppunitTest_sw_ooxmlexport CPPUNITTRACE="gdb --args" Change-Id: I4bb11dbe29e286e937f177aa436213ae40152399
2017-03-05Proper fix for multiply defined SfxEnumItem<sal_uInt16> with MSVCStephan Bergmann
With --disable-pch the original hack from f091259ad2ec1590714645839668580cd7b8c7c4 "convert SfxEnumItem to type-safe template class" doesn't happen to work: When linking sd, the occurrences of SfxEnumItem<sal_uInt16> in sd/inc/sdattr.hxx clash with those from editeng (where LanguageType is a typedef for sal_uInt16) and svl (as the respective include files from editeng and svl happen to not be included). For whatever reason, the explicit instantiation declaration without a __declspec(...) in include/svl/eitem.hxx doesn't seem to make a difference (at least with MSVC 2015 Update 3). Change-Id: I51b5943fe19a7184db9414192c6364f7c26b79eb Reviewed-on: https://gerrit.libreoffice.org/34903 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-04tdf#106304: Don't unnecessarily use bogus default char size for a:endParaRPrTor Lillqvist
Instead use the size last used for an a:rPr below the same WriteText() call. I am not exactly sure about how this hangs together, but this has the desired effect on the exported .pptx. Change-Id: Ie03dcd0b31c15cff8488b22d7423c9f9ad1e2d68
generated by cgit (git 2.34.1) at 2025-01-13 11:42:28 +0000