Age | Commit message (Collapse) | Author |
|
Change-Id: Ie5650c3a5593dcf68196802169c47270a0c3b0e6
|
|
Change-Id: Ia76df719b2f76a993e65e0bf6d55723b1a2f5b93
|
|
Change-Id: I0d89cc99a1d8f7b3c17986b45653dce5e4b436d7
|
|
Do not abort in tests which take longer then before.
Since 4f5f6d2444a24138c3d3d378771f87cb06427195 we have nice tool to
collect callgrind results, store them..
Also, make it not necessary to duplicate anything. Any test can be turned
into a performance test by using callgrindStart/callgrindDump. You only
need to duplicate the makefile name in gb_Module_add_perfcheck_targets.
So, if the test is run as part of 'perfcheck', it runs under callgrind,
otherwise it behaves like a regular unit test.
Change-Id: I7acbb855b1823c9a32ba126abb57dccc767ca239
|
|
Change-Id: Ibdbfb4a88c1c75aaf5d33672d8639a9ea55afbac
|
|
Change-Id: Ic76ccc49b9291fe82c56974eb6237cd3b85d91c8
|
|
Change-Id: I2908c57badd079c8f19c679f40ed815ce2cba374
|
|
so change from a pointer to a reference
Change-Id: I81eb2c9e4df8353fbbdad7058c6ca7ea22286e62
|
|
Points of discussion
--------------------
(*) where in the Window destructor should dispose() be called?
It's a seriously large method.
(*) we're going to need similar typedefs and declarations for every
single sub-class of vcl::Window, I assume that I will need to create a
macro to make it less verbose.
TODO
----
Update clang plugin to verify that:
(a) dispose() methods always call their superclass dispose()
(b) dispose() methods don't forget to clear any references owned
by that class.
Change-Id: I873d5d5166f811e2f65e49327cc98862559fcf30
|
|
So it will be similar to addEntriesForXColorList
Change-Id: Ie352e0cf05fa6875ed76e69478131a57293b39a1
|
|
Change-Id: I6f40eafee7652209395bd471e3508fe3a3d19d73
Reviewed-on: https://gerrit.libreoffice.org/12085
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
|
Change-Id: I8685b451a39e890250a3309ddb70346bac4084b2
|
|
because g++ 4.7.2 generates [-Werror=type-limits] as follows:
> [build CXX] vcl/source/window/settings.cxx
> [build CXX] vcl/source/window/paint.cxx
> [build CXX] vcl/source/window/resource.cxx
> [build CXX] vcl/source/window/accel.cxx
> [build CXX] vcl/source/window/accmgr.cxx
> [build CXX] vcl/source/window/brdwin.cxx
> [build CXX] vcl/source/window/accessibility.cxx
> [build CXX] vcl/source/window/legacyaccessibility.cxx
> [build CXX] vcl/source/window/clipping.cxx
> [build CXX] vcl/source/window/stacking.cxx
> [build CXX] vcl/source/window/debug.cxx
> [build CXX] vcl/source/window/globalization.cxx
> [build CXX] vcl/source/window/btndlg.cxx
> [build CXX] vcl/source/window/builder.cxx
> [build CXX] vcl/source/window/cmdevt.cxx
> [build CXX] vcl/source/window/cursor.cxx
> [build CXX] vcl/source/window/debugevent.cxx
> [build CXX] vcl/source/window/decoview.cxx
> In file included from /home/tabe/core/include/rsc/rsc-vcl-shared-types.hxx:24:0,
> from /home/tabe/core/include/vcl/keycodes.hxx:23,
> from /home/tabe/core/include/vcl/keycod.hxx:26,
> from /home/tabe/core/vcl/inc/svdata.hxx:35,
> from /home/tabe/core/vcl/source/window/brdwin.cxx:21:
> /home/tabe/core/include/o3tl/typed_flags_set.hxx: In instantiation of 'typename o3tl::typed_flags<T>::Wrap operator&(E, E) [with E = WindowBorderStyle; typename o3tl::typed_flags<T>::Wrap = o3tl::is_typed_flags<WindowBorderStyle, 12339>::Wrap]':
> /home/tabe/core/vcl/source/window/brdwin.cxx:1027:44: required from here
> /home/tabe/core/include/o3tl/typed_flags_set.hxx:105:5: error: comparison is always true due to limited range of data type [-Werror=type-limits]
> /home/tabe/core/include/o3tl/typed_flags_set.hxx:106:5: error: comparison is always true due to limited range of data type [-Werror=type-limits]
> cc1plus: all warnings being treated as errors
> make[1]: *** [/home/tabe/build/workdir/CxxObject/vcl/source/window/brdwin.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [vcl.all] Error 2
> tabe@thunk:~/build$
Cf. a6b01d01f77f84517d267bdfe31de91b9050a70c
Change-Id: Ic596eaf886d9aebb8a5b8636b5b90d5935aeadaf
|
|
Change-Id: Ia6aa4e21fef46b20d1d8996d2f15855b8ba1776e
Reviewed-on: https://gerrit.libreoffice.org/12114
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Btw, th unanounced byte-swapping of valuse in the input array in
writeArray seems a bit dubious to me... It could too easily cause
unintentional memory damage. I just hope it is always called either with
data that is not used after that anymore or with a copy of the data.
Change-Id: Ica0e9ea16cd101fe87d7e0a8fa696911769e0654
|
|
re-arrange the code to help coverity out
Change-Id: Iddc9284cbdcbaae7a0dc17e62d0e8f4b4832297c
|
|
Change-Id: I0aa9dbef960391334097b68c980064724435db38
|
|
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328
Reviewed-on: https://gerrit.libreoffice.org/12104
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I266cfd8c80088f698ec36662357477bb456a96fe
|
|
Change-Id: I3922bcf22b7efe43fd42c937d88251b230d6384a
|
|
Change-Id: I2cc9884b23b49eb3e2afd27e5610bf96998a3c7f
|
|
Change-Id: I6ccc1d4e71a9fe76cd16dd957f626722aaba543c
|
|
Change-Id: Ia0f5f0d0efbe4693aba347bff32cd694117251fe
|
|
Change-Id: I750acd6e3e765a9635829ec2ed8dddf273824595
|
|
Change-Id: I0abe66ded0fd69a2720ad64e1a1426aafc7dfffb
|
|
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba.
Conflicts:
cui/source/tabpages/transfrm.cxx
svx/source/svdraw/svdedtv1.cxx
svx/source/svdraw/svdibrow.cxx
sw/source/filter/ww1/w1filter.cxx
tools/source/generic/rational.cxx
Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
|
|
This reverts commit 091742e86aeb5287f7236f666fee48946ab4c67b.
|
|
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e.
Conflicts:
svx/source/svdraw/svdedtv1.cxx
svx/source/svdraw/svdibrow.cxx
sw/source/filter/ww1/w1filter.cxx
Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
|
|
Change-Id: Icd9c6ebc9feb3e7aba28b01729b582a8f49c832a
|
|
Change-Id: I3e9a302a7513eebfeff07402f71fc3dde22e4cc2
|
|
Saves another ~100m pcycles for 650k calls in startElementInternal()
Change-Id: I190326edc7feffb900e91fa7e5c3530b5b267f59
|
|
Change-Id: I7b0085af3b13bd6e1a50bf1e0e986d1524b52d7b
|
|
Change-Id: I7bf6dc1d366093e797a19a8e555103c15b311ac8
|
|
Some of the changes could be wrong and we don't need them.
This reverts commit 784d4bea86d8cbb3a855e557c465ce50a049cefc.
This reverts commit 8524d5aba59148eef94859289f00ab6477e0e821.
This reverts commit 018f1deae884febbbe639c7ee46b45ce4807e9d3.
This reverts commit 8124fddc5803b4e104d4fc2456cb92cb030d9436.
We use our own helper cache class in FastSaxSerializer
since f736eba5a9df8645849a37b08d2764a5f495ab45.
Change-Id: Iaca6b5b11cb32595db4420a02fa72b0007cf6286
|
|
Change-Id: I2d5dbe9adccdd231cc16a1f83a90a4adeb965c64
|
|
Change-Id: I28085d4e060bcf052e6aa97a0822a4d653d7c066
|
|
This contained an rtl_Sequence complete with horror internal
allocator, caught red-handed serializing threaded loading to no
good purpose.
Change-Id: I837b2c17e4f70fd6a49bed33ad74a7d79f98f35c
|
|
Change-Id: I359ca9d3b766b71904e4199ebfbdbd5b203775cc
|
|
And remove characters() member function.
Change-Id: Ifcedbb6d969b7b057ff378d2fbce09c2dde5ac18
|
|
Change-Id: Ibca65a2b8397358ac4013c8e5b53389ac6949e4d
|
|
Make the caller responsible for using it wisely.
AFAICS it's used only in FastSaxSerializer, so far.
Change-Id: I50d48fd7f3e6cdeb9e4637868da213b8171e542b
|
|
Use OSequenceOutputStream class to concatenate strings in a
Sequence<sal_Int8> buffer. And write data to file only at the end.
The design is a bit fragile, since all FSHelpers need to be destroyed
before calling FilterBase::commitStorage(). Otherwise data is not written.
Change-Id: I26b02335ef36011bfcda17484b560811d18c7657
|
|
Change-Id: I3ca1784b931dfc4f3dc42abe8f0af588fd6b8bd0
|
|
Change-Id: I20eb3b44d540f459cd1902a7a3b6a5c867e5bc07
|
|
'error: comparison is always true due to limited range of data type'
So just make the underlying type be 'signed int'
Change-Id: Ibf4ff72d85d33e88b7506289c622d34773ca259a
|
|
Change-Id: I4f878eff707e318fa80b7d3c19833bf724e4bcef
|
|
Change-Id: Iece61424e09fc36768889fde2c848ed2b0722701
|
|
Change-Id: I0231a52288ca9a8a2a5e5cdb13fdff772b989640
|
|
The end goal is to convert the Sidebar to use
SvxColorToolBoxControl, and get rid of the Sidebar
specific color popup, so we don't need to maintain
two popups.
Change-Id: I42e5bcb611acae25f16dfe9623d19727fc39ea07
|
|
Which makes bSetParams always false; remove that too, together with nLevel.
Change-Id: I94a4ec14b2b2c498d749ef72c1b6b118bba37076
|