summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2024-12-05jsdialog: weld::MenuSzymon Kłos
- weld::Menu doesn't have base with weld::Widget - use separate container, only one menu per WindowId - first only send menu and cancel, when user activates option we will send another request and execute entry as menu can be blocking - there is connect_activated way of async setup too Change-Id: Iea03f82a91ecc19af67b91f85364675c119056ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177722 (cherry picked from commit efeb511607dacce991866bcf328c96a01ab594f9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177852 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2024-12-05a11y: Drop SAL_LOPLUGIN_ANNOTATE("crosscast")Michael Weghorn
Added in: commit d66a97d5622bfc7c8d68452eb5a3c2378b0b1820 Date: Thu Jan 12 08:29:24 2023 +0100 loplugin:crosscast (clang-cl) > winaccessibility/source/service/AccTopWindowListener.cxx(47,36): error: suspicious dynamic cross cast from 'css::accessibility::XAccessible *' to 'VCLXAccessibleComponent *' [loplugin:crosscast] > else if (auto pvclxcomponent = dynamic_cast<VCLXAccessibleComponent*>(pAccessible)) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: Iee7585dd2fa0d92af3be6b89d7d08326de3d1e7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145380 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> AccTopWindowListener::HandleWindowOpened no longer does that crosscast now, see Change-Id: Ic96d2c95128af144c7769aac40707299b1c80f8c Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Dec 5 14:07:52 2024 +0000 tdf#164093 tdf#157001 wina11y: Use vcl::Window's actual XAccessible Change-Id: Ifca76a5d519099f9cbe06f8bde606e01871363fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177891 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-12-05Change infobar donate message after discussions in MarketingMike Saunders
Telegram group. Change-Id: Ib0ab77fafde0a7a5abc719a7eec9ef32615f15c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177853 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-12-05LOK: don't recreate the dialogs of an old view when loading new viewsPranam Lashkari
follow up for f5ebf512ccd3d5ae3af5fe706b411a85fa19182d now same actions are performed on all the dialogs Change-Id: I6531a766327dda106770a2c513ebd492dea7c655 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176933 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 2fba6df7242586870988b62909156538b42c2bc0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177892 Tested-by: Jenkins
2024-12-05weld: Add weld::Widget::signal_* methods to call handlersMichael Weghorn
Similar to what already exists in most subclasses, add signal_<event_name> methods to call the handlers and use these in the subclasses instead of calling the handlers directly. Change-Id: I6b79ddd859b360e947d97ada57f1573a276d6177 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177834 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-04a11y: Use FormattedField directly in SVTXAccessibleNumericFieldMichael Weghorn
... instead of using the toolkit/UNO wrapper SVTXNumericField. Change-Id: I86e274a06f210e2076e287087a1d4b979abe7c35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177814 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-12-04a11y: Move menu a11y classes to vcl, no more use factoryMichael Weghorn
Other than most of the a11y implementations for vcl classes, VCLXAccessiblePopupMenu etc. do not make use of any VCLXWindow (i.e. UNO/toolkit wrapper of a vcl::Window) and thus do not depend on the toolkit module, which the accessibility module depends on. Therefore, there's also no need to use the accessible factory to create them (which is needed when toolkit classes are involved to avoid a dependency cycle). Move those classes from the accessibility module to vcl and add a new method Menu::CreateAccessible and move the logic from AccessibleFactory::createAccessible there. Drop the now unnecessary factory methods previously used for those classes. No change in behavior intended (yet), but this also simplifies the code involved for the tdf#164093 scenario. Change-Id: Ie3f6f1a02bf6662206d31383473cdc868e1f9164 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177812 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-04Move helpers for css::awt/VCL point/rect/size to vcl::unohelperMichael Weghorn
Move helpers to convert between the Rectangle, Point and Size classes in vcl and in css::awt from VCLUnoHelper (in the toolkit module) to vcl::unohelper (in the vcl module), for reuse in vcl in upcoming commits. Change-Id: I7b11c8a6b8c843a01ce25b1e4c0fb1869ad1e6ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177816 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-04a11y: Move action string header to vclMichael Weghorn
... so these constants can be reused in vcl. See commit message of Change-Id: I6aeee104f271c804c85727002822b89a9263628f Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Dec 4 11:45:44 2024 +0100 a11y: Move CharacterAttributeshelper from accessibility to vcl for motivation. Change-Id: I1552c0a0111c81643ab9bb6f202c8a31662251d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177811 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-04a11y: Move CharacterAttributeshelper from accessibility to vclMichael Weghorn
This is in preparation of moving more from the accessibility module to vcl. Currently, the a11y implementations for vcl widgets are implemented in the accessibility module (in directory of the same name), which in turn depends on the toolkit module. To break the dependency cycle (vcl needs accessibility to create a11y objects for its widgets), there's a UNO service. At least some a11y classes don't really need toolkit, however, so the plan is to decouple this and move those from the accessibility module into vcl in upcoming commits. Change-Id: I6aeee104f271c804c85727002822b89a9263628f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177810 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-12-04[API CHANGE] a11y: Drop XAccessibleExtendedComponent::getFontMichael Weghorn
This method from the unpublished XAccessibleExtendedComponent interface is not used by any of the a11y platform bridges, and I don't know of any platform a11y API that would need it. In order to report character/font attributes, there is the XAccessibleText interface and its XAccessiText::getCharacterAttributes method instead, which actually gets used by the platform a11y bridges. Therefore, drop this method to simplify code, and also decouple the accessibility module a bit further from the toolkit module without having to reorganize code further. (VCLXFont from the toolkit module currently gets used in various implementations.) Change-Id: I06ea3cc5998a13927b3f869877b28f03ac07c89b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177809 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-04toolkit: Pass VCLXFont init args in ctorMichael Weghorn
Pass arguments right away in ctor rather than having a ctor that takes no arguments and then having to call VCLXFont::Init with the arguments right after calling the ctor. Change-Id: I651e27154499f61638409377438f9589bc7412a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177795 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-04Use '#pragma once' in vclxfont.hxxMichael Weghorn
Change-Id: I445ec8a08c6622c681e459efc2dd2afbf74dd78e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177794 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-12-04vcl: fix call sites for createBlendFrame(), rename to createAlphaBlendFrame()Christopher Sherlock
The call sites are actually passing in transparency, in fact to be consistent with current conventions we are actually dealing with alpha values. So we need to take the transparent values at the call sites and convert to alpha values by just subtracting 255. Hence fixing the FIXME comment. Change-Id: Ibc55ea77f469ec8afcab0cc26d2b8cdf25ea8a72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173858 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-04Disable subpixel AA in GraphicExporter::filter unconditionallyMike Kaganski
... in D2DWriteTextOutRenderer. Commit 785a56b6be7f3128c2e7a131381e02525a50eb6b (D2DWriteTextOutRenderer: use grayscale AA for file output, 2024-11-27) has disabled it only when the export settings explicitly specified a concrete AA setting. In case when the settings didn't specify explicitly, if AA should be used or not, then system settings were used, which in case of D2DWriteTextOutRenderer would still enable ClearType (subpixel AA). This stores additional flag in StyleSettings, similar to what was done in commit e6538f5bdd876911ea30f84a6512c03908e620fd (tdf#118966 vcl: add a flag to determine if AA of fonts is used from the system, 2018-07-28), that tells the renderer to prevent subpixel AA, even if use of AA itself is defined by system settings. This flag is currently only considered by D2DWriteTextOutRenderer. Change-Id: Ibd1879d3c222276eee00c37a442881d6d47c831f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177780 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-04loplugin:unusedfieldsNoel Grandin
Change-Id: Iac4a64af74c92cbd76335faa62e51fa80ef21789 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177718 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-12-04tdf#88226 sd: fix cutting off the overflow text on the notes print pageTibor Nagy
This fix offers two options to preserve the overflowed text: 1: if the "Original size" option is selected for printing, the overflowed text will be displayed on a new page. 2: if the "Fit to Printable Area" option is selected for printing, notes will be scaled to fit within the available printable space. The "Multiple sheets of paper" and "Tile sheet of paper" options are disabled for notes because these options are intended for slide printing and do not make much sense for printing notes. The orientation for the notes print page has also been fixed. Change-Id: I99e56cf9aed5c32764797469a8ea7f3b25053882 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177511 Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de> Tested-by: Jenkins
2024-12-04Use o3tl::cow_wrapper instead of std::shared_ptrMike Kaganski
Change-Id: I05ff47fe51cccce6a78745027ae8c2679783bd8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177766 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-04vcl: Change Menu::ClosePopup param to PopupMenu*Michael Weghorn
Change Menu::ClosePopup param from Menu* to the child class PopupMenu*, as this is always a PopupMenu. This also removes the need to cast to PopupMenu in the PopupMenu::ClosePopup override. Change-Id: I129e6ebc7c801c1ca93514f26f79b76f970957a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177745 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-04sd: convert sidebar masterpage panels from drawingview to iconviewRashesh
- also removes unused PreviewValueSet Change-Id: I5e7dacb4f472de526a61366295bc91edca12e9ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177642 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-12-03tdf#164090: a11y sw: add new warning for non numbered empty paragraphBalazs Varga
Add new warning for empty paragraph between numbering paragraphs. Change-Id: Ib85b376da77a72a87ab05a3e8271be43e223f129 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177493 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
2024-12-03don't bother passing const std::[u16]string_view by referenceCaolán McNamara
Change-Id: I49477c20849dd99118d5935c0f1576429648bfca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177734 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-03cid#1636522 Missing move assignment operatorCaolán McNamara
Change-Id: I2d5f4e69b5cb9205743484c23443df2084da4fad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177721 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-02vcl: Switch MenuBar::ImplCreate param to MenuBarWindow*Michael Weghorn
This avoids the need to do a dynamic_cast and makes clear that this method always gets called with either a window of a proper type or nullptr. Change-Id: I8ca4020476c806ad423379c7c7ee6fdc6ceccd3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177697 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-02vcl: Merge PopupMenu::PrepareRun into PopupMenu::ImplExecuteMichael Weghorn
Merge PopupMenu::PrepareRun into its only caller which makes it a little easier to follow the logic and track what's assigned to what local variable than when using many out params. Change-Id: Id967040a579e3f6532afa523215049bdb68f1cd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177694 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-02vcl MenuBar: Drop friend class ApplicationMichael Weghorn
Application doesn't need access to any private members. Change-Id: Ia69b64ecf8e380b0b8da7477e3a3c7d312629965 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177693 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-02vcl: No longer let MenuFloatingWindow be a friend of MenuBarMichael Weghorn
MenuFloatingWindow is the window used of PopupMenu, while the window for MenuBar is MenuBarWindow. MenuFloatingWindow only needs access to the menu bar's MenuBarWindow, so make MenuBar::getMenuBarWindow public and no longer let MenuFloatingWindow be a friend of MenuBar, to make a little clearer who is able to access whose private members,... Change-Id: I7ee492e36d6e94884d1dba652d11f26cb8543a52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177692 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-12-02unotest,sw: introduce queryDispatchStatus()Michael Stahl
... and reset the view options that are toggled in testHiddenParagraphFollowFrame and testHiddenParagraphFlys. Backporting these tests to the libreoffice-24-8 branch broke 2 unrelated tests because of the changed view settings: Test name: (anonymous namespace)::testHiddenSectionPageDescs::TestBody equality assertion failed - Expected: 532 - Actual : 798 - In <>, attribute 'height' of '/root/page[2]/body/section[1]/infos/bounds' incorrect value. xmltesttools.cxx:203:Assertion Test name: (anonymous namespace)::testTable0HeightRows::TestBody equality assertion failed - Expected: 28 - Actual : 22 - In <>, XPath '/root/page[1]/body/tab/row' number of nodes is incorrect Change-Id: Ie58242348fecabe163e54048f3896c6d427d2608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177691 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-12-02loplugin:unusedmethodsNoel Grandin
Change-Id: I85ef1d4e9391e211c9e5e7ac6e9de875e9f5f5af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177679 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-12-02mnOriginalTextPos is only written to, never readCaolán McNamara
Change-Id: Iaca97dc3a0534847cbe96816a0827549a8f8d371 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177685 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-02vcl: Pass GetSystemMenuData param by refMichael Weghorn
Change-Id: I04cae4a880dcf5c34e35ade9983b56d8ff8ed496 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177661 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-12-02vcl: Make Menu::ImplGetSalMenu constMichael Weghorn
And drop the then no longer needed const_cast in Menu::GetSystemMenuData. Change-Id: Iac438850c5258e5fc23a4b3901f4601edf82e57c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177659 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-12-02vcl: Prefix Menu::pWindow member with "m_"Michael Weghorn
This makes a bit more obvious that this is a class member while reading code where it's involved, in particular since local `pWindow` variables are used in addition. Change-Id: Ic68e856a0c3ddedbf510124937cf4bc21febf916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177658 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-12-02vcl: Consolidate to one Menu::pWindow getterMichael Weghorn
There are two getters for that member: Menu::ImplGetWindow and Menu::GetWindow. Replace uses of the former with the latter and drop Menu::ImplGetWindow. Change-Id: Ieaefe43258172f6000c326503eeeefe1a05faabb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177657 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-02loplugin:unnecessaryvirtualNoel Grandin
Change-Id: Ie010deb5cdf9da20f2ca60d79feabf1c0de93c57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177669 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-12-02svx: prefix members of E3dSphereObjMiklos Vajna
See tdf#94879 for motivation. Change-Id: If10c0d7a40536f27fb18f7624c91092471d45996 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177651 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-12-02tdf#157869 Improve description for columns in textbox (Impress)Bogdan Buzea
Change-Id: I5ddda383f41095a96597d57ab635dbab500aabc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177220 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-12-02Drop Window::IsAccessibilityEventsSuppressed paramMichael Weghorn
All callers use the default of `true` for the `bTraverseParentPath` param since Change-Id: I88fe0e6ec9bb693710e3f7ab0c6c2e46686be720 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 2 03:28:50 2024 +0100 sc a11y: Don't suppress a11y events when setting new pos , so simplify this by dropping the param altogether. Change-Id: If47333f096d31afc3fb2c57dcc03d8e342ae4aa5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177640 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-02vcl a11y: Drop newly unused vcl::Window::SetAccessibilityEventsSuppressedMichael Weghorn
Unused now after Change-Id: I88fe0e6ec9bb693710e3f7ab0c6c2e46686be720 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 2 03:28:50 2024 +0100 sc a11y: Don't suppress a11y events when setting new pos Change-Id: I4359c903d1d1902671de87121161e0ca74b88251 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177639 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-02tdf#161341 show/hide controls/shapes/pictures in view/printOliver Specht
Controls/shapes and images/objects have a display option in tools/options/ Writer/View and in print dialog there is "Form controls" and "Images and other graphic objects". With this change the options will actually be applied again. Change-Id: I52389a8519d863792a7cd126a95a389c90c05a5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171905 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-12-02tdf#120658 - Reworking of dialogues Organize macrosJim Raykowski
(make from 5 existing only one) Much of what makes up this patch is adapted from existing code that is used to organize and select macros and to assign macros to shortcut keys. Comments in the patch say where code is borrowed from. Known issues: + Scripting framework library rename for BeanShell, Java, and JavaScript always returns fail when there are no macro entries in the library even though it actually succeeds. The same thing happens using SvxScriptOrgDialog::renameEntry. + Deleting Basic macros from the Macro Manager dialog is not implemented yet. Change-Id: If4da04549f8b39675910cbbd1f94dd9a6b73c31a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176254 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-01nothing consumes the ReadParaProps nCharCount arg, so drop it from paramsCaolán McNamara
Change-Id: Iea1bd3bb7df6466aeee480d8e44659b71bef580e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177614 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-01ReadCharProps always overwrites nCharCountCaolán McNamara
its an out only param, not in-out Change-Id: I4e969bf06bed41a7e04497880f8ea51a3f784feb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177612 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-30tdf#164101: avoid incorrect OLE object scaling during loadingMike Kaganski
Use an internal property for that, alowing to pass the option from the import site to SdrOle2Obj::AddOwnLightClient. Maybe there is some more proper way to do this, but I couldn't find it. Change-Id: I74c881c5c35689a7b58d44d8d65c1010d202c98d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177586 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-30tdf#130857 Search dialog: Use weld::Container ptr instead of BoxMichael Weghorn
None of the weld::Box methods are used, so having a pointer to the weld::Container subclass is sufficient in the "Find and Replace" dialog implementation. Change-Id: I1219dd657ab8fb6067c90aabdc27b2b84c0a1443 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177577 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-30tdf#130857 qt weld: Evaluate GtkTreeView:show-expanders propertyMichael Weghorn
Evaluate the GtkTreeView:show-expanders property [1] and set the QTreeView::rootIsDecorated propert accordingly [2]: > This property holds whether to show controls for expanding and > collapsing top-level items > > Items with children are typically shown with controls to expand and > collapse them, allowing their children to be shown or hidden. If this > property is false, these controls are not shown for top-level items. > This can be used to make a single level tree structure appear like a > simple list of items. With this in place, there are no more expanders shown for Calc's "Sheets" -> "Show Sheet" dialog for the native Qt version, just like with the gtk3 or gen versions. [1] https://docs.gtk.org/gtk3/property.TreeView.show-expanders.html [2] https://doc.qt.io/qt-6/qtreeview.html#rootIsDecorated-prop Change-Id: I11bcdd39695d230866abddf6d4b305dd6af52f59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177548 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-30tdf#130857 VclBuilder: Move extractHeadersVisible to base classMichael Weghorn
Move this helper function to the base class, for reuse in QtBuilder in an upcoming commit. Change-Id: Ide125c87bd4ebf63f70f94239a9bc42c3eab3c98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177546 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-29add some comments to weld::ComboBoxNoel Grandin
because it took me a while to figure out the magic value here Change-Id: I9a188d23a1f5aaac1bff10f795a916bc30cfb7ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177534 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-29tdf#164048 sw a11y: improve error/warning levels withBalazs Varga
adding two A11y issue level: Error and warning level, and categorizing our accesibility issues based on how the PAC 2024 tools and WCAG behave with the different warnings/errors. Change-Id: If4e4800497340318bb990326c64de655f24a47e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177389 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-11-29tdf#164046 style searching improvement breaks Impress layoutNoel Grandin
regression from commit 6c2f827697b898c9d351b79c2dbb5aefc8b70dcc Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Sun Oct 20 15:07:41 2024 +0200 improve style searching in SvXMLStylesContext Two problems - the original code was searching by DisplayName, not Name, so add another index for DisplayName, and the prefix matching was not properly matching. Change-Id: Ifd43bdb89d33067954298115c8700b87c7f93050 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177488 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-02-08 15:13:52 +0000