summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2024-07-02tdf#161853 vcl: Drop unused SvxIconChoiceCtrlColumnInfoMichael Weghorn
Unused since: Change-Id: I113a00d41a40b10df9d4d6dbb71565d462d9f8ae Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Jul 1 13:24:56 2024 +0200 tdf#161853 vcl: Drop unused SvxIconChoiceCtrl_Impl::GetColumn Change-Id: Ie32fcc443323bd2840aa14edefc533b743e1ed75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169825 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-07-02tdf#161853 Translate rest of German commentMichael Weghorn
Somehow, these 2 words previously remained in German when the comments were translated. Change-Id: I9d40b7df14d9328f52ba3d9ee8217f9ec1128272 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169794 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-07-02Use more getters/setters instead of direct member accessMike Kaganski
Change-Id: I8e0077f9040f0036f16e97da65c93c3fd6a87747 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169744 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-01tdf#157172 tdf#157460 PPTX import: fix connectors adjustment valuesTibor Nagy
Change-Id: Ie95ccd5bcd4d5c3f9c45c7dcc4f88acc0c9438aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169830 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2024-07-01call fillDecimal() in SvxTabStop constructorNoel Grandin
otherwise we get the weird behaviour where two SvxTabStop instances which are constructed the same, return false from operator== because one instance has had getDecimal() called on it, and the other not. Change-Id: I1f708c1b1e03efcd9fc554eaf2777c4c3e8a80b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169774 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-01remove hashCode from SvxBorderLineNoel Grandin
because they are unused and incorrect. They are incorrect because hashCode and operator== are not mutually consistent, as I found out when I tried to use them. They were introduced in commit c39e4f6b8a942680bc7250177c34fd034a0605e0 Author: Oliver Specht <oliver.specht@cib.de> Date: Wed May 22 12:26:46 2024 +0200 Add SfxItemType to SfxPoolItem but were not used in that commit. Change-Id: I1c3c67e904823117401a0f72a49c80f4bb6398a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169773 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-01Fix typoTaichi Haradaguchi
Follow-up to 1f3c82e3b0171bac89cbc7d1ec1ca89fac1c7eec See https://www.unicode.org/charts/PDF/U1400.pdf Change-Id: Iece91e51f1eea21495849368950747f3056f197d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169769 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-06-30Optimize SystemWindow layout a bitMike Kaganski
And simplify its ctor, using default member initializers. Change-Id: I08f06182c51d38299956cdf7ad2705c926c937d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169770 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-06-30Make SystemWindow::mbIsDeferredInit privateMike Kaganski
This optimizes its layout a bit, deduplicates, and exposes less guts Change-Id: If522747fdc2c666ac7876b39e72cc689f3c5c89f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169767 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-06-29Move MapToO3tlLength and FieldToO3tlLength to respective enums' headersMike Kaganski
Decreases dependency on <tools/UnitConversion.hxx> a bit. Change-Id: Ia469c08ca2844c522f508a724ddc879120d0b50d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169761 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-06-29Fix "lets" -> "let's"Andrea Gelmini
Change-Id: I01968fc18b093dbbc27213f01c3da38ae151c62c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169748 Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net> Tested-by: Jenkins
2024-06-29Simplify a use of convertTwipToMm100 a bitMike Kaganski
For some reason, MSVC fails to find the o3tl::convert overload for Size defined in <tools/gen.hxx>, unless the call to convert is unqualified, accompanied by a 'using namespace o3tl' in convertTwipToMm100. Change-Id: I7100ef55156b6944b5adc5aefa52eee38b3fe69e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169751 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-06-28Resolves tdf#115665 Format in the CTRL+H search affectsJim Raykowski
the CTRL+F search Change-Id: I51ccd2186c47a91958c262efac9a1514b9c3b138 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169606 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Tested-by: Jenkins
2024-06-28Simplify solar.h a bitMike Kaganski
Use std::copy / std::reverse_copy for double serialization. Also remove __cplusplus conditions, because the header is not included in any C files. And simplify the functions uses, where casts were unneeded. Change-Id: I1d8375e601851231fdffcf52e3f3e3bdcbcbde7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169706 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-06-28Fix "lets see" -> "let's see"Andrea Gelmini
Change-Id: I7aa939681720bc0dc81c8f114a3608a8cdfb4f60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169722 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-06-28improve lifecycle of SdrItemPoolNoel Grandin
I ran into a problem where this global object would be destroyed and then resurrected during shutdown. Rather than make the existing code more complex, extend the existing vcl::DeleteOnDeinit code and re-use that here. Change-Id: Ib63739f57f489b1131111e9bab1db5fba7fd17bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169697 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-28use more ASSERT_CHANGE_REFCOUNTED_ITEMNoel Grandin
which did I not see when I did commit cb3c65fb706cb1c7c9224222fd16875e924a9759 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Jun 27 19:24:28 2024 +0200 assert when SfxObjectItems are modified while in a pool Change-Id: I16e2ee72eda4b3ca69f83eb70ad4f4b0a14748a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169696 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-28reduce number of SvxUnoShape listeners on SdrModelNoel Grandin
when we have a lot of shapes, the number of listeners attached to SdrModel becomes a serious bottleneck because of the number of broadcast/notify function calls. So (1) make SvxUnoShape listen to the SdrObject which achieves the same end, and reduces the bottleneck on the SdrModel. (2) repurpose the maAllIncarnatedObjects set, which tracks all objects linked to the SdrModel, so we can shut down the associated UNO shapes during ClearModel. There is no other good way of doing this, and if we don't do it, we get various use-after-free issues during shutdown. This takes the load time of a large DOCX with lots of shapes, from 35s to 17s on my machine. Change-Id: I34a6ac35c90de8b7103a7373aafe6e9607cc01c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169612 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-06-28tdf#33603: fix notespane (side/tool)bar interactionsSarper Akdemir
Introduces OverridingShells that when set, makes the view act like the MainViewShell. The main use case is having more then one ViewShell in a single window, where context (toolbars, sidebars etc.) can jump in between different ViewShells. Uses OverridingShells to enable NotesPane to react ToolBarShells. Accessing the functionality of ToolBarShells without the previous hacks with slot forwarding. Change-Id: Icc9721d7f54097025bc9dc7ef7069aed856e6d96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169658 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
2024-06-28make additionsdialog show connection errorsSarper Akdemir
use non-scoped interaction handler instead of the scoped SimpleFileAccessInteraction so that errors will be handled with correct pop-up dialogs. Also throw the correct type of DAVException for USC_CONNECT_FAILED in Content::Open Change-Id: If2031dfa2796f91fad6866bc9608194c92658b96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169519 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-06-28Related: tdf#161708 sw content controls: fix custom default of dropdown to PDFMiklos Vajna
Export the bugdoc to PDF without noticing that there is a content control around some of the content and notice how the PDF export lacks some words from the body text. What happens is that content controls are exported to PDF as PDF forms by default, and the selected option of a dropdown has to be an index, so in case the text of the dropdown content control is not one of the options, then the PDF will miss those words. Fix the problem by inserting the text of the dropdown at the start if there would be no valid index for it. Also add a bit of padding around the rectangle of the content controls, it turns out there is a default 1pt border in PDF, and this would lead to a cut-off text at the end if we don't compensate for that border. Change-Id: I99447894b320b42ad9ffe0d54d0190000621616b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169694 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-06-28item-specific instance managers for SwFormatFrameSize and SwFormatVertOrientNoel Grandin
and add some asserts to catch if we modify these things when they inside a pool, which now that they are in hash-based container, will cause trouble. Change-Id: I2779f25cbcf056fbf71e417731d9b1f09ae33dd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169629 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-06-28assert when SfxObjectItems are modified while in a poolNoel Grandin
which has always been a problem, but becomes a more obvious problem when I implement some upcoming optimisations Change-Id: I8b0368b0b8e9a726c71d241841afeed3876281d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169657 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-06-28tdf#43767 mso-format layout: no smallcaps applied to numberingJustin Luth
If the paragraph marker is formatted as Uppercase, then Uppercase is applied to that line's numbering as well. However, if the marker is formatted as SmallCaps, it MUST NOT be applied for MSO formats. Apparently MSO only supports Uppercase and SmallCaps, not Lowercase or Titlease. I don't like these adhoc exceptions, so I didn't attempt to apply them to ODF formats. Let's keep it simple for ODF - any char format that applies to the entire paragraph should apply to numbering as well (except for the existing underline/overline exceptions). - if you don't like that char attributes apply at all, blame MSO. - if you don't like that DOCX is missing your goofy formatting, blame MSO for being inconsistent. ooxmlexport12's tdf143384_tableInFoot_negativeMargins.docx is almost interesting because it applies superscript and small caps. However, the list is already uppercase, so it can't be used for the test. make CppunitTest_sw_ooxmlexport21 \ CPPUNIT_TEST_NAME=testTdf43767_caseMapNumbering Change-Id: I273baebc996adfd001e1c591dbb9aef9272a42f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169476 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2024-06-27warning C6011: Dereferencing NULL pointer 'sNewPath'Mike Kaganski
C:\lo\build\instdir\sdk\include\LibreOfficeKit\LibreOfficeKitInit.h(161) : warning C6011: Dereferencing NULL pointer 'sNewPath'. : Lines: 136, 137, 138, 140, 143, 144, 157, 159, 160, 161 Change-Id: I0fba0db79b4a36f293e867da262a970eb152e3d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169651 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-06-27tdf#159925 - A11Y sidebar: Check for missing hyperlink nameBalazs Varga
Check if the hyperlink have missing name and add a fix button to fix the warning. Change-Id: I3a69490aa81cf0ed9d0edb04eaa3401e4b47eb7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169508 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-06-27vcl: Remove graph. reader context from {Imp}Graph and GraphicReaderTomaž Vajngerl
This removes the mpContext member variable from ImpGraph, which also make {Get,Set}ReaderContext on Graphic obsolete and is also removed. GraphicFilter and other code is adjusted and simplified. Change-Id: Icd1927d7b1bd4624b523d0f49a4343911ec6cd0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165214 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-06-27reduce boilerplate code for type-specific ItemInstanceManagersNoel Grandin
create a template class to reduce repetition Change-Id: I8c9c71fdfdac20a3b34432affac07aa1d46e8373 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169613 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-06-26reduce number of SvxTextEditSourceImpl listeners on SdrModelNoel Grandin
when we have a lot of shapes, the number of listeners attached to SdrModel becomes a serious bottleneck because of the number of broadcast/notify function calls. But SvxTextEditSourceImpl can just as well listen to the SdrObject, which achieves the same end, and reduces the bottleneck on the SdrModel. We do have to adjust some of the broadcast sites to broadcast the event to the SdrObject listeners as well as the SdrModel listeners. Possibly as another change we can remove the broadcasting to the SdrModel listeners. This shaves 10% off the load time of a large DOCX with lots of shapes. Noting that we do no need to listen to SdrHintKind::ModelCleared because we will get called via SvxTextEditSourceImpl::ObjectInDestruction when the model is destroyed. Change-Id: I3f7f6aa2a2146e4c4f59c974aa3fed92becf5eca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169565 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-26speed up DefaultItemInstanceManagerNoel Grandin
we can store the registered items in a map indexed by which-id, and avoid most of the search cost Change-Id: Ib3fbed436bc034e603819cfef8223dcc77eb7f06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-25tdf#161483 enable LO to read ODF angle unitsRegina Henschel
ODF uses in several places data type 'angle' (18.3.1, ODF 1.3). That is a double followed by unit identifier 'deg', 'grad' or 'rad' or a unit less value in degrees. LO uses in the API angles in degrees, 1/10 of degrees and 1/100 of degrees in data types 'double', 'short' and 'long'. Without the fix LO does not interpret the units, but takes only the number part. Change-Id: Ib3f2a518a25199e3cf7a7a8572e169785f75c427 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169360 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2024-06-25Revert "LOK: Introduce LOK_CALLBACK_STATUS_UPDATE"Mike Kaganski
This reverts commit bbd32b39eae24e99d135ed5c48586db8c9b0fb23. A following commit will implement an alternative method without a new enum member. Change-Id: Id00a4a0abe68fc69b1a3a81c731c8085e3dbca2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169467 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-06-24svx: prefix members of SdrUndoMoveObjMiklos Vajna
See tdf#94879 for motivation. Change-Id: If81831d76617da9b9d6ac5aef2e223065e939c4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169446 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-06-24editeng: add convenience creators to ESelection All, NotFoundTomaž Vajngerl
ESelection::All() select all text ESelection::NotFound() sets seletion to not found state ESelection::NoSelection() sets selection to no / invalid selection Introduce max paragraph and position constants in ESelection, use for EE_PARA_APPEND, EE_PARA_ALL, EE_PARA_MAX_COUNT, EE_TEXTPOS_ALL, EE_TEXTPOS_MAX_COUNT. Also simplify some ESelection constructs. Change-Id: Ib110c5a730a1deabe4f988baa5a600249b3a31e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169356 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2024-06-22tdf#161658 Limit new selection overlay to Calc onlyRafael Lima
Previous patches [1] and [2] introduced a contrast white line to the selection overlay that was supposed to affect only Calc, but it ended up affecting other areas of LO, such as the star math editor as well as Writer. This patch makes sure the changes only affect cell selection in Calc. [1] dc243f0122ba656d2630e93bebfb84a2bfe4042a [2] 3c0db898092c2cf6148c01f6c561acc199d484f5 Change-Id: Ie910120e4b71c55ad8c00a905e1204e291a711f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169292 Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com> Tested-by: Jenkins
2024-06-22fix O(n^2) behaviour when fetching field info from EditEngineNoel Grandin
Change-Id: I324a1814fc1b3321eed5b29922790600e7092c17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169344 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-06-21move ensureDocumentFormatted from EditEngine to ImpEditEngineNoel Grandin
so we have the implementation in one class, instead of bouncing back and forth between two. Change-Id: I851578ff553b01fb7d48cf5aa8f7a2d795496751 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169340 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-06-21tdf#158454 Add Thai Autocorrect Support, coding partTheppitak Karoonboonyanan
SvxAutoCorrDoc::ChgAutoCorrWord() implementations: correct multiple patterns * include/editeng/svxacorr.hxx, editeng/source/misc/svxacorr.cxx: - Add classes SvxAutocorrWordList::{Iterator,WordSearchStatus}. - Make SvxAutocorrWordList::SearchWordsInList() return WordSearchStatus so the search can be continued with the added SvxAutocorrWordList::SearchWordsNext() method. - Make SvxAutoCorrect::SearchWordsInList(), and its lcl_SearchWordsInList() companion, return WordSearchStatus propagated from SvxAutocorrWordList::SearchWordsInList(). - SvxAutocorrWordList::WordMatches(): The existing mechanism of preventing collision of patterns like in tdf#83037 (→ and ← and ↔ autocorrect collisions) was by storing the matched string of wildcard pattern back to the list without overwriting existing one. If the matched string was found in the list, it would just be treated as no matching. While this worked well for collision prevention, it caused failure on the new exhaustive wildcard pattern visiting method when autocorrecting the second text chunk with the same content. In such situation, all intermediate stages of corrections of the first text chunk would be recorded into the list. And, in the second chunk, the first stage would just be applied from the recorded pattern, but all the next stages would be refused due to the "collision" with the recorded patterns. Moreover, the new method would cause the list to grow more quickly as the autocorrections are done. To solve the problem, just "peek" for the collision instead of actually storing it. And SvxAutocorrWordList::ContainsPattern() is added for this purpose. * editeng/qa/unit/core-test.cxx: - Modify TestAutoCorrDoc::ChgAutoCorrWord() to iterate through all patterns, instead of finishing at the first one. * editeng/source/editeng/edtspell.cxx: - Ditto for EdtAutoCorrDoc::ChgAutoCorrWord(). * sw/source/core/edit/acorrect.cxx: - Ditto for SwAutoCorrDoc::ChgAutoCorrWord(). - SwAutoCorrDoc::ChgAutoCorrWord(): Remove old dead code for autocorrection on text with redlines. * sw/qa/extras/uiwriter/uiwriter6.cxx, +sw/qa/extras/uiwriter/data/tdf158454.odt: - Add unit test "testTdf158454". Change-Id: I8fb4a628a977b79b0ed2f239fd3749f15823b5df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160160 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-06-21LOK: Introduce LOK_CALLBACK_STATUS_UPDATEMike Kaganski
This allows to send status messages separately from statechanged; this is needed in Impress to notify about any mode update, not only masterview-related. Also send SlideMasterPage updates automatically from core. Change-Id: I0a50dbe61a5f2f28cd418eb4416819a6a76810b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169314 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-06-21uui,ucb: webdav-curl: display curl error message on connection failureMichael Stahl
Show this in the dialog, which requires extending DAVException to store 2 strings for this case. Store it in the Exception::Message member of InteractiveNetworkConnectException, which appears to be unused. Add another UI string ERRCODE_INET_CONNECT_MSG so that the text can be shown optionally in the dialog. Change-Id: Iaf139d77051e7480113eb4df82ef40eb498f329e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169278 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2024-06-21Embind: Fix C++ UNO exception catchingStephan Bergmann
...with a new Module.catchUnoException JS function that can be used in a JS catch block to provide the thrown UNO exception as an Any. (For a non-C++ exception, it rethrows the exception, and for a non-UNO C++ exception it maps it to css.uno.RuntimeException.) The implementation reuses parts of bridges/source/cpp_uno/gcc3_wasm/, which have been moved to a new StaticLibrary_emscriptencxxabi. Change-Id: I708fe6121c43a1b9736de5dff449f6c4f32a45f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169325 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-06-21tdf#161648 vcl a11y: Add weld::Toolbar::set_item_accessible_nameMichael Weghorn
Add API to set the accessible name of toolbar items and implement it for the VCL, gtk3 and gtk4 implementations. This will be used in an upcoming commit to set a11y names for the border items in Calc's sidebar. Change-Id: I958390d8736da8f1281f91586cacbefb5975e229 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169320 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-06-21tdf#161708 sw content controls: handle font color when exporting to PDF formMiklos Vajna
Export the bugdoc to PDF, the orange "date" lost its font color. This went wrong in commit 82d90529dc2b3cb8359dec78852cbd910a66d275 (sw content controls, rich text: add initial PDF export, 2022-09-12), we export the content control as a PDF form widget by default since then. Various properties like checkbox status and dropdown items were handled already, but not text color. Fix the problem by mapping the SwFont color to the widget descriptor color, this fixes the color of the already filled in content of the widget. Note that given this is a property of the form widget, the color is correctly applied also to strings filled in via PDF readers, interacting with the form. Change-Id: Id3e8611e415c0d571afe1cd14561c97b8a910ce9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169317 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-06-21tdf#146468: Fix typo and move commentsKira Tubo
Fix typo on variable RID_SVXSTR_TABLE_PRESET_OUTER and move comments about consolidating border tooltip strings to solenv/sanitizers/ui/modules/scalc.suppr See comments on Gerrit for more information: https://gerrit.libreoffice.org/c/core/+/169052 Change-Id: Ic5283e568e13023242858850dbce8922e2c80d8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169308 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-06-20tdf#144208 speedup doc with lots of redline(13)Noel Grandin
Add a custom method to SfxItemSet, to avoid some of the function calling overhead in a hot loop Change-Id: I525c9a696af941c6e39aa1677eb2a85f69c621bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169271 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-06-20tdf#161469 - Basic: align implementation now with the now function in calcAndreas Heinisch
Align the implementation of the now function in basic with the now function in calc to include the also nanoseconds. The precision is limited to milliseconds to avoid comparision inaccuracies. Change-Id: Ia85b653898f5849f67a171749725faab976b2a8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168706 Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-06-20annot: clone annotations in SdrObjects when the page is duplicatedTomaž Vajngerl
When the page is duplicated we need to clone all SdrObjects and with that also all the annotations contained in the SdrObjects. The annotations must also be added to the page, so that we can find them quickly. Previously we only cloned the annotations and relied that the SdrObjects would be automagically be created, but as the SdrObject are also cloned this creates a mess with duplicated objects with annotatins for the wrong page or annotation objects with missing annotation. Change-Id: I4bf53e4bd387fad9b0a8e4f43edd57c3d0fd34cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169256 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit c3281e071526f7efa9b7646a993476fc3f6ff8db) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169260 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-06-20loplugin:unusedfieldsNoel Grandin
Change-Id: I4bc67811e228b4806db9f9b9bf9fb0de0eb36de2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169263 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-20loplugin:unusedmethodsNoel Grandin
Change-Id: Ia216da9bd7764f2d21aaee761a02eafda88d892e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169257 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-06-20tdf#159906 - A11Y: Add new direct character formatting group levelBalazs Varga
for Formatted warnings and keep them not expanded (default) to avoid to many visible warning message on the sidebar. Change-Id: Ic251909d793198c3c4ce5e132b763c15ac1c9a9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169110 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
generated by cgit (git 2.34.1) at 2025-01-26 22:15:24 +0000