summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2014-11-04Make comphelper::ThreadPool explicitly noncopyableMatúš Kukan
Change-Id: Ie57d0194418dd17a4c83e2859d6a85129c4f95e6
2014-11-04Remove unused membersStephan Bergmann
Change-Id: I39b12a6290d13a5404dae60b0b16548b035f24d8
2014-11-04SdrFormatter: remove unused attributeJuan Picca
Change-Id: I70633d3a4cea72c21a644e5a2f25865d8ec52122 Reviewed-on: https://gerrit.libreoffice.org/12227 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-04Bin presumably obsolete SUNWS crackTor Lillqvist
Change-Id: I83038a7160251e59a2178e54859c2ab8e4bffe2e
2014-11-03vcl: Allow SalGraphics to draw gradients nativelyChris Sherlock
The aim of this patch is to allow for native gradient rendering in SalGraphics (i.e. let OpenGL do this natively). It is a two step process: 1. I need to allow gradient draw into SalGraphics, however the current completely intertwined with the metafile code in OutputDevice. I am seperating the gradient metafile code from the gradient drawing code. 2. After splitting the metafile stuff from the actual gradient drawing, I am now able to call on SalGraphics::DrawGradient(). This just calls on SalGraphics::drawGradient() which returns false if there is no way of drawing native gradients, and true if there is. If false, then we use OutputDevice's DrawGradient() functionality. Change-Id: Ibaaabe13b76a8e7a037d9f751b5f662653a50566 Reviewed-on: https://gerrit.libreoffice.org/12119 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-11-03Related: fdo#84844 Get rid of ColorControl and ColorPopupMaxim Monastirsky
Change-Id: Ie2d00cfbccefd69c8e46381b712620def655a798
2014-11-03Related: fdo#84844 Prepare border color status updateMaxim Monastirsky
The Sidebar button handles also the color of diagonal lines. Change-Id: I26d75472a8c9ca482274797127994d4546b1b3e8
2014-11-03vcl: merge DrawPolyLineDirect() and drawPolyLineDirectNoAACheck()Chris Sherlock
I've merged these two functions, I just added a new function parameter to switch on and off the AA check, this function parameter defaults to false so DrawPolyLineDirect needs to do the AA check each time. If bBypassAACheck is set to true, then we automatically enable AA. Change-Id: Id2d9b2036a41716590f7b87f658f5bb210964392 Reviewed-on: https://gerrit.libreoffice.org/12191 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-11-02vcl: Refactor OutputDevice::TryDrawPolyLineDirect()Chris Sherlock
I've renamed TryDrawPolyLineDirect() to DrawPolyLineDirect() and also renamed TryDrawPolyLineDirectNoAACheck() to drawPolyLineDirectNoAACheck(). However, at the same time I feel that there is no need to call on drawPolyLineDirectNoAACheck in most instances, because DrawPolyLineDirect does an AA check before it can continue anyway. There is one instance where constantly checking the AA check is inefficient because it's in a loop, in that case then we call directly on drawPolyLineDirectNoAACheck, but this is the only case it is necessary. Change-Id: Ie0320bfc45b5c0e1ac6ce35912da3e2897af9429 Reviewed-on: https://gerrit.libreoffice.org/12190 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-11-02revert the KeyCode assertsNoel Grandin
there are two many places it appears to trigger in real use. will have to fix those first. Change-Id: I536b7925033d5337ba360db3c2cf40ec205157ca Reviewed-on: https://gerrit.libreoffice.org/12193 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-02vcl: include variable names in definition of OutputDevice::DrawPolyLine()Chris Sherlock
Change-Id: Ifde547b0e883871a7d30e93adbe868faa74bef71 Reviewed-on: https://gerrit.libreoffice.org/12189 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-11-02vcl: rename OutputDevice::DrawPolyLineWithLineInfo() to drawPolyLine()Chris Sherlock
Change-Id: I145ebcfb92fc75f4558d3bf090093aef9e848136 Reviewed-on: https://gerrit.libreoffice.org/12188 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-11-01tools & vcl: move OutputDevice::ImplRotatePos() to Point::RotateAbout()Chris Sherlock
OutputDevice has a private function that rotates a point around another point. However, there is no real reason why OutputDevice should be responsible for this - it's really the responsibility of the Point class in the tools module. Therefore, I've moved this functionality out of OutputDevice and into Point, but I've renamed it from the rather confusing name "ImplRotatePos" to "RotateAround", which is what it actually does. Change-Id: If12fb40a7b476653224d4edfc01887bc91a80c7d Reviewed-on: https://gerrit.libreoffice.org/12171 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-11-01Unindent.Kohei Yoshida
Change-Id: I911de1c7b47768233bdd9580361b8cf430b3684e
2014-11-01second attempt at fixing my assertsNoel Grandin
it appears I can't trust the buildbots, they don't seem to be compiling with asserts Change-Id: Ia49f5d3f134cf1a578469ddcbc7c492383aa971d Reviewed-on: https://gerrit.libreoffice.org/12184 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-01fix assert I added to KeyCodeNoel Grandin
in commit 9044260c35b22aeb6 "add some asserts to validate KeyCode values" Change-Id: I73dc4c9ee5e4ced699d44ecdfb306a49b853f67e Reviewed-on: https://gerrit.libreoffice.org/12180 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: https://gerrit.libreoffice.org/12179 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-01add some asserts to validate KeyCode valuesNoel Grandin
Change-Id: I1b4b8d44f11086ed994a093fef0029982fac2c63 Reviewed-on: https://gerrit.libreoffice.org/12161 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-31thread-pool: fix waiting until all tasks are complete.Michael Meeks
Change-Id: Iaf5a3bf28879f229a223a8760fd878f96958a53c
2014-10-31callcatcher: a titchy bit more ww1 filter falloutCaolán McNamara
Change-Id: I38517bb7fbf4ab1e9314a28973b707223d7120e7
2014-10-31cid#1242936 handle rename failureStephan Bergmann
Change-Id: I92ce690a6f8183ce77c8ed53bd2fcb45d39d756e
2014-10-31Duplicate lineStephan Bergmann
Change-Id: I55811305ec24ff3538d33e98c8eac680e7da17fe
2014-10-31fdo#80403: Import baseclasses implement FastParser interfacesDaniel Sikeler
SvXMLImportContext implements XFastContextHandler SvXMLImport implements XFastDocumentHandler Change-Id: Id400260af112f4a448fe469c9580f0ebacec4ab6
2014-10-31drop KeyCode::IsDefinedKeyCodeEqualNoel Grandin
because it's implementation is the same as operator== Change-Id: If9b63abcd13f899735d59d85be3da54406a6e324
2014-10-31convert COMMAND_WHEEL constants to an enumNoel Grandin
Change-Id: I413d821a984ab556bd19c52704c04de6d828f699
2014-10-31KEY_ALLMOD is the same as KEY_MODNoel Grandin
so just dump it Change-Id: I006045aea345e84ff1944fc1ed1daa94bd7bca61
2014-10-30thread-pool: re-work termination semantics to avoid problems.Michael Meeks
We want a pre-spun-up, shared thread-pool that doesn't get its workers created & joined frequently. Change-Id: I29081e3a3e3849ca30e63fd080ee3315d99cbe8d
2014-10-30Move thread-pool down into comphelper for re-use elsewhere.Michael Meeks
Change-Id: Ib27b8b1ccc07ff194035d6c2ef3d45c429e3cea1
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-30Improve SvSimpleTable classPalenik Mihály
It is possible to order columns. This is set in Expert Configuration dialog. The header's itembits weren't set correctly therefore mouse click handler didn't do anything. The comparsion was slow on big table. Conflicts: include/svtools/treelist.hxx svtools/source/contnr/simptabl.cxx Change-Id: I7e1301d40433ef45b3d0a3fb300909345ede9d4d Reviewed-on: https://gerrit.libreoffice.org/12070 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-10-29Resolves: rhbz#1146169 a11y frames label dies before frameCaolán McNamara
Change-Id: Ie5650c3a5593dcf68196802169c47270a0c3b0e6
2014-10-29constStephan Bergmann
Change-Id: Ia76df719b2f76a993e65e0bf6d55723b1a2f5b93
2014-10-29constStephan Bergmann
Change-Id: I0d89cc99a1d8f7b3c17986b45653dce5e4b436d7
2014-10-29Improve framework for callgrind performance unit testsMatúš Kukan
Do not abort in tests which take longer then before. Since 4f5f6d2444a24138c3d3d378771f87cb06427195 we have nice tool to collect callgrind results, store them.. Also, make it not necessary to duplicate anything. Any test can be turned into a performance test by using callgrindStart/callgrindDump. You only need to duplicate the makefile name in gb_Module_add_perfcheck_targets. So, if the test is run as part of 'perfcheck', it runs under callgrind, otherwise it behaves like a regular unit test. Change-Id: I7acbb855b1823c9a32ba126abb57dccc767ca239
2014-10-29Resolves: fdo#85111 put a border around the custom properties boxCaolán McNamara
Change-Id: Ibdbfb4a88c1c75aaf5d33672d8639a9ea55afbac
2014-10-29tools: remove DBG_ERRORFILE and replace all callersMichael Stahl
Change-Id: Ic76ccc49b9291fe82c56974eb6237cd3b85d91c8
2014-10-29coverity#1202781 Division or modulo by zeroCaolán McNamara
Change-Id: I2908c57badd079c8f19c679f40ed815ce2cba374
2014-10-29coverity#1242433 SdrMakeOutliner alway derefs pModCaolán McNamara
so change from a pointer to a reference Change-Id: I81eb2c9e4df8353fbbdad7058c6ca7ea22286e62
2014-10-29ref-counting vcl::Window subclassesNoel Grandin
Points of discussion -------------------- (*) where in the Window destructor should dispose() be called? It's a seriously large method. (*) we're going to need similar typedefs and declarations for every single sub-class of vcl::Window, I assume that I will need to create a macro to make it less verbose. TODO ---- Update clang plugin to verify that: (a) dispose() methods always call their superclass dispose() (b) dispose() methods don't forget to clear any references owned by that class. Change-Id: I873d5d5166f811e2f65e49327cc98862559fcf30
2014-10-28Rename loadColorVector to addEntriesForColorVectorMaxim Monastirsky
So it will be similar to addEntriesForXColorList Change-Id: Ie352e0cf05fa6875ed76e69478131a57293b39a1
2014-10-28fdo#81356: use boost::rational internally in FractionJuan Picca
Change-Id: I6f40eafee7652209395bd471e3508fe3a3d19d73 Reviewed-on: https://gerrit.libreoffice.org/12085 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-28Move these headers from include to svx; they are not used outside svx.Kohei Yoshida
Change-Id: I8685b451a39e890250a3309ddb70346bac4084b2
2014-10-28sal_Int16 as the underlying type of WindowBorderStyleTakeshi Abe
because g++ 4.7.2 generates [-Werror=type-limits] as follows: > [build CXX] vcl/source/window/settings.cxx > [build CXX] vcl/source/window/paint.cxx > [build CXX] vcl/source/window/resource.cxx > [build CXX] vcl/source/window/accel.cxx > [build CXX] vcl/source/window/accmgr.cxx > [build CXX] vcl/source/window/brdwin.cxx > [build CXX] vcl/source/window/accessibility.cxx > [build CXX] vcl/source/window/legacyaccessibility.cxx > [build CXX] vcl/source/window/clipping.cxx > [build CXX] vcl/source/window/stacking.cxx > [build CXX] vcl/source/window/debug.cxx > [build CXX] vcl/source/window/globalization.cxx > [build CXX] vcl/source/window/btndlg.cxx > [build CXX] vcl/source/window/builder.cxx > [build CXX] vcl/source/window/cmdevt.cxx > [build CXX] vcl/source/window/cursor.cxx > [build CXX] vcl/source/window/debugevent.cxx > [build CXX] vcl/source/window/decoview.cxx > In file included from /home/tabe/core/include/rsc/rsc-vcl-shared-types.hxx:24:0, > from /home/tabe/core/include/vcl/keycodes.hxx:23, > from /home/tabe/core/include/vcl/keycod.hxx:26, > from /home/tabe/core/vcl/inc/svdata.hxx:35, > from /home/tabe/core/vcl/source/window/brdwin.cxx:21: > /home/tabe/core/include/o3tl/typed_flags_set.hxx: In instantiation of 'typename o3tl::typed_flags<T>::Wrap operator&(E, E) [with E = WindowBorderStyle; typename o3tl::typed_flags<T>::Wrap = o3tl::is_typed_flags<WindowBorderStyle, 12339>::Wrap]': > /home/tabe/core/vcl/source/window/brdwin.cxx:1027:44: required from here > /home/tabe/core/include/o3tl/typed_flags_set.hxx:105:5: error: comparison is always true due to limited range of data type [-Werror=type-limits] > /home/tabe/core/include/o3tl/typed_flags_set.hxx:106:5: error: comparison is always true due to limited range of data type [-Werror=type-limits] > cc1plus: all warnings being treated as errors > make[1]: *** [/home/tabe/build/workdir/CxxObject/vcl/source/window/brdwin.o] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [vcl.all] Error 2 > tabe@thunk:~/build$ Cf. a6b01d01f77f84517d267bdfe31de91b9050a70c Change-Id: Ic596eaf886d9aebb8a5b8636b5b90d5935aeadaf
2014-10-28fdo#84938: replace TIMEF_ constants with enumNoel Grandin
Change-Id: Ia6aa4e21fef46b20d1d8996d2f15855b8ba1776e Reviewed-on: https://gerrit.libreoffice.org/12114 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-27fix writing const arrays on big endianDavid Tardon
Btw, th unanounced byte-swapping of valuse in the input array in writeArray seems a bit dubious to me... It could too easily cause unintentional memory damage. I just hope it is always called either with data that is not used after that anymore or with a copy of the data. Change-Id: Ica0e9ea16cd101fe87d7e0a8fa696911769e0654
2014-10-27cid#705053 Dereference after null checkNoel Grandin
re-arrange the code to help coverity out Change-Id: Iddc9284cbdcbaae7a0dc17e62d0e8f4b4832297c
2014-10-27fdo#84844 Sidebar: Use SvxColorToolBoxControl for fill colorMaxim Monastirsky
Change-Id: I0aa9dbef960391334097b68c980064724435db38
2014-10-27fdo#84938: replace KEYTYPE_ constants with enumNoel Grandin
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328 Reviewed-on: https://gerrit.libreoffice.org/12104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-26fdo#84844 Sidebar: Use SvxColorToolBoxControl for line colorMaxim Monastirsky
Change-Id: I266cfd8c80088f698ec36662357477bb456a96fe
2014-10-24Forgot to update this commentMaxim Monastirsky
Change-Id: I3922bcf22b7efe43fd42c937d88251b230d6384a