summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2024-10-30win a11y: Move (Impl)InitAccessBridge logic to only callerMichael Weghorn
Now, with previous commit Change-Id: I42f0059cecd43205690d958a875d3c17ff9a197b Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue Oct 29 15:08:37 2024 +0100 win a11y: Stop using setting to indicate AT support in place, InitAccessBridge only gets called from the Windows- specific ImplHandleGetObject. Therefore, move the logic from ImplInitAccessBridge there and drop the InitAccessBridge and ImplInitAccessBridge functions. Change-Id: Id0d08478b84434b4ec03ab72b8af40e8ad51bd71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175796 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-30win a11y: Stop using setting to indicate AT supportMichael Weghorn
No longer use a "Accessibility"/"EnableATToolSupport" VCL setting to control/report whether support for assistive technology is (or should be) enabled, which was primarily used on Windows. As described in previous commit Change-Id: I32624b830d39d08510e4731edd06fd7a77642c50 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Oct 28 21:12:48 2024 +0100 win a11y: Drop "Enable AT Tool support" from options UI , that setting got automatically enabled when an assistive technology was active on Windows, and never got reset to "false" automatically, so AT support would be enabled next time LO starts as well. Instead of persisting this via a setting, enable the Windows a11y bridge if and when a WM_GETOBJECT message is received only, see `ImplHandleGetObject` (where this was already done earlier) and no longer alternatively start the a11y bridge in Desktop::Main when the mentioned setting is enabled. Drop MiscSettings::SetEnableATToolSupport altogether. Adjust MiscSettings::GetEnableATToolSupport to no longer read a setting, but return `true` if the AT bridge has been activated (or a SAL_ACCESSIBILITY_ENABLED environment variable is set, as was already checked before). This already returns `true` when called from MenuBarManager::FillMenuManager when starting LO while the NVDA screen reader is running. With this in place, the a11y bridge on Windows should now become active whenever an AT requests information (by sending a WM_GETOBJECT message), but not otherwise, and restarting LO will result in the a11y bridge no longer being active unless AT requests information again. Change-Id: I42f0059cecd43205690d958a875d3c17ff9a197b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175795 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-29fix enabled-mergelibs-more buildJuergen Funk
ErrCode::toString is needed by desktop/source/app/ unit tests now Change-Id: Ie7a9e67aca763c958d08f3826bca5df4e0d828f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175769 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-10-29tdf#130857 VclBuilder: Move extractResizable to BuilderBaseMichael Weghorn
Turn this local helper function into a static method in the BuilderBase class, for reuse in QtBuilder in an upcoming commit. Change-Id: Iee5d5c061c8b1bad3fefb7398111ad6815fc4c6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175776 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-29tdf#130857 VclBuilder: Move extractTooltipText to BuilderBaseMichael Weghorn
Turn this local helper function into a static method in the BuilderBase class, for reuse in QtBuilder in an upcoming commit. Change-Id: Ib1129801bc7315b1745d1b2690d59747c8db7ed6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175774 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-29test: Merge SwAccessibleTestBase and AccessibleTestBaseXisco Fauli
Change-Id: Ic62bd287406326f4c3d3e0702850fe0337f17686 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175762 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-29UnoApiTest: rename load to loadFromURL and use it everywhereXisco Fauli
Change-Id: Ie67eebec74f783fa0c29acfb23bb83bc582812b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175724 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-29tdf#130857 qt weld: Set button image set in .ui fileMichael Weghorn
Implement logic to set the image for a button, as specified via the "image" property for the "GtkButton" object in the .ui file. Similar to how VclBuilder::makeObject does it, extract an icon name and load an image using that one for "GtkImage" obejcts. Add another static `toQPixmap` variant that takes an Image parameter and use that one for conversion. For buttons, if the "image" property is set, get the corresponding QLabel object, get the pixmap from that one and set an icon in the button from that. With this in place, when opening the "Help" -> "About LibreOfficeDev" dialog in a WIP branch adding "cui/ui/aboutdialog.ui" to the list of .ui files in QtInstanceBuilder::IsUIFileSupported, the button to copy the version information now shows the corresponding icon when using the qt6 VCL plugin. Change-Id: If87866d7ab935cbc4162fb513074eefda22c981a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175761 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-29tdf#130857 Move loadThemeImage from FixedImage to BuilderBaseMichael Weghorn
This static helper method is currently only used by VclBuilder. Move it to the BuilderBase class, for reuse by QtBuilder in an upcoming commit. Change-Id: I229bc98e0de2dbe0788f07c7f4ff5e5426203de9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175740 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-29tdf#130857 VclBuilder: Move extractIconName to BuilderBaseMichael Weghorn
Turn this helper function into a static method in the BuilderBase class, for reuse in QtBuilder in an upcoming commit. Change-Id: I1e3318f22d83ddef4e7bf6269c7142f307ec6d1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175739 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-28don't use iterateItemSurrogates for EE_FEATURE_FIELDNoel Grandin
Change-Id: I96cd1728e2358d4ea49275952726aae85e6f52a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175726 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-10-27tdf#143148: #pragma once instead of include guardsLorenzo Lovato
Change-Id: I573a36a488e5a76f5dbe9d629ae0aaf23d3fc711 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175679 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-10-27Simplify a bitMike Kaganski
Change-Id: I142800a20b187ee31fa1cb393803035ed0e347d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175691 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-10-27tdf#143148 Use #pragma once instead of include guardsLue_lueita
Change-Id: I045cfd010401ed4131b28aab2e94308c226cc154 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175658 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-10-26tdf#130857 qt weld: Implement QtInstanceImage::set_imageMichael Weghorn
Extract a helper to convert a BitmapEx to a QPixmap from the existing helper function `loadQPixmapIcon` and add a new helper that converts a css::uno::Reference<css::graphic::XGraphic>& to a QPixmap reusing most of the code. Use that to implement the QtInstanceImage::set_image variant with that parameter type. With this in place, opening the "Help" -> "About LibreOfficeDev" dialog in a WIP branch adding "cui/ui/aboutdialog.ui" to the list of .ui files in QtInstanceBuilder::IsUIFileSupported now opens the dialog with brand image and LibreOffice Community logo present, but other aspects in that dialog still need attention before enabling this by default. Change-Id: Ide28c0dc126be511ec8e34e57f4f1df7e70297ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175666 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-25tdf#130857 qt weld: Prefer custom handler for dialog buttonsMichael Weghorn
If a custom handler is set for a button in a dialog's button box, skip the default handling (to close the dialog with the corresponding response code, unless it's the help button) in QtInstanceDialog::handleButtonClick, so that the custom handler gets processed instead (see QtInstanceButton::buttonClicked). This is similar to what the VCL implementation (see SalInstanceButton's ClickHdl) and the gtk3 implementation (see GtkInstanceDialog::asyncresponse) do. In order to be able to determine whether a custom click handler is set, make weld::Button::connect_clicked virtual and override it in QtInstanceButton::connect_clicked to set a property on the QPushButton object to indicate that a handler is set. Introduce a static helper method QtInstanceButton::hasCustomClickHandler that evaluates this property. Without this change in place, pressing the "Rename" button in Writer's "Rename Object" dialog that will be declared as supported in upcoming commit Change-Id: I0ac8f66b977f5d999bb197cc68e8ce5533fe1ebd Author: Michael Weghorn <m.weghorn@posteo.de> Date: Fri Oct 25 10:41:45 2024 +0200 tdf#130857 qt weld: Declare support for sw "Rename Object" dialog would not actually result in a bookmark getting renamed, only the dialog would be closed. Change-Id: If3e762100349ecd06c4e9415e9a8f9a44ec6491c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175633 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-25tdf#139152 Exporting Image or Drawing to PNG is missing metadaNoel Grandin
implement this in a similar fashion to how export to JPEG does it. Add a new method to calculate pixels-per-meter, because that is how PNG stores the values internally Change-Id: I1e4cd5a36af22e52a7c52f5b3bc2407f8523ef9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175636 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-25win a11y: Assert creating MSAAService succeedsMichael Weghorn
Add an assert that creating the MSAAservice/a11 bridge succeeds in ImplInitAccessBridge on Windows, as this should never fail unless the LibreOffice installation is broken. Drop the return values of the ImplInitAccessBridge and InitAccessBridge functions accordingly and simplify code calling them. While at it, also switch to using `#ifdef _WIN32` for the Windows-specific code in `InitAccessBridge` instead of having it in the `#else` branch of `#if defined UNX`, to align this with the `#ifdef _WIN32` condition for the `ImplInitAccessBridge` declaration, as that's the function that gets called. Even if the creation of the service should fail for some reason, the DeploymentException in ImplInitAccessBridge is still handled, so unless I'm missing something, this commit shouldn't cause any harm. The "EnableATToolSupport" setting would then incorrectly be set to true indicating that AT support is enabled, but besides being used in the a11y bridge code itself, that's only used to determine whether or not to pre-populate menus, so they are available in the a11y hierarchy before the corresponding (sub)menu gets activated, s. MenuBarManager::FillMenuManager, the corresponding commit that originally introduced this, commit 08fe2669a0ed807812d005195b54cc41f092d09a Author: Rüdiger Timm <rt@openoffice.org> Date: Fri May 13 06:29:54 2005 +0000 INTEGRATION: CWS tbe22 (1.25.30); FILE MERGED 2005/05/04 14:21:00 tbe 1.25.30.1: #i48612# Opening a menu with GOK shows Tips instead of entries (fixed by CD) and the referenced bug report [1], in particular comment 3 [2]: > TBE->CD: As discussed, the accessibility hierarchy is built up, but part of the > information is missing, e.g. Menu::GetItemText() returns an empty string. > Also keyboard shortcuts should be available. > In addition, the File/New menu and the File/Wizards menu are missing. > All this information is only available, after the corresponding menus have > been opened by the user. > > In OO.o 1.1.x all this was working. The AT tools require, that the whole menu > hierarchy is available as soon as the menu bar is visible, that means before > a user has opened a menu. > > The whole menu hierarchy must be only provided, if accessiblity is enabled. > This can be checked by > BOOL bAccessibilityEnabled = > Application::GetSettings().GetMiscSettings().GetEnableATToolSupport(); This commit is also in preparation of further simplifying the handling for that setting. [1] https://bz.apache.org/ooo/show_bug.cgi?id=48612 [2] https://bz.apache.org/ooo/show_bug.cgi?id=48612#c3 Change-Id: I46149ed215c354d33003513d55defe4920a7c381 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175565 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-25cid#1633781 Initialization or destruction ordering is unspecifiedCaolán McNamara
and cid#1633780 Initialization or destruction ordering is unspecified cid#1633778 Initialization or destruction ordering is unspecified cid#1633777 Initialization or destruction ordering is unspecified cid#1633776 Initialization or destruction ordering is unspecified Change-Id: I8ae7cbede6df2ad747fe57d0ac2800e1b6a31038 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175576 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-25tdf#130857 VclBuilder: Move extractActive to BuilderBaseMichael Weghorn
Turn this helper function into a static function in the BuilderBase class, for reuse in QtBuilder in an upcoming commit. Change-Id: I68c7e62816ff5fdd1c2a02cf5e42f90b32cff627 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175571 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-25speedup saving large XLS file with lots of query formula(2)Noel Grandin
reduce cost of OUString construction by avoiding initialising a temporary and then overwriting it. 12s to 10s Change-Id: I889152ba71947004ca7d5c96f073182c94d95ed5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175539 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-24tdf#130857 VclBuilder: Make extractEntry a static helperMichael Weghorn
... in the base class BuilderBase, in order to reuse it in QtBuilder in an upcoming commit. Change-Id: Ia115804a9d2bf22b47afb94d97109e9495b21cd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175530 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-24qt: Have just a single toQString(const OUString&)Michael Weghorn
Move the `toQString` helper function to include/vcl/qt/QtUtils.hxx where it can be used from multiple modules, instead of defining it twice for both, avmedia (avmedia/source/qt6/QtPlayer.cxx) and vcl (vcl/inc/qt5/QtTools.hxx). Change-Id: I7ffe06eaa3aaf3e7c8cc7aa1a4ac41b14db5c20c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175526 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-24tdf#130857 qt: Move pixmap helper to new include/vcl/qt/QtUtils.hxxMichael Weghorn
Introduce include/vcl/qt/QtUtils.hxx as a new header for Qt-specific utility functions that can be used in multiple modules, e.g. avmedia and the Qt VCL plugins in vcl. This is meant to be used only by code that already links in Qt. There's already vcl/inc/qt{5,6}/QtTools.hxx for helpers needed in vcl only. Initially, add a `loadQPixmapIcon` helper function that can be used to retrieve a QPixmap for an icon name and is extracted from QtPlayer::createMediaPlayerWidget in avmedia. It will be reused to implement the QtInstanceButton::set_from_icon_name logic in an upcoming commit. Change-Id: I9f25aa5ca8f00da97d06ecdd164a8fae10e492dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175524 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-23tdf#90341 Clean up excessive const_cast'ingUsman Akinyemi
These changes improve const-correctness and reduce the need for const_cast usage. Change-Id: I1275edfbc0ca5d49a5e8339d1ed11148f6decd1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174701 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2024-10-22no need to cache GraphicAttr in SdrGrafObjNoel Grandin
just retrieve the data when we need it, avoids marking this object dirty unnecessarily Change-Id: Ic3455e782365e8f2d3b89d8e5052da9d7bdaba2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175371 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-22We don't need a virtual hereCaolán McNamara
Only known SdPages need this Change-Id: Id504cd1ec318fa8cce43d11f03c628e7457f7634 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175369 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-22move vcl::DeleteOnDeinit to toolsNoel Grandin
so we can fix a shutdown use-after-free in sot. Change-Id: I32f83bd94627d72d7bee7ea2ebd6ab77a7f78435 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-22set stylesheet parent at creation timeNoel Grandin
avoids a bunch of broadcasting. a similar mega-master-page scenario as reported in tdf#158773 9.1 - 7.0s Some re-ordering of SVG output occurs, which means tweaking some unit tests. Change-Id: I447a4639a96c12c627a074f7e0f1ede8b3cbaf72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175299 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-21Optimize JsonToPropertyValues a bitMike Kaganski
1. Make it take string view: helps to avoid extra string allocation e.g. in desktop::jsonToPropertyValuesVector, and will help more, when C++26 stringstream ctor taking string view is available. 2. Factor out a function taking boost::property_tree::ptree, making implementation simpler for [][]com.sun.star.beans.PropertyValue and []com.sun.star.beans.PropertyValue, without writing a child node to a JSON string, and parsing it again. Change-Id: I16ac2641633ea67a7c9c054c9df09a790500e6fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175361 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-10-21improve style searching in SvXMLStylesContextNoel Grandin
We can searching without needing a std::map by sorting the style list. Which also allows to do prefix searching. Which we can use to dramatically reduce the number of styles we need to loop through in SdXMLStylesContext::ImpSetGraphicStyles. a similar mega-master-page scenario as reported in tdf#158773 13.5 - 9.1s Needed to adjust some unit tests because the order of iteration through styles is now different, which affects some file output. Change-Id: Ia7240fe520b70839d2519eba1fb70819a3c3bf81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175281 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-21drop StyleSheetCreatedNoel Grandin
the only place that references it, effectively ignores it. I cant find anything that really uses it, as far back in the git history as commit 59bb5ba445352f88e3ac2d00a5dc3f9bb872326a Author: Vladimir Glazounov <vg@openoffice.org> Date: Wed Apr 11 18:36:28 2007 +0000 INTEGRATION: CWS hedaburemove01 (1.1.2); FILE ADDED when it was introduced. Removing this removes a bunch of expensive broadcast operations. a similar mega-master-page scenario as reported in tdf#158773 20s -> 17s Change-Id: I84ee269aa0ea96e9f77601b01d4795edd3294044 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175175 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-21svx: prefix members of Viewport3DMiklos Vajna
See tdf#94879 for motivation. Change-Id: Ice9c1353d3411146f11d4ca34eb6369403cd4094 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175294 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-10-21Make tools::Time ctor taking sal_Int64 privateMike Kaganski
This ctor is meant to set the value of nTime directly; and that value is not nanoseconds, but an encoded value, using SEC_/MIN_/HOUR_MASK. But in some places, this ctor was misused for setting of nanoseconds, which would only accidentally work for values less than one second. All places that initialized tools::Time with 0, now use EMPTY. This makes the ctor private; and for the very few cases where really the encoded value of nTime is stored / restored, fromEncodedTime is introduced. Change-Id: I1f1994bd9aab1b51a41b1de637619049fe820da4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175283 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-10-21vcl: move bitmap filter headers into vcl/bitmap global header directoryChris Sherlock
Use #pragma once instead of header guards Change-Id: Iba43f2103628ed184933cf2611991e7aef9f0173 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173369 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2024-10-18tdf#163215: Enable kashida justification for AAT fontsJonathan Clark
Currently, we use HarfBuzz-provided kashida insertion position information to decide on positions to insert kashida. This data is used both while ranking kashida insertion positions, and to avoid inserting kashida in positions that would break shaping on a per-font basis. Unfortunately, HarfBuzz cannot validate kashida insertion positions for AAT fonts. As a result, kashida were previously not inserted for text using AAT fonts. This change updates kashida justification to skip validation against HarfBuzz when AAT fonts are used. Change-Id: If0d31512b1db0f1f8155963f9b1031eb01bacc45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175165 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-10-18tdf#163486: PVS: check GetMenu()Xisco Fauli
V595 The 'GetMenu()' pointer was utilized before it was verified against nullptr. Check lines: 1582, 1612. Change-Id: I085320d3a5467e4e2c158bf2683b3156cb103e8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175125 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-18Log using LOK_WARN instead of std::cerrCaolán McNamara
Change-Id: I3a3cabd90154cb7293949d6a21f599417c364b9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174370 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Attila Szűcs <attila.szucs@collabora.com> (cherry picked from commit 4baad2222e36fe2a71b2030b1a1292310821e104) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175123 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-18tdf#143148: Use pragma once instead of include guardsMelvinYG
Change-Id: Id648d25e47034e209b291bf73ac4878226b4e755 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175105 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-10-18tdf#158237 comphelper: Use C++20 contains() instead of find() and end()Sakura286
Change-Id: I3fc233ffc4c57b02e605306cb9bf3903a88401a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175116 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-17tdf#159007 Revert "optimization to skip SdrObject::GetViewContent()"Caolán McNamara
This reverts commit 313be607903a381830600c0a60b2e299fcaec685. Change-Id: I2dc7489ecc302473edd763fd0e4d6784fadc9bb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175094 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-17tdf#34804 sw: enable keyboard shortcut for CharColor and CharBackColorJustin Luth
The result of this patch is that a keyboard shortcut can now set the font fore-/back-ground color using the color shown in the toolbar/sidebar. This is now possible thanks to Maxim's work in 7.6.2 tdf#154270 Sync toolbar button recent colors and Andreas Heinisch's 24.8 commit 8c822b764b35a0116a0865e991a87c8315e0 tdf#72991 - Remember last used color depending in cui This patch does 3 things: 1. SetRecentColor when the app initializes 2. Uses SID_ATTR_CHAR_COLOR's recentColor for .uno:FontColor if no pItem was provided (i.e. a keyboard shortcut called it) 3. Uses SID_ATTR_CHAR_BACK_COLOR's recentColor for .uno:CharBackColor if no pItem was provided (Note that without a selection, CharBackColor isn't so useful for a keyboard shortcut, since it turns the drag-and-drop template on.) Setting the recent color right away is critical for user acceptance. Otherwise, it would only function after they first modified the color in the toolbar/sidebar. make CppunitTest_sw_uiwriter9 CPPUNIT_TEST_NAME=testTdf34804 Unfortunately, I can't reliably know if this request came from an awt::KeyEvent or not, because in that case we could just avoid CharBackColor's template altogether. [While there is rReq.GetModifiers() as a good hint, it is not a guarantee (in case assigned to a function key, or CTRL held while clicking the toolbar, etc.)] Change-Id: I7377f087dcdf7011205af005cd0d172100bade2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174804 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-10-17extract NaN payload test from single unit testSakura286
Change-Id: I51a029c9ac729352fe435b9a70c5e8bd2cf746b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174964 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2024-10-16tdf#160127: Improve grammar check popups from DudenMike Kaganski
When there is a grammar check error that it has no suggestions for, Duden may return a JSON without suggestions, but still informing about the type of the error, like ... { "offset": 468, "length": 8, "errorcode": 21, "type": "orth", "proposals": [] }, ... Before the change, we underlined the error, but right-clicking it would only bring the normal Writer's context menu, as if there were no error. This was made in commit 7697ef9d8fbbed7afba10c00ff9f5362d0540cdd (Proof reading suggestions:, 2023-11-28); before that change, the context menu was shown, but since it had no suggestions, and no explanation text, it was considered better to just not show the grammar check results. But no menu for an underlined word is no better; so let's instead show the explanation, based on the type of the error reported by Duden - that is stored in SingleProofreadingError::aShortComment. Also set aFullComment, which is used in the grammar check dialog. Incidentally, it even improves popups with suggestions, because it now has the explanation as well, where previously only was an icon without any text. It may be further improved in a follow-up, because there is "errorcode" in the message, which we may use to add more details to the explanation. tdf#160127 should be fixed with this, too; but if there are cases when there are neither suggestions, nor explanation available, it will need further work. Change-Id: I62cde204e0142d6226c9c9486f1cdb5ffc20dca8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175017 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-10-16tdf#143148 Use pragma once instead of include guardsAbrar Emad
Change-Id: I9df35198804cca98cd71c19fa4ef74fb6f47fd5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175013 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-10-16loplugin:unusedmethodsNoel Grandin
Change-Id: I6ba4b4046190b701d4a15c6fa90b6009ecf4ab1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175014 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-16loplugin:unusedfieldsNoel Grandin
Change-Id: If05b87f1e6c19b15b03b2695921a582e078d0f1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175011 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-10-16jsdialog: support textWithIconEnabled into Dump icon viewJaviya Vivekkumar Dineshbhai
Change-Id: Ib005da05fe500aae5729095533aab05578e567d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171679 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-10-16tdf#100894 speed up style tree creationNoel Grandin
by using bulk_insert_for_each() more aggressively. Reduces the open time from several minutes to 18s on my machine. I had to pass down a flag, because the gtk and the gen weld backends work differently, and the gen backend absolutely has to know up front if the inserter function is going to call set_text, otherwise it asserts in SvTreeListBox::SetEntryText Change-Id: I84750888c0a80f4041cfe024e6570dd94f6d09db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174757 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-15svx: prefix members of Camera3DMiklos Vajna
See tdf#94879 for motivation. Change-Id: I87d734dbfffb2335fb5e4d69c1ad753b52256ab1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174961 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-06 01:39:56 +0000