Age | Commit message (Collapse) | Author |
|
`WB_NOSELECTION` and `WB_SMART_ARRANGE` were
dropped earlier, so drop their doc as well.
There's no `WB_SMALL_ICON`, but `WB_SMALLICON`,
so adjust the name in the doc as well.
Change-Id: I8eb36d1184743f8e7a3e501f05e3f4b5a374e51d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170210
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
At least since
Change-Id: I52c40acf2024b25b0cd713fd7c91d7e0b59f4663
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Tue Jul 9 11:55:26 2024 +0200
icon choice ctrl: Drop WB_ALIGN_TOP
, it's quite clear that the `WB_ALIGN_LEFT`
is always set, so drop the flag and code paths
only relevant if the flag were not set.
Change-Id: If736ffc386833d3ff188d4174baf36bd2bcca57e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170209
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
The `WB_ALIGN_TOP` flag is never set, last
code path that would have set it (but was
apparently already unused back then) was dropped in
commit 80bf2654d72995f6b13c5addcd7c5e89ec76b0d9
Author: Caolán McNamara <caolanm@redhat.com>
Date: Mon Jun 23 15:34:02 2014 +0100
meChoicePos is always PosLeft, simplify
Change-Id: I40085b0db89484f0d24ecaccf910f4399198294d
Therefore, drop the flag and all related code
altogether.
Change-Id: I52c40acf2024b25b0cd713fd7c91d7e0b59f4663
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170208
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
This reverts commit 85fd526fc681a994415bb422090d1d23aa7d54f6.
Change-Id: I5019f72f88497f50a77666d57f2d16c2749bd1c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170218
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
where the use_count() call was happening without any kind of
synchronisation - switch to use std::atomic which does the right thing
for us
Change-Id: I79a6452f42bd425ea494bb0298dc134de5678813
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170217
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
Change-Id: Ifd22f5cc618137d715f78f0a04550256987752ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170186
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
Change-Id: I799129a3449ebcbb7b7005b933349cd2e6287860
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170185
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ibacb8bd52f5a9838540a68d238c3ed76eff6571b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170184
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I0e722e9438e7e21d4fa8ba05a9bd56719db521fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170144
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Tested-by: Jenkins
|
|
Change-Id: I529b642072becd1171d02598d57a9237e893fa2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170146
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
- import&export connections stream
- insert xl/connections.xml reference to [Content_Types].xml
- add Relationship::CONNECTIONS
- add support for xr16 namespace
- add ../customXml/item1.xml relationship to xl/_rels/workbook.xml.rels
- add import&export support for following xml elements in xl/connections.xml:
<connections>
<connection>
<dbPr />
<olapPr />
<webPr> (Web Query Properties)
<tables>
<m />
<s />
<x />
</tables>
</webPr>
<textPr>
<textFields>
<textField />
</textFields>
</textPr>
<parameters>
<parameter />
</parameters>
<extLst>
<ext>
(Any element in any namespace) <- TODO/LATER
</ext>
</extLst>
</connection>
</connections>
Change-Id: I1d1c10675b3fe5ffd6a35f1b91d4b83401be2cae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164290
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: Ibd9638f9716c4ce8db7ee5e652dc2f207617e7de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170162
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
- rename action: rendered_combobox_entry -> rendered_entry
- change generic get json property callback to more specialized
image getter as it wasn't used anywhere apart of that and we need
image enceded as base64 only not JSON
- add to the full update of icon view "ondemand" property to the entries
with images so LOK client will know it has to download the render
- it will be possible to support HiDPI renders in the future: added TODO
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I83a6e91133f8f9cb03e0bc794b51e1947435fa90
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169622
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170160
Tested-by: Jenkins
|
|
Only the permitted units are accepted, and must follow the number immediately.
Change-Id: Iccfcbe044334f28f31ba0f8e336f96e6147af694
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170137
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: Id673c27e21c6706367f2effc92bbea61c83a5482
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170133
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I7ad748b67266926f1e4e67e843a90b5ac3fe58b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170152
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Id27784da750e2cc9913c0d00df6e0b10d080f663
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170145
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
The presentation info includes properties like document size, if the
slide is visible, master slide information and similar.
[ Miklos: don't refer to removed tools::ScopedJsonWriterArray. ]
Change-Id: I5b0acff2ee0df351dd1859e02695ca249e17c391
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170155
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I9e0d23a81186231ebe314c14993b93e7c8a9d844
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170149
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
Change-Id: Ia52a4ce4bd9390872a89bdea0182de697e209180
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170148
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I759d5f225769d3833c6da664793a9d400a398a51
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170147
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I2cfca6f61c0247947855f40d6b1cdee521e8382d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170141
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
See tdf#94879 for motivation.
Change-Id: Idbba42dd3af7a47db6a56c3a129a4da54af076d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170135
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I68649c1b71fa5455f2bc2edd9d773820299e60f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170095
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I0a811d37996e53b9a9a0bddcc265521a1125d594
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170074
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: Ie85947371df087495a80179e4e0f2f660877e368
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166277
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
|
|
In the tools module it can be used in more other modules.
Changed the instantiation to increase the counter already in the
constructor, so no need to check if the ID is 0.
Also test for UniqueID
Change-Id: I77c80461875c69496a7e218534d16d6550c168c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170061
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
It's not really needed - it sets values to defaults, which are
already set.
Change-Id: If61edace7975cd438d86ee9774535c0f14868fd5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166275
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
document by highlighting the corrosponding entry in the "Manage
Changes" dialog and sidebar panel
Change-Id: I1f31580a4fe764dd800c6db1e9a4e2024db14c6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169692
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
|
|
Change-Id: Icb1df2b857568cf085b597e378094e7231286fce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170047
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I5d2030f1057f0a2232680ed60f4312331eca2926
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170063
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
UniqueID generates an unique ID (unique for all users of UniqueID)
and keeps the value for the object's life time.
Change-Id: Ic2cc1665e57b1984c231a050f82a330c9dcf1ffc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169691
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170017
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
found by doing some git grepping, we should now have values
for all items in the hierarchy
Change-Id: I397ca7e8f53f53737201385c4c8029b436895c1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170016
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
Change-Id: I6727def5dd42ecd5dae3ddd27d2af733b5883e09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170006
Tested-by: Jenkins
Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
|
|
In online the client side comments/annotations are used, so to
keep this behavior for presentations we only enable the core side
rendering of annotations when the document is a PDF. No change in
the desktop applitation.
Change-Id: I50ffd1b6d81d2fcf6ef9f821e783ae228e39e4e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169969
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
after commit 85fd526fc681a994415bb422090d1d23aa7d54f6
"fix and simplify the ItemInstanceManager mechanism"
The problem is that some *Item classes in sw/ and sc/
share WhichIds, and a whole bunch of SfxBoolItem
subclasses share the same SfxItemType enum value.
So we ended up mixing and matching objects
of different concrete subclasses in a given
*ItemManager collection.
Add some asserts to the global pool code to catch
issues like this earlier on.
Add unique value of the SfxItemType enum for all
the SfxBoolItem subclasses
Change-Id: I3c8d4e02be1cd412b0292e973a6498df5f8e7102
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170003
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ic96d53c113cd6ae5b805df5a8e80d4da7adfec59
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169966
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
Change-Id: Ic5c78a0de4e7edafc0ba97bf69d43c377f7b5503
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169633
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ic03c78f6dde68f5557d474147336fa62be6f3aaa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169967
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ic5838c929db9c08d6d9c6e1c87160dc2530105e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169847
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
This mechanism to manually sort the entries by setting
a link/pointer to the neighbours isn't actually used, so
drop the code to maintain a linked list.
See
Change-Id: I44eceb41866bb6d99ccea032f98637a42dabc9ee
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Jul 3 10:44:46 2024 +0200
tdf#161853 Drop always null SvxIconChoiceCtrl_Impl::pHead
Change-Id: Ib939145999725232d803103dc1fd0b49fa2d425a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169916
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
The flag is never set, so there's no need to
check or clear it either.
Change-Id: I63ab1272140a0d5386538e6b749ba0f652f49c38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169910
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
The flag is never set, so there's no need to
check or clear it either.
The only method setting it
(`SvxIconChoiceCtrl_Impl::LockEntryPos`) was dropped in
commit 18d18c8a5646868a8229dea9ffe3f46888c2bad5
Author: Joseph Powers <jpowers27@cox.net>
Date: Sat Jul 23 07:16:14 2011 -0700
unusedcode.easy: svxIconChoiceCtrl_Impl
Doing List cleanup, I ran into SaveSelection() and decided to delete it.
While I was in the class, I went ahead and cleanup them all up.
, but that method was already unused by then.
Drop the flag and related code.
Change-Id: I9b886f3a63444d502ef8c488437889a2b05e065a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169909
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
That flag is unused since `OApplicationIconControl`
was ported away from using `SvtIconChoiceCtrl` in
commit fd2ea8e03510c6a99ec8be6228b7422f6c5b182b
Date: Wed Aug 19 14:59:33 2020 +0100
weld OApplicationSwapWindow
, so drop it.
Change-Id: I0c6f191017b13fffee57d1e5eba1c03c05736ee2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169904
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
Since
commit af9413cb4ad49c0b4854c08cc2804644220755ae
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Tue Jul 2 11:53:27 2024 +0200
tdf#161853 icon choice ctrl: Drop support for non-single selection modes
, the `IconChoiceFlags::DownDeselect` and `IconChoiceFlags::DownCtrl`
flags are never set, so `SvxIconChoiceCtrl_Impl::MouseButtonUp`
wouldn't effectively do anything.
Drop it and the now unused flags.
Also drop the `SvtIconChoiceCtrl` override for
`Control::MouseButtonUp`.
Change-Id: I06808726389f31a426cba36e627b4305fb362bee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169903
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
The mechanism is currently broken because it uses hash values as keys,
in two different places. But hash values are not required to be unique,
and as soon as there are enough items of a given type, a collision is
inevitable.
So just simplify this whole mechanism. There is no reason we need
type-specific item managers. Stuff everything into a single global pool,
that uses hashing correctly.
Notes
(*) Performance, as far as I can tell, is the same or slightly better.
(*) I removed the NUMBER_OF_UNSHARED_INSTANCES thing, in favour
of just having a simpler mechanism
Change-Id: I9068baf9bf6fae2500ae5748c6d1aabe6c3a18a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169709
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
That bit is never set, so drop it.
Change-Id: Iffa13bd0a679505bdc47bc3fb5d828969ac9eb1b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169878
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Since
commit fd2ea8e03510c6a99ec8be6228b7422f6c5b182b
Date: Wed Aug 19 14:59:33 2020 +0100
weld OApplicationSwapWindow
, the `SvtIconChoiceCtrl` and its implementation
class, `SvxIconChoiceCtrl_Impl`, is only used
in `VerticalTabControl`.
That one was explicitly enabling
`SelectionMode::Single` in its ctor.
Therefore, other modes are unused.
Drop support for them altogether to simplify
the implementation.
This commit primarily drops `SvxIconChoiceCtrl_Impl::eSelectionMode`
and uses thereof, and allows for further simplification in
upcoming commits.
Change-Id: I0acde664d695571e9058b9829ad02745a4abaad2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169872
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
It's never set, so drop it, also to prepare for further
cleanup in upcoming commits.
Change-Id: Id1751b68e3666130a69b981f9095303115d30caa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169871
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Added and corrected quite some stuff to this basic
construct provided by Caolan (thanks again!). No
detailed descriptions here, but it's getting more
complete and faster.
May contain errors and is primitive-complete in the
sense that all gets rendered, but some basic stuff
that should be directly supported is still missing,
e.g. text rendering.
Adding this to allow people to check it out (speed)
also since it's not yet used as default in master,
so it's safe and also safes the changes publically.
To test it, use TEST_SYSTEM_PRIMITIVE_RENDERER as
set EnvVar in linux systems.
Change-Id: I25f795c9ea4ad4f3b99591304f8803dffa499436
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168911
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
|