summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2017-03-10coverity#1402152 Uninitialized pointer fieldCaolán McNamara
forgot to remove this unused member Change-Id: I596d9f95284d1e27c2ca86e4c1ee75fc38cb7fce
2017-03-09No need for extra heap allocationStephan Bergmann
Change-Id: I0844a0a8a3476cdb007ab1d587b15ce26c68783e
2017-03-09just calculate the scanline positionsCaolán McNamara
rather than generating a big offset table to dramatically reduce the amount of memory loading graphics takes Change-Id: I8a4b1dc5cbcb686d6b8570f2eeef61ee0fe25515 Reviewed-on: https://gerrit.libreoffice.org/35005 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-09Clean up uses of integer typesStephan Bergmann
Change-Id: I1155dfe3e2bcfe2c15c101c7373fcc9e161aa366
2017-03-09Fix "specialization in different namespace" error with old GCCsStephan Bergmann
Change-Id: I8b2c678ec70de3432bb335d7e76487ef44cd72a6
2017-03-09Clean up uses of integer typesStephan Bergmann
Change-Id: If022ca9de8db49b885065c32b4f6f89debae1392
2017-03-09mpScanBuf can be privateCaolán McNamara
Change-Id: I78d6f94f65c9f6e667840c26c1359aa1ab9ad794
2017-03-09Use o3tl::typed_flagsStephan Bergmann
Change-Id: I02b88e60a03441c3c4df6ed32616bb618089539c
2017-03-09convert SvxCellHorJustify to scoped enumNoel Grandin
Change-Id: I0dd88b5bf9e1aededfa2d94b6b2d3d26694fff33 Reviewed-on: https://gerrit.libreoffice.org/34968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-09Don't use SetDisplayable when enabling Unity modeMaxim Monastirsky
because now it tracks the global menu too, but all we need here is to hide the in-window menubar widget. Change-Id: Ic3c8c20b88d37430e80b682333ca384bccc3f697
2017-03-08Clean up uses of integer typesStephan Bergmann
Change-Id: Ia89668f12f93c9fada3ecf31851f8df2a2567979
2017-03-08make SfxGetpApp just get and move GetOrCreate to the peripheryCaolán McNamara
Change-Id: If3b22635e46dbccf0fad101f51bb653cbbcd3a32 Reviewed-on: https://gerrit.libreoffice.org/34957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-08convert SvxShadowLocation to scoped enumNoel Grandin
Change-Id: Ie51995579312328538263172cd3173641df89bca Reviewed-on: https://gerrit.libreoffice.org/34965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-08convert SvxCaseMap to scoped enumNoel Grandin
Change-Id: Iea77ddc21e9b2d5a021c08e323da9ccabf9d46bd Reviewed-on: https://gerrit.libreoffice.org/34963 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-08convert VclReferenceBase::mnRefCnt to oslInterlockedCountNoel Grandin
Which means that ref-counting VCL widgets is now thread-safe. Destroying them, however, is not safe without holding the SolarMutex, which will the subject of a future patch. According to my tests running 'perf stat make check', this costs us approx 2% runtime on a non-debug Linux build using gcc. Costs are quite a bit higher when building with clang, which might need further investigation. Change-Id: I737170b74ec79e6b7c7d586ed5be89a73ee83597 Reviewed-on: https://gerrit.libreoffice.org/34948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-08convert SvxAdjust to scoped enumNoel Grandin
Change-Id: I0df7a5313d6d62d0c657e62ef6014a3ddbab4639 Reviewed-on: https://gerrit.libreoffice.org/34941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-07loplugin:loopvartoosmallStephan Bergmann
Change-Id: Ia8c57fb69873d57c3271a8f6d497fecec3db1899
2017-03-07ofz: fix ppt import leakCaolán McNamara
Change-Id: I48b855f96464c74b76b473d5674fcdcc8388bf1b
2017-03-07only one use of GetLastSaveDirectoryCaolán McNamara
which is to get its value and do a const_cast dance to save and restore its value which is a strange thing to do just for one obscure dialog when no other use of the save/load dialogs does this Change-Id: I7700d7ed738d578869284d415197de06167001b5
2017-03-07make SfxApplication ctor privateCaolán McNamara
Change-Id: I85d2a112b1f7e6215480d89e038d6515d641d147
2017-03-07Remove unused include/systools/win32/comptr.hxxStephan Bergmann
(there's a close cousin in fpicker/source/win32/filepicker/ that's actually in use there) Change-Id: I3250112703f09871e7451257b0417d1d3c332f73 Reviewed-on: https://gerrit.libreoffice.org/34932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-07Remove redundant 'inline' keyword, Linux reduxStephan Bergmann
Change-Id: I10c7dbd6a7acce309b056a1ae57c39f00f22c46d
2017-03-07Add Tooltips for emoji toolbar controlAkshay Deep
Change-Id: I93d9fb1af42d83c7f7f518a1441f4666fd7ee30a Reviewed-on: https://gerrit.libreoffice.org/32231 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-06convert SdrTextAniKind to scoped enumNoel Grandin
Change-Id: Ie79aaf96a0d89c96c4ecd4ee8ccb0eabd3456bd0 Reviewed-on: https://gerrit.libreoffice.org/34916 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06convert HTMLTableRules to scoped enumNoel Grandin
Change-Id: Id8758955565579abd1f4687907d7fe06aaefa749
2017-03-06convert HTMLTableFrame to scoped enumNoel Grandin
Change-Id: I1353619ca11f867ca37dec3105e50ba9f3d70d54
2017-03-06convert HTMLInputType to scoped enumNoel Grandin
Change-Id: I3f6f6aadd813898ccff93154138a2fbf911b9c8f
2017-03-06convert HTMLScriptLanguage to scoped enumNoel Grandin
Change-Id: If87863b520da704410a6ad261330bbde7ef8008c
2017-03-06convert ScrollingMode to scoped enumNoel Grandin
Change-Id: Ice1628ba09998be455fd6a77a044cb403235d462 Reviewed-on: https://gerrit.libreoffice.org/34914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06templatize HTMLEnumOption::GetEnum methodsNoel Grandin
And consequently fix bug in htmlfld.cxx in the RES_DOCSTATFLD/SwDocStatSubType handling, where it was updating the m_bUpdateDocStat fields by comparing the wrong enum variable. Change-Id: If9a68699a9d375ace120a3bf4f4bf4d4ae20a8e0 Reviewed-on: https://gerrit.libreoffice.org/34857 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-05ubsan: add in all the valid value for NumberingType to the SvxNumType enumCaolán McNamara
/include/editeng/numitem.hxx:69:67: runtime error: load of value 52, which is not a valid value for type ´SvxNumType´ #0 0x2b29cf86dc41 in SvxNumberType::SetNumberingType(SvxNumType) /include/editeng/numitem.hxx:69:67 #1 0x2b29d5448771 in SwXNumberingRules::SetPropertiesToNumFormat(SwNumFormat&, rtl::OUString&, rtl::OUString*, rtl::OUString*, rtl::OUString*, SwDoc*, SwDocShell*, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sw/source/core/unocore/unosett.cxx:1851:25 #2 0x2b29d542f727 in SwXNumberingRules::SetNumberingRuleByIndex(SwNumRule&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, int) /sw/source/core/unocore/unosett.cxx:1517:5 #3 0x2b29d542b0e8 in SwXNumberingRules::replaceByIndex(int, com::sun::star::uno::Any const&) /sw/source/core/unocore/unosett.cxx:1180:9 make CppunitTest_sw_ooxmlexport CPPUNITTRACE="gdb --args" Change-Id: I4bb11dbe29e286e937f177aa436213ae40152399
2017-03-05Proper fix for multiply defined SfxEnumItem<sal_uInt16> with MSVCStephan Bergmann
With --disable-pch the original hack from f091259ad2ec1590714645839668580cd7b8c7c4 "convert SfxEnumItem to type-safe template class" doesn't happen to work: When linking sd, the occurrences of SfxEnumItem<sal_uInt16> in sd/inc/sdattr.hxx clash with those from editeng (where LanguageType is a typedef for sal_uInt16) and svl (as the respective include files from editeng and svl happen to not be included). For whatever reason, the explicit instantiation declaration without a __declspec(...) in include/svl/eitem.hxx doesn't seem to make a difference (at least with MSVC 2015 Update 3). Change-Id: I51b5943fe19a7184db9414192c6364f7c26b79eb Reviewed-on: https://gerrit.libreoffice.org/34903 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-04tdf#106304: Don't unnecessarily use bogus default char size for a:endParaRPrTor Lillqvist
Instead use the size last used for an a:rPr below the same WriteText() call. I am not exactly sure about how this hangs together, but this has the desired effect on the exported .pptx. Change-Id: Ie03dcd0b31c15cff8488b22d7423c9f9ad1e2d68
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03Typo: requirments -> requirementsSamuel Mehrbrodt
Change-Id: I02c5846eb51071e1a958c3d65e150fb7cbc7d58a Reviewed-on: https://gerrit.libreoffice.org/34873 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-03[API CHANGE] Remove SAL_CONSTEXPR againStephan Bergmann
...now that LIBO_INTERNAL_ONLY always has constexpr support. It had been added for LO 5.0 (effectively always expanding to nothing for !LIBO_INTERNAL_ONLY), not wrapped in '#if LIBO_INTERNAL_ONLY' presumably because it was assumed to be used freely in URE include files, but turned out to be only used in LIBO_INTERNAL_ONLY code. It is unlikely that any 3rd party code made use of it. Change-Id: I68970c5a2e2d7ef68ac5b79efc8dc1de54c43198
2017-03-03drop SvxNumType and rename SvxExtNumType->SvxNumTypeNoel Grandin
Both of them are abstractions over the css::style::NumberingType constants. SvxNumType serves no useful purpose, since it's just a typedef to sal_Int16. At least SvxExtNumType wraps up the css::style::NumberingType constants in a nice enum. Change-Id: I7b3f97cd42b0aa23aff7a4db4930da86149d4f4e Reviewed-on: https://gerrit.libreoffice.org/34816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03remove unused CreateDefault methodsNoel Grandin
Change-Id: Ifbdd7d41f0938e9a03693f88416792ff8087f8c2 Reviewed-on: https://gerrit.libreoffice.org/34850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03Fix typosAndrea Gelmini
Change-Id: I95fc63af11c336cde9f5bef908e1389c2fb56f02 Reviewed-on: https://gerrit.libreoffice.org/34823 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03Fix typosAndrea Gelmini
Change-Id: I5e3c9683741ddc66283008c20794be5c2b2bc53f Reviewed-on: https://gerrit.libreoffice.org/34804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03Remove uses of SAL_CONSTEXPR in LIBO_INTERNAL_ONLYStephan Bergmann
Change-Id: I9a7dc7c83302b3361f056fcf6636bbba7672f15f Reviewed-on: https://gerrit.libreoffice.org/34840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03use SvxExtNumType in SvxNumberTypeNoel Grandin
and follow the rabbit trail, fixing various other types in the process Change-Id: I8fc7df3b585df21578ffb28fdd7e5e427b3bfd9d Reviewed-on: https://gerrit.libreoffice.org/34814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03convert SfxEnumItem to type-safe template classNoel Grandin
and drop the SvxChartTextOrientItem class, unused. Change-Id: I99100837d1beb953450f57b2cda47d165df1620c Reviewed-on: https://gerrit.libreoffice.org/34747 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-02Remove HAVE_CXX11_CONSTEXPR, always true nowStephan Bergmann
...after 84b36c704d73362d4d86dc9e9c0efa0625958347 "Drop support for MSVC 2013". Make this a fatal configuration error for now. The check should be removed completely after LO 5.4 branch-off. Change-Id: I990fd8fcb4ec1327282df4efe21640c938d3cf06 Reviewed-on: https://gerrit.libreoffice.org/34821 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-02tdf#60874 Set custom HID for Protect Document windowGabor Kelemen
The window has its own help page but the SfxPasswordDialog has a default help page as well. We need to use custom help IDs here. The Password entry already has a custom HID however it is used on the default help page of SfxPasswordDialog. We need to set a custom help ID for the Confirm entry and use it in the scalc/01/06060200.xhp file like the one belonging to the Password entry. Change-Id: I9344c85cf362a1829202664315f8c8be0a265b59 Reviewed-on: https://gerrit.libreoffice.org/34501 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-03-02COMPRESS_OWN define is not used standalone anywhereCaolán McNamara
Change-Id: Iaca54d62a48711a7763cac98c6f303b952b2da29
2017-03-02don't need this STL hack anymoreNoel Grandin
Change-Id: Id0883060acf2ca73af5cce56e1cf9021c2fb121a
2017-03-02no need to use smart pointers for DataFlavorExVectorJochen Nitschke
DataFlavorExVector is a std::vector<..> typedef. remove odd void pointer in BrowseBox. return const references to keep getter const qualified. Change-Id: Iafd529a46b7511941c1dffc86d2066fdc4f07e28 Reviewed-on: https://gerrit.libreoffice.org/34767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-01ofz: timeout loading emf with move clip recordCaolán McNamara
Change-Id: Id5d60f0037873598e1447b063e66e9c29840587c Reviewed-on: https://gerrit.libreoffice.org/34740 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-01Blind fix for 64-bit Windows buildsNoel Grandin
Change-Id: Ica9e99fc363d8c7bfbc40dceb66ad350e5a02ce5
generated by cgit (git 2.34.1) at 2025-03-15 20:06:50 +0000