summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2019-05-28parallel deflate compression (one stream, multiple threads)Luboš Luňák
ZipPackageStream::saveChild() already had one threaded compression, but that still uses only one thread for one stream. Many documents contain many streams (where this is useful), but large documents often contain one huge content.xml, which then would be compressed using just one thread. But it is in fact possible to do deflate in parallel on the same data, at the cost of somewhat increased CPU usage (spread over threads). This is handled separately from the background thread path, as integrating these two approaches would probably be needlessly complex (since they both internally use ThreadPool, the tasks should often intermix and parallelize anyway). On my 4-core (8 HT threads) machine this reduces the compression time of tdf#113042 from 3s to 1s. Change-Id: Ifbc889a27966f97eb1ce2ce01c5fb0b151a1bdf8 Reviewed-on: https://gerrit.libreoffice.org/73032 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-28split out thread functionality from ZipOutputEntryLuboš Luňák
It can be easily separated out, it looked like hacked in. And I will need to do more refactoring of the class, so this shouldn't be more complex than necessary. Change-Id: I302da55409e9195274907ca4939c37fbb2427b18 Reviewed-on: https://gerrit.libreoffice.org/73031 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-27tdf#125271 under wayland without gtksink, try waylandsinkCaolán McNamara
and if there is no videosink then give up Change-Id: I6b60e7be1e77dbf5c4c277ccf47a4d121f3cd6a5 Reviewed-on: https://gerrit.libreoffice.org/72871 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-27tdf#42949 Fix IWYU warnings in include/svx/[sS][a-h]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I84fc75e06e61e5391aef6e237c36daad95dedb84 Reviewed-on: https://gerrit.libreoffice.org/72550 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-24tdf#101443 Calc multiline input bar reworkedThorsten Wagner
Change-Id: Ic35c9898624f0c13b6d64725808e765a64c17081 Reviewed-on: https://gerrit.libreoffice.org/71937 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-05-24Wrong downcast from svx::a11y::AccFrameSelectorChildStephan Bergmann
...to svx::a11y::AccFrameSelector (which are unrelated final classes). UBSan Calc "Format - Cells... - Borders - Line Arrangement - User-defined:" and clicking into the top-right corner of the widget caused > svx/source/dialog/frmsel.cxx:972:50: runtime error: downcast of address 0x60f0003dfa80 which does not point to an object of type 'a11y::AccFrameSelector' > 0x60f0003dfa80: note: object is of type 'svx::a11y::AccFrameSelectorChild' > e1 03 80 0d 90 4f c2 88 ce 7f 00 00 02 00 00 00 be be be be 00 00 00 00 00 00 00 00 00 00 00 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'svx::a11y::AccFrameSelectorChild' > #0 in svx::FrameSelector::SelectBorder(svx::FrameBorderType) at svx/source/dialog/frmsel.cxx:972:50 > #1 in svx::FrameSelector::MouseButtonDown(MouseEvent const&) at svx/source/dialog/frmsel.cxx:1114:21 [...] The code was like that ever since 60f11adb950e4f9645cc9ecb0f5af8235cc97366 "Integrate branch of IAccessible2", which had presumably confused AccFrameSelector and AccFrameSelectorChild here (while there'd apparently not been a deeper need for the static_casts anyway). Change-Id: I1f52629143dcfc84e57e9539a428fb0f51fdc72e Reviewed-on: https://gerrit.libreoffice.org/72910 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-24cannot create a shared_ptr from an existing objectNoel Grandin
so pass in the shared_ptr we already have (and enforce that we pass in the right one) Change-Id: Ic481b5ec17c34ed9cba50586dedb6184505dee24 Reviewed-on: https://gerrit.libreoffice.org/72908 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-23tdf#125447 get rid of ~ in STR_UNDO stringCaolán McNamara
Change-Id: Ifdd3df50b98641785a4b1d258092efe531e98e7d Reviewed-on: https://gerrit.libreoffice.org/72870 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-23rename SvxGraphCtrl back to GraphCtrlCaolán McNamara
Change-Id: I340b1695588bea0f1ce15685731c522907fdb7ee Reviewed-on: https://gerrit.libreoffice.org/72806 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-23rename SvxGraphCtrlView back to GraphCtrlViewCaolán McNamara
Change-Id: I658773f4fc0409a73de56301f5457fa1fb9e4a28 Reviewed-on: https://gerrit.libreoffice.org/72805 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-23rename SvxGraphCtrlUserCall back to GraphCtrlUserCallCaolán McNamara
Change-Id: I9c348e34a07ab269217f35633cb3a54ea4f7cf68 Reviewed-on: https://gerrit.libreoffice.org/72804 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-23remove now unused GraphCtrlCaolán McNamara
Change-Id: I6d4aca59d5f9e24521876c36853b663b65a2d200 Reviewed-on: https://gerrit.libreoffice.org/72803 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-23SFX_IMPL_FLOATINGWINDOW_WITHID is now unusedCaolán McNamara
Change-Id: I93f3dccb1aac4a018f5a5dd7af61024306099675 Reviewed-on: https://gerrit.libreoffice.org/72802 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-23weld FloatingContourCaolán McNamara
Change-Id: I055f01d2ce462009986801d4a603b0b72b1a621c Reviewed-on: https://gerrit.libreoffice.org/72787 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-23Add new customize and position merged dialogGülşah Köse
Change-Id: I898fb0830a9f53da4a7917cb5900f082e3a9d6b7 Reviewed-on: https://gerrit.libreoffice.org/71944 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-23Fix moving / orientation-changing ScrollBarJan-Marek Glogowski
Just implements Move the same way then Resize. More importantly the patch correctly resets the Thumb and Page rectangles to position (0,0) instead of just Empty, which ImplCalc is based on. Otherwise this results in broken scroll bars, when the StarMath elements window is docked in in the bottom or top area and switches the scrolling orientation on undock. Change-Id: I32b0507cdd6551cc7f42655a730faf8ef25b747b Reviewed-on: https://gerrit.libreoffice.org/72794 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-22VCL refactor duplicate code in ToolboxJan-Marek Glogowski
Moves duplicate code from ImplInitSettings and ApplySettings into their own functions. Change-Id: I65b5a052b171a661ee22762e373745c28779a9e9 Reviewed-on: https://gerrit.libreoffice.org/72790 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-22VCL keep / return the original set TextEngine fontJan-Marek Glogowski
TextEngine::SetFont copies the font parameter and then modifies its color, transparency, fill color and alignment, so passing the same font again will not be detected as the same font. Therefore this patch stores the original font in addition to the modified one and also returns that one on the GetFont call. This allows us to merge the font setup in VclMultiLineEdit's ImplInitSettings and ApplySettings into a common function. Change-Id: I618d283ecd0ae14faf9b87a3aceec6ca1c37b526 Reviewed-on: https://gerrit.libreoffice.org/72788 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-22tdf#120837 File saving at least 5 times slowerNoel Grandin
The problem here is that we never actually hit the maExportGraphics cache in SvXMLGraphicHelper, even though we are passing the same image down repeatedly. There are two bugs here: (1) BitmapEx::operator== does not return true if we instantiate 2 Graphic objects from the same XGraphic, so change it to use the more expensive operator==. To mitigate the cost, move the expensive checks to the bottom of the method. (2) in order to use an object in std::unordered_map, the object must implement an equality function and a hash function. If two objects are equal THEY MUST have the same hash value. Using the Impl* as the hash value does not satisfy that condition, so rather use the checksum, which does. After these fixes, the save time drops to less than a second. Also make the checksum method look more like the operator== method, and add a checksum calculation method for SVG data that more accurately reflects the underlying SVG data. Change-Id: I4ca0c7bee60b2efa6fe42301e582c7b278022b46 Reviewed-on: https://gerrit.libreoffice.org/72615 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-22tdf#42949 Fix IWYU warnings in include/svx/[h-r]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib7e1d0f7483aa8b5cab320278714f2d5f36fdbd9 Reviewed-on: https://gerrit.libreoffice.org/72534 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-21tdf#109158 short-circuit text width measuring with fixed width columnsCaolán McNamara
Change-Id: Id050bfa8b4dae70e2a3a45b2501bb071d82d14e5 Reviewed-on: https://gerrit.libreoffice.org/72601 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-21turn off OutputToWindow during dtorCaolán McNamara
Change-Id: I46d45c2487b7d4ac99d48ce0fc49bed120291f3c Reviewed-on: https://gerrit.libreoffice.org/72668 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-21Fix typoAndrea Gelmini
Change-Id: I7fd8a1657f0c39937860671de54e7f85e8f13a35 Reviewed-on: https://gerrit.libreoffice.org/72623 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-21Fix typoAndrea Gelmini
Change-Id: Ib4e99488025d2eedb08eff3690cbb57d0741f1f1 Reviewed-on: https://gerrit.libreoffice.org/72621 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-20calc item width on requestCaolán McNamara
Change-Id: Ifa56a903b3c3a3962fd2ecf76ff101976e17fc05 Reviewed-on: https://gerrit.libreoffice.org/72600 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-20Resolves: tdf#125369 recover newline support of tdf#101779Caolán McNamara
Change-Id: Ia46fc89f056c714e9a06c48e980277025fb16a61 Reviewed-on: https://gerrit.libreoffice.org/72602 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-20Use DBG_UTIL instead of OSL_DEBUG_LEVEL for the OOX dumping stuffTor Lillqvist
We want it to be possible to compile an arbitrary subset of the source files for debugging. DBG_UTIL, on the other hand, has to be consistent across the whole build. We should not use OSL_DEBUG_LEVEL to switch (internal) API on/off. Change-Id: Ia5111a36326ad7ad4c72d9e8f7ad88c8dbe8e272 Reviewed-on: https://gerrit.libreoffice.org/72616 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-05-20split width/height to allow intercept of how width is calculatedCaolán McNamara
in order to possibly get width on demand Change-Id: I1e6fcb6849705f2b166821516ebe72b179e00ee7 Reviewed-on: https://gerrit.libreoffice.org/72513 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-20tdf#125360: PPTX: Shape fill transparency is not exportedTamás Zolnai
.. if the original shape fill is defined with a theme Override the alpha value with the current value get from FillTransparence API attirbute even if the color is defined with a style or a color scheme. Change-Id: I09d26238a9c2b501279e6749687dc535e614bbd6 Reviewed-on: https://gerrit.libreoffice.org/72596 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-05-20Related: tdf#109158 GtkTreeStore append performance is poorCaolán McNamara
so prepend in opposite order Change-Id: Ibfa2878d999b945e774b5a90309a663f11b132b5 Reviewed-on: https://gerrit.libreoffice.org/72488 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-20Fix typosAndrea Gelmini
Change-Id: I4922f95ebc38e80e471139880ed894eda89402a8 Reviewed-on: https://gerrit.libreoffice.org/72142 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-05-20lok: update graphic selection callback descriptionMarco Cecchetti
Change-Id: I1ae073cc8e307b5c42aed9b17d405ef36ce4dc43 Reviewed-on: https://gerrit.libreoffice.org/70569 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2019-05-19tdf#125207 [API CHANGE] extend css.awt.PrinterServer: XPrinterServer2brinzing
Change-Id: Ic2df8ac676ae786d9c0ea2ab3619f9f9de087ca7 Reviewed-on: https://gerrit.libreoffice.org/72135 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-19Fix nillability of ooSetupLastVersionStephan Bergmann
...that had been introduced with 5187d3ae495a07373a12fd5980c9269bc8ce3f8f "Resolves: tdf#69042 - Add a 'What's New' infobar": * Make the default value nil instead of an empty string. * A nilable prop can't reuse the legacy utl::ConfigManager framework to obtain string prop values, so drop it from there and directly use the direct-access functionality in SfxViewFrame::Notify. Change-Id: I5fc67a3d7e0fcb44a218889ecf8c69e81661567e Reviewed-on: https://gerrit.libreoffice.org/72485 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-19tdf#123793 Follow up fix for kb nav of special chars popupJim Raykowski
Static variable use to determine if initializing can focus properties of recent and favorite controls is needed only allows init to ever happen once. This patch changes use to a member variable. This corrects the problem of kb navigation only works the the first time the popup is shown and tab is used to navigate. Change-Id: I2bbb66071b582c9a4282c79d801b4a36c375ed2d Reviewed-on: https://gerrit.libreoffice.org/72264 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-05-18tdf#125254 Performance: A spreadsheet opens too slow, NameSpaceEntryNoel Grandin
NameSpaceEntry does not need to be a weak object, it is sufficient to be ref-counted. The empty string in SvXMLNamespaceMap can be statically allocated. Don't allocate a NameSpaceEntry in GetKeyByAttrName_ if we don't intend to cache it. Takes the load time from 39.5s to 38.5s. Change-Id: I4a9a1296af84c12d44e9b3ff354297f37d29f1e8 Reviewed-on: https://gerrit.libreoffice.org/72515 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-18tdf#125346: PPTX export: Shape has wrong fill color comming from themeTamás Zolnai
Write the correct theme path to the InteropGrabBag, the same path what is generated and checked in the export code. Change-Id: I32617c1a11cf3bafb142f7c8839b498aaac49aa0 Reviewed-on: https://gerrit.libreoffice.org/72500 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-05-18Adapt AutoFormatHelper to std::unique_ptrArmin Le Grand
Change-Id: I3087a7e95e73dbcda798ca62705f7941a6466ccb Reviewed-on: https://gerrit.libreoffice.org/72401 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2019-05-17tdf#115813 unit test for handle position of OOXML shapesRegina Henschel
The patch contains some additions to tdf#115813 and a unit test. The test covers nearly all OOXML preset shapes with handles. Only some shapes do not fit to the test pattern: swooshArrow and polar handle shapes arc, blockArc, chord, circularArror, mathNotEqual, pie, leftCircularArrow, leftRightCicularArrow. The shapes star24 and star32 are excluded because of tdf#125181. The shapes gear6 and gear9 are excluded because a correct handle movement is not yet implemented. Connector shapes are inserted as ordinary shapes to prevent converting. The error string is designed to identify the affected shape. Change-Id: Icd3358f3701ac2db2cc61eb045ae10bc4b72b9ca Reviewed-on: https://gerrit.libreoffice.org/72229 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-05-17drop now unused SFX_IMPL_MODELESSDIALOG_WITHIDCaolán McNamara
Change-Id: I5c764847218d95289b64ee51e39665dfca8cde69 Reviewed-on: https://gerrit.libreoffice.org/72273 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-17there's already a way to customize the invalidationCaolán McNamara
Change-Id: I486494de730b8665e56cfc664b62830fb0b8b8ee Reviewed-on: https://gerrit.libreoffice.org/72415 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-17weld SvxIMapDlgCaolán McNamara
Change-Id: I5418176a015e61ef8eee4c2acd8e84b008f76f82 Reviewed-on: https://gerrit.libreoffice.org/72249 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-17Resolves: tdf#69042 - Add a "What's New" infobarheiko tietze
Shows an infobar with a link to the respective wiki page Adds a button to the About dialog Replaces If6eb1542d2ad310226f76850f480f2f99070b803 Change-Id: I1eeb504994a6364feb90cfa447029875e0ec1969 Reviewed-on: https://gerrit.libreoffice.org/72218 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-05-17sw btlr writing mode: implement UI for fly framesMiklos Vajna
Change-Id: Id183dccb5802a1be0180471140266f3dd7a8123d Reviewed-on: https://gerrit.libreoffice.org/72428 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-17allow a OutputDevice parent where that is sufficientCaolán McNamara
Change-Id: I2920ea1a82de5eacbfeceafbb3c63693dd4365db Reviewed-on: https://gerrit.libreoffice.org/72414 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-17split out toplevel window area invalidateCaolán McNamara
Change-Id: I840ed6cbb3f7950230b1f7169ae3245a4a669249 Reviewed-on: https://gerrit.libreoffice.org/72410 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-17allow overruling treatment as not-WindowCaolán McNamara
Change-Id: I26f987b1c2993f50cb67d89a68daf4ec82641700 Reviewed-on: https://gerrit.libreoffice.org/72383 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-16Introduce vcl::lok::unregisterPollCallbacks() and clarify isUnipoll()Tor Lillqvist
There was a problem in the iOS app where a callback was done passing a registered mpPollClosure that pointed to the mainKit variable in lokit_main() even though that variable had already gone out of scope and been destructed. Introduce unregisterPollCallbacks(), which just sets the mpPollClosure pointer to null. That means no callbacks should be done any more. It does not mean that Unipoll would not be active. Change isUnipoll() to look at whether the mpPollCallback pointer has been set or not. Change-Id: I5d5527c0ef097682679371dc642f8896ff05450d Reviewed-on: https://gerrit.libreoffice.org/72283 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-05-16tdf#125254 Performance: A spreadsheet opens too slow, part1Noel Grandin
This takes the opening time from 55s to 48s for me. Change-Id: Ia60fff33e9948e0bd6906c82b48aa30f8b2551bb Reviewed-on: https://gerrit.libreoffice.org/72394 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-16tdf#42949 Fix IWYU warnings in include/svx/[e-g]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I861d3f0fa15ee3b7e0e830c4fac2e5794ea4071b Reviewed-on: https://gerrit.libreoffice.org/72213 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
generated by cgit (git 2.34.1) at 2025-01-30 14:16:19 +0000