summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2021-06-24BmpScaleFlag::Super is deadNoel Grandin
ever since commit 2269ac65de127d33d41843ae15f6bece5bc778bc Author: Michael Meeks <michael.meeks@collabora.com> Date: Fri Nov 7 05:42:51 2014 +0000 icontest: remove hand-coded opengl path. Change-Id: Ida030be0e087353e20897a9e961c9ce1134b21e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117782 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-24remove uno::Type move constructorNoel Grandin
not necessary for the optimisation I was going for, and actually less efficient than just using the copy constructor Change-Id: I0f2019a0bf032283fb6c8d5d834603ea7a5ce3c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117762 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-24uno::Type needs a move operatorNoel Grandin
speeds up some operations where Type is stored in a vector Change-Id: Id7112e51d4e4707bc6d261313e994c6ffef54d31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117693 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-24Delete copy ctors/assignments for DLLEXPORT classMike Kaganski
... instead of including <vcl/window.hxx> where it is not directly used. For details, see commit ee405fb2ef36337851801f1bd34411c606d55988. This reverts commits 6aa6b6c814b0353768fa7276d1f11d69a0ebedba and beeb19b361213d22247e5cb776dc522cbf190ca8. Change-Id: Ia91f3c303e1df0a698d06cdef1d8e64e99d781ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117751 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-23tdf#135316 add SvFileStream::SetDontFlushOnCloseNoel Grandin
if we're going to be deleting a temporary file, there is no point flushing it on close, which has a measureable cost This takes my load time from 17s to 16s Change-Id: I2fce7eeaf0ce9fef826b4ce9a1a4d4c8114cac76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117607 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-23The Chrome Trace Event viewer doesn't support nested async eventsTor Lillqvist
Instead of nestable b(egin) and e(nd) events, generate the allegedly deprecated S(tart)' and F(inish) events. Makes the code simpler. (And AsyncEvent is still unused. Unclear whether adding it was based on a misunderstanding.) Change-Id: Ic029b67e0951dda775c0d0af009f2e431ae55e53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117700 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-06-23tdf#92525 tdf#142398: fix export of simple custom shapesAttila Bakos (NISZ)
Most of the custom shapes were exported with DrawingML custom geometry instead of DOCX preset shapes, losing their preset type, adjust handles and text position. Add a preset exporter class to handle all possible preset shapes later, and fix the export of the following shapes now: "bevel", "blockArc", "bracePair", "bracketPair", "hexagon", "octagon", "parallelogram", "plus", "roundRect" and "triangle". tdf#92525: keep text position in triangles with different adjustments, too. tdf#142398: part 1: export simple shapes as preset shapes. Change-Id: I6aee74f7670bea8c1fe5909cbf307778ea728669 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115606 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-06-22simplify and improve WildcardNoel Grandin
it is faster to just process OUString data, rather than perform expensive conversion to OString and back again. Change-Id: Ie007b872ee507ac5c6e8b55cc0a49ef3ac1f0139 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117608 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21create SfxHintId::SwLegacyModify idNoel Grandin
to avoid expensive dynamic_casts in writer Change-Id: Ic73ae7d4af985043f8533913b33939e3445ec7de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117586 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21Delete copy ctors/assignments for DLLEXPORT classMike Kaganski
Their default definitions may create/destroy temporary OutputDevice objects, which requires that the class is defined at the site of instantiation of the implicit definition. The solution is to delete these unused methods. If they would happen to be needed, then move the default definitions to the correct place. This reverts commit 30a17b05fb8a860c1e53cb7cfc405b1cea0a9d15. Change-Id: I43f4e76763ff4409e9527f44cd2d8e227982257c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117574 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-21bundle the FolderPicker instantiations behind a single callCaolán McNamara
in prep to add parent support Change-Id: I2aa4b9343f895ae866f600dd3260b7fdc4e1efec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117579 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21tdf#142590 PPTX import: fix custom slide show use as defaultTibor Nagy
If the PPTX file contains a custom slideshow, which set by default and opening in Impress, this setting wasn't imported. See also commit 312334f8488a668e9b5302959b60292ce151e4fc "tdf#47365 PPTX export: support loop attribute" and commit a4b66458a7b8da2f5580014813e5dabe3fa670b6 "tdf#125071 PPTX: fix missing custom slide show export". Change-Id: I9c2b3773f6883ee795f119df5b8534fcdfa6618f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117172 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-06-21drawinglayer: put BufferedDecompositionPrimitive2D in its own fileTomaž Vajngerl
And fix includes all over the place... Change-Id: I6e2696bbeeac6ab7467cac70545fa7209aa981a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117528 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-20Fix typosAndrea Gelmini
Change-Id: I70d723ea2d0cad5a28840e250ae261aab6a08bfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117514 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-20Include the header to workaround MSVC bug (shows with disabled pch)Mike Kaganski
https://developercommunity.visualstudio.com/t/error-c2027-use-of-undefined-type-with-declspecdll/1455069 [build CXX] oox/source/core/filterbase.cxx C:\lo\src\core\include\rtl/ref.hxx(129): error C2027: use of undefined type 'OutputDevice' C:\lo\src\core\include\oox/helper/graphichelper.hxx(50): note: see declaration of 'OutputDevice' C:\lo\src\core\include\rtl/ref.hxx(127): note: while compiling class template member function 'rtl::Reference<reference_type>::~Reference(void)' with [ reference_type=OutputDevice ] C:\lo\src\core\include\vcl/vclptr.hxx(216): note: see reference to function template instantiation 'rtl::Reference<reference_type>::~Reference(void)' being comp iled with [ reference_type=OutputDevice ] C:\lo\src\core\include\vcl/vclptr.hxx(64): note: see reference to class template instantiation 'rtl::Reference<reference_type>' being compiled with [ reference_type=OutputDevice ] C:\lo\src\core\include\oox/helper/graphichelper.hxx(140): note: see reference to class template instantiation 'VclPtr<OutputDevice>' being compiled make[1]: *** [C:/lo/src/core/solenv/gbuild/LinkTarget.mk:301: C:/lo/src/build/workdir/CxxObject/oox/source/core/filterbase.o] Error 2 Change-Id: I50ee1bf97b7075224525525ef074c0ffcc168485 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117507 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-20cid#1485150 suppress Uncaught exceptionCaolán McNamara
Change-Id: Ic1b2a44afd15e0720edd48f3502dd2799795551a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117508 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-20drawinglayer: remove ImplPrimitive2DIDBlock macroTomaž Vajngerl
We can just implement the simple getPrimitive2DID method in all primitives. The ImplPrimitive2DIDBlock macro doesn't save us anything. Change-Id: I02f44d4891d7b340220890bf52a7ebfc8e41850a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117509 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-19SvMemoryStream::GetSize can be more efficientNoel Grandin
Change-Id: I6d60d6549089e049d730c1000ab7ec592924c685 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117499 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-19fix loading calc files with embedded form macrosNoel Grandin
GraphicHelper was trying to use the current frame/ window to convert values, but during initial load there is no current window. Change-Id: I8a79501df1d2e83a13d3cfb64ae8e66152c60561 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117470 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-19loplugin:finalclassesNoel Grandin
improve the plugin to detect more cases. I only apply the new final changes to classes in /include here. Which reveals that RoadmapWizard::getPageController( TabPage* _pCurrentPage ) will always return nullptr Also needed to sprinkle some SAL_DLLPUBLIC_TEMPLATE around to workaround Visual Studio linking problems. Change-Id: Iadb7d46a9e0e73dabce562375ca013c0fea6690c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117365 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-19svx: prefix member variables for SdrTextObj and othersTomaž Vajngerl
All classes in svdotext.hxx Change-Id: Ib15deca2a625d8352a2572d9fc3e15188b4e718a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117478 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-19svx: use constexpr instead of a define for a constantTomaž Vajngerl
Change-Id: Ie2fdd0dbe2c6d8e5c9ff406af5d2be20383fe62b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117477 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-19svx: prefix member variables for SdrCreateViewTomaž Vajngerl
Change-Id: I4fb067201d3285b8aad8877bba2f018aab41c026 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117476 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-19svx: remove whitespace in member variablesTomaž Vajngerl
Change-Id: Ie841bd3c9449ac7b227ae6adc4df49ad452b59ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117475 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-18tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWNArmin Le Grand (Allotropia)
Rename ::StateChanged methods using SfxItemState to allow better analysis of SfxItemState/SfxPoolItem usage(s), discussion see tdf#130428 comment 30 Change-Id: I736be0160ad7a9b7882c1c8a4cc05d9396ee3305 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117366 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-06-18Add Last 4 UNO Commands To CrashReport DumpGopi Krishna Menon
Adds last 4 uno commands executed in CrashReport to assist in investigating the crashes Change-Id: Ib7307ffc62d6d51d52f9d5e7fabefc2eaf858e5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117388 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-06-18Add Active Sfx Object Name To CrashReport DumpGopi Krishna Menon
Adds Active-SfxObject field in CrashReport to assist in investigating the crashes Change-Id: I08637a66ae95977e7afe4f5dce634b46c928a423 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117318 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-06-18VCL graphics rendering tests that a run on LO version changehomeboy445
This commit includes the implementation of graphics rendering tests which would be automatically triggered at first installation or upgrades of LibreOffice. These tests check the graphic rendering interface of LibreOffice by drawing and checking various graphical rendering tools (eg:. by drawing lines, polygons etc.). After the successful completion of tests, their results are stored in the user folder for future reference. Change-Id: I59c94b57a1f3f3a9cba55af1067a9702b6da98d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116779 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-17tweak tools::Color::IsDark so it triggers on UbuntuNoel Grandin
in dark mode, otherwise some of the UI elements e.g. the start centre brand image, do not display the right version Change-Id: I3bfdc597324b564a9dbd47174332bb5f21b6a052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117383 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-17use string_view in the Translate APINoel Grandin
Change-Id: I0bb0ea9d39ed623928060ffd3f2e2bc36ba33209 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117272 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-17Adapt o3tl::temporary to C++23 P2266R1Stephan Bergmann
With the recent implemenation of <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p2266r1.html> "P2266R1: Simpler implicit move" in Clang 13 trunk as <https://github.com/llvm/llvm-project/commit/bf20631782183cd19e0bb7219e908c2bbb01a75f> "[clang] Implement P2266 Simpler implicit move", a --with-latest-c++ build started to fail with > In file included from sal/rtl/random.cxx:25: > include/o3tl/temporary.hxx:21:62: error: non-const lvalue reference to type 'double' cannot bind to a temporary of type 'double' > template <typename T> constexpr T& temporary(T&& x) { return x; } > ^ > sal/rtl/random.cxx:97:37: note: in instantiation of function template specialization 'o3tl::temporary<double>' requested here > return std::modf(random, &o3tl::temporary(double())); > ^ etc. (And fixing that by adding the recommended static_cast then triggered a false loplugin:redundantcast warning.) Change-Id: I222429e9872afdedf77a07014c0a2e9e06c60b50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117335 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-17Drop the "console" functionality of ProfileZoneTor Lillqvist
It was not used anywhere and had not been cherry-picked to the relevant vendor production branches so apparently it was just some temporary experimentation? It is good to reduce complexity and increase code similarity between branches. Change-Id: Ib6717063f96d901d65ec36d65f3683af31065f2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117364 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-06-17svx: prefix member variables SdrViewEvent SdrView SdrObjGroupTomaž Vajngerl
Change-Id: Ic20c9dc7b8109cb095a883f2dfcec3e4f10b2428 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117352 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-17tdf#90401 xmloff: remove personal info of comments and changesLászló Németh
If Options → LibreOffice → Security → Security Options and Warnings → Options... → Security Options → Remove personal information on saving" is enabled. Use the same time (1970-01-01T00:00:00) for mandatory time stamps, and replace authors and creator-initials with "1", "2", "3" etc., also to avoid of joining adjacent redline ranges. Note: to see the work of the unit test in Linux command line: (cd sw && make UITest_writer_tests7 UITEST_TEST_NAME="tdf90401.tdf90401.test_tdf90401_remove_personal_info" SAL_USE_VCLPLUGIN=gen) Change-Id: I3b4d710dbeeee12177aff378597cd2b683ca6c25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117319 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-06-17svx: pragma once for some SdrObject subclassesTomaž Vajngerl
Change-Id: Ibbadf5069fbf5327a8a5964a3003bf6e258fd00b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117351 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-17basegfx: change template param to use int instead bool - Tuple2DTomaž Vajngerl
Change-Id: I82bf089ea95fc3b2b527aa55cc8c9f09aa684502 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117353 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-17basegfx: generalise tuples with template class Tuple2D and Tuple3DTomaž Vajngerl
B2DTuple2D, B2ITuple2D and B2I64Tuple share a lot in common so we can generalise it as a template class. The same goes for the 3D variants - B3DTuple and B3ITuple. This is the initial attempt, but doesn't yet generalise all that is possible. Add some tests for the tuple variants that test the behaviour of overloaded operators and other common methods. Change-Id: Iee5ed15d58ea88e65ee7854bd05a87ceab22023d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117104 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-17basegfx: change template param to use int instead boolTomaž Vajngerl
Change-Id: I5e0f52ba9b9a82ad702204a2d35ea49a8d74aa55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117326 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-16Move enable_if from dummy template parameter to return typeStephan Bergmann
...and drop the no-longer necessary loplugin:implicitboolconversion exclusion (which had been necessary to avoid > [CXX] vcl/source/window/dockingarea.cxx > In file included from vcl/source/window/dockingarea.cxx:26: > In file included from vcl/inc/svdata.hxx:26: > include/o3tl/hash_combine.hxx:14:78: error: implicit conversion (Dependent) from 'bool' to 'std::enable_if_t<(sizeof(N) == 4), bool>' (aka 'typename enable_if<(sizeof(N) == 4), bool>::type') [loplugin:implicitboolconversion] > template <typename T, typename N, std::enable_if_t<(sizeof(N) == 4), bool> = false> > ^~~~~ etc.) Change-Id: If764365213cf29f7dec6fdd6a773dc9894dd15bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117330 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-16tdf#59323: pptx export: add initial support for lstStyles in textboxesSarper Akdemir
Adds initial support for writing lstStyles that are specific to a shape. Current implementation only writes first paragraph and first textruns properties in it. Made WriteParagraphProperties return a bool that determines whether or not it wrote a pPr tag. Needed this since lvl1pPr tag should be started even if there was no paragraph properties since run properties also written inside it. Change-Id: Ie0cfc9b9f221093db3a1111ca29140a6dfb5e8ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117011 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-06-16Add Active App Name Field To Crash ReportGopi Krishna Menon
Adds a Active-App field in Crash Report to assist in investigating the crashes Change-Id: I30e5f307045b8e5def9986447551f39e70b94edc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116786 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-06-16tdf#59323: pptx export: add datetime field type helpersSarper Akdemir
Creates helper functions to convert from LO time and date formats to datetime fields on OOXML Change-Id: Ibbfefa18d0422eddb6c37539294ed23e77fe5f22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117009 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-06-16sw HTML export: allow larger bitmaps for shapes than the vcl defaultMiklos Vajna
VCL default would be 500k pixels, i.e. a 2" x 1" shape at 600 dpi would be already truncated from 1200 pixels width to 1000 pixels. That's a bit too extreme, use a larger limit in the sw HTML export. Change-Id: I52b85d77cd27410d53c700a89190c99348de5e19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117287 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-06-16basegfx: use namespace for "ftools", make sure input is FP numberTomaž Vajngerl
Don't use empty class with static methods for ftools, but just use namespace instead. Also make sure it works with any floating point numbers (float and double) and don't allow input if it is anything else than a floating point number Change-Id: I94b964291b3999d38ae13afe6ddfdbe6d891d410 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117154 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-15editengine-columns: add sidebar property panelMike Kaganski
Change-Id: I90aefc10f9ddddeb64a65799480777bc4287abae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117107 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-15vcl: outdevmap.hxx -> rendercontext/ImplMapRes.hxxChris Sherlock
Change-Id: I96e191999e43e1a4203d548eeacd386ed883cd8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115368 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-14tdf#59323: ooxml import: hasNonInheritedShapePropertiesSarper Akdemir
Introduces hasNonInheritedShapeProperties helper to PPTShape. If the shape has something imported from it's spPr tag mbHasNoninheritedShapeProperties set to true. Change-Id: I0529f1def8d2c32d5bf06172ce44facdde92893c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117003 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-06-14Workaround internal compiler error on tb77Mike Kaganski
As reported in https://ci.libreoffice.org/job/gerrit_windows/98360/console : C:/cygwin/home/tdf/jenkins/workspace/gerrit_windows/svx/source/svdraw/svdedxv.cxx(2639): fatal error C1001: Internal compiler error. (compiler file 'msc1.cpp', line 1591) To work around this problem, try simplifying or changing the program near the locations listed above. If possible please provide a repro here: https://developercommunity.visualstudio.com Please choose the Technical Support command on the Visual C++ Help menu, or open the Technical Support help file for more information C:/cygwin/home/tdf/jenkins/workspace/gerrit_windows/svx/source/svdraw/svdedxv.cxx(2631): note: while evaluating constexpr function 'svl::ItemsArray' INTERNAL COMPILER ERROR in 'C:\PROGRA~2\MIB055~1\2019\COMMUN~1\VC\Tools\MSVC\1427~1.291\bin\Hostx64\x86\cl.exe' Please choose the Technical Support command on the Visual C++ Help menu, or open the Technical Support help file for more information tb77 uses VS 16.7.7 (cl.exe is under Tools/MSVC/14.27.29110); tb68 with cl.exe under Tools/MSVC/14.28.29910 has no problems compiling this. Let's make the code simple for now, until we upgrade the tooling on CI. Change-Id: I10aaf289454c89b2f49b4be947627a9a3be30fde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117137 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-14tdf#59323: ooxml import: hasShapeStyleRefsSarper Akdemir
Helper function to determine whether the shape has style refs or not. Change-Id: I57b244b4af5b9e3abba90f0e4e25a35da27e3409 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117002 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-06-13Assert on valid order of which ids in ranges on SfxItemSet creationMike Kaganski
This allows to make sure we actually use sorted which ranges, and then it's safe to call SfxItemSet::MergeRange when needed. Also this change relaxes the previous requirement that ranges must be separated by at least one; this allows to have adjacent ranges, like in RES_FRMATR_BEGIN, RES_FRMATR_END-1, RES_GRFATR_BEGIN, RES_GRFATR_END-1, where RES_FRMATR_END is equal to RES_GRFATR_BEGIN. Allowing this makes possible to (1) self-document the ranges, so it's clear which ranges are included; and (2) be safe in case when these constants would change, so that the one merged range would not unexpectedly contain everything inserted between RES_FRMATR_END and RES_GRFATR_BEGIN. Change-Id: Iaad0f099b85059b3aa318a347aa7fbd3f6d455c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116909 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-29 16:18:06 +0000