summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2021-01-22tdf#135550 ListBox should triger an event when changed non-interactivelyCaolán McNamara
not just when changed by the user Change-Id: If2238341ff8465fee6375dad1ea9b4d7ec0110e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109827 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-22tdf#135590 rotated paper sizes reported as portrait size they are notCaolán McNamara
since... commit ff4896a2af1df6138e9246fe1588dfe8c3748f1a Date: Fri Jun 29 11:36:03 2018 -0300 Sets paper sizes listbox in print dialog see as the above commit added some uses of doSloppyFit to vcl I imagine the calls there want to be able to match rotated paper sizes, but in the cases of tdf#135590 we don't want that behaviour because it doesn't match what the user is presented with, the width and height are swapped. So drop matching against swapped height/width by default, but let calls added in 'Sets paper sizes listbox in print dialog' continue to match rotated sizes. Change-Id: I34aeddf12a7ca22234fbc6394487d3c8da7772ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109784 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-22improve loplugin:pointerboolNoel
to look through template instantiations involving std::forward motivated by commit b1617acde182d1683bdfb529794d7456f8b4bf6d drop RadioButton arg defaults the nBits arg in builder.cxx was in the wrong place Change-Id: I222ea2aeea6f44ae54839e824a247a8105392c2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109789 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-22tdf#139590 Drag and drop doesn't work in SdrObjEditViewCaolán McNamara
Change-Id: Id8deeee0c1a919f330bc6623f708453279a214c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109785 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-22tdf#135590 MapUnit::Map100thMM fallback is inappropiate for writerCaolán McNamara
which uses MapUnit::Twip so directly after insert, envelope, ok the new document sidebar was using MapUnit::Map100thMM to lookup paper sizes instead of MapUnit::Twip giving inconsistent results against format, page Change-Id: I6a92fddedfe9fef8ad7532ad00b2b38b9741bb69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109782 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-22find-can-be-private-symbolsNoel
update the script to use python3, and run it Change-Id: I9c2a86e1f7a2eb889dcf214f2a2f6a31ceb1f59e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109710 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-22vcl: support creating a Graphic with only GfxLink as swapped-outTomaž Vajngerl
This adds support to create a Graphic with only a GfxLink and the Graphic is in a swapped-out state. This is similar to the prepared state, but the prepared state is a special state of the Graphic. In the future, all loading will probably be done in this way and prepared state will go away, but for now this is only supported for PDF and is used in PDFium import only. The main reason is to avoid that a multi-page PDF is immediately swapped out after loading, which just does unneeded work and freezes the application for a while. Change-Id: I409741d27a4ad309264cdf27b2ba03f2cf37ead9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109600 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-21avmedia: add doc model for bitmap fill of slide narrationsMiklos Vajna
This allows specifying a custom bitmap for a media shape. It's mostly useful for audio-only streams where the additional bitmap may be e.g. a speaker icon to indicate this a narration. Change-Id: I21c1b492ac09b631cf6e3ec8120be8b82c01c26d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109763 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-01-21merge pair of duplicate blocks together into one functionCaolán McNamara
Change-Id: Id43553befd79dc73683444312629f473a5747678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109716 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-21drop RadioButton arg defaultsCaolán McNamara
the nBits arg in builder.cxx was in the wrong place Change-Id: Id4d0dd6919444cb39cf0d9e593f46d324f343a31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109714 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-21tdf#114441: Convert use of sal_uLong to better integer typessiddheshpatil777
Change-Id: I14742675541a315e72191df4ee38c35373b39d52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108842 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-21lok: fix incorrect invalidate cursor positionHenry Castro
When the comment is created and it's shown in the "Writer" application, it creates an initial output area: mpOutlinerView->SetOutputArea( PixelToLogic( tools::Rectangle(0,0,1,1) ) ); Unfortunately, it causes that send to client side cursor position and scroll to the beginning of the document. Change-Id: I13e21c71328b7f05781e7cdeed082d6cc2b9d679 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109371 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 4618849a1cbba4e249ee13c3b6412337160a2816) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109732 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-01-21pdfium: use PDFiumDocument in VectorGraphicSearch::ImplementationMiklos Vajna
Which means no need to manually close the doc in the dtor. Change-Id: Icf1357f162313a845d7694323d546a6fccad344e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109724 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-21Use C++20 consteval for the Color(sal_uInt32) ctorStephan Bergmann
...to make it more obvious that, since 63a68064bb33f180b8a231f7524d99405d910226 "make the Color constructors explicitly specify transparency", it should only be called when the argument is known at compile-time to have no transparency/alpha channel. (This revealed a GCC bug causing bogus > xmloff/source/chart/ColorPropertySet.cxx: In constructor ‘xmloff::chart::ColorPropertySet::ColorPropertySet(Color)’: > xmloff/source/chart/ColorPropertySet.cxx:81:9: error: ‘this’ is not a constant expression > 81 | m_nDefaultColor( 0x0099ccff ) // blue 8 > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ so in configure.ac suppress HAVE_CPP_CONSTEVAL when the compiler is found broken.) Change-Id: I68df7bd5fbd9b2dcf2243b5a4bde4064d3d665fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109697 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-21jsdialog: remove unnecessary handlerSzymon Kłos
Change-Id: I4e4d032c73fc090f443dcc7bef0267e1df123810 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109643 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-20make crashreports include info about the system (CPU,memory)Luboš Luňák
This may be useful when we again will be deciding on how well something is or isn't supported (such as when we were making SSE2 required on Windows). Breakpad already kind of provides this information (as CPU family, model and stepping), but that appears to be next to useless in practice (on X86_64 it doesn't even say the CPU vendor). So send as metadata CPU name, flags (SSE etc.) and system RAM, as these may be possibly useful information. Change-Id: I77ed935d78501d49f70e8b9769fab6be79f1db77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109358 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-01-20tdf#139115 vcl tree list: add new toggle behaviorsAttila Szűcs
at clicking on list items with checkboxes to clean-up generic VCL plugin commit 2471d6f44c7e8ecbe86a90eeb593b899a08a7408 (tdf#116675 vcl tree list: toggle by label click (e.g. in AutoFilter)). This limits the new toggle-always to ScCheckListMenuControl (e.g. AutoFilter). set_clicks_to_toggle() options to set the effect of the click on a treeview list item: 0 == clicking never toggles the checkbox (default setting) 1 == clicking always toggles the checkbox 2 == clicking only toggles the checkbox of a selected list item, i.e. the first click selects a not selected list item, and only the second click toggles its checkbox. It would be better if we could set this information in the .ui files, but I did not find a good way for that. A good place in the code to call this function can be found by searching for the .ui filename. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I5c72d710508fc397f2b6f959d7680b23f8dc6f67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108947 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-01-20ofz#29691 revert throw SvStreamEOFExceptionCaolán McNamara
reasonably sane code like s.ReadUInt32(a).ReadUInt32(b).ReadUInt32(c).ReadUInt32(d); if (s.good()) // use a, b, c d; stopped working. FWIW on a short read we retain whatever was in the variable before the read, rather than overwrite it with new random data, so sal_uInt32 a(0xdead); s.ReadUInt32(a); assert(s.good() || a == 0xdead); the msoffice ppt/escher/xls/doc filters especially speculatively parse and rely on a variables preinit value in the case of a short read. commit b345a2bab0d6f981049951a86b172ce49ce7d4c2 cid#1470786 Uncaught exception commit 71aec4726a94dcde1169fd293dbecfeb0e840e6d ofz#29528 uncaught exception commit bed03603f6cae264abb9e5b58aa2ab00448d92ff ofz#29414 uncaught exception commit 684885a99a1eb7ad943e9736166d4bb1468663be ofz#29443 uncaught exception commit 93574ac7768d247ed754ecda322e54e4bd447e43 ofz#29251 Abrt commit 413db68d95bd39d34e6a6b81a7c5c9478ced0514 ofz#29152 short read commit f400e883044143f999c460375a293647b4a57244 ofz#29151 short read commit 96ea80a725dfe4ef38993f78917c243f13e3beb5 ofz#29129 Abrt on uncaught exception commit 646a635efe6eecbc3d1dd3a7cbb02a278c6f3be5 ofz#28931 Indirect-leak commit b0e573f18629d28fe3179c12d0d434653f92fc93 ofz#29030 Abrt in xlsfuzzer commit 95407c39168d186ee44e67b1a6a4bcf592c58b84 ofz#28902 uncaught exception commit 45175d655ad3773df1c006182108cf25e87b1091 oss-fuzz: tgafuzzer doesn't pass sanity check commit b82fc702bae9d6190bda1b4818a47cfa197df6d8 oss-fuzz: psdfuzzer doesn't pass sanity check commit e7c76d604a4694e6568bf10c2a06a786f1096319 oss-fuzz: epsfuzzer doesn't pass sanity check commit 901e5e7c9170184e286ea3e46fce406136aa9572 oss-fuzz: xlsfuzzer doesn't pass sanity check commit 127bfab61c297df06fd8e71e709bc4362cb89d21 oss-fuzz: pngfuzzer doesn't pass sanity check commit 77387ae00ae27e3f8bcdf7bccf97fb2db8f196b7 oss-fuzz: mtpfuzzer doesn't pass sanity check commit 974ffa79b0fef4ca76558bb8b16bce84af3aaf6c oss-fuzz: xlsxfuzzer doesn't pass sanity check commit 6d6d104cbb382d0045e1f04b12d268992fa5c624 oss-fuzz: bmpfuzzer doesn't pass sanity check commit a7d1d107ec58d3b00b4019c89edddcff71ca6ff3 oss-fuzz: qpwfuzzer doesn't pass sanity check commit 898993aa62276f59480df8af1da4bad530829b56 oss-fuzz: pcxfuzzer doesn't pass sanity check throw/catch parts of commit 8c9a4ff511a3b1d84a7a6d08a1b153c07f164abb throw exception in SvStream when reading past end of file Change-Id: Ic49c249768b17b64d8e868655dbc05b31906c2e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109621 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-20vcl: add an UNO interface and impl. for BinaryDataContainerTomaž Vajngerl
Change-Id: Icbc384892bee8c31eb7f3a39ff9a64f1199b23b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109596 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-20pdfium: rework to eliminate FPDF_PAGEOBJECT from the public interfaceMiklos Vajna
And fix bin/find-unneeded-includes to not report noise on PDFiumLibrary.cxx. Change-Id: I93337e49a5656349089bdb790876bebe8505082c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109656 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-19loplugin:unusedmethodsNoel
GtkPrintWrapper stuff is dead since commit ed07ec7606cb24cccaf6b7b81b2bd308debaa2e6 drop never completed GtkSalPrinter Change-Id: Ia42e9bca020a9683ba247d466f743a0018e920f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109618 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-19tdf#124176 Use pragma once instead of include guardsprincesinghtomar
Change-Id: I44a269b5c01f044880b07aaa6d7e9ee369d98f54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108506 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-01-19add OutputDevice::GetOutputRectPixel methodNoel Grandin
to simplify some and make an upcoming change less invasive Change-Id: I699b2be8fa35b2b72271eda4a0885f89a47b348a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109563 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-19vcl: remove or rename too long methods names in VectorGraphicDataTomaž Vajngerl
Change-Id: I8a64d27927b608afdc7996e0b0bbc59a58fde90f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108443 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-19vcl: remove VectorGraphicDataArray, use BinaryDataContainer insteadTomaž Vajngerl
This change removes the contructor taking VectorGraphicDataArray for constructing VectorGraphicData, and instead of this, use the BinaryDataContainer instead. This further removes duplication and copying of the binary source data for various vector graphics formats (most importantly PDF and SVG). Change-Id: I1b9abf1662e1f30965c9068d04cb0afb82b3edaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108442 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-19vcl: a way to create data for BinaryDataContainer without copyingTomaž Vajngerl
Construstor for BinaryDataContainer taking unique_ptr<sal_uInt8> represents a way how to create and fill the data for the container and make sure that the container is the only one that is managing the data after construction. Generally we don't want to give the access to the internal shared_ptr to the outside, so with the unique_ptr we make sure that there is no outside references present (which would be the case if the we would take shared_ptr as the constructor) and the unique_ptr is cleared (moved) after construction. Change-Id: I123114c8bee92e342740d94a784b2c16e2564528 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108441 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-18make internals of ::Color privateNoel
was made public in commit d487d6e082bc7ce652217578ffd37397a59cc3ca rework Color to have R,G,B,A public variables but it's best to keep them private since we're changing the internal representation - and there is surprisingly little that depends on accessing the internals anyhow. Change-Id: I234d80fb33105f7bf5b865fb7c8194d893b09878 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109508 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-18Fix typoSamuel Mehrbrodt
Change-Id: I19ca7330285815bb7fdca86ad7348d7e9ae508b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109507 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-01-18devtools: handle the doc. model tree with attached obectsTomaž Vajngerl
Instead of filling the document model tree with fill* methods, refactor that to use objects that are attached (via get_id) to the tree nodes directly. For this introduce DocumentModelTreeEntry and subclasses, which implement what the current UNO object is that is being shown for a tree node and a "fill" virtual method, which is used to fill the child nodes of the tree when expanding a tree node. This makes the code much easier to work with and in addition it makes it possible to have all the tree nodes to fill the content on demand when expanded. Change-Id: Id5a027e060af90e483181439568f17d0172d1b35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109500 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-18Bring uno:RefreshView to CalcSamuel Mehrbrodt
Allow refreshing the document layout via UNO slot Change-Id: I956bb884b1fb4231b1f617c4aa5a80ff9a45ec92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109230 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-01-18devtools: separate DocumentModelTreeHandler into its own file(s)Tomaž Vajngerl
Change-Id: Ie657fca3d7e221ca6fbce1016589bd86312530fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109499 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-18devtools: separate handling of document model tree into own classTomaž Vajngerl
This introduces DocumentModelTreeHandler which is used to handle the left-side document model tree. This makes it easier to track how the tree is populated and handled by encapsulation. Change-Id: I0c11d8012d149c6f4ce9a5067a8c368fb794efe1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109498 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-17use ::Color in ColorSet::addNoel Grandin
Change-Id: I8b34807e62c292a19700e6d37edd99e442574ec4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109452 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-17return Color from BGRToRGBNoel Grandin
instead of converting at all the call-sites Change-Id: I4732082fcd4731f6fd46aef197a15564586f0c90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109450 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-17tools: support reading xml namespace with XmlWalkerTomaž Vajngerl
Adds methods namespaceHref and namespacePrefix for reading the current element's namespace prefix and the href. Change-Id: I1c16857c6fc0bdfde2d983d8f42f153111119029 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109442 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-16transparency->alpha in vcl::RawBitmapNoel Grandin
Change-Id: I68e05555518f0dc6a7c01d2fec734b0d0aff0d48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109427 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-16tdf#138829 don't grab focus to roadmap label when sync timer firesCaolán McNamara
Change-Id: Icc8a03a2ce5d63f3a2c477671a9aa52aefd1df96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109385 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-16devtools: Add more elements to the document model tree viewTomaž Vajngerl
This change adds more elements to the document model tree view. for all: style families and styles for Writer: shapes, graphic objects, OLE objects, frames, tables for Impress: master slides for Calc: shapes, charts, pivot tables Change-Id: Ic6d2c6c8f45fe7881e17aee3727864aeb4d701c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109376 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-16Fix o3tl::checked_multiply for Raspberry pi 4bJulien Nabet
usr/bin/ld : /usr/bin/ld: Erreur DWARF: ne peut repérer la spécification de variable au décalage 8953 /usr/bin/ld: Erreur DWARF: ne peut repérer la spécification de variable au décalage 93da /usr/bin/ld: Erreur DWARF: ne peut repérer la spécification de variable au décalage 967a /usr/bin/ld: Erreur DWARF: ne peut repérer la spécification de variable au décalage 991a /home/pi/lo/libreoffice/workdir/CxxObject/sw/source/filter/xml/xmlimp.o : dans la fonction « bool o3tl::checked_multiply<long long>(long long, long long, long long&) » : /home/pi/lo/libreoffice/include/o3tl/safeint.hxx:121 : référence indéfinie vers « __mulodi4 » /usr/bin/ld : /home/pi/lo/libreoffice/include/o3tl/safeint.hxx:121 : référence indéfinie vers « __mulodi4 » /usr/bin/ld : /home/pi/lo/libreoffice/include/o3tl/safeint.hxx:121 : référence indéfinie vers « __mulodi4 » /usr/bin/ld : /home/pi/lo/libreoffice/include/o3tl/safeint.hxx:121 : référence indéfinie vers « __mulodi4 » clang: error: linker command failed with exit code 1 (use -v to see invocation) make[1]: *** [/home/pi/lo/libreoffice/sw/Library_sw.mk:20 : /home/pi/lo/libreoffice/instdir/program/libswlo.so] Erreur 1 DWARF Error: can't find spec of var at offset 8953 undefined reference to "__mulodi4" Change-Id: I1c88a1567e25370eb5759912ea4918d7183f3786 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109322 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-01-16make the Color constructors explicitly specify transparencyNoel
to reduce the churn, we leave the existing constructor in place, and add a clang plugin to detect when the value passed to the existing constructor may contain transparency/alpha data. i.e. we leave expressions like Color(0xffffff) alone, but warn about any non-constant expression, and any expression like Color(0xff000000) Change-Id: Id2ce58e08882d9b7bd0b9f88eca97359dcdbcc8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109362 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-16devtools: change to on-expand filling of the doc. model tree-viewTomaž Vajngerl
Instead of traversing the document model at once and filling the tree-view, only fill the root element names first, and fill the children on expand. For example first add "Paragraphs" root node, and when the user expands that node, fill the child nodes of the tree with actual paragraphs. Change-Id: Ifa71603a4fa1b69d2b1b590f0d0493e22092deb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109375 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-16devtools: fill left-side document model view for all document typesTomaž Vajngerl
Change-Id: I19f1cfdbdde86b3fbeb2a0a7e3e4255ef0055cf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109073 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-16transparency->alpha in BitmapExNoel Grandin
Change-Id: I631f4ca5a2bdcb8c7691a9a8c71d3de15377213b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109390 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-15tdf#135641 update DataBrowser has-focus when child widget gains focusCaolán McNamara
Change-Id: Ic5e618b50c31ebeffa1b2cc59857582804874747 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109369 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-15replace stock button imagesCaolán McNamara
Change-Id: I9be83856c0dd15552a042f009464c279bf239848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109199 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-15Fix handling of the OBJECTDESCRIPTOR clipboard (pasteboard) type on macOSTor Lillqvist
This fixes a demonstrable problem, and affects only macOS. This is also on the path towards fixing https://github.com/CollaboraOnline/online/issues/849 , even if the code touched here is for macOS only. The iOS pasteboard handling code is based on the macOS one. We need the pasteboard to have the OBJECTDESCRIPTOR type as a MIME type that includes the typename attribute, because the code in sc checks for that when it decides whether it is a proper OBJECTDESCRIPTOR. Simplify the data in the flavorMap array. No need to duplicate the same MIME type string as both the pasteboard type and MIME type, for those cases where the MIME type is used diretly as pasteboard type. We also know that for those types, the MIME type might have additional parameters, so be more lenient in checking. With this change, and my recent change to sot, this now works: Start LibreOffice. Open a spreadsheet. Select a cell range. (It can include formulas.) Edit > Copy. Quit LibreOffice. Start LibreOffice again. Open a spreadsheet. Edit > Paste. You get the very same cells that you pasted as such (with relative cell addresses in formulas properly adjusted, as expected). Previously, it would paste an image of the copied cell range, which is fairly pointless. There is still lots of opportunity for cleanup in the clipboard code for macOS and iOS. It is presumably rather pointless to put images on the pasteboard in Windows bitmap format, for instance. Just PNG should be enough. No idea why the code provides the TIFF pasteboard type for images. Ditto for Windows metafiles (WMF and EMF). It is also unclear how useful the EMBED_SOURCE or LINK_SOURCE types are on macOS, for instance. Change-Id: I573648480b03972b506203b4f470d513bcb81212 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109297 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-01-15OUString::matchAsciiL() can be used instead of the fresh startsWithAsciiL()Tor Lillqvist
Revert the addition of the latter. Change-Id: I93636a901cde401b0b7d923e052887f57dd58212 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109315 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-01-15pdfium: add wrapper for FPDF_FILLMODE_* definesMiklos Vajna
Which is, I think, the last direct pdfium usage outside vcl. Change-Id: I2e435e5a3669c6163bf2c20bc6d1d8bd4c88cecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109314 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-15Use value comparison hereMike Kaganski
This was always comparing pointers, ever since commit cb07ed8c74d71de9ef512c7a3568c7ee85585cef. They could only happen to be not different if they are both nullptr. But the uses of the function seem to expect value comparison (see SdrObjEditView::ImpChainingEventHdl, SdrObjEditView::SdrEndTextEdit). Change-Id: I2265dc8f0f7e4441940f8e19ec0b016b5f78e812 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109284 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-14cid#1471346 Uncaught exceptionCaolán McNamara
Change-Id: I535affd6597636aa32e1cf9c6005238f9503ef6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109266 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-22 08:01:35 +0000