summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2024-11-06loplugin:passstuffbyref in svxNoel Grandin
Change-Id: Ic5fd72cb64208c278ffc129591cd3d1131efdc08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176137 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06loplugin:passstuffbyref in basicNoel Grandin
Change-Id: I1aee08f0ff2a3dabcedc49a31e7ff4de9428007e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176136 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06loplugin:passstuffbyref in editengNoel Grandin
Change-Id: I015616d7a008692b63586cd5d2ae9cc5586ead4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176135 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06loplugin:passstuffbyref in xmloffNoel Grandin
Change-Id: I4837cb60c2c78b5a9008b6ffbb6323da50c7c705 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176111 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06loplugin:passstuffbyref in ucbhelperNoel Grandin
Change-Id: I70f0774ec2f38c0ba250aee7999d72eaa4a82673 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176110 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-06loplugin:passstuffbyref in vclNoel Grandin
Change-Id: Id152f7321bb81ecb17b31775277d1466ccd91ab4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176108 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-06loplugin:passstuffbyref in svlNoel Grandin
Change-Id: Ibc4628941b40159aa35a0a55900efb3dd882369e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176056 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06loplugin:passstuffbyref in toolsNoel Grandin
Change-Id: Id902f711d14eb21dc14366e8fe8fc5a96c0afec4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176055 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06loplugin:passstuffbyref in unotoolsNoel Grandin
Change-Id: I0a63fc95f76664408a7ec3ee53a8d025eb5f560d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176054 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06loplugin:passstuffbyref in comphelperNoel Grandin
Change-Id: I2c94b6e0bbdce4f4236815df8c4841327a33939e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176053 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06add an EMPTY_OUSTRING in OUString headerNoel Grandin
we already declare the same thing in various places, and I intend to be using this some more, so it makes sense to only declare it in one place Change-Id: Ifea6b589e992dd9f6cd8f2301f837e71397481c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176046 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06tdf#162177 Adapt function EASTERSUNDAY to ODF 1.4Regina Henschel
This includes writing ORG.OPENOFFICE.EASTERSUNDAY for ODF 1.3 and ODF 1.2. Change-Id: Ifa19021060f0d0223234c1ca1109300908e2dda1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175736 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2024-11-05Replace unnecessary #include with forward declarationPatrick Luby
The fix in commit 2fe53b2e436cb236b2dc121ceec4f22de49a13a8 still works on macOS with a forward declaration of the VCLXMenu class. Change-Id: I1080466d1783464c886111e9b47d445fb16f0d3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176045 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-05Fix crash due to unexpected dynamic_cast failures in optimized buildPatrick Luby
When an optimized build of this branch is compiled on Silicon Mac, a dynamic_cast from com.sun.star.awt.XPopupMenu to VCLXPopupMenu will fail. The pointer being casted has not been deleted and is an undeleted instance yet dynamic_cast fails. However, a dynamic_cast to VCLXPopupMenu's superclass VCLXMenu succeeds so cast to that class instead. Change-Id: Ie9ab79df109eece46351545a71325d1e37bde94d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175992 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
2024-11-04move CryptTools from oox to comphelper so we can reuse itTomaž Vajngerl
Also move the relevant tests and clean-up the names a bit to make it mroe consistent. Change-Id: I929ef9c13b954fd6a506471231d1bc41e4ef9980 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176027 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-11-04pdf: initial PDF 2.0 and PDF/A-4 supportTomaž Vajngerl
Added PDF 2.0 and PDF/A-4 version to enums. Write the PDF 2.0 support for the file headers. Add the identical considitons as for the PDF/A-4 as they were for PDF/A-3. Change-Id: Iccf5afbf09c4cd0cd1ae7122c860e8cbefe3a6fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176023 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2024-11-04comphelper: move tostring to hash.hxx so it can be reusedTomaž Vajngerl
tostring to convert a vector of bytes into a hex string is useful in other tests and implementation, so move it into common hash.hxx Change-Id: Iebc71919c6209222eb01b78c307420afddc8caca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176020 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-11-04svx: prefix members of E3dCubeObjMiklos Vajna
See tdf#94879 for motivation. Change-Id: I0e1dcb44cd46fdf40ae21c264017c8fc9ca96b53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175980 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-11-03tdf#143148 Use #pragma once instead of include guardslynn_edem
Change-Id: I3ff0f661a3b4109b79ec13dad4e3472378048ec7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175705 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2024-11-02tdf#36709 Add loext:text-indent supporting font-relative unitsJonathan Clark
This change adds an ODF font-relative first-line indent paragraph style attribute as a LibreOffice extension. The corresponding ODF standard change is tracked by OFFICE-4165. This change only implements what is minimally necessary to serialize, deserialize, and check for ODF files containing this attribute. Further changes are necessary. * Added cssLength to schema, which is equivalent to length but also allows ic and em as units. * Added loext:text-indent to schema as a paragraph style attribute. This attribute is equivalent to fo:text-indent, but accepts cssLength instead of length. * Added XML_TYPE_UNIT_MEASURE to the ODF parser, which currently accepts only the font-relative measures and forces fallback in other cases. * Added loext:text-indent to the ODF parser. This attribute accepts font-relative metrics, and will behave as an import-only alias for fo:text-indent in other cases. * Updated SvxFirstLineIndentItem to handle unit-denominated measures. * Added proof-of-concept indentation handler to Writer. This implementation is incomplete and temporary, and will be revised in future changes. Change-Id: I7eb5c7382093cb18a9b0afbf93dacb34ba1d35ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175941 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-01tdf#36709 Refactor Converter to separate parsing from unit conversionJonathan Clark
Previously, Converter::convertMeasure parsed measure strings and performed unit conversion in a single call. This was appropriate, as all such measure strings could be converted to a common unit ahead of time. tdf#36709, however, will introduce measures that are relative to the current font and font size. In order to perform layout, the original measure unit must be preserved and passed along with the original value. This change introduces Converter::convertMeasureUnit, which parses a measure string and returns both the value and the unit. Existing unit conversion code has been refactored to facilitate this change. Change-Id: Ic8dfda432e1ca117ad80c05c1939ebaf43e79a9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175937 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-01Drop GraphicFilter's bUseConfigMike Kaganski
It controlled how the FilterConfigCache initialized, and also how the unused aFilterPath was initialized. The FilterConfigCache is reused, when there are other instances of GraphicFilter - so that means, that the "bUseConfig" flag doesn't necessarily mean that the initialization will happen as intended: the existing instance could have been initialized using the other value. Avoid this indeterministic behavior, and always use the config, except in fuzzing. The VCL tests, that could possibly once depend on that, now use config, so this is not an issue - and that means testing the same thing as used in the working code, not something different. Change-Id: I6555dc47328b362e020138cf454f5ede7f39d063 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175894 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-01Merge ImplInit into ctorMike Kaganski
Change-Id: I41ef9a3660cbb897074ec2bb2f234706d8b68de1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175893 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-10-31cid#1606874 silence Data race conditionCaolán McNamara
Change-Id: I6703ee228ac0717b04f58e14eedd02ab0722edf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175861 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-31convert KernArray from sal_Int32 to doubleNoel Grandin
which allows us to eliminate a bunch of rounding at various layers, and consequently maintain a lot more precision Change-Id: I911dedd7c041c1d67396c082e5695346ea689acb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175814 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-30win a11y: Move (Impl)InitAccessBridge logic to only callerMichael Weghorn
Now, with previous commit Change-Id: I42f0059cecd43205690d958a875d3c17ff9a197b Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue Oct 29 15:08:37 2024 +0100 win a11y: Stop using setting to indicate AT support in place, InitAccessBridge only gets called from the Windows- specific ImplHandleGetObject. Therefore, move the logic from ImplInitAccessBridge there and drop the InitAccessBridge and ImplInitAccessBridge functions. Change-Id: Id0d08478b84434b4ec03ab72b8af40e8ad51bd71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175796 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-30win a11y: Stop using setting to indicate AT supportMichael Weghorn
No longer use a "Accessibility"/"EnableATToolSupport" VCL setting to control/report whether support for assistive technology is (or should be) enabled, which was primarily used on Windows. As described in previous commit Change-Id: I32624b830d39d08510e4731edd06fd7a77642c50 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Oct 28 21:12:48 2024 +0100 win a11y: Drop "Enable AT Tool support" from options UI , that setting got automatically enabled when an assistive technology was active on Windows, and never got reset to "false" automatically, so AT support would be enabled next time LO starts as well. Instead of persisting this via a setting, enable the Windows a11y bridge if and when a WM_GETOBJECT message is received only, see `ImplHandleGetObject` (where this was already done earlier) and no longer alternatively start the a11y bridge in Desktop::Main when the mentioned setting is enabled. Drop MiscSettings::SetEnableATToolSupport altogether. Adjust MiscSettings::GetEnableATToolSupport to no longer read a setting, but return `true` if the AT bridge has been activated (or a SAL_ACCESSIBILITY_ENABLED environment variable is set, as was already checked before). This already returns `true` when called from MenuBarManager::FillMenuManager when starting LO while the NVDA screen reader is running. With this in place, the a11y bridge on Windows should now become active whenever an AT requests information (by sending a WM_GETOBJECT message), but not otherwise, and restarting LO will result in the a11y bridge no longer being active unless AT requests information again. Change-Id: I42f0059cecd43205690d958a875d3c17ff9a197b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175795 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-29fix enabled-mergelibs-more buildJuergen Funk
ErrCode::toString is needed by desktop/source/app/ unit tests now Change-Id: Ie7a9e67aca763c958d08f3826bca5df4e0d828f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175769 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-10-29tdf#130857 VclBuilder: Move extractResizable to BuilderBaseMichael Weghorn
Turn this local helper function into a static method in the BuilderBase class, for reuse in QtBuilder in an upcoming commit. Change-Id: Iee5d5c061c8b1bad3fefb7398111ad6815fc4c6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175776 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-29tdf#130857 VclBuilder: Move extractTooltipText to BuilderBaseMichael Weghorn
Turn this local helper function into a static method in the BuilderBase class, for reuse in QtBuilder in an upcoming commit. Change-Id: Ib1129801bc7315b1745d1b2690d59747c8db7ed6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175774 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-29test: Merge SwAccessibleTestBase and AccessibleTestBaseXisco Fauli
Change-Id: Ic62bd287406326f4c3d3e0702850fe0337f17686 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175762 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-29UnoApiTest: rename load to loadFromURL and use it everywhereXisco Fauli
Change-Id: Ie67eebec74f783fa0c29acfb23bb83bc582812b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175724 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-29tdf#130857 qt weld: Set button image set in .ui fileMichael Weghorn
Implement logic to set the image for a button, as specified via the "image" property for the "GtkButton" object in the .ui file. Similar to how VclBuilder::makeObject does it, extract an icon name and load an image using that one for "GtkImage" obejcts. Add another static `toQPixmap` variant that takes an Image parameter and use that one for conversion. For buttons, if the "image" property is set, get the corresponding QLabel object, get the pixmap from that one and set an icon in the button from that. With this in place, when opening the "Help" -> "About LibreOfficeDev" dialog in a WIP branch adding "cui/ui/aboutdialog.ui" to the list of .ui files in QtInstanceBuilder::IsUIFileSupported, the button to copy the version information now shows the corresponding icon when using the qt6 VCL plugin. Change-Id: If87866d7ab935cbc4162fb513074eefda22c981a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175761 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-29tdf#130857 Move loadThemeImage from FixedImage to BuilderBaseMichael Weghorn
This static helper method is currently only used by VclBuilder. Move it to the BuilderBase class, for reuse by QtBuilder in an upcoming commit. Change-Id: I229bc98e0de2dbe0788f07c7f4ff5e5426203de9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175740 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-29tdf#130857 VclBuilder: Move extractIconName to BuilderBaseMichael Weghorn
Turn this helper function into a static method in the BuilderBase class, for reuse in QtBuilder in an upcoming commit. Change-Id: I1e3318f22d83ddef4e7bf6269c7142f307ec6d1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175739 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-28don't use iterateItemSurrogates for EE_FEATURE_FIELDNoel Grandin
Change-Id: I96cd1728e2358d4ea49275952726aae85e6f52a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175726 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-10-27tdf#143148: #pragma once instead of include guardsLorenzo Lovato
Change-Id: I573a36a488e5a76f5dbe9d629ae0aaf23d3fc711 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175679 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-10-27Simplify a bitMike Kaganski
Change-Id: I142800a20b187ee31fa1cb393803035ed0e347d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175691 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-10-27tdf#143148 Use #pragma once instead of include guardsLue_lueita
Change-Id: I045cfd010401ed4131b28aab2e94308c226cc154 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175658 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-10-26tdf#130857 qt weld: Implement QtInstanceImage::set_imageMichael Weghorn
Extract a helper to convert a BitmapEx to a QPixmap from the existing helper function `loadQPixmapIcon` and add a new helper that converts a css::uno::Reference<css::graphic::XGraphic>& to a QPixmap reusing most of the code. Use that to implement the QtInstanceImage::set_image variant with that parameter type. With this in place, opening the "Help" -> "About LibreOfficeDev" dialog in a WIP branch adding "cui/ui/aboutdialog.ui" to the list of .ui files in QtInstanceBuilder::IsUIFileSupported now opens the dialog with brand image and LibreOffice Community logo present, but other aspects in that dialog still need attention before enabling this by default. Change-Id: Ide28c0dc126be511ec8e34e57f4f1df7e70297ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175666 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-25tdf#130857 qt weld: Prefer custom handler for dialog buttonsMichael Weghorn
If a custom handler is set for a button in a dialog's button box, skip the default handling (to close the dialog with the corresponding response code, unless it's the help button) in QtInstanceDialog::handleButtonClick, so that the custom handler gets processed instead (see QtInstanceButton::buttonClicked). This is similar to what the VCL implementation (see SalInstanceButton's ClickHdl) and the gtk3 implementation (see GtkInstanceDialog::asyncresponse) do. In order to be able to determine whether a custom click handler is set, make weld::Button::connect_clicked virtual and override it in QtInstanceButton::connect_clicked to set a property on the QPushButton object to indicate that a handler is set. Introduce a static helper method QtInstanceButton::hasCustomClickHandler that evaluates this property. Without this change in place, pressing the "Rename" button in Writer's "Rename Object" dialog that will be declared as supported in upcoming commit Change-Id: I0ac8f66b977f5d999bb197cc68e8ce5533fe1ebd Author: Michael Weghorn <m.weghorn@posteo.de> Date: Fri Oct 25 10:41:45 2024 +0200 tdf#130857 qt weld: Declare support for sw "Rename Object" dialog would not actually result in a bookmark getting renamed, only the dialog would be closed. Change-Id: If3e762100349ecd06c4e9415e9a8f9a44ec6491c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175633 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-25tdf#139152 Exporting Image or Drawing to PNG is missing metadaNoel Grandin
implement this in a similar fashion to how export to JPEG does it. Add a new method to calculate pixels-per-meter, because that is how PNG stores the values internally Change-Id: I1e4cd5a36af22e52a7c52f5b3bc2407f8523ef9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175636 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-25win a11y: Assert creating MSAAService succeedsMichael Weghorn
Add an assert that creating the MSAAservice/a11 bridge succeeds in ImplInitAccessBridge on Windows, as this should never fail unless the LibreOffice installation is broken. Drop the return values of the ImplInitAccessBridge and InitAccessBridge functions accordingly and simplify code calling them. While at it, also switch to using `#ifdef _WIN32` for the Windows-specific code in `InitAccessBridge` instead of having it in the `#else` branch of `#if defined UNX`, to align this with the `#ifdef _WIN32` condition for the `ImplInitAccessBridge` declaration, as that's the function that gets called. Even if the creation of the service should fail for some reason, the DeploymentException in ImplInitAccessBridge is still handled, so unless I'm missing something, this commit shouldn't cause any harm. The "EnableATToolSupport" setting would then incorrectly be set to true indicating that AT support is enabled, but besides being used in the a11y bridge code itself, that's only used to determine whether or not to pre-populate menus, so they are available in the a11y hierarchy before the corresponding (sub)menu gets activated, s. MenuBarManager::FillMenuManager, the corresponding commit that originally introduced this, commit 08fe2669a0ed807812d005195b54cc41f092d09a Author: Rüdiger Timm <rt@openoffice.org> Date: Fri May 13 06:29:54 2005 +0000 INTEGRATION: CWS tbe22 (1.25.30); FILE MERGED 2005/05/04 14:21:00 tbe 1.25.30.1: #i48612# Opening a menu with GOK shows Tips instead of entries (fixed by CD) and the referenced bug report [1], in particular comment 3 [2]: > TBE->CD: As discussed, the accessibility hierarchy is built up, but part of the > information is missing, e.g. Menu::GetItemText() returns an empty string. > Also keyboard shortcuts should be available. > In addition, the File/New menu and the File/Wizards menu are missing. > All this information is only available, after the corresponding menus have > been opened by the user. > > In OO.o 1.1.x all this was working. The AT tools require, that the whole menu > hierarchy is available as soon as the menu bar is visible, that means before > a user has opened a menu. > > The whole menu hierarchy must be only provided, if accessiblity is enabled. > This can be checked by > BOOL bAccessibilityEnabled = > Application::GetSettings().GetMiscSettings().GetEnableATToolSupport(); This commit is also in preparation of further simplifying the handling for that setting. [1] https://bz.apache.org/ooo/show_bug.cgi?id=48612 [2] https://bz.apache.org/ooo/show_bug.cgi?id=48612#c3 Change-Id: I46149ed215c354d33003513d55defe4920a7c381 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175565 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-25cid#1633781 Initialization or destruction ordering is unspecifiedCaolán McNamara
and cid#1633780 Initialization or destruction ordering is unspecified cid#1633778 Initialization or destruction ordering is unspecified cid#1633777 Initialization or destruction ordering is unspecified cid#1633776 Initialization or destruction ordering is unspecified Change-Id: I8ae7cbede6df2ad747fe57d0ac2800e1b6a31038 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175576 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-25tdf#130857 VclBuilder: Move extractActive to BuilderBaseMichael Weghorn
Turn this helper function into a static function in the BuilderBase class, for reuse in QtBuilder in an upcoming commit. Change-Id: I68c7e62816ff5fdd1c2a02cf5e42f90b32cff627 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175571 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-25speedup saving large XLS file with lots of query formula(2)Noel Grandin
reduce cost of OUString construction by avoiding initialising a temporary and then overwriting it. 12s to 10s Change-Id: I889152ba71947004ca7d5c96f073182c94d95ed5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175539 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-24tdf#130857 VclBuilder: Make extractEntry a static helperMichael Weghorn
... in the base class BuilderBase, in order to reuse it in QtBuilder in an upcoming commit. Change-Id: Ia115804a9d2bf22b47afb94d97109e9495b21cd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175530 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-24qt: Have just a single toQString(const OUString&)Michael Weghorn
Move the `toQString` helper function to include/vcl/qt/QtUtils.hxx where it can be used from multiple modules, instead of defining it twice for both, avmedia (avmedia/source/qt6/QtPlayer.cxx) and vcl (vcl/inc/qt5/QtTools.hxx). Change-Id: I7ffe06eaa3aaf3e7c8cc7aa1a4ac41b14db5c20c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175526 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-24tdf#130857 qt: Move pixmap helper to new include/vcl/qt/QtUtils.hxxMichael Weghorn
Introduce include/vcl/qt/QtUtils.hxx as a new header for Qt-specific utility functions that can be used in multiple modules, e.g. avmedia and the Qt VCL plugins in vcl. This is meant to be used only by code that already links in Qt. There's already vcl/inc/qt{5,6}/QtTools.hxx for helpers needed in vcl only. Initially, add a `loadQPixmapIcon` helper function that can be used to retrieve a QPixmap for an icon name and is extracted from QtPlayer::createMediaPlayerWidget in avmedia. It will be reused to implement the QtInstanceButton::set_from_icon_name logic in an upcoming commit. Change-Id: I9f25aa5ca8f00da97d06ecdd164a8fae10e492dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175524 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-23tdf#90341 Clean up excessive const_cast'ingUsman Akinyemi
These changes improve const-correctness and reduce the need for const_cast usage. Change-Id: I1275edfbc0ca5d49a5e8339d1ed11148f6decd1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174701 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-11 00:13:01 +0000