summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2021-03-23use single-use attribute for ContextChangeEventMultiplexerNoel Grandin
instead of rtl::Instance, which means it will get cleaned up when UNO shuts down Change-Id: I13b36f1fe570f789036ef54ecfb7d0a85ce1450c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112842 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-22tdf#140539 don't allow help to be relaunched during launchCaolán McNamara
its fine once it is launched to fire help again, just not during the launch itself via the yield-call done during html load that probably exists to let the progress bar redraw Change-Id: I42e0bf670023d91f70cb1de3fa0fda23e82d0678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112921 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-22WMF EMF Add more SAL_INFO and SAL_WARN to help debugging import issuesBartosz Kosiorek
With this change, the WMF record type is displayed after enabling emfio. Change-Id: I055fc1dde6c37cf6ab8c6125fc2522bd7b1517cc Change-Id: Iff6ccbad69f4f836957206357dd707e4ddd06931 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112863 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2021-03-22change SfxApplication::GetTopWindow to weld::WindowCaolán McNamara
Change-Id: I19906f2a9d820c99375e2e5677a484d4e2e25fdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112857 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-21cid#1473926 Uninitialized scalar variableCaolán McNamara
Change-Id: I794d2b58aa65f7eeb3aa32fa50e827ebf32b35ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112843 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-21elide extracting vcl::Window from awt::XWindowCaolán McNamara
Change-Id: Ifb44471b996e20007ae49d09b212016ee77a4618 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112816 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-21ODF load: suppress calendar modifiers in format codes if possibleEike Rathke
... for switching to/from implicit secondary calendar, like ja-JP explicit [~gengou] and [~gregorian] most times are superfluous and GE or YYYY are used. In preparation for https://gerrit.libreoffice.org/c/core/+/108532 Change-Id: I8eb412c0fbba0927741bb305f91eb575b5f1bb13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112596 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-03-21devtools: change "Current Selection" button to toolbarTomaž Vajngerl
Change "Current Selection" toggle button and add it to the toolbar instead. Change-Id: Id891c4a324832f23f52449328d0f7eda6a862993 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112639 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-03-20drop unneeded includeCaolán McNamara
Change-Id: I3fe4ffd724613313db3791aa0d8c81c60b42f83b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112812 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-20add GetInputLanguage to EditViewCaolán McNamara
and hide the need to expose its vcl::Window Change-Id: Ide8a2e2500116af412a8717052a300e8ef4d1a48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112782 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-20SvxShape: no need to inherit from WeakAggImplHelper1 twiceNoel Grandin
once here, and once in one of the superclasses Change-Id: I0396012b613f195783ef8c7eae38f29120007381 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112744 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-19Fix typo in commentStephan Bergmann
Change-Id: I6b670bca6c6f374dec97a27134fc24b40cb45d9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112741 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-03-18inline some tiny sfx2 functionsNoel
Change-Id: I960d479d18bdd29fc14dd39649330d05fcdc0010 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112664 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-18elide SetParentAtSdrObjectFromSdrObjListNoel Grandin
the indirection just makes the code harder to follow Change-Id: I4046a822972d729ecfc9a9897bfdac146519dbd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112678 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-18weld the sidebar deckCaolán McNamara
Change-Id: Idc6710df7e59bcb5f61fca783e0cc0666cb13a1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112404 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-17optimize SalLayoutGlyphs for the common caseLuboš Luňák
This should reduce memory usage (libstdc++ vector is 3 int's and allocates dynamically). The usual case should be no font fallback. Change-Id: I2e7981c0962f4f417fd024e3c27f01bc2a71127e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112591 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-03-17make SalLayoutGlyphs work with MultiSalLayoutLuboš Luňák
Code that needs to lay out texts repeatedly can cache the result of SalLayout::GetGlyphs() can reuse it. But GetGlyphs() returns nullptr for MultiSalLayout, so caching for it doesn't work. Worse still, it actually increases the number of layout calls, because there's the initial layout for caching and then each call will need to do the layout again because of the nullptr that's not cached. This commit changes SalLayoutGlyphs to possibly include multiple SalLayoutGlyphsImpl objects, one for each SalLayout handled by MultiSalLayout. Changes include making GenericSalLayout work directly with the Impl class, which avoids an indirection and simplifies code. Change-Id: Ic4b19934a8a06d4955b51527fe3777c5e91107b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112590 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-03-17devtools: add refresh button for the DocumentObjectTreeViewTomaž Vajngerl
Change-Id: I4fea7dd2a12bc04649ff62e0d04e3058cf09c884 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112579 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-03-16enable grabbing focus to an unspecified container childCaolán McNamara
Change-Id: I269f76a3e71832ef2e8961952d9362838bd49cfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112577 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-16systools is no longer part of the URE interfaceStephan Bergmann
...since de030cd7a234fd9191364647deb1a4836ca992cb "gbuild: Remove MSVC 2013 legacy code", so no longer treat it as such in compilerplugins. (Which caused a few loplugin:includeform and loplugin:nullptr warnings.) Change-Id: I99b42e76992e31aff56b417c05738d4d29e3faf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112575 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-03-16add access to DumpAsPropertyTree for sidebar::DeckCaolán McNamara
Change-Id: I9df780ba3a6701275256fff585f4a969178aaff2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112574 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-16vcl: add BmpReader{Writer} and many BMP format testTomaž Vajngerl
Change-Id: Ibadfed73b9649689cec6e69f562a7a1226aef932 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112554 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-03-16devtools: add a text view to show the value of selected propertyTomaž Vajngerl
Sometimes the property value in textual form can take a lot of space, which can't be shown completely in the tree view. To solve this problem, this change adds a text view at the bottom of the tree view, that shows the complete value of currently selected property. The text view can be expanded if necessary, but to not require constant changing of the pane, the position of the text view is always reset to 90% of the total height. Change-Id: I209ee29c7b60ecaa15227cc4966f19a063a7dc0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112548 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-03-16devtools: put ObjectInspector widgets into it's own classTomaž Vajngerl
This is needed so they can be shared between ObjectInspectorHandler and DevelopmentToolDockingWindow, otherwise we have to add each widget as a parameter to the constructor and for each make a referenced member. This worked for a while but with more a nd ore widgets it is becoming ugly. Change-Id: I8f17e4593b04efaf85ef50d0639c306c204ce92a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112547 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-03-15Fix typo in codeAndrea Gelmini
It passed make check on Linux Change-Id: Idf02a51ff3f8a0a25d30606ea9744ec8d896924e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111083 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-15drop PrintWindowSubTree that is only callable by itselfCaolán McNamara
Change-Id: I14ec71ca429e60f7e350c92534db6d983a559c61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112536 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-15Fix typosAndrea Gelmini
Change-Id: I03d48712252cb9f2a3e3c14d6800081ed6af84d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111911 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-03-15tdf#133487 sw ODF export: reorder flys' ZOrder/z-index...Michael Stahl
... so background shapes have lower z-index than foreground shapes, as is recommended by ODF 1.3. Also let SdrObjList::sort() record Undo actions, because earlier Undo actions could expect the previous sort order. Change-Id: Idbecf0a2acd525d42efc0ac92677b1c7987cc6ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112180 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-15Drop obsolete commentsMike Kaganski
... since f14b9d30293f180500fc56d81e5390021758e7c1 and 7d8e94444d989d0ac4a4055b207726708e9ec0da. Change-Id: I51dcd16779adfa7acd95d916769f1142372190a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112426 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-15Clarify that rtl::ToStringHelper::length must be preciseStephan Bergmann
d87f5d30879aca73fff271c254589fc41a91fdd0 "support for fast O(U)String concatenation using operator+", introducing rtl::ToStringHelper, had intended that length can return an optimistic maximum value if the exact value cannot be determined (e.g., when creating the textual representation of a numerical value only on the fly, not upfront), witness the comments removed now, but never made use of that, always returning precise values from the various rtl::ToStringHelper::length specializations. And then cbe3b2fe0b9d745e22a2bf436ce55141b15f9502 "Avoid conversion warning in O[U]String[Buffer] constructors", not being aware that length could theoretically return an imprecise value, made certain code rely on it always returning a precise value. So clarify the status quo, that length always returns a precise value. (See also the discussion in the comments of abandoned <https://gerrit.libreoffice.org/c/core/+/110129> "Drop obsolete comments".) Change-Id: I7dc72e9e15304779cc4d2edc01331959b6fbe869 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112397 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2021-03-15no need for this map<> key to be constNoel
it is a value type Change-Id: If2b122a72b3e0359a9b7996ede85e625a44102d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112476 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-14fix typo in style dialog functionSeth Chaiklin
Change-Id: I88b38a33a1ca50a0165b11679ca28bb092a6eab5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112307 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-14tdf#141011: Postpone SwFieldDBPage::Reset to tab activationMike Kaganski
This way, it will only ask for password when dialog is switched to that tab. Change-Id: Ie2a453b0b6867ceb1ef3728a8565de4f6cbf4757 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112469 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-14check for quit when calling Yield in loopNoel Grandin
so we don't get stuck threads when the main application quits Change-Id: Id36e99267ceb4154873b6ef8ef494622fff6c19a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112409 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2021-03-14loplugin:unusedmethodsNoel
Change-Id: I851eba4ca80eac9ee5896df53fbcd0f5ad125763 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112433 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-13merge the various SetPointFont via DefaultDevice callsCaolán McNamara
Change-Id: I769bb95c588c7222ff0dc6c4b845dfc3f0d7cbc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112390 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-13devtools: document classes and method, remove unneeded methodsTomaž Vajngerl
This documents DevTools classes and methods. In addition it also removes some methods that aren't needed anymore. Change-Id: I550e2ce197d1565b4f770eb7dd59b2195f2230a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112379 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-03-13devtools: show superclass tree in interface and services tree viewTomaž Vajngerl
Change-Id: I508b568bbb5b0559c265a3f058e689eeeb326b83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112372 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-03-13add PixelFormat enum that replaces bit count in Bitmap/BitmapExTomaž Vajngerl
Bit count for the image is a numeric value (sal_uInt16) but only a handful of values make sense - namely 1,4,8,24 and 32. This replaces the numeric value with an enum, which only accepts those values and checks the correct values are used at compile time. Change-Id: I0fc137c62bce3b0d021f05019a1648da628521bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112408 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-03-12drop PNGReader and use only PngImageReaderLuboš Luňák
PNGReader is a home-made PNG reader that does not use libpng, so it's more code, presumably less optimized and it apparently also doesn't always map colors properly. The only two features it has that PngImageReader doesn't are explicit chunk reading (used only for reading Microsoft's GIF in PNG, I implemented that for PngImageReader in a previous commit), and it loads paletted images as BitmapEx with a palette instead of converting to direct-color 24/32bpp or 8bpp-gray. The latter is even questional if nowadays that's feature or a misfeature, as it saves memory at the expense of speed. I can implement that if somebody misses it. I had to adjust some tests: - CVE-2016-0952-1.png - invalid CRC of the PNG header, neither Gimp nor Gwenview can display that, it should fail - afl-sample-Z_NEED_DICT.png - failure while decompressing data, but the loader considers that only a partially broken image since the header is correct, so it "passes" (like in Gimp or Gwenview) - SdImportTest::testTdf134210() and testPictureWithSchemeColor::Load_Verify_Reload_Verify() need the colors tested changed, because apparently gamma correction or something is now applied correctly, and it wasn't before (again checked the loaded images with Gimp) Change-Id: Id46f8d8a01256daf48ca64264b47c4e609183837 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112042 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-03-12add support for Microsoft Gif chunk to PngImageReaderLuboš Luňák
Change-Id: I7d7f47041c48eb1a19e2aaee0c6da8c675ada4b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112039 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-03-12tdf#140136 sc: fix tree list expansion in AutoFilterAttila Szűcs
Now clicking on +/- buttons (i.e. before the checkbox) only expands/collapses the tree without toggling the associated checkboxes, using the new GetItemPos() to get the position (and width) of the checkbox in the actual list item. Regression from commit 2471d6f44c7e8ecbe86a90eeb593b899a08a7408 "tdf#116675 vcl tree list: toggle by label click (e.g. in AutoFilter)". Note: Use generic VCL plugin to test it on Linux: SAL_USE_VCLPLUGIN=gen instdir/program/soffice Co-authored-by: Tibor Nagy (NISZ) Change-Id: Iceb17bc9b235d297c313361429ee89f04d809e96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111668 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-12use some forward declares to avoid including vcl/window.hxxCaolán McNamara
Change-Id: I67992b7743f98d6228a0a52d2e5a92e4f25eaa15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112347 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12use preferred variant when window arg is nullCaolán McNamara
Change-Id: I8fad194b6f147b40ecee6fff9fbbe947e7faa014 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112345 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12transport error dialog parent as awt::XWindow earlierCaolán McNamara
Change-Id: Idfc6ffdb31d28316886800eed12ac46c1dbcc191 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112336 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12Fix wrong position on move when page has marginmert
Change-Id: I9ac2d9914b86210ca2148b44488c2c70cc5870d4 Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111949 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111929 Tested-by: Jenkins
2021-03-11use an explicit parent for error messageCaolán McNamara
Change-Id: Idf5a1c6a4313ab58c2bf6ee0ec02a8d003eee83a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112335 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11use an explicit parent for error messageCaolán McNamara
Change-Id: Ib171ee0e7dc4936552b5a9a5c9d50ae7fd6a54d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112333 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11TransferableDataHelper::CreateFromSelection doesn't use its argumentCaolán McNamara
Change-Id: Id43995411d850ae051d1d803bcea2745e1dc17a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112331 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11keep SfxObjectShell::GetDialogParent ret as an awt::XWindowCaolán McNamara
instead of extracting the vcl::Window impl details from it Change-Id: Ia13c1559861ab2a65a2108c8ccd704cba711916c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112329 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-10 13:29:43 +0000