summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2018-01-13loplugin:useuniqueptr in PolyPolygonNoel Grandin
Also - convert to o3tl::cow_wrapper - drop the second param to the constructor and just let vector use it's own resize logic - bump MAX_POLYGONS from 0x3FF0 to 0xffff so that the ios2met filter can load it's files properly. Change-Id: I9db19e4f7b4f946e801ea07c31d2d0ded7837a0e Reviewed-on: https://gerrit.libreoffice.org/47789 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-13provide uno::Sequence with ostream output operatorThorsten Behrens
Alongside Anys and other UNO data types, you can now also stream out Sequences, e.g. in SAL_INFO or SAL_DEBUG statements. Example code: uno::Sequence<sal_Int8> aBuffer... SAL_DEBUG("my buffer: " << aBuffer); Would yield: debug:<pid>: my buffer: 0xb6, 0x61, 0xa8, ... Change-Id: I03b0789372c44a4dd057625824862f43b1b8dfdc Reviewed-on: https://gerrit.libreoffice.org/47779 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-12tdf#114939 sal: deprecate rtl_digest_*SHA* and rtl_digest_PBKDF2Michael Stahl
Document the disaster but don't fix it so this implementation can be used to import existing documents with bad SHA1 hashes. Change-Id: I4f3648dd0987392ef49dc149a9213bcafcefb202
2018-01-12tdf#114939 package,comphelper: Try both real SHA1 and StarOffice SHA1Michael Stahl
... when importing ODF documents. In CreatePackageEncryptionData(), add a 3rd SHA1 password hash, PackageSHA1CorrectEncryptionKey, to EncryptionData. Use it in ZipPackageStream::getDataStream(), which has 3 fall-backs for SHA1 bugs now. Also add a CorrectSHA1DigestContext, to be used together with PackageSHA1CorrectEncryptionKey, and rename the existing one to StarOfficeSHA1DigestContext, to be used together with the existing 2 PackageSHA1{UTF8,MS1252}EncryptionKey. The fallback won't be used very often anyway: for the password SHA1 to be wrong, you need a password between 52 and 55 bytes long, and for the SHA1/1K checksum to be wrong, you need a file smaller than 1K with compressed size mod 64 between 52 and 55; all XML files have enough random "chaff" added to be too large. Test that we can read both correct SHA1 and StarOffice SHA1. Change-Id: I988fa489b5e40c7657f404f18538f637d54d28f1
2018-01-12test: cancel interaction on password *re-entry*Michael Stahl
If the password was wrong the first time, it's not going to be right if we return it a second time. Avoid infinite loops in tests. Change-Id: Ie4bf92853d0789b0114250f6c8ded1b2c3ab184d
2018-01-12sfx2 store: add API to allow disabling thumbnails only for a single saveMiklos Vajna
This is similar to the officecfg::Office::Common::Save::Document::GenerateThumbnail config setting, but here we allow configuring this at a per-save basis, not persistently. Change-Id: Ieb5bd57f1d8fc9e211011f2647276d985cf53131 Reviewed-on: https://gerrit.libreoffice.org/47812 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-12More loplugin:cstylecast: basegfxStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: Ifa4a6643b41525c962cd6af5776e1bf10bddb71c
2018-01-12More loplugin:cstylecast: basicStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I20b38196ee1b6a34384dc46d9de1b6e1b44947ae
2018-01-12More loplugin:cstylecast: canvasStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I1054389bc292544a1ba302509175c8718dbec747
2018-01-12More loplugin:cstylecast: comphelperStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I71a5092b344f206f2c7de606f2739d3b6e2cf0bb
2018-01-12More loplugin:cstylecast: connectivityStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: Idbefb16acae20ab137497e78c9bc5dc5634c07fe
2018-01-12More loplugin:cstylecast: cppuStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I8531b2dc474b257c63016c8ae80014c7322e5a71
2018-01-12More loplugin:cstylecast: cppuhelperStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I3966d302241a52014aaad41f72924a2095ea6621
2018-01-12More loplugin:cstylecast: editengStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I09a4d688e6f3c1ecbe05a7d27ebd955e8ba1eb65
2018-01-12More loplugin:cstylecast: i18nutilStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: Idca83b62766c2de87bf112cf0bb565e953b7dcb0
2018-01-12More loplugin:cstylecast: o3tlStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I7cb2c6ff2421d615599d178dc6eb3d62dd1becf7
2018-01-12More loplugin:cstylecast: ooxStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I8fd61e3220a4b9e08d4f97acde28600f31d448ca
2018-01-12More loplugin:cstylecast: salStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I7d89b011464ba5d2dd12e04d5fc9f65cb4daebde
2018-01-12More loplugin:cstylecast: sfx2Stephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: Ia3bed56999f3d684f706ce0bd5be8a2269b06d22
2018-01-12More loplugin:cstylecast: sotStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I7387e4c7877faba8bc82372734c14d2263457300
2018-01-12More loplugin:cstylecast: svlStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I71e3b2c9b4c68183288f43999d242e95ae13584d
2018-01-12More loplugin:cstylecast: svtoolsStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: Ide9e7c53b554f0a36e2078a8823f5ef6fb5cc8fa
2018-01-12More loplugin:cstylecast: svxStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I100e6c14cbf1d780f0e5ebca6b0c9e71ce1caaf7
2018-01-12More loplugin:cstylecast: toolsStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: Ifb9ebc9623c8df14ea0d4c907001bd16c5b9ae59
2018-01-12More loplugin:cstylecast: vclStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I363c01a1ae9e863fca4fb4589829492d7280d711
2018-01-12More loplugin:cstylecast: xmloffStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: Ic872cef7bb9982305528ec3ce12a1871f055b752
2018-01-12Repair windows build break.jan Iversen
Forgot to isolate extern declaration, mac/linux had no problem, but windows breaks. Change-Id: Ib09119661225193d9cfb1cd9118b78cf7d9bd2f4
2018-01-12iOS, stop trying to do dynamic load in init()jan Iversen
LibreOfficeKit, tries traditionally to load a dylib, and locate the symbols, for iOS this is already linked to a single Kit.o. Code is changed to a simple call Change-Id: Ie94a447260cb3007e7e2b56c1b67896ad40d79d3
2018-01-12filter: fix dbglevel=2 build of msfilterMiklos Vajna
Change-Id: Ifb6747f170d7c9928d07cebb0918fdb329e96dbf Reviewed-on: https://gerrit.libreoffice.org/47778 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-12new[] vs. delete mismatchStephan Bergmann
...after e57a036939e27ecd173ace691689e26a6a33df8e "loplugin:useuniqueptr in tools,stoc,unotools" Change-Id: Ifb9a3a5f37895aa75edc7f4e90e8cfe47d79bca7
2018-01-12loplugin:useuniqueptr in Accelerator and ImplSplitSetNoel Grandin
Change-Id: Ic7f3f2653a1d28b8f18804981de788c93eb97c56 Reviewed-on: https://gerrit.libreoffice.org/47729 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-11tdf#105000, related tdf#80196: Make new color names translatableGabor Kelemen
Make the new color names of the Tonal palette translatable These were added in 98419425080f58880f2d0d85749a4a55e8abb40b Change-Id: I9a55fbd50bbb97d294f7e6cfdfbe56c2605d5ae7 Reviewed-on: https://gerrit.libreoffice.org/45838 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-01-11Replace macro with functionStephan Bergmann
...and move it into the only .cxx that uses it; making just enough of BitmapColor constexpr as is useful here Change-Id: I8a035f67f4b218dcef2f100814c62b25fb32d5be Reviewed-on: https://gerrit.libreoffice.org/47750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-11loplugin:redundantcast: svxStephan Bergmann
(after a to-be-committed improved loplugin:cstylecast would have rewritten the C-style casts into static_casts) Change-Id: Icd1f084d4ffab286fd3c7c02693444eaf7799354
2018-01-11loplugin:redundantcast: toolsStephan Bergmann
(after a to-be-committed improved loplugin:cstylecast would have rewritten the C-style casts into static_casts) Change-Id: I20c94335b3ddeeea40af1f2b0d3777f139186a01
2018-01-11loplugin:redundantcast: vclStephan Bergmann
(after a to-be-committed improved loplugin:cstylecast would have rewritten the C-style casts into static_casts) Change-Id: I5e515738a29c6d79154560d69c8b86885800ba88
2018-01-11loplugin:useuniqueptr in svlNoel Grandin
Change-Id: I2fdb63517349474d90cb17ad2bd667f30840e83d Reviewed-on: https://gerrit.libreoffice.org/47727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-11[API CHANGE] migrate PackageKit usage to Modify2Caolán McNamara
xid dropped in favour of application_id Change-Id: Id1eb43aa9c8dfb4eac82f99eff0f84c5320e0da0 Reviewed-on: https://gerrit.libreoffice.org/47661 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-11connectivity: various small cleanups in the Writer driverMiklos Vajna
Change-Id: I91735c3e92262fd37966c53f973d5eee1522cd61 Reviewed-on: https://gerrit.libreoffice.org/47741 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-11loplugin:useuniqueptr in tools,stoc,unotoolsNoel Grandin
Change-Id: Ia72b65577143623cedc7a40bc34f7fb897add097 Reviewed-on: https://gerrit.libreoffice.org/47726 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-11tdf#36308 make double click not expand/collapse node in Navigator treeJim Raykowski
Change-Id: I0075af147e5aa02f09db57fc2113dcdfcab5bc57 Reviewed-on: https://gerrit.libreoffice.org/47241 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-11convert (a>b?a:b) to std::max(a,b)Noel Grandin
with something like: git grep -nP '(.*)\s*>\s*(.*)\s*\?\s*\g1\s*:\s*\g2' Change-Id: I60b9a3a2a09162bc0de4c13fdde2c209696e5413 Reviewed-on: https://gerrit.libreoffice.org/47602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-11RotateFlyFrameFix: Add RotCenter info to ODF exportArmin Le Grand
Since the WriterFlyFrames are implicitly rotated around their center in the Writer UI this has to be added to the transformation in ODF expressing this. The saved data now contains the shape data in svg:x/y/width/height statements (and thus back-compatible AFAP) and a draw:transform statement (that is to be applied to the defined shape) containing the rotation around the object's center. Change-Id: Iccfc70924364f1d58995fce180bce9b6e7643ff4 Reviewed-on: https://gerrit.libreoffice.org/47719 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-10Mention that the getError() semantics are unclearTor Lillqvist
Change-Id: Ifd5b04cc13085749f0f800bdb69cc3fdd5581916
2018-01-10sfx2 store: add API to allow avoiding the fsync of the output fileMiklos Vajna
The use-case is when the consumer of the output file will read it right after SfxBaseModel::storeToURL() returns, in which case an expensive fsync is pointless. Times for 100 hello world inputs: 8516 -> 2785 ms is spent in ODT-load + HTML export + close (33% of original). Change-Id: I05e424a43ebfeea363f82b57af60f5aaa28696b4 Reviewed-on: https://gerrit.libreoffice.org/47695 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-09tdf#114173 Preserve size of chart legend during xlsx exportBartosz Kosiorek
During export chart into .xlsx file, the information about size of legend was not saved. Example of proper size: <c:w val="0.41459448854442293"/> <c:h val="0.23161616722845749"/> another issue was hardcoded "layoutTarget" which was always "inner": <c:layoutTarget val="inner"/> also properties regarding default text style was not preserved: <c:txPr> <a:bodyPr/> <a:lstStyle/> <a:p> <a:pPr> <a:defRPr sz="900" b="0" i="0" u="none" strike="noStrike" kern="1200" baseline="0"> <a:solidFill> <a:schemeClr val="tx1"> <a:lumMod val="65000"/> <a:lumOff val="35000"/> </a:schemeClr> </a:solidFill> </a:defRPr> </a:pPr> <a:endParaRPr lang="pl-PL"/> </a:p> </c:txPr> With this patch all these issues was resolved, and in case of layoutTarget "outer", the field is not availble at all, according to specification. Change-Id: I2c9b7a112bdd911542b5273e660222d7fefa2d88 Reviewed-on: https://gerrit.libreoffice.org/47358 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-09convert COLOR_CHANNEL_MERGE to constexpr functionNoel Grandin
Change-Id: Ie46e0a47b433517b0bae0deabb447ff5c1000f22 Reviewed-on: https://gerrit.libreoffice.org/47595 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-09RES_CHRATR_PROPORTIONALFONTSIZE and RES_CHRATR_NOLINEBREAK unusedNoel Grandin
but leave placeholders behind to avoid having to renumber items. Change-Id: Ifa1a9dc790a68d7486da7504c11b3c203a5fd3db Reviewed-on: https://gerrit.libreoffice.org/47580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-09tdf#45904 Move _SpreadsheetViewSettings Java tests to C++Jens Carl
Change-Id: I68dcabd15b4b318a833a893b4de96c64ffd2a164 Reviewed-on: https://gerrit.libreoffice.org/47625 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-09tdf#45904 Move _SubTotalDescriptor Java tests to C++Jens Carl
Change-Id: Id4265dd6a8123624bccdfe343655525948cadee7 Reviewed-on: https://gerrit.libreoffice.org/47623 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>