summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2020-01-30loplugin:unusedmethodsNoel Grandin
Change-Id: Icab9a4789b0bb9187ad5393a2b8578fc4c5e401f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87736 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-30tdf#124176: Use pragma once instead of include guardsbugrakurt
Change-Id: Ia353a95df0e78e9da2b6fb95c2bc3a6e83c72fcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87738 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-30loplugin:unusedfieldsNoel Grandin
Change-Id: Ifb9c91b3e8d6c2dd3a639a239fa41e7d5c7a4ee6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87735 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-30tdf#124176: Use pragma once instead of include guardsbugrakurt
Change-Id: I15f9cbce2344cebbe73a915758ce1631f46d7da8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87721 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-30slider.hxx has no need to include field.hxx anymoreCaolán McNamara
Change-Id: Ib612df11eda9afe5b8e5610b3caf520bf8668e6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87711 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-30mpLinkedField is never setCaolán McNamara
Change-Id: Ib774c57e9137979fc3f70d4798f1b875b99e4ea1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87710 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-29lok: preserve mouse event logic position and use in calcTomaž Vajngerl
When clicking in online Calc any of the charts, shapes (and other objects), sometimes the cell underneath is selected instead. The problem is that the object is not correctly recognised to be hit. From lok we get the mouse event position in logic coordinates, which we usually can just use in writer and impress. In calc however we need the coordinates in pixels, so we transform them before sending the mouse event to calc. Still calc also uses common SdrObjects (chart, shapes,...), which operate in logic coordinates. So in case of SdrObject we need to convert the coordniates back from pixel to logic again, which causes problems because conversion doesn't have access to the displaying conditions on an stateless online client. OTOH we already had the correct logic coordinates, and we can just send them along. This is what this change does. It adds an optional maLogicPosition to MouseEvent, which is filled with logic position if those is known. Change-Id: I26f6466085baf613850b5861e368f22cad7c1d26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87681 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-29bInterim is always trueCaolán McNamara
Change-Id: Id9f72fdb94a766ef58a44b3653a36f22335b5718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87676 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-29bInterim is always setCaolán McNamara
Change-Id: I2a84351d98523a2dda7db96a4099837d0e8a8ad1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87664 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28tdf#128352 stylistic correction of dialog box titleSeth Chaiklin
- Change template Manager to "Set as Default" Change-Id: Ifb34e2621b9795be5eae829b7f84f252cfa74285 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87600 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28Use better types for PPDContext::countValuesModified/getModifiedKeyStephan Bergmann
Change-Id: I663216e94fed3ce8f61cef0aeab3cd79f358b7fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87632 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-28HAVE_GCC_ATTRIBUTE_WARN_UNUSED should always be true now for Clang/GCCStephan Bergmann
...but for safety, leave the configure.ac check in for some longer. Change-Id: I90cba5812492ba85d7723ff71aba75b7721b9622 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87621 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-28move private TimeBox to toolkit-only headersCaolán McNamara
move private DateBox to toolkit-only headers move private CurrencyBox to toolkit-only headers move private PatternBox to toolkit-only headers move private CurrencyField to toolkit-only headers move private CurrencyFormatter to toolkit-only headers Change-Id: If5ba9e07b20cdc69ca554af388ec9d9e362cbf9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87555 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28remove newly unused ToolbarPopup ctorCaolán McNamara
Change-Id: I8ec0d4fd4e26cfc8b87649c25b03298fdd652250 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87597 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28add SAL_WARN_UNUSED to RegionCaolán McNamara
Change-Id: Iff46a2d46dd9ee7fb4f5966451dac345e1e14126 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87587 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28ToolbarMenu is now unusedCaolán McNamara
Change-Id: Id48bb98045886ee79149f27c58e54488a80af41f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87554 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28weld FontworkAlignmentWindowCaolán McNamara
Change-Id: Ib686407bae900cefa35294249fc02458a7992d8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87553 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28weld FontworkCharacterSpacingWindowCaolán McNamara
Change-Id: Idb049b2b7461c4f8206e0ded3c0bd36390df3682 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87544 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28New loplugin:unsignedcompareStephan Bergmann
"Find explicit casts from signed to unsigned integer in comparison against unsigned integer, where the cast is presumably used to avoid warnings about signed vs. unsigned comparisons, and could thus be replaced with o3tl::make_unsigned for clairty." (compilerplugins/clang/unsignedcompare.cxx) o3tl::make_unsigned requires its argument to be non-negative, and there is a chance that some original code like static_cast<sal_uInt32>(n) >= c used the explicit cast to actually force a (potentially negative) value of sal_Int32 to be interpreted as an unsigned sal_uInt32, rather than using the cast to avoid a false "signed vs. unsigned comparison" warning in a case where n is known to be non-negative. It appears that restricting this plugin to non- equality comparisons (<, >, <=, >=) and excluding equality comparisons (==, !=) is a useful heuristic to avoid such false positives. The only remainging false positive I found was 0288c8ffecff4956a52b9147d441979941e8b87f "Rephrase cast from sal_Int32 to sal_uInt32". But which of course does not mean that there were no further false positivies that I missed. So this commit may accidentally introduce some false hits of the assert in o3tl::make_unsigned. At least, it passed a full (Linux ASan+UBSan --enable-dbgutil) `make check && make screenshot`. It is by design that o3tl::make_unsigned only accepts signed integer parameter types (and is not defined as a nop for unsigned ones), to avoid unnecessary uses which would in general be suspicious. But the STATIC_ARRAY_SELECT macro in include/oox/helper/helper.hxx is used with both signed and unsigned types, so needs a little oox::detail::make_unsigned helper function for now. (The ultimate fix being to get rid of the macro in the first place.) Change-Id: Ia4adc9f44c70ad1dfd608784cac39ee922c32175 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87556 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-27tdf#124176: Use pragma once instead of header guardPelin Kuran
Change-Id: Id28874549342349fb2727c3cb8e92da1dcdb727c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87513 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-27weld ExtrusionDepthWindowCaolán McNamara
Change-Id: I62f7ebb1c2f6b882fdd59825a52b9b308ccafd34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87536 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-27weld ExtrusionSurfaceWindowCaolán McNamara
Change-Id: I13b61c8e4ef0a251472b02061fa150451a7b03a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87530 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-27weld ExtrusionLightingWindowCaolán McNamara
Change-Id: I3078ca8315f84f03431a07630987687144857818 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87527 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-27weld ExtrusionDirectionWindowCaolán McNamara
Change-Id: I94f6d602f489d34f9b35ee2ec20e7fdf62e50adf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87519 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-27tdf#124176: Use pragma once instead of include guardsKemal Ayhan
Change-Id: I6315560e8607f50fdcc64631a04163d032666fad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87377 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-27weld LayoutToolbarMenuCaolán McNamara
Change-Id: I779f631a1c6de42357b53a56582680cf3a7f559d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87507 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-27tdf#124176: Use pragma once instead of include guardsHakan Bakacak
Change-Id: I65639e32765ba0804aeb5b5880eca2b5d186485e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87431 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-27tdf#130197 give paragraph and table panels column widths of 5 toolbutton widthsCaolán McNamara
Change-Id: Iae4f10eef6b293731d22eec8dcbb85a07d3e6c11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87462 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-26tdf#124176: Use pragma once instead of include guardsiakarsu
Change-Id: I6a7f7711fa931657dd97c9c0bc1bdce671b69b7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87405 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-26tdf#124176: Use pragma once instead of include guardsMehmet Emin Başoğlu
Change-Id: I045ce53c74bfb24be77537986fb5a8fcad3ed173 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87401 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-26tdf#124176: Use pragma once instead of header guardPelin Kuran
Change-Id: I55ca953de1d0c4eea1df802e66b0c8d9468d5126 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87381 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-26restore fix of tdf#83320 Hide vertical text commands earlyCaolán McNamara
Change-Id: I738776028af90e2711418f922ff6e77a5cce14c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87423 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-26move "remove duplicates" for a vector to o3tl/vector_utils.hxxTomaž Vajngerl
Change-Id: I9ecf95a2bf975912b7029cdfb459a9ebc159c75d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87429 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-26acc. check: check if text format conveys additional meaningTomaž Vajngerl
Change-Id: I8f51248e453018c33ddc64b00cdbc1708309e577 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87420 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-25Resolves: tdf#130159 hide writedirection unless CTL is enabledCaolán McNamara
rework as ToolboxControllers registered in Controller.xcu Change-Id: I3e7fea09fe83d1ed6400218c41384f82b38b07a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87419 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-25tdf#130137 Replace remaining uses of WNT define checks with _WIN32A_GAN
Change-Id: If95f1ea5a81de62eb4f725e5fcb30ccb8530062a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87372 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-25tdf#124176: Use pragma once instead of include guardEfdal İncesu
Change-Id: Ic525a57880067fc589346b87237c08fae4644ac5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87403 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-25Related: tdf#128942 remove the scrolledwindow frames from all the dialcontrolsCaolán McNamara
Change-Id: I445753ad1eb4d441e5a5e909ae450bda6013a6b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87352 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-25Change some more #define to constexprStephan Bergmann
...similar to 572681bfc7bb141c9f16694df05a505e9d9f1a88 "Change some #define to constexpr" Change-Id: I2a8972396a5d9765ea9b4f04ff172309e8f3b9f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87378 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-25Change some #define to constexprStephan Bergmann
...plus loplugin:unnecessaryparen fallout in sw/source/uibase/docvw/edtwin.cxx. Each of the files contained at least one #define that would have caused warnings with upcoming loplugin:unsignedcompare. For consistency, I changed all #defines in those files (using a variable of a specific type if the original #define used a cast to that type, otherwise using 'auto'). Change-Id: I66f71b2d83394c9dc6952ae19df774cdd4d0b76a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87374 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-24rename PreviewControl3D back to Svx3DPreviewControlCaolán McNamara
Change-Id: I90791c4d87da465fbf486014cefe755985b600b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87338 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-24rename LightControl3D back to Svx3DLightControlCaolán McNamara
Change-Id: I3e62bd55f195e9f652ddc21bff74f529a8678b5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87337 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-24Svx3DLightControl is unusedCaolán McNamara
Change-Id: Ibd884eea366d3a66f786fc9e52323883f2dbca89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87299 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-24rename LightCtl3D back to SvxLightCtl3DCaolán McNamara
Change-Id: I2cf5d019324643b048eea432753705af485720a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87336 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-24remove some unused includes and update pchCaolán McNamara
Change-Id: I481e3431ce50618cc64b744303734a1763c51e57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87301 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-24Svx3DPreviewControl is now unusedCaolán McNamara
Change-Id: I5ab6783cd0e36718798b0e7075f46a4e28e11761 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87300 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-24SvxLightCtl3D is now unusedCaolán McNamara
Change-Id: I4aca00692184a91ce969feb909a75dff897fe5e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87298 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-24weld Svx3DWinCaolán McNamara
Change-Id: I472a4edb5ac7a8039d21128256c204e2969acc6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87296 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-24set title of Color Replacer dialogCaolán McNamara
Change-Id: I79ae929e12b844c738eb62660d363fbd4699ed15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87295 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-24loplugin:makeshared in ooxNoel Grandin
Change-Id: I6502e7be4881834b143ec7207c432881b2ae263c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87322 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-13 03:33:57 +0000