summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2018-02-09add setter methods to tools::RectangleNoel Grandin
intended to replace the existing methods that return mutable ref And add the clang rewriter I will use to do most of the work. Change-Id: If00be13da5c16c07671cedbcfea21528bac33c8a Reviewed-on: https://gerrit.libreoffice.org/49430 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-09tdf#115394 correct transition in case of 0sSzymon Kłos
Change-Id: I23d18acef0bd5db4a4ad6fc67d409e7ed5c93949 Reviewed-on: https://gerrit.libreoffice.org/49462 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-02-09tdf#108210: Allow to ignore a lock file if there's no filesystem lockMike Kaganski
Two cases are handled: when a file is being opened, and when it was opened read-only already, and one tries to reopen it in edit mode. The option to ignore locking and open the file anyway is only offered when there is no filesystem lock present on the file. Change-Id: I377d3cae4c949ae64d449634acea8fb3f68a5700 Reviewed-on: https://gerrit.libreoffice.org/49448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-08tdf#86739 Option to set image anchor type in image insert dialogSamuel Mehrbrodt
This adds the selectbox to (hopefully) all filepickers: - LO native - GTK/GTK3 - KDE4 - KDE5 - Windows - macOS Change-Id: I01bd42b1ca18e0f691b879647a6cb1b62177d3ce Reviewed-on: https://gerrit.libreoffice.org/49311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-08Add debug output operator for IIDTor Lillqvist
This file is the place for future similar additions. Change-Id: Ibe168731ed97fe2366afb89409fe5ae2afa711e4
2018-02-08sd, sc lok: IME support + unit testsPranav Kant
Change-Id: I710ba4347977641102b89fd274a159d34bc29e72 Reviewed-on: https://gerrit.libreoffice.org/49385 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-02-08Different approach for tdf#115227Maxim Monastirsky
This reverts the previous attempt of commit 250ad9311a613d9b4e1cf5cf5fdaf33d9b326220 ("tdf#115227 svtools: suppress UNO notifications for color selectors"), in favor of a different fix. The advantage of this new approach is that is doesn't affect events other than activate/deativate, and that it covers more cases: Toolbar popups even if not based on svtools::ToolbarPopup, or if closed by clicking outside them, font name/size and paragraph style toolbar controls, notebookbar, context and main menus (for the non gtk3 native case, the gtk3 native menus left for a future investigation). For now, keep this logic inside toolkit, but ideally it should be in vcl (after reviewing vcl internal listeners). One side effect that I noticed after this change, is that there is a deactivation/activation pair which suppressed when e.g. opening a new document from the start center. But I'm not sure if that's a problem, given that the focus state of the top window as a whole wasn't changed, only its contents, and there are other APIs to track activation of document components. This happens because the source and the target windows of those events are the same, and we need to suppress this case to fix the font name/size style controls, and also the color picker after 27473d1c0f8ba3006262001cbefff33f639a19ac ("tdf#114935 Move the focus back to the document"). Otherwise we'll need to find another way to move the focus to the document w/o triggering listeners. Another case that will see a change in behavior, is document event listeners in dbaccess, as the Focus/UnFocus events there are based on top window activation/deactivation. However, I think it's a good change, as currently just opening of a toolbar popup or main/context menus there triggers those document events, making them useless. I would like to also mention here, that in fact those top window activation events never really worked as tdf#115227 expects them, as the superfluous events for at least the font name/size, style and color toolbar buttons existed already in OOo. The behavior of the color buttons changed in LO for a few years, but regressed again in the work on a real focus grabbing for floating windows starting with commit dd46727b99d4bb5135451aa7e5e1bdb197373843 ("Resolves; tdf#87120 no keyboard navigation inside floating windows"). That work also introduced superfluous events when using menus. And a note about the change in menubarwindow.cxx: When a menubar popup is closed it's deleted using the lazydelete mechanism, which reparents the popup window, so it doesn't appear anymore in the hierarchy of the document window. Moreover, I suspect that at some point the lazydelete thing will be replaced by a VclPtr mechanism, which might break this even further, so the event won't appear as coming from the popup window (which might be already disposed at this stage). So instead, temporarily set the menubar window as the current focus window, so the activation will appear as if it was coming from the menu bar window itself. Change-Id: I292232adfcbd1a31d66ce394cd2f1bf42a013ecb Reviewed-on: https://gerrit.libreoffice.org/48746 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-08move setAlphaFrom from GraphicTransformer to BitmapExNoel Grandin
Change-Id: I69329c61e81791db3806fabe3256571fa937deb6 Reviewed-on: https://gerrit.libreoffice.org/49360 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-08sw lok: IME support + unit testPranav Kant
Change-Id: I557493db23dfa3529606050c86161628dbd722e7 Reviewed-on: https://gerrit.libreoffice.org/49354 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-02-08sprinkle SAL_WARN_UNUSED over Bitmap/BitmapExNoel Grandin
Change-Id: If6fe5f05ecfc26c38890efde0f5e61edb7c3fbc5 Reviewed-on: https://gerrit.libreoffice.org/49359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-07tdf#115483 svl xmloff sc sw: verify all ODF 1.2 protection-key hashesMichael Stahl
ODF 1.2 has added some mandatory requirements for protection-key hashes which did not exist in ODF 1.1. This affects sections and indexes in ODT documents, as well as spreadsheets and sheets in ODS documents. 1. Accept the following hashed passwords: * UTF16 LE/BE encoded StarOffice-SHA1, OOo legacy and allowed by ODF 1.1 * UTF8 encoded proper SHA1, as required by ODF 1.2 * UTF8 encoded SHA256, as required by ODF 1.2 - specified either with the wrong URL used in the ODF 1.2 spec or the correct URL from the W3C spec, see OFFICE-3702 * Excel+SHA1 double-hash, only in Calc, see OFFICE-2112 2. Round-trip any of the above as-is * for SHA256 only write the URL from the ODF 1.2 spec 3. Generate only UTF16 LE encoded SHA1 for now, so that older LO releases can still verify the password * some time in the future, switch to generating some valid ODF 1.2 hash More changes are necessary in Calc, which can actually preserve different hashes for the same passwords in its runtime data model, whereas Writer just has a single buffer without even any metadata. For the Calc unit tests we need one document per hash because the protection-key attribute can be set on the entire spreadsheet, which is an unique element in the document. There are further uses of SvlPasswordHelper for change-tracking passwords, but apparently those are stored in settings.xml, so ODF has no requirements for them, so let's leave that as it is. Change-Id: Icb720b14ae9c0d9c04d2e082769ae2b74e3af8aa Reviewed-on: https://gerrit.libreoffice.org/49352 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-07move Bitmap::SetToData to BitmapToolsNoel Grandin
Change-Id: I0fc62d29d2044c2aa8af3742d4aeb9d782793713 Reviewed-on: https://gerrit.libreoffice.org/49280 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-07tdf#115394 import custom slide transition time in PPTXSzymon Kłos
* custom values are imported correctly * standard (fast, slow, medium) values are changed to match values in the MSO Change-Id: I004242afbbf641fe414abc8df248a2844c104502 Reviewed-on: https://gerrit.libreoffice.org/49139 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-02-07ofz: Pos2Page returns true on same value that returned false previouslyCaolán McNamara
a failed position returns false, but stays at the failed position, so next time its called without moving it then it returns true store what we return for a given position for reuse if the position doesn't change Change-Id: I404c65ac89eb6f5c867f62a62028b87effdbcbf8 Reviewed-on: https://gerrit.libreoffice.org/49308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-07use scanline when reading pixel dataNoel Grandin
extracts code from the innermost part of fairly hot loops And add a GetIndexFromData method to make the call sites a little easier to read. Change-Id: I4ce5c5a687ecdb6982562a0aafce8513d86f9107 Reviewed-on: https://gerrit.libreoffice.org/49337 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-07loplugin:useuniqueptr in TextChainFlowNoel Grandin
Change-Id: Iad96df43c9c7ae6d5fd4f3aa9c2c5c721711da30 Reviewed-on: https://gerrit.libreoffice.org/49331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-07loplugin:useuniqueptr in SdrUndoObjSetTextNoel Grandin
Change-Id: Idd1eb8263d679efed0f0be88fb05963fe44f8668 Reviewed-on: https://gerrit.libreoffice.org/49328 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-07loplugin:useuniqueptr in SdrTextNoel Grandin
Change-Id: I23cc319707132c28725acdb8be0bea275025b9e5 Reviewed-on: https://gerrit.libreoffice.org/49332 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-07loplugin:useuniqueptr in SdrUndoGeoObjNoel Grandin
Change-Id: I8b48642a3a6ab4d94c1b58f8dae3589e703612b1 Reviewed-on: https://gerrit.libreoffice.org/49329 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-06Avoid signed integer overflow during BrowseBox::AutoSizeLastColumnStephan Bergmann
Observed with UBSan with `soffice --base`, "Finish", "Save", "Tables", "Create Table in Design View...": > include/tools/gen.hxx:485:37: runtime error: signed integer overflow: 288 + 9223372036854775803 cannot be represented in type 'long' > #0 0x7fe2d7f827dd in tools::Rectangle::Rectangle(Point const&, Size const&) include/tools/gen.hxx:485:37 > #1 0x7fe2d7f73833 in BrowseBox::ImplFieldRectPixel(long, unsigned short) const svtools/source/brwbox/brwbox1.cxx:2039:12 > #2 0x7fe2d7f57d46 in BrowseBox::GetFieldRectPixel(long, unsigned short, bool) const svtools/source/brwbox/brwbox1.cxx:1977:29 > #3 0x7fe2d7f42bdb in BrowseBox::GetFieldRect(unsigned short) const svtools/source/brwbox/brwbox1.cxx:2068:12 > #4 0x7fe2d7f4502b in BrowseBox::SetColumnWidth(unsigned short, unsigned long) svtools/source/brwbox/brwbox1.cxx:542:19 > #5 0x7fe2d7f48d18 in BrowseBox::AutoSizeLastColumn() svtools/source/brwbox/brwbox1.cxx:633:9 > #6 0x7fe2d7fd299c in BrowseBox::Resize() svtools/source/brwbox/brwbox2.cxx:537:5 > #7 0x7fe2d807ee7a in svt::EditBrowseBox::Resize() svtools/source/brwbox/editbrowsebox.cxx:1095:20 > #8 0x7fe2cdbe5711 in vcl::Window::ImplCallResize() vcl/source/window/event.cxx:522:5 > #9 0x7fe2ce1c8f71 in vcl::Window::Show(bool, ShowFlags) vcl/source/window/window.cxx:2261:13 > #10 0x7fe25d27b58f in dbaui::OTableDesignView::initialize() dbaccess/source/ui/tabledesign/TableDesignView.cxx:199:22 > #11 0x7fe25d23403b in dbaui::OTableController::impl_initialize() dbaccess/source/ui/tabledesign/TableController.cxx:519:20 > #12 0x7fe25c3dd649 in dbaui::OGenericUnoController::initialize(com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) dbaccess/source/ui/browser/genericcontroller.cxx:270:9 > #13 0x7fe25c3361cd in DBContentLoader::load(com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XLoadEventListener> const&) dbaccess/source/ui/browser/dbloader.cxx:270:19 > #14 0x7fe28521412a in framework::LoadEnv::impl_loadContent() framework/source/loadenv/loadenv.cxx:1101:23 > #15 0x7fe285209e0a in framework::LoadEnv::startLoading() framework/source/loadenv/loadenv.cxx:375:20 > #16 0x7fe28520738b in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/loadenv/loadenv.cxx:161:14 > #17 0x7fe285332ba8 in (anonymous namespace)::Frame::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/services/frame.cxx:589:12 > #18 0x7fe285349f7d in non-virtual thunk to (anonymous namespace)::Frame::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/services/frame.cxx > #19 0x7fe25cba4dae in dbaui::DatabaseObjectView::doDispatch(comphelper::NamedValueCollection const&) dbaccess/source/ui/misc/databaseobjectview.cxx:140:41 > #20 0x7fe25cba3514 in dbaui::DatabaseObjectView::doCreateView(com::sun::star::uno::Any const&, rtl::OUString const&, comphelper::NamedValueCollection const&) dbaccess/source/ui/misc/databaseobjectview.cxx:97:16 > #21 0x7fe25cba667c in dbaui::TableDesigner::doCreateView(com::sun::star::uno::Any const&, rtl::OUString const&, comphelper::NamedValueCollection const&) dbaccess/source/ui/misc/databaseobjectview.cxx:233:40 > #22 0x7fe25cba2fec in dbaui::DatabaseObjectView::createNew(com::sun::star::uno::Reference<com::sun::star::sdbc::XDataSource> const&, comphelper::NamedValueCollection const&) dbaccess/source/ui/misc/databaseobjectview.cxx:79:16 > #23 0x7fe25c07bdfe in dbaui::OApplicationController::newElement(dbaui::ElementType, comphelper::NamedValueCollection const&, com::sun::star::uno::Reference<com::sun::star::lang::XComponent>&) dbaccess/source/ui/app/AppController.cxx:1968:40 > #24 0x7fe25c076546 in dbaui::OApplicationController::Execute(unsigned short, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) dbaccess/source/ui/app/AppController.cxx:1223:25 > #25 0x7fe25c3ef474 in dbaui::OGenericUnoController::executeChecked(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) dbaccess/source/ui/browser/genericcontroller.cxx:1061:13 > #26 0x7fe25c1dd91a in dbaui::OCreationList::onSelected(SvTreeListEntry const*) const dbaccess/source/ui/app/AppDetailView.cxx:309:81 > #27 0x7fe25c1e0de9 in dbaui::OCreationList::MouseButtonUp(MouseEvent const&) dbaccess/source/ui/app/AppDetailView.cxx:275:9 > #28 0x7fe2ce263026 in ImplHandleMouseEvent(VclPtr<vcl::Window> const&, MouseNotifyEvent, bool, long, long, unsigned long, unsigned short, MouseEventModifiers) vcl/source/window/winproc.cxx:711:25 > #29 0x7fe2ce298c14 in ImplHandleSalMouseButtonUp(vcl::Window*, SalMouseEvent const*) vcl/source/window/winproc.cxx:1994:12 > #30 0x7fe2ce27c59c in ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) vcl/source/window/winproc.cxx:2329:20 > #31 0x7fe29bebd05a in SalFrame::CallCallback(SalEvent, void const*) const vcl/inc/salframe.hxx:275:29 > #32 0x7fe29be5cfad in GtkSalFrame::CallCallbackExc(SalEvent, void const*) const vcl/unx/gtk3/gtk3gtkframe.cxx:4318:16 > #33 0x7fe29be755ac in GtkSalFrame::signalButton(_GtkWidget*, _GdkEventButton*, void*) vcl/unx/gtk3/gtk3gtkframe.cxx:2620:16 > #34 0x7fe29b2a4a7a (/lib64/libgtk-3.so.0+0x233a7a) > #35 0x7fe2f60c373c in g_closure_invoke (/lib64/libgobject-2.0.so.0+0xf73c) > #36 0x7fe2f60d64dd (/lib64/libgobject-2.0.so.0+0x224dd) > #37 0x7fe2f60de69e in g_signal_emit_valist (/lib64/libgobject-2.0.so.0+0x2a69e) > #38 0x7fe2f60df66e in g_signal_emit (/lib64/libgobject-2.0.so.0+0x2b66e) > #39 0x7fe29b3efcd3 (/lib64/libgtk-3.so.0+0x37ecd3) > #40 0x7fe29b2a1a4d (/lib64/libgtk-3.so.0+0x230a4d) > #41 0x7fe29b2a3b6f in gtk_main_do_event (/lib64/libgtk-3.so.0+0x232b6f) > #42 0x7fe29adb1304 (/lib64/libgdk-3.so.0+0x37304) > #43 0x7fe29ae0ddf1 (/lib64/libgdk-3.so.0+0x93df1) > #44 0x7fe2f5deab76 in g_main_context_dispatch (/lib64/libglib-2.0.so.0+0x4ab76) > #45 0x7fe2f5deaf1f (/lib64/libglib-2.0.so.0+0x4af1f) > #46 0x7fe2f5deafab in g_main_context_iteration (/lib64/libglib-2.0.so.0+0x4afab) > #47 0x7fe29bcbdbca in GtkSalData::Yield(bool, bool) vcl/unx/gtk3/gtk3gtkdata.cxx:459:31 > #48 0x7fe29bccd0d2 in GtkInstance::DoYield(bool, bool) vcl/unx/gtk3/../gtk/gtkinst.cxx:410:29 > #49 0x7fe2cf6a65e3 in ImplYield(bool, bool) vcl/source/app/svapp.cxx:469:48 > #50 0x7fe2cf68ef1b in Application::Yield() vcl/source/app/svapp.cxx:534:5 > #51 0x7fe2cf68eda3 in Application::Execute() vcl/source/app/svapp.cxx:449:9 > #52 0x7fe2f7e1eef8 in desktop::Desktop::Main() desktop/source/app/app.cxx:1622:17 > #53 0x7fe2cf6d8687 in ImplSVMain() vcl/source/app/svmain.cxx:194:35 > #54 0x7fe2cf6e1f7f in SVMain() vcl/source/app/svmain.cxx:232:16 > #55 0x7fe2f7f466b4 in soffice_main desktop/source/app/sofficemain.cxx:166:12 > #56 0x42a83c in sal_main desktop/source/app/main.c:48:15 > #57 0x42a816 in main desktop/source/app/main.c:47:1 > #58 0x7fe2f67a6009 in __libc_start_main (/lib64/libc.so.6+0x21009) > #59 0x402e69 in _start (instdir/program/soffice.bin+0x402e69) Change-Id: I6a92a87b481396955cfc1f21bf88e2f0ad9cea9f Reviewed-on: https://gerrit.libreoffice.org/49279 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-06simplify ImpXPolygonNoel Grandin
just use a std::vector<std::pair<Point,PolyFlags>> Change-Id: I85de832af9095a33bda1620781c3b231a345e07c Reviewed-on: https://gerrit.libreoffice.org/49275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-06loplugin:useuniqueptr in SdrTextObjNoel Grandin
Change-Id: I48f52056dcf17a568266be49f7422fa05be974db Reviewed-on: https://gerrit.libreoffice.org/49274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-06loplugin:useuniqueptr in OLEObjCacheNoel Grandin
Change-Id: Ie16963e2b3b9d85d5640f03daa487dbe231af4a1 Reviewed-on: https://gerrit.libreoffice.org/49272 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-06loplugin:useuniqueptr in SdrEdgeObjNoel Grandin
Change-Id: I457520760d182fdd4f89cb7c7a4ea2c0e514e0c4 Reviewed-on: https://gerrit.libreoffice.org/49273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-06tdf#104861: extension list is not a child dlg control anymoreKatarina Behrens
After 989cf68b68ed, 88f31af74816 and 3aec456ba8a0 buttons aren't embedded in the extension list anymore, so treating it like a child dlg control just causes Tab key to skip the widget Change-Id: I4372062c135804d8b51a8640c1e9959f03a617fe Reviewed-on: https://gerrit.libreoffice.org/49254 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-06loplugin:useuniqueptr in TextRangerNoel Grandin
Change-Id: I176da69a399eab0169c5fdddd454912672a92fba Reviewed-on: https://gerrit.libreoffice.org/49267 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-06loplugin:useuniqueptr in SdrCreateViewNoel Grandin
Change-Id: Id9e52550264d2c1e0a838ff792f2257fddb64701 Reviewed-on: https://gerrit.libreoffice.org/49269 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-06clean up some include guard terminatorsNoel Grandin
found with git grep -n -A10 '#endif // INCLUDED' | grep -v endif | grep -v vim | grep -v -- '--' Change-Id: I7ae67cd7c1313e76f059fb8e6afb723caca8a6d7 Reviewed-on: https://gerrit.libreoffice.org/49244 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05use unique_ptr to store GraphicObject for SdrGrafObjTomaž Vajngerl
Change-Id: I578156cd96e1e1400e93e96ace8a38759e3d1b2c Reviewed-on: https://gerrit.libreoffice.org/49221 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-05fix ubsan after "TypedWhichId in svx part 1"Noel Grandin
<sberg> noelgrandin, SID_ATTR_PAGE_EXT1 is used both as an SfxBoolItem (e.g., sd/source/ui/func/fupage.cxx) and as an SfxStringItem (e.g., sw/source/uibase/utlui/uitool.cxx) commit 24158311c115c2db6dd05a751f75a5c084e2c0d1 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed Dec 20 13:30:21 2017 +0200 TypedWhichId in svx part 1 Change-Id: If4e75470449d8f967f5f6818067edd7c24bc19a1 Reviewed-on: https://gerrit.libreoffice.org/49230 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-05loplugin:useuniqueptr in E3DModifySceneSnapRectUpdaterNoel Grandin
Change-Id: Ied2cdfa314f86ff3a25cecd5c13c03d3428966f0 Reviewed-on: https://gerrit.libreoffice.org/49207 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05loplugin:useuniqueptr in OTableNoel Grandin
use rtl::Reference here since these are reference counted data structures, and we hand out references to me via our API Change-Id: I8f69dde2db08519cb3d9de20b4ad54462e3ecc98 Reviewed-on: https://gerrit.libreoffice.org/49180 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05tdf#108523 Removed @author annotations.Manuj Vashist
Change-Id: I6a60128c413beab6cabb857c073607e15ddbc98f Reviewed-on: https://gerrit.libreoffice.org/49215 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-05tdf#115434 Fix key press misbehaviors in sidebarJim Raykowski
This patch also is for tdf#98505 and tdf#84657 Change-Id: I6bc125ace035b2c8126f013a63bcc9498b06e08c Reviewed-on: https://gerrit.libreoffice.org/49219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-05vcl: remove BitmapColor Color() operatorChris Sherlock
BitmapColor has a Color() operator. However, this is confusing and tends to hide that the two classes aren't the same. I have converted this to GetColor(). Change-Id: I0be2dcb3fc420e7be9c8d04330e7a3fe69a5412a Reviewed-on: https://gerrit.libreoffice.org/48245 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-05sal: remove unnecessary comments in types.hChris Sherlock
Change-Id: I17a42951d2fbb02d1d2bc5d7c01574051a3ac30c Reviewed-on: https://gerrit.libreoffice.org/47735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-05loplugin:useuniqueptr in ViewObjectContactNoel Grandin
Change-Id: I69721e71f5351276d43d04107058eeb14d4925aa Reviewed-on: https://gerrit.libreoffice.org/49213 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05loplugin:useuniqueptr in MasterPageDescriptorNoel Grandin
Change-Id: I54d46aeec5f74ccf088ea33d03fd1d8a2009d43f Reviewed-on: https://gerrit.libreoffice.org/49211 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05loplugin:useuniqueptr in ObjectContactNoel Grandin
Change-Id: I89104fe93bbb2db4ca7c092784583eac6fbdda08 Reviewed-on: https://gerrit.libreoffice.org/49209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05loplugin:useuniqueptr in GalleryNoel Grandin
Change-Id: Ia12805bff0403fe260786360233be677ef91f710 Reviewed-on: https://gerrit.libreoffice.org/49208 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05loplugin:useuniqueptr in SvxAutoCorrectLanguageListsNoel Grandin
and cleanup horrendous weirdity in the interaction between LoadXXX and SetXXX methods Change-Id: I1253579a27e835f6f79c39acf72eac85278275d6 Reviewed-on: https://gerrit.libreoffice.org/49184 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05loplugin:useuniqueptr in OSQLParseNodeNoel Grandin
Change-Id: Ibad6e4b32b19a925de621b9dea7070d3930f05ef Reviewed-on: https://gerrit.libreoffice.org/49182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05loplugin:useuniqueptr in OFlowChainedTextNoel Grandin
Change-Id: I63f6242a41eddd36b9ebbef470faf9e5111b19f1 Reviewed-on: https://gerrit.libreoffice.org/49149 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05loplugin:useuniqueptr in SvxRTFParserNoel Grandin
Change-Id: I0d01e8612ff4e8eb1eb53a817c8fb586b61aa5bb Reviewed-on: https://gerrit.libreoffice.org/49150 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05loplugin:useuniqueptr in SvxUnoTextRangeBaseNoel Grandin
Change-Id: I2f416e415ec388d1fac334b997f25427f6c1750f Reviewed-on: https://gerrit.libreoffice.org/49175 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05loplugin:useuniqueptr in OutlinerNoel Grandin
Change-Id: I68568dd61ef6ba99fcb0ac386170bfe67ab2bbd7 Reviewed-on: https://gerrit.libreoffice.org/49174 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05loplugin:useuniqueptr in SvxRTFItemStackTypeNoel Grandin
Change-Id: I1677915d91fb151997d4bef18473f33ab2f09648 Reviewed-on: https://gerrit.libreoffice.org/49173 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05loplugin:useuniqueptr in SvxNumRuleNoel Grandin
Change-Id: I778f62edbddfa2ca10eefa396272e7b011025513 Reviewed-on: https://gerrit.libreoffice.org/49172 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05loplugin:useuniqueptr in SvxNumberFormatNoel Grandin
Change-Id: I0433349e6f4108297e0f4cab65c1e859424bd282 Reviewed-on: https://gerrit.libreoffice.org/49148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-03more TypedWhichId in SfxShell and SfxTabDialogNoel Grandin
and remove some unnecessary local copies of pool items Change-Id: Ifdac8d84658fd4b803267038592d7da370e23a0d Reviewed-on: https://gerrit.libreoffice.org/49138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-17 20:38:50 +0000