summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2016-01-16vcl: created accessors and mutators for font classesChris Sherlock
Font accessors: - GetFamily() - GetPitch() - GetWidthType() - GetWeight() - GetItalic() - GetName() <--- shouldn't that be GetFamilyName()?!? - GetStyleName() Font mutators did not need to be added. Font unit tests are testing: - Setting and getting FontFamily private member - Setting and getting FontPitch private member - Setting and getting FontWidth private member - Setting and getting FontWeight private member - Setting and getting FontItalic private member - Setting and getting the family name and style ImplFont accessors: - GetFamilyNoAsk() - GetPitchNoAsk() - GetWidthTypeNoAsk() - GetWeightNoAsk() - GetItalicNoAsk() - GetFamilyName() - GetStyleName() (These "NoAsk" functions are necessary because the default getters call on a function that checks the configuration for default values, something that is not wanted in all cases). Change-Id: Icfbc8b4e5253d55a80892df050b0803dfc7d7c9f Reviewed-on: https://gerrit.libreoffice.org/21501 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-15oox: export Math objects to PPTX filesMichael Stahl
These hit the assert in lcl_StoreOwnAsOOXML now so better implement some export. Change-Id: I10c005a547e8a85f2a82198a49f9a03fc46a61d7
2016-01-15loplugin:unusedmethods unused return value in include/toolsNoel Grandin
Change-Id: I77a6a46ca20cb41ed73050185fb2064a1bbf2009 Reviewed-on: https://gerrit.libreoffice.org/21485 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-15basic: coverity#1348466 checked returnMichael Stahl
Kind of unnecessary but let's hope it shuts up coverity. Change-Id: I4903c9df788ce5fb9648c5fd68627ff21362828f
2016-01-15starmath: only use WordProcessingML elements in DOCX filesMichael Stahl
Change-Id: I1b0f6d67bd0db0796756fd920ab92303a7ee7d79
2016-01-15oox: move enum DocumentType out of drawingml.hxxMichael Stahl
... which has nasty dependencies. Change-Id: I84ba0302142ade6e15291b782453dbe3bac753dd
2016-01-15loplugin:unusedmethods unused return value in include/unotoolsNoel Grandin
Change-Id: I3b2281dc713bff92eb3d80fddef04a8a39838aa8 Reviewed-on: https://gerrit.libreoffice.org/21484 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-15vcl: add symbol and charset accessors and mutators to FontChris Sherlock
Rules for the vcl::Font class for setting character set and the symbol flag: If the characterset changes to anything other than RTL_TEXTENCODING_SYMBOL then the symbol flag should be off. If the characterset changes to RTL_TEXTENCODING_SYMBOL then the symbol flag should be on. If the symbol flag is set to false and the characterset is already RTL_TEXTENCODING_SYMBOL then set the characterset to RTL_TEXTENCODING_DONTKNOW and set the symbol flag to false. However, if we are setting the symbol flag from false to false (i.e. we know the characterset) then we can keep the characterset as it is. Unit test written in this commit to test this is working. Change-Id: Iced44659ab88ff66b711c560cb68bd4681ecb537
2016-01-15loplugin:unusedmethods unused return value in include/xmloffNoel Grandin
Change-Id: I6615a467152a50e9c65f04fd0d6c8cc128517bdb
2016-01-15svx: remove now unused SdrModel::isTiledRendering()Miklos Vajna
Change-Id: I8d3c6b1de2db57e39678a7e57de6e015c72719ec
2016-01-15vcl: allow doxygen to see boost::intrusive_ptrChris Sherlock
We are using boost::intrusive_ptr for a number of classes, unfortunately by default we cannot see this in the Doxygen collaboration diagrams. However, we can work around this problem by making a dummy namespace which we include in a header that is scanned by Doxygen, but never included in LibreOffice. To be sure of this, however, I have put #ifdef DOXYGEN_ONLY guards around the file and defined this in the Doxygen config file. Change-Id: I18d6956518a49e6006b64e2147023ec8266c8f5c
2016-01-14-Werror=misleading-indentation (GCC 6)Stephan Bergmann
Change-Id: Ic28a87df35ef3087071f87c4bc74c4c274169b51
2016-01-14-Werror=misleading-indentation (GCC 6)Stephan Bergmann
Change-Id: I83beda380dc35544b9bc6fd5b1c7359546f8c8c5
2016-01-14-Werror=misleading-indentation (GCC 6)Stephan Bergmann
Change-Id: I07f653626dd4519d86dba735be9fec3e4c7e91e6
2016-01-14svx: loplugin:overrideMiklos Vajna
Change-Id: I532525fa12af2a0afbc1277b9a918c4d563f3b4f
2016-01-14editeng: handle SdrModel::isTiledSearching()Miklos Vajna
Given that the edit/outliner views can come and go, avoid the lifecycle problems with just passing a pointer to the sdr model to editeng, and then it'll always have the up to date "are we searching" information. editeng can't depend on svx, so provide an interface class SdrModel can implement. Change-Id: I3b98011593b00ac0fab05b6b9c591dd20d94c579
2016-01-14sd tiled rendering: it's pointless to send selection changes during search allMiklos Vajna
But they do cause annoying flashing. Change-Id: Ic313a15429c5db98c5660a5274aa49e95dd217e5
2016-01-14fix the MSVC 2013 --enable-lto buildMichael Stahl
... by sacrificing the appropriate number of chickens to the template dllexport gods. Change-Id: I27fb6a1f0a8a32c9bdc67574b3a2f3ec9f27b00f Reviewed-on: https://gerrit.libreoffice.org/21442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-14vcl: FontMetric now has ImplFontMetricPtr objectsChris Sherlock
ImplFontMetricPtr is a typedef to an intrusive_ptr<ImplFontMetric>. I have ditched the manual reference counting to use Boost's smart pointer. Change-Id: I5e93f45d19d43c8b7253f4342c1b9ef4a4301527
2016-01-13resolve TODO, remove SVVERB_SHOWMichael Stahl
Change-Id: I10148330f1a356dbd423af98267c25d7128c3a86
2016-01-14vcl: ImpFontMetric and FontMetric no longer friends with OutputDeviceChris Sherlock
Exposng your private members as public is bad, but its also unacceptable to allow friends to access your private members. It's not the done thing in civilized C++ society. Change-Id: Id8f811f0e775afde26c6119b274f37908731507c
2016-01-14vcl: Create mutator for bullet offset attribute in FontMetricChris Sherlock
Mutator created for bullet offset attribute in FontMetric. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit tests - check to ensure that can get and set bullet offset attribute - check equality operator on FontMetric after setting bullet offset attribute Change-Id: I87a76982a8b3ed697664299cb340fa35fb514c0e
2016-01-14vcl: Create mutator for slant attribute in FontMetricChris Sherlock
Mutator created for slant attribute in FontMetric. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit tests - check to ensure that can get and set slant attribute - check equality operator on FontMetric after setting slant attribute Change-Id: I5490a40dba4c86386d59a42f2d04303b3fc4d536
2016-01-14vcl: Create mutator for line height attribute in FontMetricChris Sherlock
Mutator created for line height in attribute FontMetric. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit tests - check to ensure that can get and set line height attribute - check equality operator on FontMetric after setting line height attribute Change-Id: I86dff217fa24850b5f9d04a17ddda464dfb0156a
2016-01-13vcl: Create accessor and mutator for ascent and descent in FontMetricChris Sherlock
Accessor and mutator created for ascent and descent spacing in FontMetric. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit tests - check to ensure that can set font ascent and descent spacing - check equality operator on FontMetric after setting both ascent and descent font spacing Change-Id: I714363b14bdc61ddfa37a619fe4b03f4e4e96f7a Reviewed-on: https://gerrit.libreoffice.org/21458 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-13cppuhelper: remove invalid doxygen markupChris Sherlock
Change-Id: I97e8757c1f5006bb1320b4a65da34745cc563e58 Reviewed-on: https://gerrit.libreoffice.org/21456 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-13vcl: Create accessor and mutator for int and ext leading in FontMetricChris Sherlock
Accessor and mutator created for external and internal leading space in FontMetric. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit tests - check to ensure that can set external and leading space - check equality operator on FontMetric after setting both external and internal leading space - enhanced tests to also check the inequality operator Change-Id: I973970dd0b0631c5eca3e89039dce57ac3a3eb63 Reviewed-on: https://gerrit.libreoffice.org/21454 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-13vcl: Create accessor and mutator for builtin font flag in FontMetricChris Sherlock
Accessor and mutator created for builtin font flag, removed the existing bit field. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit tests - check to ensure that can set builtin font flag - check equality operator on FontMetric after setting builtin font flag Change-Id: Iac3f4270f86d10f9dcd0bb6e3951c0e983a4f22f Reviewed-on: https://gerrit.libreoffice.org/21414 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-13remove unused o3tl/ptr_container.hxxMichael Stahl
Change-Id: I8132958b979add35bdd7aea52ce8788f3cdcbe51
2016-01-13-Werror=misleading-indentation (GCC 6)Stephan Bergmann
Change-Id: I83e38c017600946e4055a5b8ada87a0f64e83222
2016-01-13This stuff is private to vclTor Lillqvist
Change-Id: I623da89ea390a07bd6a3236b5c099be094a7acde
2016-01-13loplugin:unusedmethods unused return value in include/svxNoel Grandin
Change-Id: I9a5e937905fd71ecbbf9cb215ff6cc2b7defc6f3
2016-01-13loplugin:unusedmethods unused return value in include/svtoolsNoel Grandin
Change-Id: Ibc83f032bb703559cc643933e53e8670bd6560b3
2016-01-13Fix memory leakStephan Bergmann
Change-Id: I9e271c3b7ff49d33f4f6f3f8c50b70ac5ce1541e
2016-01-13loplugin:unusedmethods unused return value in include/svlNoel Grandin
Change-Id: I759fe8769daccea07c2157bfb5912df8ba285534
2016-01-13loplugin:unusedmethods unused return value in include/sotNoel Grandin
Change-Id: I8da6d5f60b6c65ff0da8659045da1cd7666fb1d9
2016-01-13loplugin:unusedmethods unused return value in include/sfx2Noel Grandin
Change-Id: Id4017bdfe18f8224d28a9f787865c7a880aeeed8
2016-01-13vcl: Create accessor and mutator for full stop centered in FontMetricChris Sherlock
Accessor and mutator created for full stop centered flag, removed bit field. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit tests - check to ensure that can set full stop centered flag - check equality operator on FontMetric after setting full stop centered flag Change-Id: I9cacb0fbf9ea65cfebcaebdc9f0481c0a796cbcf Reviewed-on: https://gerrit.libreoffice.org/21413 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-13vcl: Create accessor and mutator for font scaling in FontMetricChris Sherlock
This is fragile code! There are actually *two* classes that do almost precisely the same thing, they are: - ImplFontMetric, and - ImplFontMetricData They both have much in common, including their class name, and even most of their functionality. In fact, they both have common accessor functions. When I look at the code, it looks like OutputDevice is actually given an ImplFontMetricData object, which it then uses to populate an ImplFontMetric object... Basically, I'm going to merge these classes. To do so, I'm going to do the following: Step 1: Implement accessor functions for ImplFontMetric and FontMetric (then remove the friendship of this class to OutputDevice!) Step 2: Write a unit test for each accessor function in ImplFontMetric Step 3: Ensure that ImplFontMetric and ImplFontMetricData use some sort of smart pointer (probably an intrusive_ptr like I did ages ago with FontCharMap) Step 4: Merge the two classes together once their class interfaces are the same and I am satisfied they do the same thing Step 5: Find all instances of inefficient usage - for instance, I can do away with the code that copies the ImplFontMetricData attributes into an ImplFontMetric object. Change-Id: I07c1cb848774b130fa2ca60b51da53e07754dd00 Reviewed-on: https://gerrit.libreoffice.org/21399 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-12xmloff: SvXMLExport::mbExtended is dead nowMichael Stahl
Change-Id: Ie679259deccce87949d7bf8767af707827b4134c
2016-01-12tdf#97075 - don't render sdr overlays before we paint.Michael Meeks
Change-Id: I0b22af14c7dd684c25cfee26e8c12b95b40479ee Reviewed-on: https://gerrit.libreoffice.org/21400 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-01-12Revert "Re-work focus handling to use an idle handler"Miklos Vajna
This reverts commit 0ba752201dca6129cc6b4a19ec93eb369eb70890. It breaks CppunitTest_desktop_lib on Linux.
2016-01-12Re-work focus handling to use an idle handlerTor Lillqvist
Gets rid of some flashing when using OpenGL. Change-Id: I1273b960725bf868e7340eac3f2bad2f20e73d91 Reviewed-on: https://gerrit.libreoffice.org/21390 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-01-12Mark some classes as finalStephan Bergmann
...namely exactly those for which fa91dd31f39a24329d288d4e1cda28db3a16af0d "5th step to remove tools/rtti.hxx" (which is assumed the culprit in tdf#96067 "Crash on undo row inserts") had replaced exact-type checks of the form v->Type() == TYPE(X) with type-or-subtype-of checks of the form dynamic_cast<X *>(v) != nullptr which is only sound if X is a final class. (Except for one case already handled differently in 791ad3e170bcb5a2daedac77932dc9822f7f1092 "Stick to exact-type check.") Change-Id: Ia822c55c7c0e982d42c6a97589307e577721e324
2016-01-12comphelper: initial SfxFilterFlags::SUPPORTSSIGNINGMiklos Vajna
Currently digital signatures can be made only on OWN formats. Add a new flag that can be used to mark filters (only DOCX as a start) which could also support signing and fix the first place that assumes that only OWN formats support signing. Change-Id: If9fbf956b765d75838986762e4d4063a9e8c0b5e
2016-01-12typosMichael Stahl
Change-Id: I970429c266cc1a8cf36cfba379b447899b5dbce9
2016-01-12loplugin:unusedmethods unused return value in include/ooxNoel Grandin
Change-Id: I22acb6b94774c5944d8276827c53a419f0803f83
2016-01-12loplugin:unusedmethods unused return value in include/helpcompilerNoel Grandin
Change-Id: Ieebbd896bf1ad66cd1950456ca1600f0dd8cda83
2016-01-12GetImageFromURL/SetImageProducer unusedNoel Grandin
looks like these have been abandoned recently in the toolbar manager update Change-Id: I5556833dfef0db5958a5779bdb32482c18a46a5f
2016-01-12Bin unnecessary forward declarationTor Lillqvist
Change-Id: Iae574695c299b458cc1fa1c7f7709828ffc21527
generated by cgit (git 2.34.1) at 2024-12-28 19:57:47 +0000