summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)Author
2016-06-03loplugin:constantparamsNoel Grandin
Change-Id: Ib162ba9297b9d900ea42c7e5216e152d3e58a361 Reviewed-on: https://gerrit.libreoffice.org/25769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Strip also a CR if there (and there seems to be such)Tor Lillqvist
Sad that it took so long for me to notice. Change-Id: I14b8a61930bb0b2dd1c5e9cce2a6c3e375dcb6ed
2016-06-03loplugin:refcounting (RequestFilterSelect_Impl derives from XInterface)Stephan Bergmann
Change-Id: Iabf9b94626b599b4fe799523b3523e18df5203c5
2016-06-03tdf#89329: use unique_ptr for pImpl in accimplaccessXisco Fauli
Change-Id: Ib10088b5669695dd5e288fe043ad72056a34b1e4 Reviewed-on: https://gerrit.libreoffice.org/25745 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Move page size listbox from cui to svxKatarina Behrens
make it a custom widget so it is accessible e.g. to sidebar panels Change-Id: Ic36a9a8af96a09fc76efd8e9ae75b8ebdf81717e Reviewed-on: https://gerrit.libreoffice.org/25764 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-03tdf#89329: use unique_ptr for pImpl in imageitmXisco Fauli
Change-Id: I935da01bd03a9812facf30e1d45da1c4949188ed Reviewed-on: https://gerrit.libreoffice.org/25633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Drop unused enum LATHE_PARTNoel Grandin
Change-Id: If06ee75ff6832199079b1f175f09e59a94fecf58 Reviewed-on: https://gerrit.libreoffice.org/25790 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Convert NupOrderType to scoped enumNoel Grandin
Change-Id: If04deb1bc080679d1b71d155f7568ab89cb5888d Reviewed-on: https://gerrit.libreoffice.org/25765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Convert whichOfficePath to scoped enumNoel Grandin
Change-Id: If31c00ac8820e6dfce5047e997c35f5e1878db6f Reviewed-on: https://gerrit.libreoffice.org/25763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Convert FontRights to scoped enumNoel Grandin
Change-Id: Ib46fe9dbe4b41bfe2e85e9171e8dcf7a96ccb483 Reviewed-on: https://gerrit.libreoffice.org/25717 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03tdf#89329: use unique_ptr for pImpl in embeddedobjectcontainerXisco Fauli
Change-Id: I679555e2eb51e2b9660bb035a08d8da8b1687cab Reviewed-on: https://gerrit.libreoffice.org/25747 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03tdf#89329: use unique_ptr for pImpl in interactionXisco Fauli
Change-Id: I21ad7278f7978e7eebf6962fdf1fac2d3cb2bddb Reviewed-on: https://gerrit.libreoffice.org/25637 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-02add NF_DATETIME_ISO_YYYYMMDD_HHMMSS YYYY-MM-DD HH:MM:SS builtin format codeEike Rathke
Change-Id: I4fe6ef01a4c7fb795e4499e54aa55ebaaa0d433d
2016-06-02New o3tl::try/doGet to obtain value from AnyStephan Bergmann
...in an attempt to reduce usage of type-unsafe void const * css::uno::Any::getValue() These new functions are often more convenient to use than the existing ">>=" and Any::get<T>. Note how they are careful to provide a pointer directly into the given Any, instead of creating temporaries. As an example, replaced most calls of getValue across xmloff: * Cases that first check for a specific type (via getValueType etc.) and then call getValue can instead call tryGet. (But beware that tryGet supports some conversions, which a check for a specific type may have missed---either intentionally or by accident. Also beware the somewhat common idiom of checking for TypeClass_ENUM and then using getValue to obtain a sal_Int32; this cannot be replaced with a call to tryGet.) * Cases that seem confident that the Any is of the correct type when calling getValue (but apparently are confident due to some higher-layer protocol, as the surrounding code does not do any checking via getValueType or similar) can instead call doGet. It throws an exception if it turns out the confidence wasn't warranted. (Many of the existing calls that directly dereferenced the return value of getValue as sal_Bool look suspicious, in that the author might have thought the given code would also cover a VOID Any---which technically it even would have happened to do. If any RuntimeExceptions thrown from these doGet calls start to crop up, these changes need to be revisited. Some may even be rewritten as uses of ">>=". But at least "make check" did not show any such problems. Also note that casting the value obtained from getValue to any css::uno::Reference<X> with X being anything but the base css::uno::XInterface was always prone to producing a bad pointer, in case the interface actually stored in the Any derived from X via multiple inheritance.) * Should there ever be cases where an Any is known to be of the requested type, some additional forceGet could be introduced (which would assert instead of throwing an exception). Change-Id: I2d8739e86314eff73abfcafe01d806f5bc5c34db
2016-06-02drop some more RTL_CONSTASCII_USTRINGPARAMNoel Grandin
Change-Id: I528b0ecb5282178d8e727471beb126cb7d3f2eb4
2016-06-02remove wrong commentJochen Nitschke
comment is there since initial commit cd3b0741a8f509f20c5b6deaa32f2158b315939d but HIDESELECT is handled in svtools/source/brwbox/brwbox1.cxx and used in chart2 and dbaccess Change-Id: Idf0524f14a0f719b2287d234c912fef4fe24b7a3 Reviewed-on: https://gerrit.libreoffice.org/25762 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-02tdf#89329: use unique_ptr for pImpl in propertysetinfoXisco Fauli
Change-Id: I8df0ed4d7c7df27f570ad09936f17941c30aae91 Reviewed-on: https://gerrit.libreoffice.org/25749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-02tdf#89329: use unique_ptr for pImpl in propertysethelperXisco Fauli
Change-Id: I5891fe7c298b4b3409ac6579ed167a4e0183c89a Reviewed-on: https://gerrit.libreoffice.org/25748 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-02tdf#89329: use unique_ptr for pImpl in componentmoduleXisco Fauli
Change-Id: Ida8e271b1dd755289371e457a7c83657b8a84f99 Reviewed-on: https://gerrit.libreoffice.org/25746 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-02loplugin:unuseddefaultparamsNoel Grandin
Change-Id: I0fe173534dc2e70c3d507eae757a91e48a26acfc Reviewed-on: https://gerrit.libreoffice.org/25757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-02loplugin:unusedfieldsNoel Grandin
Change-Id: Ieed5f4d9411478d2568b8e5f4bbe0782bd1d309d Reviewed-on: https://gerrit.libreoffice.org/25724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01loplugin:passstuffbyrefStephan Bergmann
Change-Id: Ic2c7381c4ad033a86ed3485081d16590cfea6ad0
2016-06-01Make class HexColorControl globalRishabh Kumar
Change-Id: I755e5aab5425d5d136d5fe7c75706a93cf4559ae Reviewed-on: https://gerrit.libreoffice.org/25665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-01Can use boost::make_optionalStephan Bergmann
...reportedly available since Boost 1.34, and configure.ac checks for at least Boost 1.47. Change-Id: I07952de220f1eee5f91ad83a1965420eb6b09ada
2016-06-01Impress: Replace Presentation Wizard with Template ManagerAkshay Deep
Drop the Presentation wizard and show the Template Manager instead when starting Impress. 1. Opens a blank template with Template Manager. 2. If user selects a template, load it over the blank template. 3. SfxTemplateSelectionDlg for impress integration. Change-Id: Ia9c3cafc973e3741c6ea9f838018a35956f37f4a Reviewed-on: https://gerrit.libreoffice.org/25642 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-01tdf#89329: use unique_ptr for pImpl in accessiblecontexthelperXisco Fauli
Change-Id: Ib78ee2f1faa4f9430e08bfbd0cfb0863da7d6dcb Reviewed-on: https://gerrit.libreoffice.org/25744 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-01pass by referenceJochen Nitschke
Fraction does SAL_WARN when we create an invalid Fraction and SAL_WARN again when converted to double (returns 0.0) remove the warnings here and use 1.0 for invalid Fraction Change-Id: I26de55ed7e3c9b4dac69c422fcaf7900804a0807 Reviewed-on: https://gerrit.libreoffice.org/25467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-06-01tdf#89329: use unique_ptr for pImpl in msgpoolXisco Fauli
Change-Id: I97f7deab763b4da8e267e871cb78d0547711e777 Reviewed-on: https://gerrit.libreoffice.org/25751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01tdf#89329: use unique_ptr for pImpl in objfaceXisco Fauli
Change-Id: Ie4d84a7e9958c5291b3a9db7f9e7e019ff27cfbd Reviewed-on: https://gerrit.libreoffice.org/25750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01tdf#89329: use unique_ptr for pImpl in itempoolXisco Fauli
Change-Id: Ie0a5e5a16cf4b724ff55b0a89ee0ec803df6eb41 Reviewed-on: https://gerrit.libreoffice.org/25635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01loplugin:unusedmethodsNoel Grandin
Change-Id: Ia7981447e96d9ac87526ad1276585ab3077d7f08 Reviewed-on: https://gerrit.libreoffice.org/25707 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01tdf#89329: use unique_ptr for pImpl in toolbarmenuXisco Fauli
Change-Id: I2adafe082bd83edc31777f11f66313a51fde7d81 Reviewed-on: https://gerrit.libreoffice.org/25478 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01remove unused SID constants and associated codeNoel Grandin
found with a python script that looks like: process = subprocess.Popen( "git ls-files *.hrc | xargs grep -hE '#define +SID_' | cut -d ' ' -f 2 | sort -u", shell=True, stdout=subprocess.PIPE) for line in iter(process.stdout.readline, b''): line = line.strip() if line.startswith("//"): continue if line.startswith("sfx"): continue if len(line) < 10: continue i = subprocess.check_output("git grep -nP \"#define +" + line + " \"", shell=True) if i.count("#define") < 2: continue print line + " " + i Change-Id: I40eac2569c2b5b129d9459cb723a9d6f26d09264 Reviewed-on: https://gerrit.libreoffice.org/25715 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01Convert orientation to scoped enumNoel Grandin
Change-Id: If66319f51d8fa070b5575cc6e8eb6890d03768ff Reviewed-on: https://gerrit.libreoffice.org/25718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01Convert printer enums to scoped enumsNoel Grandin
Change-Id: Ic0f9d57181809b3fef3abbad462456fc2d5ced55 Reviewed-on: https://gerrit.libreoffice.org/25719 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01Convert VCL_MESSAGE to scoped enumNoel Grandin
Change-Id: I976536849fa5585c96cee23b660c56d3d0116933 Reviewed-on: https://gerrit.libreoffice.org/25720 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31tdf#100092: Deterministic scheduling to prevent unpredictable behavior.Jan Holesovsky
Low priority idles can fire more or less randomly, and consequently two consequent runs of LibreOffice differ in the amount of the idles that have been performed during an operation. This commit adds a possibility to turn on a 'deterministic mode' where two subsequent runs of LibreOffice trigger about the same amount of events when they perform the same set of operations. Change-Id: I92566ef4eee20e7d604cfd48f01c4df30c77e653
2016-05-31Remove inline renaming of title in ThumbnailViewItemAkshay Deep
Change-Id: I8fa2cae3390dd1576aab531bc826b8bb5985eaf9 Reviewed-on: https://gerrit.libreoffice.org/25645 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-05-31Convert ControlType to scoped enumNoel Grandin
Change-Id: Iaa13c3e7030296a97bab144103745867d43b4b19 Reviewed-on: https://gerrit.libreoffice.org/25554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31tdf#89329: use unique_ptr for pImpl in styleXisco Fauli
Change-Id: I206f1a7ee5a4020f712a969d26bde9268d9f2c53 Reviewed-on: https://gerrit.libreoffice.org/25636 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31fix KDE4 buildNoel Grandin
after 3d7325898547c94826cfdd "loplugin:unusedmethods" Change-Id: I32303948c5046b2880cd4e64cada32ea776a0861
2016-05-31More comphelper/extract.hxx clean upStephan Bergmann
Change-Id: I36c1ebea58bcd32b65a48d3447c106aeecdac230
2016-05-31Convert RSC_TOOLBOXITEM to scoped enumNoel Grandin
Change-Id: Ic90b6950016417d5f57963ab69fd20905a943bb7 Reviewed-on: https://gerrit.libreoffice.org/25683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31Convert ToolBoxLayoutMode to scoped enumNoel Grandin
Change-Id: I95b2432fc9f4df8d055227331a44151af4d773ab Reviewed-on: https://gerrit.libreoffice.org/25672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31loplugin:unusedmethodsNoel Grandin
Change-Id: Ifeb818227a960cab8fd2e8e7352468efbfe1232c Reviewed-on: https://gerrit.libreoffice.org/25668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31Convert PrinterSupport to scoped enumNoel Grandin
Change-Id: I2bde7261b8e8f31e6dd5a02cd4130156a04b8a7f Reviewed-on: https://gerrit.libreoffice.org/25657 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31Convert GfxLinkType to scoped enumNoel Grandin
Change-Id: Iae074ef0927a55f1fbf401cb66f4f183213f547c Reviewed-on: https://gerrit.libreoffice.org/25656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31teach refcounting clang plugin about uno::ReferenceNoel Grandin
uno::Reference is only allowed to used with classes that have a ::static_type member. So convert all those places to rtl::Reference. Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and uno::Reference to make this a little smoother? Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3 Reviewed-on: https://gerrit.libreoffice.org/25516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30tdf#100068: Initial implementation of ScreenshotIdKatarina Behrens
it's the same as HelpId in default implementation and extended with '=?config=foo' string otherwise, depending on different configurations the dialog/tabpage can have (e.g. different widgets hidden/shown) Change-Id: I01312a5a88ef7ba784bca315b336420cdb63c8dc Reviewed-on: https://gerrit.libreoffice.org/25455 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-30Fix int2enumStephan Bergmann
* The data argument to the Any ctor call needs to point at sal_Int32, not int. * All calls to int2enum guarantee that rType is an enum type, so assert that. Change-Id: I0ccd498420638fee80aeeccc93d9c1e3309f83b0
generated by cgit (git 2.34.1) at 2025-01-14 09:57:06 +0000