summaryrefslogtreecommitdiff
path: root/javaunohelper/com
AgeCommit message (Collapse)Author
2017-09-13Fix a locking bug in our Java ComponentBase class, where after the transitionDamjan Jovanovic
to disposed, the relevant variables (bDisposed and bInDispose) are written to outside a synchronized block. The equivalent C++ implementation in main/cppuhelper/source/implbase.cxx, method WeakComponentImplHelperBase::dispose(), already does this. Patch by: me (cherry picked from commit 2d382cef5450cf1593322184649257d3666cbbd8) Change-Id: I6c3e2ef78bc3c945245fe9fb7b6b713eb83710be Reviewed-on: https://gerrit.libreoffice.org/42189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-06-23Fix typos: uniform registeredAndrea Gelmini
We have in the same files "registered" and "registred". Change-Id: I604a8fdb7d5c40fe208fc11e9120333b3eaef3da Reviewed-on: https://gerrit.libreoffice.org/39097 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-12Translate German comments and debug strings (leftovers in dirs j... to q...)Johnny_M
Translates all (leftovers) found using a custom regex, in directories not shown by /bin/find-german-comments and beginning with "j" to "q". Additionally: - A few spelling fixes Change-Id: I5abf71dde3efc0dbaad162c705c6dc17af50f6c1 Reviewed-on: https://gerrit.libreoffice.org/38613 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-03-25Fix typosAndrea Gelmini
Change-Id: Id5811d092917c872715559f4508d01e4173d090c Reviewed-on: https://gerrit.libreoffice.org/35636 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-02-17javaunohelper: fix all javadoc warningsMichael Stahl
Change-Id: Iaaeab13005fef160def2e5bd49d4bfd40f42fe33
2016-02-08cid#1326918 FB.NP_CLONE_COULD_RETURN_NULLStephan Bergmann
Change-Id: I875cc2fc868fb4f1f45e90320e1fdaf70fe871d8
2016-02-04coverity#1326400 Dereference null return valueCaolán McNamara
Change-Id: Ie28d817d7be24b2de19f51e11786c0396a2e016f
2015-12-30coverity#1326973 SBSC: String concatenation in loop using + operatorCaolán McNamara
Change-Id: I8fb8afa2951201106443f76fde3f55ead24d43c2
2015-12-21related tdf#86784: new API got backported to 5.1Thorsten Behrens
Change-Id: Id195e487a029424e490008915f0df513a32b22b0
2015-12-21cid#1343654 FindBugs: Bad practice (FB.DMI_RANDOM_USED_ONLY_ONCE)Stephan Bergmann
Change-Id: Ifbc362835bc62578851a029e9c5ce8c20184846a
2015-12-20Fix @since tagsStephan Bergmann
Change-Id: I0ef45caae00ba056fd5feffb1b393b024775db5e
2015-12-18tdf#86784: Pass custom options to Java bootstrapKatarina Behrens
Change-Id: I9e9c78387627e173dea8062e4a3f16bc396e8115 Reviewed-on: https://gerrit.libreoffice.org/20720 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-05java: remove ((unnecessary)) parenthesesNoel Grandin
Change-Id: I39fbe3a260c8dbfc203662c54eec4db064b88195
2015-11-05java: combine nested if statementsNoel Grandin
Change-Id: I0457b81668e9427a3c8d6a4af93438b7fb2bb7ba
2015-10-15coverity#1326731 Dm: Dubious method usedCaolán McNamara
and coverity#1326732 Dm: Dubious method used coverity#1326734 Dm: Dubious method used coverity#1326735 Dm: Dubious method used coverity#1326739 Dm: Dubious method used Change-Id: Id9d39decf7442b503079ebcfe8c881f0f2fe3eb3
2015-10-15cid#1326115 Unchecked return valueNoel Grandin
and drop some truly bizarre and unnecessary code Change-Id: I105ba8784b6c4179a3cd7ad5bf9a250fd680d64a
2015-10-14cid#1326733 Dm: Dubious method usedNoel Grandin
there is no point in re-decoding a Java String object, it is already UTF-16 Change-Id: Iedc59d457422d32b306782f24cac9b6c2f6b04fe
2015-10-14use early returns to make method easier to readNoel Grandin
Change-Id: Iabaedbd51d3832eff8e7470fd586132c38e1d039
2015-09-30Fix typosAndrea Gelmini
Change-Id: I44bdb63bef76e9686e995661a24a3bef7cd50ab7 Reviewed-on: https://gerrit.libreoffice.org/18959 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-06-11java:regulatize the order of 'final' and public/privateNoel Grandin
Make the order be 'public static' or 'private static' Just makes the code nicer to read. Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2 Reviewed-on: https://gerrit.libreoffice.org/16202 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-09java:Non-synchronized method should not override a synchronized methodNoel Grandin
Change-Id: I46307828757ee1142747c14d2942515340083605
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-01-09java: simplify array creationNoel Grandin
and remove the need to worry about keeping indexes correct Change-Id: I9a5fc00f7e28f305279b41099274c96daebebb95
2015-01-09fix indexesCaolán McNamara
Change-Id: I99d3a715cce203eb2303c76da3b20e6d853a9d23
2015-01-07drop crashrep unused since start of LibreOfficeCaolán McNamara
Change-Id: I3df1216054c133314b2317849744a0a37e9fbc8f Reviewed-on: https://gerrit.libreoffice.org/13733 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-12-15stronger checks when creating Java UNO componentsNoel Grandin
check the visibility of construction method at load time for Java UNO components. This means that we get more informative errors at startup, instead of failures much later on when we actually create the component. Change-Id: I08cd16875cf53cfeeef7e8954ecd0d3177d70eb5 Reviewed-on: https://gerrit.libreoffice.org/13446 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: improve use of WrappedTargetException to set cause properlyNoel Grandin
since we introduced the new constructors that pass the cause all the way up to java.lang.Throwable. Also simplify some exeception printing sites, because Throwable will correctly print out child exceptions for us. Change-Id: Ibbecce3c6f971fbc80d6de2052ab4f33a4503c0a
2014-11-25java: remove some comment noiseNoel Grandin
Change-Id: I1c258b853097448d4a59334d915e94dba4c7eb34
2014-11-25java: final fields that can be staticNoel Grandin
found by PMD Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f Reviewed-on: https://gerrit.libreoffice.org/13099 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-18java: make fields final where possibleNoel Grandin
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: reduce excessive code indentation levelsNoel Grandin
by using early return in some methods Change-Id: I3611c8c89b3a94ef7e1772d178acf065fd7fcdc7 Reviewed-on: https://gerrit.libreoffice.org/12374 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-18javaunohelper: remove unused importRobert Antoni Buj i Gelonch
Change-Id: Ibee790a50e35219a8427b7037331943b778292a2 Reviewed-on: https://gerrit.libreoffice.org/11997 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-17java: final fields that can be staticNoel Grandin
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-16java: when rethrowing, store the original exceptionNoel Grandin
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
2014-10-16java: always use braces for while loopsNoel Grandin
Change-Id: Iff896b0cace8b8305528b3b0140004ea856169ce
2014-10-16java: reduce the depth of some deeply nested if blocksNoel Grandin
Change-Id: I3c0c7f08d4d8ea594e72fc0d9b93d085d4ab4bf5
2014-09-29fix more Java1.5 incompatibilityNoel Grandin
Change-Id: I9c4d62e4d3703e4e1015efe2b2917d54f82bc83f
2014-09-25java: when rethrowing exceptions, store the original causeNoel Grandin
so that we get a nice complete stacktrace when it hits the final handler Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
2014-09-23javaunohelper: Using "final" modifier whenever applicable in javaRobert Antoni Buj i Gelonch
All classes that belongs to the com.sun.star.lib.uno.adapter package are not part of the stable URE interface. (cf. <http://api.libreoffice.org/docs/java/ref/index.html>), for that reason those classes may be final. Remove unused import in com.sun.star.comp.helper.ComponentContext class. Change-Id: I68be8da4324f5163505e65365bf49a6a9cd00672 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-22javaunohelper: Using "final" modifier whenever applicable in javaRobert Antoni Buj i Gelonch
* com.sun.star.lib.uno.adapter.ByteArrayToXInputStreamAdapter class may be final. There is a overridable method call in the constructor. * Private methods can't be overridden. The private method "instantiate" is declared final in the com.sun.star.lib.uno.helper.Factory class. Change-Id: I7dba78a3d1857bbc328f6a581d8e9a5ae130739d Reviewed-on: https://gerrit.libreoffice.org/11546 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-19javaunohelper: use HashMap instead of Hashtable CollectionRobert Antoni Buj i Gelonch
Change-Id: I04e3245342a83df762fbec35a1523021a021f896 Reviewed-on: https://gerrit.libreoffice.org/11547 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-15javaunohelper: warning: unchecked castrbuj
Change-Id: I7c47e3a8657ec2368543088743879085878d78fb Reviewed-on: https://gerrit.libreoffice.org/11444 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-13javaunohelper: use a character literalrbuj
Change-Id: Ib0a69ac4714cd694ccd6a9bea87e32c1aadb0428 Reviewed-on: https://gerrit.libreoffice.org/11433 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-09-13javaunohelper: use String.length()==0 instead of String.equals(empty string)rbuj
Change-Id: Ic738dbbee4ce972ebf7efcfda33ccbb3f3ac48ff Reviewed-on: https://gerrit.libreoffice.org/11432 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-09-09javaunohelper: fix some misspellingsrbuj
Change-Id: Ibfa6e6ed2a4b4d3fa4b5e5cf624e42442653d358 Reviewed-on: https://gerrit.libreoffice.org/11363 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-07javaunohelper: fix javadoc error: unknown tag: attention (Doxygen)rbuj
Change-Id: Idd1d92699cab0ccb26b95e9d5392c6fc7a8a2aa6 Reviewed-on: https://gerrit.libreoffice.org/11308 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-02javaunohelper: fix javadoc error: unknown tag: returnsrbuj
Change-Id: I2cd47bd928da322be6c392d65d2a04152553fbef Reviewed-on: https://gerrit.libreoffice.org/11246 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-20java: remove unnecessary constructor declarationsNoel Grandin
in the absence of any other constructors, the compiler will automatically generate a public no-arg constructor Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
2014-08-20java: avoid unnecessary comparisons in boolean expressionsNoel Grandin
i.e. stuff like "x == true" Change-Id: Ib82a4a30e736df392405332fa197b588482cffcf
generated by cgit (git 2.34.1) at 2024-12-28 07:46:57 +0000