Age | Commit message (Collapse) | Author |
|
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'
Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
|
|
Change-Id: If0728af19ba48896678cc3196c922185e403a885
|
|
and remove the need to worry about keeping indexes correct
Change-Id: I9a5fc00f7e28f305279b41099274c96daebebb95
|
|
Change-Id: I99d3a715cce203eb2303c76da3b20e6d853a9d23
|
|
Change-Id: I3df1216054c133314b2317849744a0a37e9fbc8f
Reviewed-on: https://gerrit.libreoffice.org/13733
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ie8427e9ad7a2a03d6698ee95ce0f11fb458c00e3
|
|
and also a leak in that mode with a missing ReleaseStringChars after
GetStringChars in one use, and a use after free in the other use where
ReleaseStringChars is called
Change-Id: I2da0310429daf8519554fd7aaf47bba9f6f0e85c
|
|
found by looking for unused parameters (in Eclipse)
Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
|
|
found by UCDetector
Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
|
|
found by UCDetector
Change-Id: I0a0a00d1fae1fed2e6aef198b7a1482d7e7e29f0
|
|
and just use OOoRunner, there is no point in having a stripped down
jar, the cost of firing up the Java VM completely dwarfs any benefit
of having a smaller jar.
Change-Id: Ibcc3c5bd6e9b9c918041142dd32db0ea5dddc25b
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I5d6071096307adbe7df0178000346cf915afa3e7
Reviewed-on: https://gerrit.libreoffice.org/13477
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
still leaks on usual success case of course
Change-Id: Ia6e0f61b5a08271c03690bbb1c0af59081bea663
|
|
check the visibility of construction method at load time for Java UNO
components. This means that we get more informative errors at startup,
instead of failures much later on when we actually create the component.
Change-Id: I08cd16875cf53cfeeef7e8954ecd0d3177d70eb5
Reviewed-on: https://gerrit.libreoffice.org/13446
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ie2da7cbbd1733881ff2da6fa095c37c21cf19fe8
Reviewed-on: https://gerrit.libreoffice.org/13435
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
found by PMD
Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6
Reviewed-on: https://gerrit.libreoffice.org/13409
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
since we introduced the new constructors that pass the cause all the
way up to java.lang.Throwable.
Also simplify some exeception printing sites, because Throwable
will correctly print out child exceptions for us.
Change-Id: Ibbecce3c6f971fbc80d6de2052ab4f33a4503c0a
|
|
...assuming the delayLoadHook in cli_ure/source/native/native_bootstrap.cxx is
no longer necessary and loading of cppuhelper from the program dir cannot fail
regardless in whatever scenario the cli_cppuhelper library itself is loaded.
Change-Id: I13f32b327bca4cce9780864f5e57cdad3860afe5
|
|
Change-Id: I86864f832c0377d307cfa0b2c137f452e43797eb
|
|
The ../../../program/ links in the URE jar Class-Paths are a temporary kludge
(and juh.jar had lacked adaption for Mac OS X).
Change-Id: I2542d8a582866485dd61c05df3fc6b4b39a8403d
|
|
Change-Id: I1c258b853097448d4a59334d915e94dba4c7eb34
|
|
found by PMD
Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f
Reviewed-on: https://gerrit.libreoffice.org/13099
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I30f316ee87bd8fe4bc56f6e928fb36d3ab0c8e94
|
|
found by PMD
Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
|
|
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
by using early return in some methods
Change-Id: I3611c8c89b3a94ef7e1772d178acf065fd7fcdc7
Reviewed-on: https://gerrit.libreoffice.org/12374
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
and
coverity#705666 Resource leak
still actually fails to dlclose module, but explicitly does that
Change-Id: Idbf5608b052e3a7c5a465a73d8ad067a0a9494c5
|
|
Change-Id: Ibee790a50e35219a8427b7037331943b778292a2
Reviewed-on: https://gerrit.libreoffice.org/11997
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
|
|
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
|
|
Change-Id: Iff896b0cace8b8305528b3b0140004ea856169ce
|
|
Change-Id: I3c0c7f08d4d8ea594e72fc0d9b93d085d4ab4bf5
|
|
Change-Id: I1bb0999783f365e20b682c3707e73c65724265c9
Reviewed-on: https://gerrit.libreoffice.org/11955
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
the instanceof check returns false when passed a null value
Change-Id: I7742d0d9cf25ef23d9adee7328f701c7efeea8b5
|
|
Change-Id: I09fa2462d8131381f380574b8a9aeaf080211b2b
Reviewed-on: https://gerrit.libreoffice.org/11759
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I99aa3ac27c5157a6858978da20e480bc9847d88f
|
|
Change-Id: I53b69a488c70769cbb841db519bc28fd211dc087
|
|
Change-Id: I9c4d62e4d3703e4e1015efe2b2917d54f82bc83f
|
|
$ make JunitTest_juh
Change-Id: Ie6ed5070db01d8c183ddaae1852117667eae02f3
Reviewed-on: https://gerrit.libreoffice.org/11668
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
so that we get a nice complete stacktrace when it hits the final
handler
Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
|
|
Integrate WeakBase_Test and MultiTypeInterfaceContainer_Test in juh tests.
Remove unused import in InterfaceContainer_Test.
Remove getImplementationId() test in WeakBase_Test. Deprecated as of
the commit: 90b27c9493f4225e1612364b5813971b45b681a6
$ make JunitTest_juh
Change-Id: I1205c001e7f15bc5a28289051194fb225e114f13
Reviewed-on: https://gerrit.libreoffice.org/11630
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
Tested-by: David Ostrovsky <david@ostrovsky.org>
|
|
integrate InterfaceContainer_Test in juh tests
use java.util.logging in ComponentContext_Test
$ make JunitTest_juh
Change-Id: I92a855f8dea4bc893bb65e23e57ea4b12f59a31d
Reviewed-on: https://gerrit.libreoffice.org/11615
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Use -XX:MaxGCPauseMillis=50 in conjunction with Thread.sleep(51) to wait 51ms
after a GC call, instead of waiting 10s.
http://docs.oracle.com/javase/1.5.0/docs/guide/vm/gc-ergonomics.html
$ make JunitTest_juh
Change-Id: Id2cdada0e493fd450aab5dbec164502e0173857f
Reviewed-on: https://gerrit.libreoffice.org/11593
Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de>
Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de>
|
|
All classes that belongs to the com.sun.star.lib.uno.adapter package are not part of the stable URE interface.
(cf. <http://api.libreoffice.org/docs/java/ref/index.html>), for that reason those classes may be final.
Remove unused import in com.sun.star.comp.helper.ComponentContext class.
Change-Id: I68be8da4324f5163505e65365bf49a6a9cd00672
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
$ make JunitTest_juh_ComponentContext
Change-Id: Ibcd8ed7b1da7da82593e51b6f25a53763e9455f7
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
* com.sun.star.lib.uno.adapter.ByteArrayToXInputStreamAdapter class may be final. There is a overridable method call in the constructor.
* Private methods can't be overridden. The private method "instantiate" is declared final in the com.sun.star.lib.uno.helper.Factory class.
Change-Id: I7dba78a3d1857bbc328f6a581d8e9a5ae130739d
Reviewed-on: https://gerrit.libreoffice.org/11546
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Icdc61dc88a11afae5257bcddda32adb691cb5883
Reviewed-on: https://gerrit.libreoffice.org/11564
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I04e3245342a83df762fbec35a1523021a021f896
Reviewed-on: https://gerrit.libreoffice.org/11547
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I7c47e3a8657ec2368543088743879085878d78fb
Reviewed-on: https://gerrit.libreoffice.org/11444
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ib0a69ac4714cd694ccd6a9bea87e32c1aadb0428
Reviewed-on: https://gerrit.libreoffice.org/11433
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|