summaryrefslogtreecommitdiff
path: root/jurt
AgeCommit message (Collapse)Author
2015-11-25coverity#1340230 Dereference before null checkCaolán McNamara
ah!, the original code had a type in it. That's why it was refactored to remove the null check. Now a proper fix for cids: 1326180<->1326190 Change-Id: Iba7fd47c03eb5c157f878e0e297e8688f20ae348
2015-11-24coverity#1326190 Explicit null dereferencedCaolán McNamara
set this back to its original code pre.. commit e5bc8b60ecfca09a2014ab7090659f3428c8efa0 Date: Tue Aug 5 12:18:20 2014 +0200 to silence coverity about it Change-Id: I9d8f1bda1a32fbf97c0bdc73edfeab9f74d6443a cids: 1326180<->1326190
2015-11-12Generalize COM_GCC_IS_CLANG -> COM_IS_CLANGStephan Bergmann
...in anticipation of building with clang-cl.exe on Windows Change-Id: I1d723c9d3b5ca8a2bc6b27ef0189a7b053581398 Reviewed-on: https://gerrit.libreoffice.org/19928 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-11-05java: combine nested if statementsNoel Grandin
Change-Id: I0457b81668e9427a3c8d6a4af93438b7fb2bb7ba
2015-10-20coverity#1327460 DLS: Dead local storeCaolán McNamara
Change-Id: I53431357f153d61d3f80e9a3e76358d8e9bb0e0b
2015-10-15use AtomicInteger for _life_countNoel Grandin
(cid#1326323 Unguarded read) Just switch this to an AtomicInteger, it's cheaper, and doesn't require synchronization, so less chance of a deadlock. This is an API change since this is a protected field in a public class, but anyone messing with the internals of this class should have known better. Change-Id: Idafc760c2e9d83442b8209ad23d180acb8dccb20
2015-10-15cid#1327023 to cid#1327077 SIC: Inner class could be made staticNoel Grandin
Change-Id: I41f89c4feefe4e012d72c663ebb9bbcb4aa7f163
2015-09-30Fix typosAndrea Gelmini
Change-Id: I44bdb63bef76e9686e995661a24a3bef7cd50ab7 Reviewed-on: https://gerrit.libreoffice.org/18959 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-07-31fix use of TCP_NODELAY for localhost URP connectionsNoel Grandin
we implemented this logic in the C++ URP code a while back, but the Java code was not correctly updated. Change-Id: I377d7150f1adb69d6f86d9b4f3406163aaf85aea Reviewed-on: https://gerrit.libreoffice.org/17427 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-19Fix typosAndrea Gelmini
Change-Id: I52cbaad71560d73f5e24f3de3cd62b00d678dd6c Reviewed-on: https://gerrit.libreoffice.org/17187 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-03Fix typosAndrea Gelmini
Change-Id: I8e429d1f03aac7c7cdb7ff4b43b3f46d40292510 Reviewed-on: https://gerrit.libreoffice.org/16709 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-23Revert "Typo: iff->if"Julien Nabet
This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d. iff can mean "if and only if" so not a typo
2015-06-23Typo: iff->ifJulien Nabet
Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3
2015-06-22Fix typosAndrea Gelmini
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b Reviewed-on: https://gerrit.libreoffice.org/16408 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15java: 'final static' to 'static final'Noel Grandin
this is the canonical order, and it makes the code easier to read Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470 Reviewed-on: https://gerrit.libreoffice.org/16242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-06-11java:regulatize the order of 'final' and public/privateNoel Grandin
Make the order be 'public static' or 'private static' Just makes the code nicer to read. Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2 Reviewed-on: https://gerrit.libreoffice.org/16202 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-04-20java: some random small cleanupsNoel Grandin
Change-Id: I22a5b9fa29d465a21e682279e6e88d37bd8adf93
2015-02-21Typos: caculate->calculate + acceses->accessesJulien Nabet
Change-Id: Id2b645829ceb9affc76483a651fe6830a9f01cda
2015-01-20enable tcpNoDelay for loopback connections automaticallyNoel Grandin
it can make a significant speed difference for applications talking to the office binary via UNO Change-Id: If6e901908fe6a6119ac1fd0bf8feebabe5602ff7 Reviewed-on: https://gerrit.libreoffice.org/13856 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-06-Werror,-Wmacro-redefined (under Clang -fsanitize=*)Stephan Bergmann
Change-Id: Ifd23373b1ac4919793d1b4251ed90cf2dd6f2bda
2015-01-05java: remove dead codeNoel Grandin
found by UCDetector Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2014-12-16java: remove OOoRunnerLightNoel Grandin
and just use OOoRunner, there is no point in having a stripped down jar, the cost of firing up the Java VM completely dwarfs any benefit of having a smaller jar. Change-Id: Ibcc3c5bd6e9b9c918041142dd32db0ea5dddc25b Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-12-15java: remove some unused fields and variablesNoel Grandin
Change-Id: I5d6071096307adbe7df0178000346cf915afa3e7 Reviewed-on: https://gerrit.libreoffice.org/13477 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-11update documentationStephan Bergmann
Change-Id: Icd966a850b7c5e276e8b1d74566a4ea02e5b4a5c
2014-12-11java: reduce visibility of fields and methodsNoel Grandin
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-09rhbz#1036877: Join Java AsynchronousFinalizer thread well before exitStephan Bergmann
AsynchronousFinalizer was originally added as 870a4401c05beec3d31c1f6055a64591edd0a9d9 "INTEGRATION: CWS mtg1: #i57753# Avoid long-running finalize methods" referring to <https://issues.apache.org/ooo/show_bug.cgi?id=57753> " Fix JNI-UNO bridge so that the JVM doesn't run out of memory when a destructor locks the SolarMutex." It is unclear to me how relevant "If JVMs are getting more mature and should no longer have problems with long-running finalize methods, this class could be removed again" really is in practice. After all, advice on hotspot-gc-devel is to avoid finalize() if possible (<http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2014-June/010215.html> "Re: History of finalizer execution and gc progress?"). So stick with this approach of home-grown draining for now (where a home-grown approach using PhantomReferencens would need a dedicated draining thread, too, so would not have much benefit over the existing code in practice). Timely termination of AsynchronousFinalizer threads is achieved by using a dedicated thread per bridge and joining it in the remote bridge's dispose() resp. the JNI environment's new java_env_dispose. Change-Id: Idcef2dbf361a1de22f60db73828f59e85711aea7
2014-12-08Typo "mehtod" -> "method"Stephan Bergmann
Change-Id: I49f3f59c76bd4dd078f7014b6a0450241214db7f
2014-12-05fdo#86745 - Possible exception/segfault in jurt jpipe.dll under Windows ...Juergen Funk
- Remove the LoadLibrary from DLLMain (from windows not recommended) see http://msdn.microsoft.com/en-us/library/windows/desktop/ms682583(v=vs.85).aspx in section Remarks - Improve the comment why we need two dll's (jpipe.dll and jpipx.dll) - Integrate CriticalSection, init in DllMain see link http://msdn.microsoft.com/en-us/library/windows/desktop/dn633971(v=vs.85).aspx#general_best_practices Signed-off-by: Stephan Bergmann <sbergman@redhat.com>: removed the unsafe module == NULL check around the critical section in getFunction Change-Id: I6d5f655a4942437f6dc722236f6c371063e2c407
2014-12-05java: remove some unused local variablesNoel Grandin
Change-Id: Ia01528460e2f4b610d123e29cad66520abc6a965
2014-12-03Fold URE: WindowsStephan Bergmann
...assuming the delayLoadHook in cli_ure/source/native/native_bootstrap.cxx is no longer necessary and loading of cppuhelper from the program dir cannot fail regardless in whatever scenario the cli_cppuhelper library itself is loaded. Change-Id: I13f32b327bca4cce9780864f5e57cdad3860afe5
2014-11-28Fold URE: Linux ure/share/java/* -> program/classes/Stephan Bergmann
Change-Id: I86864f832c0377d307cfa0b2c137f452e43797eb
2014-11-28Fold URE: Linux ure/lib/* -> program/Stephan Bergmann
The ../../../program/ links in the URE jar Class-Paths are a temporary kludge (and juh.jar had lacked adaption for Mac OS X). Change-Id: I2542d8a582866485dd61c05df3fc6b4b39a8403d
2014-11-19readwrite_helper.c -> readwrite_helper.cxxStephan Bergmann
Change-Id: I6d9f43a18e13cb291cb678b6faeeed7c0ec9de1a
2014-11-19pipe.c -> pipe.cxxStephan Bergmann
Change-Id: I0c9659379e6120c0bf01b6436d3127b83ad01af1
2014-11-19nlsupport.c -> nlsupport.cxxStephan Bergmann
Change-Id: Ida0c3c0c521f71fd3f18a12c02cf98ac96c5b7a6
2014-11-19mutex.c -> mutex.cxxStephan Bergmann
Change-Id: I24ebffd1b055bdd6ad93d2f071d20480b549379f
2014-11-19memory.c -> memory.cxxStephan Bergmann
Change-Id: I87d977aabd09ff01cba0f25247dca43a2bf0dd2b
2014-11-18java: make fields final where possibleNoel Grandin
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: last statement in finalize() method should be call to super.finalize()Noel Grandin
Change-Id: I1785c6cef1fe7c1990207a76c263cff388cbb7e1 Reviewed-on: https://gerrit.libreoffice.org/12375 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: reduce excessive code indentation levelsNoel Grandin
by using early return in some methods Change-Id: I3611c8c89b3a94ef7e1772d178acf065fd7fcdc7 Reviewed-on: https://gerrit.libreoffice.org/12374 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-27Fix indentationStephan Bergmann
Change-Id: Ic058759782f95e330d8c581911aeb163340a7c4b
2014-10-16java: when rethrowing, store the original exceptionNoel Grandin
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
2014-10-16java: always use braces for while loopsNoel Grandin
Change-Id: Iff896b0cace8b8305528b3b0140004ea856169ce
2014-10-16java: reduce the depth of some deeply nested if blocksNoel Grandin
Change-Id: I3c0c7f08d4d8ea594e72fc0d9b93d085d4ab4bf5
2014-10-14jurt: print an array with java.util.Arrays.toStringRobert Antoni Buj i Gelonch
Change-Id: I76431b67f9f6fdde2906d6d8082457ef0847108e Reviewed-on: https://gerrit.libreoffice.org/11964 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13java: import from the same packageRobert Antoni Buj i Gelonch
Change-Id: I1bb0999783f365e20b682c3707e73c65724265c9 Reviewed-on: https://gerrit.libreoffice.org/11955 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-10jurt: use new exception constructorsRobert Antoni Buj i Gelonch
Change-Id: I58e7ebdd5c48094142f93f47271bcc0cc8b97981 Reviewed-on: https://gerrit.libreoffice.org/11892 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-08jurt: remove unused importRobert Antoni Buj i Gelonch
Change-Id: I597dac3cae7eafef75982789ab1b0d3d8d6999d2 Reviewed-on: https://gerrit.libreoffice.org/11863 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
generated by cgit (git 2.34.1) at 2024-12-29 00:10:49 +0000