Age | Commit message (Collapse) | Author |
|
...fixing regression introduced with 49eb02f07a5af44da59008a238e828b4a9532bef
"new loplugin:unusedvariablemore"
Change-Id: Ib598d67add50031937c9c9f3e23ea16d0a1da107
|
|
collection of heuristics to look for local variables that are never read
from i.e. do not contribute to the surrounding logic
This is an expensive plugin, since it walks up the parent tree,
so it is off by default.
Change-Id: Ib8ba292241bd16adf299e8bba4502cb473513a06
Reviewed-on: https://gerrit.libreoffice.org/52450
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
sUserClassPath may be empty (instead of containing "-Djava.class.path=...")
here, which older versions of Java have apparently silently ignored. But
Java 10 now fails with JNI_EINVAL (-6). (Happens e.g. during
CppunitTest_dbaccess_hsqldb_test.)
Change-Id: Ifd13222f0d0ae69547bd1a9fe0fd5eae47917d0a
Reviewed-on: https://gerrit.libreoffice.org/51949
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ibb69ba9c994e44c162318e40c4469c311309f326
Reviewed-on: https://gerrit.libreoffice.org/48996
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
the description in the comment was right, but the code was not
Change-Id: I7c038e7453f4387d33ec6423c0c55446d6d0df47
Reviewed-on: https://gerrit.libreoffice.org/44680
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I148a47a9b63b78651ec18cd947f45b8f4dbb9345
Reviewed-on: https://gerrit.libreoffice.org/44094
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: If92869e19c413e11f1f299a97f96b9637aaba65d
Reviewed-on: https://gerrit.libreoffice.org/43864
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I7292ced23647692fdc85a3c234fb1469a91ad0ea
|
|
to simplify and avoid all the typedefs
Change-Id: Ia14337dd71b55fc24f162b5436af76aeeb8d2575
Reviewed-on: https://gerrit.libreoffice.org/43346
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
We should only use generic foo function name when it takes params
that are also dependent on UNICODE define, like
LoadCursor( nullptr, IDC_ARROW )
where IDC_ARROW is defined in MSVC headers synchronised with
LoadCursor definition.
We should always use Unicode API for any file paths operations,
because otherwise we will get "?" for any character in path that
is not in current non-unicode codepage, which will result in failed
file operations.
Change-Id: I3a7f453ca0f893002d8a9764318919709fd8b633
Reviewed-on: https://gerrit.libreoffice.org/42935
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Iadb0ebb66809c192fb817b8c7cf2f8cdb4d0b874
Reviewed-on: https://gerrit.libreoffice.org/42419
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Ic11634ca28396fd156390c511087bae03bd5fb70
Reviewed-on: https://gerrit.libreoffice.org/42156
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I3d13e1c0bb6aa4a7aacc463198747c1368ebc9b4
Reviewed-on: https://gerrit.libreoffice.org/38114
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
extend oncevar to any POD type
Change-Id: Ia98ee0a67f183e40fb0c38477760124b2c411dc0
Reviewed-on: https://gerrit.libreoffice.org/40564
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ic021968b648359d94e7e44d59606b25a6f6ce8c3
|
|
Change-Id: Ib291521963a791a9c6175964571e9d9895072acf
Reviewed-on: https://gerrit.libreoffice.org/39646
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb
Reviewed-on: https://gerrit.libreoffice.org/38905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
|
|
Change-Id: I80d221a348c4bd5fcec82cafc455a051237ae95d
Reviewed-on: https://gerrit.libreoffice.org/38131
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This reverts commit 957874168491f4b030fda85c65dd969aae82a670. It wasn't really
necessary (see commit message of 8b1fcedcd10366523967ebcbd463b2c0c6b5b17a
"...and re-eanble loplugin:stringcopy again") and reportedly causes issues with
older Boost (see
<https://lists.freedesktop.org/archives/libreoffice/2017-May/077786.html>
"[Libreoffice-commits] core.git: jvmfwk/source").
|
|
Change-Id: I04e3faf18cd6dae39d948cfb3dd0834dd96751b1
|
|
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
|
|
Change-Id: Ie06633dd6a49ed9fc51dfb5e6066529020dcf268
|
|
Change-Id: I945d3fe6af5f88937b341dfc3696bf1d36344862
Reviewed-on: https://gerrit.libreoffice.org/36874
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I2beb95c42c666a788a87a45f59bc15ccfcf25aa6
|
|
Change-Id: I3511eaa12bb689a374a775204a3480d7c667a915
|
|
Change-Id: I8be48d1eec799f347a5edaa67837cf1bbf4d2cc3
|
|
...thereby fixing a memory leak
Change-Id: I1aa91eeb407987abcdaa5221f4abd447f881c5d2
|
|
...dropping remaining uses of CJavaInfo
Change-Id: I76afd5af927233712181f58b14fe6f4c1a9c15c2
|
|
Change-Id: Ib659d6edf362901a95cfb50ac008520805ad0fb0
|
|
Change-Id: I89cb19969285200a61c47d29e819a50845fa692b
|
|
Change-Id: If53347633ec4b2f8c2b221ba2057e0c38fa97b67
|
|
Change-Id: Idac31e282fe4df69449298a03d491473e460c742
Reviewed-on: https://gerrit.libreoffice.org/36495
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
No automatic tools. Manual checked and tested.
Change-Id: Ife260fa4e1d786cf81f2917a901664cc54943754
Reviewed-on: https://gerrit.libreoffice.org/36371
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I0af90fbb9eb77e5e65b29a79cc3b37af8cfc75e6
|
|
Change-Id: Ib350999ddf3ed2753b9e615a07b963c459dc714b
|
|
Change-Id: I51ee45dba007e5709b1516c36b029f940ea7153e
|
|
Change-Id: I55f96873661f686cd9625d69523718ccb54659dc
|
|
Change-Id: I2cc1071bbaf9c68fbd621d6c0c6953b7646b1a62
|
|
Change-Id: I08de5cab29dabc6fd824d5df8bac12c8520a05ae
|
|
Change-Id: Iff4b8ccc79e194f645791ac73818e3b677ae32a6
|
|
...lacking since recent f0454e72c1d1b11c3bcbacb23048a62fdecd037c "Use
std::unique_ptr<JavaInfo> for lifecycle management in jvmfwk/framework.hxx"
Change-Id: Ied39be52ccc8cbef48cdfb4933e4ac1914fd0fd3
|
|
Change-Id: If632eb547aa5082ad13eac8c2ad39a1742309fc7
|
|
Change-Id: I004b3d6f6b7b32d1bb41072d7fdd4a66f944d992
|
|
Change-Id: Iec70d6726e36af607a0a5b5a0f6dc86d05322435
|
|
Change-Id: I2067b77393427a5a6a4273c2f609ff8d335f436a
|
|
Change-Id: I8df49f349308cc17d684d5c0e8215aa628dfaeda
|
|
Change-Id: Ie604c75e92c407ff3118aaa58155648d956c91fb
|
|
Change-Id: Ia9e807c0d1e5b0664d711c551a5e70afccbcc564
|
|
Change-Id: Iad0728fe53912d85ee40ef1b39d476a47aaad2d2
Reviewed-on: https://gerrit.libreoffice.org/35433
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I02c5846eb51071e1a958c3d65e150fb7cbc7d58a
Reviewed-on: https://gerrit.libreoffice.org/34873
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|