Age | Commit message (Collapse) | Author |
|
Change-Id: Iba449fc66423959340c7967c64bc422a28fc75dd
|
|
Put all the UI content in UI XML file.
Unfortunately, lots of boilerplate code because
G_DECLARE_* macros are available only since glib 2.44
Change-Id: Idc74ba8565d482c28abd00b6f6f75646ab3d40b9
Reviewed-on: https://gerrit.libreoffice.org/39913
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
|
|
Change-Id: I8b82d46d4688b1a59d6fe1b05da7d5c8dfc13ca6
Reviewed-on: https://gerrit.libreoffice.org/38766
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I82e366fefd2e31928b99840fe76649cc3521e623
Reviewed-on: https://gerrit.libreoffice.org/38789
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I99211e2dc016fb97b6744799b35e05acd7470464
|
|
A new callback has been introduced for notifying the client:
LOK_CALLBACK_CELL_ADDRESS
Change-Id: I40b38a3cb8fb658c3f00332d56cfcbaf98e13771
Reviewed-on: https://gerrit.libreoffice.org/37357
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
|
|
When it failed, it always failed like this:
libreofficekit/qa/unit/tiledrendering.cxx:311:TiledRenderingTest::runAllTests
equality assertion failed
- Expected: 3
- Actual :
It's not clear yet what triggers the failure, sounds like some kind of timing.
Change-Id: Ib5f44523f9a29c892aeda9eb881f452b57adb8a8
Reviewed-on: https://gerrit.libreoffice.org/36445
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
With this the test passes for me 10 times in a row, while previously it
failed from time to time, hopefully this fixes the false negatives.
Change-Id: I233276ddfe4e9d8c86557f7f1c29d997f2fb51f6
Reviewed-on: https://gerrit.libreoffice.org/36420
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: Ibe2108984df8f4fef9ed681941d517ca9ad9479c
Reviewed-on: https://gerrit.libreoffice.org/36177
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: Iee2f4540cddeb05fcf0ae2ecadf7de8fbb4e3a0d
|
|
Change-Id: Idf4d3ba6b55be1f885f9d8fc89157e7e498d4e42
|
|
Change-Id: I59b71ee6815cbcfa4c8b5f68ae6dc9299856d49e
Reviewed-on: https://gerrit.libreoffice.org/35494
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
|
|
Avoid -Werror=deprecated-declaration and use
gtk_show_uri_on_window instead, which needs a GtkWindow.
Change-Id: Ia77978348809c8d88cb2823a1549cbdeffcc6c97
Reviewed-on: https://gerrit.libreoffice.org/34926
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
|
|
...if initializing these members is necessary at all; a bit hard to tell from
the code.
Change-Id: I384fbeedb3a5b0690a80cabdd13ca13d07e8d627
|
|
Change-Id: I9dcd32a7e64198ca4772f263ed89a458e298c53b
|
|
It was changed in ce96c5957c38384f8911d6307605c502eca0c644
Change-Id: I4cc1f90d85e31044306ab36eaeac9d4424d965c0
|
|
Change-Id: I7fa82096298a8a7c9f586a1d3c06aa5852e6842e
|
|
Impress was the only doctype remaining which didn't have comments api
yet, but now it does
Change-Id: I4e287301e879dff1c29c26880305505466ceaba4
|
|
Change-Id: I229451bac7cf4c223efd3fa18c177d650d3f9954
Reviewed-on: https://gerrit.libreoffice.org/34327
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
|
|
Change-Id: Id8fbebe2f6e339120741ed3744b18f50941c995e
|
|
Move this code to initWindow too
Change-Id: I057d9b8f60b9da2c20b28901ab958f9fc2095df3
|
|
Change-Id: I8aa0a00768e074b016ea20680c67884f19fe26df
|
|
This code (populating part selector, part mode selector etc.) is something
that needs to be executed for each view, not just the view that makes
open_document call. Put all such code in initWindow function from now.
Change-Id: Ibf9b12adb156258aa3cfdf959fffb541a88da529
|
|
Change-Id: I9a5be9050f3bedd14b6b5602b51bf40da0a11175
|
|
Change-Id: Ia94041884b7fde5f6c104a41c77c6a3aa96b7be1
|
|
Change-Id: Iaf6bbe81f519d49b82f624282d786c8cc18d641c
Reviewed-on: https://gerrit.libreoffice.org/34199
Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>
Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
|
|
There is no major harm in excluding these lines of code on
platforms with older gtk.
Change-Id: Ica3f1e2b4f60f0bab55254632663ace7b4c61d4d
|
|
Change-Id: I8333876cc4b540c385e316ce8dcbc5f7bd1f7902
|
|
Change-Id: I1bf8833041cf0e0a42aca1b6d851f6f4ca28d68f
|
|
Change-Id: Ic6623ebc05f1a09d5fc1b6bae5fab149d98724ab
|
|
TODO: Ideal would be to replace these buttons with a popover menu
containing all the actions that can be taken on a comment
Change-Id: Iec19e6c4a934394f84bcf4bb20cc14f207ef95be
|
|
Change-Id: Ieeae560fc6b6c82ef92ad5331cc6cddacb893a19
|
|
... and put the sidebar in a scrolled window
Change-Id: I57e982c849ed0c4dda4e8f5fdbcb0b85e46da36c
|
|
Change-Id: I282390f7319de2e24564e0122e8c0081235a0ef5
|
|
Change-Id: I82040893added83ff13395db3917b230ef6b01d5
|
|
Change-Id: I6762baac6c387d968dc6ee94d3494907c817214c
|
|
Pass --enable-tiled-annotations to gtktiledviewer on command line
to turn comments on again, by default they are turned off now.
Change-Id: I40e93ab683ec9538e088ae9aa83cda2eaaf9939e
Reviewed-on: https://gerrit.libreoffice.org/33622
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
|
|
Change-Id: Icf5bb78859668bfb5c43efc3e5fa9afce8458f41
Reviewed-on: https://gerrit.libreoffice.org/33621
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
|
|
Change-Id: I0fce00d4c794918e5b14b2c4f3f9f36231f28718
Reviewed-on: https://gerrit.libreoffice.org/33604
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
This is a testing tool, most of the time developers want to do
something with the document to test some functionality, lets keep
edit mode on by default and save them a second.
Change-Id: I61bbd2b85054b7ebdd14e69ca170674e260368e5
|
|
We used to use HorizontalAlignment uno command for cell alignment
both in online and gtktiledviewer. To make things simpler, lets
use separate cell alignment uno commands for spreadsheets like we
have in writer and impres.
Change-Id: I2a959d1892f6b02db7a9ce51d55309216e4b3c6c
Reviewed-on: https://gerrit.libreoffice.org/33444
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
|
|
Change-Id: I76e70ccb5b1f40193a1eda1cbca19b3444168dae
|
|
Use .uno:HorizontalAlignment instead of .uno:XXXPara for calc
Change-Id: I5af4fe62dc3075af4ba779499d062e6d91f21ecf
Reviewed-on: https://gerrit.libreoffice.org/32773
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
|
|
Change-Id: I5db217b525d0f976ef6a7840e370f8f6a21d60cb
Reviewed-on: https://gerrit.libreoffice.org/32772
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
|
|
Change-Id: I33be18779ea680f7a9c20814ca3c3d94d206900b
|
|
For now only care about the start of the cursor, which can be only at a
single redline.
Add matching testcase + expose it in the gtktiledviewer status bar for
interactive manual testing.
Change-Id: Ib61757412d6b54bef64361d4a8563795ca0bab6c
|
|
Previously .uno:NextTrackedChange always worked by cursor position, but
redlines are stored in the redline table, so they have a unique index.
Allow specifying that index when invoking the command, and in that case
ignore the cursor position.
Change-Id: I7dbe8044feca8fcc48635482a22317b024f40ffa
|
|
As it's currently implemented only for Writer.
Change-Id: I8c281b2294564472f2c2c5b7de5dd3f86a11a94a
|
|
This avoids some code duplication, and also means that the redline
author set by SwDocShell::SetView() affects the inserted Writer comments
as well, while those were 'Unknown Author' in the LOK case.
Change-Id: Ib51183302ee6904fdf69fb16f27ecfe6df39e6cb
|
|
A redline can have a manual comment and also an autogenerated
description, like "Insert 'abc'". Expose this later property as well, as
it provides useful additional information, especially when the comment
property is empty.
Change-Id: Id0f0ff62aef58d96b9b6071706c6f5b4a0d74800
|